Also call agent request in the update_item method, to make it more safe.
And added lost transaction commit
Fix 500 response for the incorret x3_port input
Change-Id: Ic538ffdd4d7fff833ba5395934a1b2bc6cf71664
The codebase does not use autodie directly, it does indirectly via
Sipwise::Base, and the autodie module is part of the standard perl
distribution anyway. TryCatch is imported via Sipwise::Base, and
that depends on it. The rest are not used anymore in the codebase.
Change-Id: Ic08e246cc60d7d151381dff39e0eba517a492e06
which implies, among others, strict and warnings. these should never
be omitted and are one of the most frequent complaints of perlcritic
currently.
as a result TryCatch can be removed (imported by Sipwise::Base).
also, "no Moose" is removed (has no effect).
Change-Id: I901b6a9f0f6d426f62b73e68f2c5ad6365c1eeef
by using a relative target url (without the host part) we make sure,
that when logging in as an admin we don't get redirected to a subscriber
page or vice versa. also simplifying the login controller a bit.
Change-Id: Ib9f0cdf7c687b711f8b357816e17a175efdfd1fe
the uppermost level in @searchColumns is to be comined via AND,
the next level, via OR (implicitly by DBIx::Class)
- plus fix billing networks in customers to be date-searched
Change-Id: I8db95cc5e8aadf5d5c86ef8fe06e59eb5e95c3d0
format is
<external_documentation>
<link>
name Google
url http://elgoog.im/
</link>
<link>
name Sipwise Website
url https://sipwise.com/
</link>
</external_documentation>
Change-Id: Id9283f1df5fb5933fa6523cbf2f01a458fa21475
using (de|en)code_base64url because the callid can contain a lot of characters,
which are invalid in a url including forward slash and questionmark.
see https://tools.ietf.org/html/rfc3261#section-25
Change-Id: I9818e0e06e251c3f58a8b26e46973176162103c1
+prohibit deletion of lnp providers if numbers are
still linked to it
+number+provider must be unique
+fixed other panel lnp page validation checks
+db constraints to stand concurrent inserts/updates
+fixup all txn_do die() calls in panel to properly
display the error
+bulk upload checks by db constraints
+lnp api testcase
Change-Id: I872b19f50d96e6c39c7fd5728b2a16555a397236
- the connector name is properly set when creating a reseller
- the network tag defaults to just (sip,xmpp,webrtc,...)
- rtcsessions doesn't accept network tag anymore
- an rtc-account is created for every network of the rtc-user
- the identifier in the rtc-account is set according to the specific connector
- api-rtc-full.t has been simplified for the user (no more need for domain_id)
- update available networks (in reseller api)
Change-Id: I2700c646726a06569cc5a70a5a30d4cb67eb1c80
Authoritative is rejecting call with 404 if number is not assigned
to local subscriber.
Skip Rewrite is skipping lnp rewrite rules.
Change-Id: I106df797a0b6530b4aaa0fc25ce54d3a459cbd97
a map used by the profile_edit logic mistakenly used
voip_subscriber_profile_attributes.id
as keys instead of
voip_preferences.id
keys.
so editing a subscriber profile seems to drop arbitrary
voip_usr_preferences values (and also cf mappings),
even when just changing the profile's name.
in addition, the resseller_edit config option is made
working as expected.
Change-Id: I75a60ee3e1e3889bdb16ccc0fa7d5661305f351c
in line with the web-login, a domain can be specified or defaults to
the request host.
because validating the format "username@domain" is not supported natively
by the catalyst HTTP auth plugin, the domain is checked manually at the
appropriate place.
Change-Id: Ifcc86234bc27598244788d1b4b07c2611c2e593b
Should be "Sprachnachrichten" instead of "Sprachnachriten".
Change-Id: Ib8086854bd27be01708d8f468f5de726f4250fac
Thanks: Matthias Hohl for reporting this bug on the spce-user mailing list
+creation of profile packages with hour and minute
intervals was disabled in api-balanceintervals.t
Change-Id: Idd18ced9704522bf5d919155d866c91b81526b92
this is neccessary to support multiple threads
plus remove the "handle" indirection
plus remove Moo - OO has no advantage here
Change-Id: I1c0657fd454c5dc2001404920abfadd01aa0a953
drop "inversion of control" loading them
this way we can remove MooseX::Object::Pluggable completely, which did
a filesystem search on _every_ panel page called.
Change-Id: If22dbb1a5a2ab24dee7af68a0085072ab1b2b855
using a direct relation to the required widgets instead of MooseX::Object::Pluggable
this also means additional widgets can easily enabled/disabled by the platform admin
in a next step, we can also refactor topmenu widget, to remove this completely
Change-Id: I890b47edc68b6d1df259d71075bda3c04045871e
- extended apply_rewrite to allow "rwr_rs" parameter to
override rewrite rule set
- added lookup functions for Subscriber and Peering to
perform a lookup based on calleer/callee
Change-Id: Iceea7a807587e12e1f5485998ade23bc932adaaf
Zone name is used as a result hash key.
Zone detail should be obtained from zones API if necessary.
Change-Id: Ic45d79bb5c0fc0b637da542571c58ec10802ee6e
Use proper fh to write and close
Also insert trailing rows not multiples of chunk size
Also download/upload routing number
Change-Id: I2654c880f89ccc58de1ff1eae320746ee3792788
Switch from the discouraged base module to the light-weight parent module.
Also remove some surrounding BEGIN blocks from 'use parent' which are
completely unnecessary.
Change-Id: I3a669e8024f098819be45030ca9d1afa8756105c
interestingly, the sorting with a malformed comparison used here
sort {$a > $b} @elements
gives different results on master (mr4.2x) and mr3.8.5. however,
results are the same with correct comparison.
sort {$a <=> $b} @elements
Change-Id: I62f0fd65b62a1db24ee9e2cc735839e30d5da916
If we have a 20M lnp file to upload, putting everything into the
numbers array is killing the fcgi process on low-mem machines.
Make sure to write each 2k chunk to DB and clear the array
afterwards.
Change-Id: I857be5d6a0195607b1fcb86db3327a9fd10ce5f1
Make LNP number params optional.
Fix clearing optional LNP number params.
Fix rewrite rule inflation, deflation and validation (doesn't seem
related to the lnp rwr changes, just started to not work anymore?).
Change-Id: If2278ad6dceacb84facd0397388ee2895b120b00
+due to optimisations in hal_from_item
+journal affected as well, thats how we found this
+so the last failing journal testcase should be fixed
Change-Id: I33824cc92c4a4895d2dd3afe8bd963f442f556f5
by choosing "stable" (about 1m30s) or "fast" (about 30s) as second
argument of testrunner, only tests are run, which are currently
succeeding on a plain trunk vm using docker. (times are on my machine)
I hope we can in this way re-enable them on nightlies (or even in gerrit)
so that devs have some better feedback on the impact of our changes.
Current status of tests (in trunk):
| Problems:
| api-callforwards.t
| api-balanceintervals.t
| api-faxes.t
| api-journals.t
|
| Fixed:
| api-all-links.t
| api-contracts.t
| api-customercontacts.t
| api-customers.t
| api-rewriterulesets.t
| api-root.t
|
| Working:
| api-billingfees.t
| api-billingnetworks.t
| api-billingprofiles.t
| api-billingzones.t
| api-calllists.t
| api-calls.t
| api-cert-auth.t
| api-cfdestinationsets.t
| api-ncoslevels.t
| api-pbxdevicemodels.t
| api-pbxdevices.t
| api-peeringgroups.t
| api-peeringrules.t
| api-peeringservers.t
| api-preferences.t
| api-profilepackages.t
| api-resellers.t
| api-rewriterules.t
| api-soundsets.t
| api-subscriberregistrations.t
| api-subscribers.t
| api-systemcontacts.t
| api-threads.t
| api-topuplogs.t
| api-trustedsources.t
| api-valid-patch.t
| api-vouchers.t
Change-Id: I74e672d9dc6bcccfd3ace2fe233dbcf325c6fc4d
Currently I only need to fetch a collection and create a new item
within the collection, no need for update/delete an existing one.
Thus, no AdminsItem.pm yet.
Since we're exposing field names now, rename md5pass to password.
Change-Id: I571a340f89560bc456147b0ec27d3ae737e6dbc3
which was provided by Capture::Tiny, which was provided by perl5i,
which was provided by Sipwise::Base
As an alternative, we just merge stdout and stderr using perl primitives.
Change-Id: I5aaf8267ff6275754981998296692577ee25332d
+dashboard uses a similar query for the survey
info visible to subscribers, which should now
load faster as well.
+the filter dropdown select+update table was
generally not working properly (MT#17323):
-fnFilter() does net necesarily trigger new
ajax requests, but searches in clientside
table store. the list stays empty, if there
is no direction column present, to match
"in" or "out" literals.
-using sSearch for specifying in/out filter
disallows to enter other search params in
text search field.
+union all now also used for the api
subscriber_id filter
Change-Id: Ia777504b9ade7acb34c66cb899f366ce029c905f
this is important, because it allows us, to be completely
independent of their href uris, whom we cannot always trust (the domain
part in particular)
Change-Id: Ic67f8240dfb50a5ea4948931d7e0554ce7f5ef4e
+input validation for verlapping time ranges
for both weekdays and special. can be disabled.
+root entiy locking
+peektime special is growing and not paginated,
so PUT/PATCH will get slower if special peektimes
are added on a regular basis. they can be removed
using the UI however
+testcase to check overlap detection
Change-Id: I935d943078ab5c81263da88ecd04e004deb26c8b
creating and deleting the entities users and networks
via the rtc api, when a reseller is created or modified
Change-Id: I2e9c785cacec680d1b22827983abca6037cdee3b
HDV130 only supports HTTP download of firmware, provide a
template var for config templates as firmware.booturl.
Change-Id: Ia7be98867849489de9beab67acdf7615ec99f42d
CAUTION: uses some optimized bulk-insert and truncate mechanisms
bypassing DBIC to make it reasonably fast (1M rows up in ~20s).
Optimized CSV download also to use partial writes to avoid
gateway timeouts on huge files.
Allows to handle LNP carriers in /api/lnpcarriers/.
Allows to handle LNP numbers and batch uploads in /api/lnpnumbers/.
Change-Id: I2f659bf5ee53270bedd3bb416a011bddc558b9ae
On X1 requests, properly update the configured agents on the cluster.
Currently we only throw an error if no agents are configured at all,
but let it slip through if the actual requests are failing, as they
might be down or failing.
Change-Id: I0f4e021a5cc4ba6a30e30bb197ed20d4504797d8
+failed txn due to to binding a row object instead of value
+remove warning with topup voucher validation
+remove warning when preparing topup log row data
Change-Id: I3a08b6ef297f9b197f30731d886e9d07686336dd
calls of subscribers of the same contract (inter-pbx?)
should not appear in "in" calls when using "customer_id" filter.
Change-Id: I9380a171c200f87601ae2d047460d3de278e20e9
that commit had introduced a couple of syntax errors:
Global symbol "$sub" requires explicit package name at /usr/share/perl5/NGCP/Panel/Controller/Device.pm line 1610.
Global symbol "$sub" requires explicit package name at /usr/share/perl5/NGCP/Panel/Controller/Device.pm line 1615.
Global symbol "$sub" requires explicit package name at /usr/share/perl5/NGCP/Panel/Controller/Device.pm line 1619.
Global symbol "$sub" requires explicit package name at /usr/share/perl5/NGCP/Panel/Controller/Device.pm line 1622.
Change-Id: Ie8d31fdaa60da18f73daba4983fe54ea427a9f9a
+subscriber instead of source_subscriber typo fixed
+rudimentary test case to see if the filter works
+fixed in/out direction filter testcase: sum of in and
out calls should be >= total count of calls
Change-Id: Ibe4b8153f023c53bb463626ad9e6613992fc101d
+fix for profile package "initial balance" default value
+fix for clearing the reseller id when editing billing profiles (related to MT#15399)
Change-Id: I53954dd12061fa5ebc4bde7c1769a502e6f862fe
+basically, the fix means to set
billing.contract_balances.start
billing.contract_balances.end
billing.contracts.create_timestamp
billing.contracts.modify_timestamp
to the 'local' timezone.
+test cases added
Change-Id: I203f8fc93df2b53c1cfe89bb1a90cdf6388e20b3
Fix faxserversettings PUT/PATCH processing found after faxes tests run
MT#15441 Tests for subscriber number changes
MT#12347 Test framework small fixes and additions
Some format changes and unused library removals
Add put_and_get method as common
Replace request_get & check 200 with check_item_get
Changes for API that doesn't return created object json after POST
Complete base_uri using replacement with normalize_uri
Change-Id: Ia31a97eb9511f1ca1de63c72bcbe380b89dfed34
any *attempt* of a top-up request should be
logged.
+create top-up log records for api
in order to record failed top-up requests as well,
the somewhat tricky thing is to have two
separate transactions here
+propery casting of topup request json field
values to numbers etc., so the transaction for
creating the log entry cannot fail and e.g.
requests with subscriber_id='blah' are recorded
correctly
+new "request_token" parameter for /api/topupvoucher
and /api/topupcash, to identify and filter for
particular requests.
+topup log api resource
+topup log api tests
+fix to correctly reject used vouchers
+topup log panel UI
+fix for balanceintervals.t threaded tests
Change-Id: I86eb845f6173803705b12cc7e5cdbac9a3153a0a
Cli can be edited through subscriberpreferences.
In such case it's value should be preserved on primary_number change.
Change-Id: I6b9d4a8d70e6e85dd9e2bf063cf4c047296deea1
+refactoring recent failing api-balanceintervals.t test to
need only two concurrent transactions (instead of three,
see https://bugtracker.sipwise.com/view.php?id=15277
Change-Id: I4902e616c3adfae81676194fa5e2b99e4b516ed1
in short: whenever the contract_balances "cash_balance" is
about to decrease, it might drop below thresholds defined
by a contract's profile package. in that case, subscribers
are to be locked and/or underrun billing profile sets are
to be applied. this commit also contains some minor fixes:
+when creating/editing profile packages, all billing
profiles of initial, topup, underrun sets must show the
same interval_free_cash and interval_free_time values.
there was also a problem with adding profile sets to
packages that use profile with prepaid = 1 (see ticket
14301)
+when editing packages using the panel UI, the validation
was not properly invoked (!) +the frequency of topups has
to be limited to 1 per second.
+updating the "lock" subscriber prior to editing or viewing
it in the panel UI was added.
+topup cash and topup voucher panel UI added
+when aquiring multiple contract row locks at once, no
joined tables are used any mure. the number of row locks
is therefore minimal now (see ticket 14903)
+rework of updating prepaid subscriber preference
Change-Id: Ideb0fec2404ca10b3ac5d8735f53620d0c3a24ed
MT#14779 Add default value for the q parameter
MT#14891 Consider form validation for the POST request (create location)
MT#14789 Remove user_agent registration parameter
Change-Id: I9f81ec3ec5c308c731b3dfe6aa5f075c7d7b50ab
This plugin is no longer in use, code dependencies were dropped
in commit 6a9f4559 and the Debian package dependency was dropped
in commit 0e1b9ef
Change-Id: Ie674e8b2673b98732f9f09674fe8a642d16d9182
Jenkins Git User
Irina Peshinskaya
Andreas Granig
Rene Krenn
Gerhard Jungwirth
Guillem Jover
Kirill Solomko
Michael Prokop
Alexander Lutay
Richard Fuchs
Andrew Pogrebennyk
Victor Seva