When testing the bugfix mentioned in the ticket I found the below
bugs and proceeded with the fixes:
- cscCfGroupConditionDate: added try/catch to handle better errors.
Before the fix the component was gettign stuck on loading when
the backend was returning an error
- refactored post() in common.js to reflect sipwise js policy
- actions.js: fixed bug to pass correct timeSetId in the cfmapping
PATCH requests. Before the fix we were passing an object with all
the data of the new timeset rather than the id only and the backend
was complaining.
Change-Id: I7bfabaf7a1a2aea8c6034de0d8f76e2f90633cdb
Some conditions were not evaluating correctly as we are passing
empty strings instead of null/undefined values. We replaced the
nullish coellish operator with a simple or operator until we have
more time to review the incorrect use of empty strings in oppose of null
and undefined values in the entire app
Change-Id: Ifb8635976166830e0d32b88a27985a7661854acb
sip username is created removing whitespaces and special chars from
the name input. This logic was handled by a lodash method. This commit
replaces the mentioned method with a custom function that mirrors the
logic we use in ngcp-admin to handle the pbx group creation.
The new method is less aggressive in fact it allows the use of
underscores and doesn't dash numbers. As part of the change we also
expose sip username as read-only field in the edit pbxGroupDetails
page.
Change-Id: I086b3a7011e47d8f542ac92f42bd923c38630331
- Changing list view to 8 rows with 3 columns.
- Preferences/Edit are now open in a separate page.
- Adding the new 4 preferences ( - Admin Name/ Disable web GUI/ User config priority over-provisioning/FW upgrade disable) together with the existing parameters.
Change-Id: Iae92c3313c592f7662587f52d0d4c9293ba41a97
Add a new "force CLI" checkbox to the add pbx seat form.
If the checkbox is ticked, "?create_primary_acli=false" is
added to the request URL params when creating a subscriber.
Removes customer_id params from createSubscriber() as it
seems to be a leftover from old code.
Change-Id: I58e287030bc740659415f888d8ed42f5ab6894d1
Resolve current lint issues to improve the code reliability.
Disable lint for auto-generated/auto-updated files. Note,
Vue3 does not longer provide a default export therefore the line
has been ignored for now, however tests still seem to work as expected.
Change-Id: I668c50868b4cb9eceb0ff89767be9082585655a7
- remove some spaces and some code in comment
- change icon for upload
- adding an error for the number when it is duplicated in add/edit pages
Change-Id: I3f1ca01e70a1b3bcf068bdea3c5cc98668f74c9f
The jest module cannot be found after the update due
to a wrong transformation:
07:46:39 yarn run v1.22.19
07:46:39 $ jest --updateSnapshot
07:46:39 ● Validation Error:
07:46:39
07:46:39 Module vue-jest in the transform option was not found.
07:46:39 <rootDir> is: /tmp/code
07:46:39
07:46:39 Configuration Documentation:
07:46:39 https://jestjs.io/docs/configuration
This commit fixes the transformation and points to the new
'@vue/vue3-jest'
Change-Id: If781a23155352d0e3275c064bbca92d17076dbad
The files were not updates since long time.
Now they are in line with the english version, but still not traslated
Change-Id: I0ff78c1a8576ab2ee5e50a6553be1da7b86c0dee