MT#60289 Uploading greeeting files in voicebox bug fix

Some conditions were not evaluating correctly as we are passing
empty strings instead of null/undefined values. We replaced the
nullish coellish operator with a simple or operator until we have
more time to review the incorrect use of empty strings in oppose of null
and undefined values in the entire app

Change-Id: Ifb8635976166830e0d32b88a27985a7661854acb

src/store/call-settings.js

@@ -47,7 +47,7 @@ export default {
     },
     actions: {
         async loadSubscriberPreferencesAction (context, id) {
-            const subscriberId = id ?? context.getters.subscriberId
+            const subscriberId = id || context.getters.subscriberId
             const subscriberPreferences = await getPreferences(subscriberId)
             context.commit('subscriberPreferencesSucceeded', subscriberPreferences)
         },
@@ -66,7 +66,7 @@ export default {
             await context.dispatch('fieldUpdateAction', { field: 'music_on_hold', value })
         },
         async setLanguage (context, options) {
-            const subscriberId = options.subscriberId ?? context.getters.subscriberId
+            const subscriberId = options.subscriberId || context.getters.subscriberId
             if (options.language) {
                 await setPreference(subscriberId, 'language', options.language)
                 context.commit('subscriberPreferencesUpdate', {

src/store/fax.js

@@ -35,14 +35,14 @@ export default {
     },
     actions: {
         async loadFaxSettingsAction (context, id) {
-            const subscriberId = id ?? context.getters.subscriberId
+            const subscriberId = id || context.getters.subscriberId
             const faxServerSettings = await getFaxServerSettings(subscriberId)
             context.commit('settingsSucceeded', {
                 faxServerSettings
             })
         },
         async faxServerSettingsUpdateAction (context, options) {
-            const subscriberId = options.id ?? context.getters.subscriberId
+            const subscriberId = options.id || context.getters.subscriberId
             const faxServerSettings = await setFaxServerField({
                 subscriberId: subscriberId,
                 field: options.field,
@@ -55,14 +55,14 @@ export default {
         },
 
         async loadMailToFaxSettingsAction (context, id) {
-            const subscriberId = id ?? context.getters.subscriberId
+            const subscriberId = id || context.getters.subscriberId
             const mailToFaxSettings = await getMailToFaxSettings(subscriberId)
             context.commit('settingsSucceeded', {
                 mailToFaxSettings
             })
         },
         async mailToFaxSettingsUpdateAction (context, options) {
-            const subscriberId = options.id ?? context.getters.subscriberId
+            const subscriberId = options.id || context.getters.subscriberId
             const mailToFaxSettings = await setMailToFaxSettingField({
                 subscriberId: subscriberId,
                 field: options.field,

src/store/voicebox.js

@@ -323,7 +323,7 @@ export default {
     },
     actions: {
         async settingsLoadAction (context, id) {
-            const subscriberId = id ?? context.getters.subscriberId
+            const subscriberId = id || context.getters.subscriberId
             context.commit('settingsRequesting')
             const res = await Promise.all([
                 getVoiceboxSettings(subscriberId),
@@ -392,7 +392,7 @@ export default {
             })
         },
         async greetingUpload (context, options) {
-            const subscriberId = options.subscriberId ?? context.getters.subscriberId
+            const subscriberId = options.subscriberId || context.getters.subscriberId
             try {
                 context.commit(options.type + 'GreetingUploadRequesting')
                 const cancelToken = apiCreateCancelObject()