sipwise
/
sems
mirror of https://github.com/sipwise/sems.git
1
0
Fork 0
Code Issues Releases Wiki Activity

MT#62181 fix initialisers

Browse Source 
Add missing initialisers and fix order.

In some cases the member was actually unused and could just be removed.

Change-Id: I0f0c927eb8271c35dcfd371f225847f62bea2812
Warned-by: Coverity
master
Richard Fuchs 2 months ago
parent 05506cd2bb
commit 1b695faabb
20 changed files with 80 additions and 46 deletions
Show Stats Download Patch File Download Diff File

1
apps/db_reg_agent/DBRegAgent.cpp
Unescape View File

@ -76,6 +76,7 @@ class RegTimer : public timer {
DBRegAgent::DBRegAgent(const string& _app_name)
: AmDynInvokeFactory(_app_name),
AmEventQueue(this),
expires(0),
uac_auth_i(NULL)
{
}

3
apps/sbc/RegisterCache.cpp
Unescape View File

@ -188,7 +188,8 @@ struct RegCacheLogHandler
_RegisterCache::_RegisterCache()
: reg_cache_ht(REG_CACHE_TABLE_ENTRIES),
id_idx(REG_CACHE_TABLE_ENTRIES),
contact_idx(REG_CACHE_TABLE_ENTRIES)
contact_idx(REG_CACHE_TABLE_ENTRIES),
gbc_bucket_id(0)
{
// debug register cache WRITE operations
setStorageHandler(new RegCacheLogHandler());

18
apps/sbc/SBCCallProfile.h
Unescape View File

@ -345,26 +345,34 @@ struct SBCCallProfile
transparent_dlg_id(false),
dlg_nat_handling(false),
keep_vias(false),bleg_keep_vias(false),
force_outbound_proxy(false),
aleg_force_outbound_proxy(false),
next_hop_1st_req(false),
patch_ruri_next_hop(false),
next_hop_fixed(false),
allow_subless_notify(false),
anonymize_sdp(false),
have_aleg_sdpfilter(false),
sst_enabled_value(false),
auth_aleg_enabled(false),
uas_auth_bleg_enabled(false),
rtprelay_enabled_value(false),
force_symmetric_rtp_value(false),
aleg_force_symmetric_rtp_value(false),
msgflags_symmetric_rtp(false),
rtprelay_transparent_seqno(true),
rtprelay_transparent_ssrc(true),
rtprelay_dtmf_filtering(false),
rtprelay_dtmf_detection(false),
rtprelay_interface_value(-1),
aleg_rtprelay_interface_value(-1),
rtprelay_bw_limit_rate(-1),
rtprelay_bw_limit_peak(-1),
outbound_interface_value(-1),
have_aleg_sdpfilter(false),
contact_hiding(false),
reg_caching(false),
log_rtp(false),
log_sip(false),
patch_ruri_next_hop(false),
next_hop_1st_req(false),
next_hop_fixed(false),
allow_subless_notify(false),
max_491_retry_time(2000)
{ }

5
apps/xmlrpc2di/xmlrpc++/src/XmlRpcClient.cpp
Unescape View File

@ -112,6 +112,11 @@ XmlRpcClient::XmlRpcClient(const char* host, int port,
_ssl = ssl;
if (!_ssl) { _ssl_ssl = (SSL *) NULL; }
_sendAttempts = 0;
_bytesWritten = 0;
_isFault = false;
_contentLength = 0;
// Default to keeping the connection open until an explicit close is done
setKeepOpen();
}

9
core/AmAudioFile.cpp
Unescape View File

@ -265,10 +265,11 @@ int AmAudioFile::fpopen_int(const string& filename, OpenMode mode,
AmAudioFile::AmAudioFile()
: AmBufferedAudio(0, 0, 0), data_size(0),
fp(0), begin(0), loop(false), autorewind(false),
on_close_done(false),
close_on_exit(true)
: AmBufferedAudio(0, 0, 0),
fp(0), begin(0), iofmt(0), open_mode(0),
data_size(0), on_close_done(false),
close_on_exit(true),
loop(false), autorewind(false)
{
}

8
core/AmB2ABSession.cpp
Unescape View File

@ -37,8 +37,9 @@ AmB2ABSession::AmB2ABSession()
}
AmB2ABSession::AmB2ABSession(const string& other_local_tag)
: other_id(other_local_tag),
AmSession()
: AmSession(),
other_id(other_local_tag),
connector(NULL)
{}
@ -268,7 +269,8 @@ AmB2ABCalleeSession* AmB2ABCallerSession::createCalleeSession()
AmB2ABCalleeSession::AmB2ABCalleeSession(const string& other_local_tag,
AmSessionAudioConnector* callers_connector)
: AmB2ABSession(other_local_tag),
is_connected(false)
is_connected(false),
released(NULL)
{
connector=callers_connector;
connector->block();

9
core/AmB2BMedia.cpp
Unescape View File

@ -178,13 +178,14 @@ void AudioStreamData::initialize(AmB2BSession *session)
AudioStreamData::AudioStreamData(AmB2BSession *session):
in(NULL), initialized(false),
force_symmetric_rtp(false),
enable_dtmf_transcoding(false),
dtmf_detector(NULL), dtmf_queue(NULL),
relay_enabled(false), relay_port(0),
relay_paused(false), muted(false),
receiving(true),
outgoing_payload(UNDEFINED_PAYLOAD),
incoming_payload(UNDEFINED_PAYLOAD),
force_symmetric_rtp(false),
enable_dtmf_transcoding(false),
muted(false), relay_paused(false), receiving(true)
incoming_payload(UNDEFINED_PAYLOAD)
{
if (session) initialize(session);
}

4
core/AmB2BMedia.h
Unescape View File

@ -68,10 +68,10 @@ class AudioStreamData {
bool enable_dtmf_transcoding;
/** Enables RTP DTMF (2833/4733) filtering */
bool enable_dtmf_rtp_filtering;
//bool enable_dtmf_rtp_filtering;
/** Enables DTMF detection with RTP DTMF (2833/4733) */
bool enable_dtmf_rtp_detection;
//bool enable_dtmf_rtp_detection;
/** Low fidelity payloads for which inband DTMF transcoding should be used */
vector<SdpPayload> lowfi_payloads;

18
core/AmDtmfDetector.cpp
Unescape View File

@ -179,11 +179,13 @@ void AmSipDtmfDetector::process(AmSipDtmfEvent *evt)
AmDtmfDetector::AmDtmfDetector(AmDtmfSink *dtmf_sink)
: m_dtmfSink(dtmf_sink), m_rtpDetector(this),
m_sipDetector(this),
m_eventPending(false), m_sipEventReceived(false),
m_inbandEventReceived(false), m_rtpEventReceived(false),
m_inband_type(Dtmf::SEMSInternal),
m_currentEvent(-1),
m_current_eventid_i(false)
m_startTime{0,0},
m_lastReportTime{0,0},
m_currentEvent(-1), m_eventPending(false),
m_current_eventid_i(false), m_current_eventid(-1),
m_sipEventReceived(false),
m_inbandEventReceived(false), m_rtpEventReceived(false)
{
//#ifndef USE_SPANDSP
// setInbandDetector(Dtmf::SEMSInternal, m_session->RTPStream()->getSampleRate());
@ -553,10 +555,14 @@ static char dtmf_matrix[4][4] =
AmSemsInbandDtmfDetector::AmSemsInbandDtmfDetector(AmKeyPressSink *keysink, int sample_rate)
: AmInbandDtmfDetector(keysink),
SAMPLERATE(sample_rate),
m_buf(),
m_last(' '),
m_idx(0),
m_count(0),
SAMPLERATE(sample_rate)
m_result(),
m_lastCode(0),
m_last_ts(0),
m_count(0)
{
/* precalculate 2 * cos (2 PI k / N) */
for(unsigned i = 0; i < NELEMSOF(rel_cos2pik); i++) {

1
core/AmOfferAnswer.cpp
Unescape View File

@ -53,6 +53,7 @@ static const char* getOAStateStr(AmOfferAnswer::OAState st) {
AmOfferAnswer::AmOfferAnswer(AmSipDialog* dlg)
: state(OA_None),
saved_state(OA_None),
cseq(0),
sdp_remote(),
sdp_local(),

9
core/AmPlayoutBuffer.cpp
Unescape View File

@ -45,9 +45,9 @@
#define MAX_DELAY sample_rate*1 /* 1 second */
AmPlayoutBuffer::AmPlayoutBuffer(AmPLCBuffer *plcbuffer, unsigned int sample_rate)
: r_ts(0),w_ts(0), sample_rate(sample_rate),
last_ts_i(false), recv_offset_i(false),
m_plcbuffer(plcbuffer)
: r_ts(0),w_ts(0), m_plcbuffer(plcbuffer), last_ts(0),
last_ts_i(false), sample_rate(sample_rate), recv_offset(0),
recv_offset_i(false)
{
buffer.clear_all();
}
@ -515,7 +515,8 @@ u_int32_t AmAdaptivePlayout::time_scale(u_int32_t ts, float factor,
*****************************************************************/
AmJbPlayout::AmJbPlayout(AmPLCBuffer *plcbuffer, unsigned int sample_rate)
: AmPlayoutBuffer(plcbuffer, sample_rate)
: AmPlayoutBuffer(plcbuffer, sample_rate),
m_last_rtp_endts(0)
{
}

8
core/AmPrecodedFile.h
Unescape View File

@ -57,13 +57,13 @@ class AmPrecodedFileFormat : public AmAudioFileFormat {
amci_subtype_t subtype;
/* encoded frame size in bytes */
int frame_encoded_size;
//int frame_encoded_size;
public:
AmPrecodedFileFormat(precoded_payload_t& precoded_payload);
~AmPrecodedFileFormat();
amci_subtype_t* getSubtype() { return &subtype; }
int getFrameEncodedSize() { return frame_encoded_size; }
//int getFrameEncodedSize() { return frame_encoded_size; }
};
class AmPrecodedRtpFormat : public AmAudioRtpFormat
@ -71,13 +71,13 @@ class AmPrecodedRtpFormat : public AmAudioRtpFormat
precoded_payload_t& precoded_payload;
/* encoded frame size in bytes */
int frame_encoded_size;
//int frame_encoded_size;
public:
AmPrecodedRtpFormat(precoded_payload_t& precoded_payload);
~AmPrecodedRtpFormat();
int getFrameEncodedSize() { return frame_encoded_size; }
//int getFrameEncodedSize() { return frame_encoded_size; }
};
class AmPrecodedFileInstance

3
core/AmRtpAudio.cpp
Unescape View File

@ -33,7 +33,8 @@
AmAudioRtpFormat::AmAudioRtpFormat()
: AmAudioFormat(-1),
advertized_rate(-1)
advertized_rate(-1),
frame_size(0)
{
}

5
core/AmSipMsg.cpp
Unescape View File

@ -9,7 +9,10 @@
AmSipRequest::AmSipRequest()
: _AmSipMsgInDlg(),
max_forwards(-1)
rack_cseq(0),
first_hop(false),
max_forwards(70),
local_if(0)
{
}

2
core/AmSipMsg.h
Unescape View File

@ -42,7 +42,7 @@ class _AmSipMsgInDlg
unsigned short local_port;
string trsp;
_AmSipMsgInDlg() : cseq(0), rseq(0) { }
_AmSipMsgInDlg() : cseq(0), rseq(0), remote_port(0), local_port(0) { }
virtual ~_AmSipMsgInDlg() { };
virtual string print() const = 0;

1
core/sip/parse_uri.cpp
Unescape View File

@ -34,6 +34,7 @@
sip_uri::sip_uri()
: scheme(UNKNOWN),
port(0),
trsp(NULL)
{
}

2
core/sip/resolver.cpp
Unescape View File

@ -725,8 +725,6 @@ dns_base_entry* dns_naptr_entry::get_rr(dns_record* rr, u_char* begin, u_char* e
return naptr_r;
}
sip_target::sip_target() {}
sip_target::sip_target(const sip_target& target)
{
*this = target;

2
core/sip/resolver.h
Unescape View File

@ -212,7 +212,7 @@ struct sip_target
sockaddr_storage ss;
char trsp[SIP_TRSP_SIZE_MAX+1];
sip_target();
sip_target() : ss{}, trsp{} {};
sip_target(const sip_target& target);
void clear();

12
core/sip/sip_trans.cpp
Unescape View File

@ -68,16 +68,20 @@ inline trans_timer** fetch_timer(unsigned int timer_type, trans_timer** base)
}
sip_trans::sip_trans()
: msg(NULL),
: timers{},
type(0),
msg(NULL),
reply_status(0),
state(0),
last_rseq(0),
targets(NULL),
retr_buf(NULL),
retr_socket(NULL),
retr_len(0),
last_rseq(0),
retr_addr{},
retr_socket(NULL),
logger(NULL),
canceled(false)
{
memset(timers,0,SIP_TRANS_TIMERS*sizeof(void*));
}
sip_trans::~sip_trans()

2
core/sip/tcp_trsp.h
Unescape View File

@ -36,7 +36,7 @@ class tcp_trsp_socket: public trsp_socket
sockaddr_storage peer_addr;
string peer_ip;
unsigned short peer_port;
bool peer_addr_valid;
//bool peer_addr_valid;
parser_state pst;
unsigned char input_buf[MAX_TCP_MSGLEN];

Write Preview
Loading…
Cancel
Save