TT#19710 Do not modify $_ in list functions

Change-Id: I03459308a8589cccfbae9a29b1f35d3eae33af78 Warned-by: perlcritic
8 years ago · ac64f2b3c9
parent 088df47512
commit ac64f2b3c9
1 changed files with 6 additions and 8 deletions
--- a/tools/render_schema.pl
+++ b/tools/render_schema.pl
@ -113,20 +113,18 @@ sub _load_model {
                push(@foreign_columns,$foreign);
            }
            @self_columns = map {
-                    if ($_ =~ /^self\./) {
-                        $_ =~ s/^self\.//;
+                    if (m/^self\./) {
+                        s/^self\.//r;
                    } else {
-                        $_ = '\'' . $_ . '\'';
+                        '\'' . $_ . '\'';
                    }
-                    $_;
                } @self_columns;
            @foreign_columns = map {
-                    if ($_ =~ /^foreign\./) {
-                        $_ =~ s/^foreign\.//;
+                    if (m/^foreign\./) {
+                        s/^foreign\.//r;
                    } else {
-                        $_ = '\'' . $_ . '\'';
+                        '\'' . $_ . '\'';
                    }
-                    $_;
                } @foreign_columns;
            my $multi = $rel_info->{attrs}->{accessor};
            if ('multi' eq $multi) {