From ac64f2b3c9e2b6b6965981b5ad2aa7183b02da92 Mon Sep 17 00:00:00 2001 From: Guillem Jover Date: Tue, 7 Nov 2017 10:52:43 +0100 Subject: [PATCH] TT#19710 Do not modify $_ in list functions Change-Id: I03459308a8589cccfbae9a29b1f35d3eae33af78 Warned-by: perlcritic --- tools/render_schema.pl | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/tools/render_schema.pl b/tools/render_schema.pl index e1c96e94..a9366910 100644 --- a/tools/render_schema.pl +++ b/tools/render_schema.pl @@ -113,20 +113,18 @@ sub _load_model { push(@foreign_columns,$foreign); } @self_columns = map { - if ($_ =~ /^self\./) { - $_ =~ s/^self\.//; + if (m/^self\./) { + s/^self\.//r; } else { - $_ = '\'' . $_ . '\''; + '\'' . $_ . '\''; } - $_; } @self_columns; @foreign_columns = map { - if ($_ =~ /^foreign\./) { - $_ =~ s/^foreign\.//; + if (m/^foreign\./) { + s/^foreign\.//r; } else { - $_ = '\'' . $_ . '\''; + '\'' . $_ . '\''; } - $_; } @foreign_columns; my $multi = $rel_info->{attrs}->{accessor}; if ('multi' eq $multi) {