You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Rene Krenn 22c3696930 MT#56817 MT#56362 fix errors from nondetermistic query param ordering ... the /api/callists rail supports the "call_id" query parameter to match calls with a callid prefix. this filter also adds an implicity ordering ORDER BY length(call_id) ASC, 'start_time' ASC. the /api/callists api rail also requires the query parameter "susbcriber_id", which renders a (fast) compound SQL query to list matching incoming (query1) and outgoing calls (query2) using UNION ALL (instead of a slow OR query). query1 UNION ALL query2 this is supported by the https://metacpan.org/pod/DBIx::Class::Helper::ResultSet::SetOperations module, which however generates invalid SQL syntax if query1 or query2 contains an ORDER BY. this is exactly what caused the 500 error of the customer who applied both "call_id" and "susbcriber_id" parameter in the request at the same time. ... ORDER BY length(call_id) ASC, `start_time` ASC UNION ALL SELECT `me`.`id`... the error happens randomly, because query parameters are stored in a hash (which by definition has no deterministic order of the entries). when the "call_id" parameter is applied at last, it worked as expected. so the issue can be adressed by strictly ordering the UNION ALL result, and prohibit ORDER BY in query1 and query1. the latter was added already with commit b2dfe28eed, and could be hotfixed. however, the ORDER BY of "call_id" query param is lost, and should be properly handled by forcing strict ordering of how query parameters are applied. the fix will introduce paramater ordering according to their order of definition in the code. Change-Id: I165d341b5c20e9bb750bd1fba88c836b393e80bd (cherry picked from commit a15d00894a)		1 year ago
..
API	MT#56817 MT#56362 fix errors from nondetermistic query param ordering	1 year ago
SOAP	TT#78557 - Use bcrypt to hash webpassword	5 years ago
Administrator.pm	TT#154500 improve admin users behaviour	3 years ago
BatchProvisioning.pm	TT#173900 rename provisioning_template "lang" element	3 years ago
Billing.pm	TT#147151 fast loading/paging/searching panel datatables	4 years ago
CallListSuppression.pm	TT#37104 fix Subroutines::ProhibitBuiltinHomonyms perlcritic error	7 years ago
CallRouting.pm	TT#38005 fix/resolve various perlcritic errors	7 years ago
Callflow.pm	TT#156000 enable callflow UI for users with "call_data" flag	3 years ago
Contact.pm	TT#147151 fast loading/paging/searching panel datatables	4 years ago
Contract.pm	MT#33041 add reseller max subscribers support	2 years ago
Customer.pm	MT#33041 add reseller max subscribers support	2 years ago
Dashboard.pm	TT#22827 Implement form factory	8 years ago
Device.pm	MT#56835 Fix device provisioning when external_number is in use	2 years ago
Domain.pm	MT#55687 add ncos_set preferences support	2 years ago
EmailTemplate.pm	TT#123650 Fix 500 error in Panel UI Email Templates	4 years ago
EmergencyMapping.pm	TT#96652 Add suffix for emergency number.	3 years ago
Grafana.pm	TT#51065 Workaround for grafana not setting UTF-8 in Content-Type for js	6 years ago
Header.pm	TT#182053 hide UI /header page access on CE	3 years ago
InternalSms.pm	TT#179901 Discontinue iNew dedicated features and code (part 2)	2 years ago
Invoice.pm	MT#53849 peer/reseller invoicing	2 years ago
InvoiceTemplate.pm	MT#53849 peer/reseller invoicing	2 years ago
Lnp.pm	TT#34800 inflate/deflate DateTime for timestamps	7 years ago
Login.pm	TT#130659 Improve debug log layout (common style, removing plus/star markers)	4 years ago
Logout.pm	TT#96250 - Delete 'framed' from session on ajax logout	5 years ago
MaliciousCall.pm	TT#56463 fix $c->log vs $c->loc #2	6 years ago
NCOS.pm	MT#57580 add expose_to_customer support for NCOS	2 years ago
Network.pm	TT#177851 BillingNetworks close button (back) target selection	3 years ago
NumberBlock.pm	TT#22827 Implement form factory	8 years ago
Package.pm	TT#177851 Fix ProfilePackage navigation for close button	3 years ago
Pbx.pm	TT#52961 Use separate port for Cisco SPA search	6 years ago
Peering.pm	MT#56776 Fix peer deletion when not enabled	2 years ago
PeeringOverview.pm	TT#29620 Clean TAP test warning: Missing AUTHOR/DESCRIPTION/LICENSE section in POD	7 years ago
Phonebook.pm	TT#182101 hide UI /phonebook page access on CE	3 years ago
Product.pm	TT#65101 add ccareadmin ccare roles	6 years ago
Reseller.pm	MT#33041 add reseller max subscribers support	2 years ago
Rewrite.pm	TT#75000 fix rewrite rule move in replicated table	5 years ago
Root.pm	TT#188950 ignore domain for subscriber authentication	3 years ago
Security.pm	TT#71950 Fix typos	5 years ago
Sound.pm	MT#58709 rework NGCP::Utils::Sound::get_handlers_rs	1 year ago
Statistics.pm	TT#130659 Stop calling systemd openvpn status twice on every HTTP request	4 years ago
Subscriber.pm	MT#57580 add expose_to_customer support for NCOS	2 years ago
SubscriberProfile.pm	MT#55687 add ncos_set preferences support	2 years ago
TimeSet.pm	TT#61813 fix timeset.create after nested reseller creation	6 years ago
Voucher.pm	TT#64370 - Fix for topup voucher ajax error	6 years ago