sipwise
/
ngcp-panel
mirror of https://github.com/sipwise/ngcp-panel.git
1
0
Fork 0
Code Issues Releases Wiki Activity

TT#37104 fix Subroutines::ProhibitBuiltinHomonyms perlcritic error

Browse Source 
to fix sipwise TAP tests.

Change-Id: I622eb8063694a0056d55796001ff35242b0ea847
changes/93/21493/5
Gerhard Jungwirth 8 years ago
parent 20a201581a
commit f916bdcf3f
23 changed files with 28 additions and 28 deletions
Show Stats Download Patch File Download Diff File

2
lib/NGCP/Panel/Controller/Administrator.pm
Unescape View File

@ -237,7 +237,7 @@ sub edit :Chained('base') :PathPart('edit') :Args(0) {
);
}
sub delete :Chained('base') :PathPart('delete') :Args(0) {
sub delete_admin :Chained('base') :PathPart('delete') :Args(0) {
my ($self, $c) = @_;
if($c->stash->{administrator}->id == $c->user->id) {

2
lib/NGCP/Panel/Controller/CallListSuppression.pm
Unescape View File

@ -182,7 +182,7 @@ sub create :Chained('list') :PathPart('create') :Args(0) {
$c->stash(form => $form);
}
sub delete :Chained('base') :PathPart('delete') :Args(0) {
sub delete_suppression :Chained('base') :PathPart('delete') :Args(0) {
my ($self, $c) = @_;
try {

2
lib/NGCP/Panel/Controller/Callflow.pm
Unescape View File

@ -35,7 +35,7 @@ sub root :Chained('/') :PathPart('callflow') :CaptureArgs(0) {
}
sub index :Chained('root') :PathPart('') :Args(0) {
sub callflow_index :Chained('root') :PathPart('') :Args(0) {
my ( $self, $c ) = @_;
$c->stash(

2
lib/NGCP/Panel/Controller/Contact.pm
Unescape View File

@ -215,7 +215,7 @@ sub edit_without_reseller :Chained('base') :PathPart('edit/noreseller') :Args(0)
$self->edit($c, 1);
}
sub delete :Chained('base') :PathPart('delete') :Args(0) {
sub delete_contact :Chained('base') :PathPart('delete') :Args(0) {
my ($self, $c) = @_;
try {

2
lib/NGCP/Panel/Controller/Domain.pm
Unescape View File

@ -258,7 +258,7 @@ sub edit :Chained('base') :PathPart('edit') :Args(0) {
$c->stash(edit_flag => 1);
}
sub delete :Chained('base') :PathPart('delete') :Args(0) {
sub delete_domain :Chained('base') :PathPart('delete') :Args(0) {
my ($self, $c) = @_;
my $domain = $c->stash->{'domain_result'}->domain;

2
lib/NGCP/Panel/Controller/Invoice.pm
Unescape View File

@ -205,7 +205,7 @@ sub create :Chained('inv_list') :PathPart('create') :Args() :Does(ACL) :ACLDetac
$c->stash(create_flag => 1);
}
sub delete :Chained('base') :PathPart('delete') {
sub delete_invoice :Chained('base') :PathPart('delete') {
my ($self, $c) = @_;
try {

2
lib/NGCP/Panel/Controller/InvoiceTemplate.pm
Unescape View File

@ -240,7 +240,7 @@ sub edit_info :Chained('base') :PathPart('editinfo') {
$c->stash(edit_flag => 1);
}
sub delete :Chained('base') :PathPart('delete') {
sub delete_invoicetemplate :Chained('base') :PathPart('delete') {
my ($self, $c) = @_;
try {

2
lib/NGCP/Panel/Controller/Login.pm
Unescape View File

@ -9,7 +9,7 @@ use NGCP::Panel::Form;
use NGCP::Panel::Utils::Admin;
sub index :Path Form {
sub login_index :Path Form {
my ( $self, $c, $realm ) = @_;
$realm = 'subscriber'

2
lib/NGCP/Panel/Controller/Logout.pm
Unescape View File

@ -23,7 +23,7 @@ Catalyst Controller.
=cut
sub index :Path {
sub logout_index :Path {
my ( $self, $c, $realm ) = @_;
$c->logout;

2
lib/NGCP/Panel/Controller/MaliciousCall.pm
Unescape View File

@ -97,7 +97,7 @@ sub base :Chained('mcid_list') :PathPart('') :CaptureArgs(1) {
$c->stash->{mcid_res} = $res;
}
sub delete :Chained('base') :PathPart('delete') {
sub delete_mcall :Chained('base') :PathPart('delete') {
my ($self, $c) = @_;
$c->detach('/denied_page')

2
lib/NGCP/Panel/Controller/NCOS.pm
Unescape View File

@ -138,7 +138,7 @@ sub edit :Chained('base') :PathPart('edit') {
);
}
sub delete :Chained('base') :PathPart('delete') {
sub delete_ncos :Chained('base') :PathPart('delete') {
my ($self, $c) = @_;
try {

2
lib/NGCP/Panel/Controller/Package.pm
Unescape View File

@ -240,7 +240,7 @@ sub edit :Chained('base') :PathPart('edit') :Args(0) {
);
}
sub delete :Chained('base') :PathPart('delete') :Args(0) {
sub delete_package :Chained('base') :PathPart('delete') :Args(0) {
my ($self, $c) = @_;
my $package = $c->stash->{package_result};

2
lib/NGCP/Panel/Controller/Peering.pm
Unescape View File

@ -155,7 +155,7 @@ sub edit :Chained('base') :PathPart('edit') {
return;
}
sub delete :Chained('base') :PathPart('delete') {
sub delete_peering :Chained('base') :PathPart('delete') {
my ($self, $c) = @_;
try {

2
lib/NGCP/Panel/Controller/Phonebook.pm
Unescape View File

@ -178,7 +178,7 @@ sub edit :Chained('base') :PathPart('edit') {
$c->stash(edit_flag => 1);
}
sub delete :Chained('base') :PathPart('delete') {
sub delete_phonebook :Chained('base') :PathPart('delete') {
my ($self, $c) = @_;
try {

5
lib/NGCP/Panel/Controller/Root.pm
Unescape View File

@ -298,7 +298,7 @@ sub auto :Private {
return 1;
}
sub index :Path :Args(0) {
sub root_index :Path :Args(0) {
my ( $self, $c ) = @_;
$c->response->redirect($c->uri_for('/dashboard'));
@ -323,7 +323,8 @@ sub back :Path('/back') :Args(0) {
$c->detach;
}
sub default :Path {
# any path that is not matched by anything else (e.g. /foo/bar)
sub root_default :Path {
my ( $self, $c ) = @_;
$c->detach( '/error_page' );
}

2
lib/NGCP/Panel/Controller/SOAP/Intercept.pm
Unescape View File

@ -15,7 +15,7 @@ sub thewsdl : GET Path('/SOAP/Intercept.wsdl') :Local :Args() {
$c->response->content_type('text/xml');
}
sub index : POST Path('/SOAP/Intercept') {
sub intercept_index : POST Path('/SOAP/Intercept') {
my ($self, $c) = @_;
my $h = Sipwise::SOAP::Intercept->new(c => $c);
my $server = SOAP::Transport::LOCAL::Client->new;

2
lib/NGCP/Panel/Controller/Security.pm
Unescape View File

@ -21,7 +21,7 @@ sub root :PathPart('/') :CaptureArgs(0) {
my ( $self, $c ) = @_;
}
sub index :Chained('/') :PathPart('security') :Args(0) {
sub security_index :Chained('/') :PathPart('security') :Args(0) {
my ( $self, $c ) = @_;
my $ips = NGCP::Panel::Utils::Security::list_banned_ips($c);

2
lib/NGCP/Panel/Controller/Sound.pm
Unescape View File

@ -267,7 +267,7 @@ sub edit :Chained('base') :PathPart('edit') {
return;
}
sub delete :Chained('base') :PathPart('delete') {
sub delete_sound :Chained('base') :PathPart('delete') {
my ($self, $c) = @_;
try {

8
lib/NGCP/Panel/Controller/Statistics.pm
Unescape View File

@ -22,7 +22,7 @@ sub root :PathPart('/') :CaptureArgs(0) {
my ( $self, $c ) = @_;
}
sub index :Chained('/') :PathPart('statistics') :Args(0) {
sub statistics_index :Chained('/') :PathPart('statistics') :Args(0) {
my ( $self, $c ) = @_;
my $posted = ($c->req->method eq 'POST');
@ -58,7 +58,7 @@ sub index :Chained('/') :PathPart('statistics') :Args(0) {
);
if($posted && !$form->validated) {
$c->log->error("tried to select invalid host/folder pair");
$c->response->redirect($c->uri_for_action('/statistics/index'));
$c->response->redirect($c->uri_for_action('/statistics/statistics_index'));
return;
}
delete $c->stash->{hosts};
@ -110,7 +110,7 @@ sub rrd : Chained('/') :PathPart('statistics/rrd') :Args() {
unless(defined $host && defined $folder && defined $file) {
$c->log->error("tried to fetch rrd with incomplete path");
$c->response->redirect($c->uri_for_action('/statistics/index'));
$c->response->redirect($c->uri_for_action('/statistics/statistics_index'));
return;
}
@ -122,7 +122,7 @@ sub rrd : Chained('/') :PathPart('statistics/rrd') :Args() {
return;
}
$c->response->redirect($c->uri_for_action('/statistics/index'));
$c->response->redirect($c->uri_for_action('/statistics/statistics_index'));
return;
}

2
lib/NGCP/Panel/Controller/Voucher.pm
Unescape View File

@ -122,7 +122,7 @@ sub base :Chained('voucher_list') :PathPart('') :CaptureArgs(1) {
$c->stash(voucher_result => $res);
}
sub delete :Chained('base') :PathPart('delete') {
sub delete_voucher :Chained('base') :PathPart('delete') {
my ($self, $c) = @_;
$c->detach('/denied_page')

3
lib/NGCP/Panel/Role/EntitiesItem.pm
Unescape View File

@ -299,8 +299,7 @@ sub put {
return;
}
sub delete {
sub delete { ## no critic (ProhibitBuiltinHomonyms)
my ($self, $c, $id) = @_;
my $guard = $self->get_transaction_control($c);

2
lib/NGCP/Panel/Widget/Dashboard/AdminSystemOverview.pm
Unescape View File

@ -35,7 +35,7 @@ sub emergency_mode {
return $em_count.'';
}
sub system {
sub system_status {
my ($self, $c) = @_;
return { color => "#000000", text => $c->loc("OK") };
}

2
share/templates/widgets/admin_system_overview.tt
Unescape View File

@ -9,7 +9,7 @@ enqueLists.push([{
$("#admin_system_overview_lazy_items_list").prepend('<li>[% c.loc('Applications') %] <strong style="color:' + col + '">' + txt + '</strong></li>');
}
},{
res: 'system',
res: 'system_status',
widgetName: "AdminSystemOverview",
cb: function(data) {
//console.log(data);

Write Preview
Loading…
Cancel
Save