1926 Commits (96364f14a5eb93a8d4fe041fa6a43c033d3d2bc2)

Author	SHA1	Message	Date
Rene Krenn	22c3696930	MT#56817 MT#56362 fix errors from nondetermistic query param ordering ... the /api/callists rail supports the "call_id" query parameter to match calls with a callid prefix. this filter also adds an implicity ordering ORDER BY length(call_id) ASC, 'start_time' ASC. the /api/callists api rail also requires the query parameter "susbcriber_id", which renders a (fast) compound SQL query to list matching incoming (query1) and outgoing calls (query2) using UNION ALL (instead of a slow OR query). query1 UNION ALL query2 this is supported by the https://metacpan.org/pod/DBIx::Class::Helper::ResultSet::SetOperations module, which however generates invalid SQL syntax if query1 or query2 contains an ORDER BY. this is exactly what caused the 500 error of the customer who applied both "call_id" and "susbcriber_id" parameter in the request at the same time. ... ORDER BY length(call_id) ASC, `start_time` ASC UNION ALL SELECT `me`.`id`... the error happens randomly, because query parameters are stored in a hash (which by definition has no deterministic order of the entries). when the "call_id" parameter is applied at last, it worked as expected. so the issue can be adressed by strictly ordering the UNION ALL result, and prohibit ORDER BY in query1 and query1. the latter was added already with commit b2dfe28eed, and could be hotfixed. however, the ORDER BY of "call_id" query param is lost, and should be properly handled by forcing strict ordering of how query parameters are applied. the fix will introduce paramater ordering according to their order of definition in the code. Change-Id: I165d341b5c20e9bb750bd1fba88c836b393e80bd (cherry picked from commit a15d00894a)	1 year ago
Rene Krenn	8e9be5b63e	MT#59216 restore appending wildcard behaviour ... with the change to harmonize wildcard symbols % and * to * in query param filters across all restapi rails, only - /api/subscribers?alias= - /api/subscribers?pbx_extension= - /api/subscribers?primary_number= - /api/pbxdevices?pbx_extension= are supposed to include implicit leading an trailing wildcards. panel UI uses trailing wildcard by default everywhere, and so should the databales of the new Admin UI. external_id were used to support patterns, but must not include a trailing wildcard in rest API, as this can break logic that rely on unique api request results. we now therefore no longer append wildcards in particular to: - /api/voicemails?folder= - /api/voicemailgreetings?type= - /api/subscribers?subscriber_external_id= - /api/subscribers?customer_external_id= - /api/subscribers?display_name= - /api/subscribers?domain= - /api/profilepackages?profile_name= - /api/profilepackages?network_name= - /api/pbxdevices?display_name= - /api/faxserversettings?name_or_password= Change-Id: I40ef1912d7224a56c6d14619d258c70e447ab23d (cherry picked from commit 672a3110bc)	1 year ago
Kirill Solomko	52ad4f81bd	MT#59238 fix rewrite rules transaction control for PATCH,DELETE ... * /api/rewriterules PATCH, DELETE methods used the generic transaction, which conflicted with the xmlrpc reload command. * own_transaction_control was only set for PUT and now also extended to PATCH, DELETE to ensure that dialplan_sip_reload() is called properly after $guard->commit. Change-Id: I7313b4f6d1f6699bf38ae34749c5383a3943f61d (cherry picked from commit 80f8b1da0b)	1 year ago
Kirill Solomko	edaca5c52e	MT#58709 rework NGCP::Utils::Sound::get_handlers_rs ... * get_handlers_rs() is renamed into get_file_handles() and reworked from an indented 'from' resultset into 2 separate resultsets, one fetching all the handles and another one files for the sound set, it is now returned as an array with the similar data. Reason for this rework is the deprecated use of 'from', that resulted in a lot of warnings in panel-fcgi.log: DBIx::Class::SQLMaker::ClassicExtensions::_join_condition(): ResultSet {from} structures with conditions not conforming to the SQL::Abstract::Classic syntax are deprecated: you either need to stop abusing {from} altogether, or express the condition properly using the { -ident => ... } * adjust file_handles data key names to better follow the naming conventions and readability, e.g.: groupname -> group_name, fileid -> file_id Change-Id: Ia91c9104c0b4dc79ee5bc359eb0b6e035e56ef3e (cherry picked from commit a4d54b10e4)	1 year ago
Rene Krenn	2fb7b3ebbf	MT#58890 force cft_ringtimeout as number ... Change-Id: I4df4fbf6522d28a30731c87a36c95ae8350830fa (cherry picked from commit cc8fd8928d)	1 year ago
Rene Krenn	50333dd988	MT#59025 fix peering groups name filter ... Change-Id: I329e644c937058069c5932abf8e897dce48a8c10 (cherry picked from commit 1e9f223276)	1 year ago
Rene Krenn	c7d653565f	MT#58762 adjust restpi tests to harmonized wildcard filters ... Change-Id: I68b2199a3487fedb388803012c950c3abca1a8b3 (cherry picked from commit aa2d07ef29) (cherry picked from commit 5f070d0fd8)	1 year ago
Rene Krenn	182e67e2dc	MT#58762 harmonize restapi wildcard filters ... - all standard LIKE search are migrated - will avoid LIKE unless a pattern (* wildcard) is used as a search term. this encourage db index usage, will be faster - supports wildcard escape sequence \\* - harmonize swagger UI descriptions of filters Change-Id: Iea155871c9be6c284e6970a562d4e6af73fedc4b (cherry picked from commit 308a974059) (cherry picked from commit 5b62ba15f3)	1 year ago
Rene Krenn	3b69942ab1	MT#56239 avoid ambersand symbol in apidoc descriptions ... Change-Id: Ic024d16c008648cb4d9cf14ae0e58d1ebe8febe9 (cherry picked from commit 71480acfa3)	1 year ago
Rene Krenn	d43cd398f4	MT#56239 api/callrecordings support filtering multiple metakeys ... filtering an Entity-Attribute-Value model cannot be done as simple conjunctions, but requires either INTERSECT set operation, or joining the same table multiple times. Change-Id: I5ce1ae1ece9406b6610487654f09d768a233b122 (cherry picked from commit 8e82715eb8)	1 year ago
Rene Krenn	7dd64659eb	MT#56239 api general caller/callee wildcard search support ... various api rails will need to support ?caller= and ?callee= url query parameters. since this involves SQL queries against potentially large database tables, special care is taken with wildcard search to prevent slow queries: - the ?wildcards=true query parameter has to be specified to accept search patterns that contain wildcard symbols, so wildcards are not accepted by default. WARNING: a search string with a leading wildcard will always force a *slow* full db table scan! - the * symbol is used as a wildcard symbol - \ (backslash) is used as escape character to search for a literal '*' Change-Id: Ie6065b0cfa883f7963e1dc8259fffea9a1edfdfe (cherry picked from commit 9c3a549094)	1 year ago
Rene Krenn	df2251e44e	MT#58346 caller/callee filters for conversations ... the conversation list now supports ?caller= and ?callee= url query parameters. since this involves SQL queries against potentially large database tables, special care is taken with wildcard search to prevent slow queries: - the ?wildcard=true query parameter has to be specified to accept search patterns that contain wildcard symbols, so wilddcards are not accepted by default. WARNING: a search string with a leading wildcard will always force a *slow* full db table scan! - the * symbol is used as a wildcard symbol - \ (backslash) is used as escape character to search for a literal '*' Change-Id: I792d2ea9c649c69c4b5cc98076097cb96467d4bc (cherry picked from commit ae612eb401)	1 year ago
Marco Capetta	b79d73232e	MT#58596 Enable api soundgroups and soundhandles for subscriber ... The commit extends what done already in e15e40423 allowing the subscribers to get the soundgroups and soundhandles using API. This is necessary for some CSC features like the selection of the Custom Announcement to play after Call Forward. Change-Id: I40d57d1efdc107c64fe3efafd9e87d1403c4d124	2 years ago
Kirill Solomko	9b4099ea40	MT#58430 fix allowed_ngcp_types in API GET ... * allowed_ngcp_types check is now correct in the Controller:API::Root::GET * also fix allowed roles check Change-Id: I2446d7377d2a1ef152560bfb2799bb9debd0f34b (cherry picked from commit 706b472465)	2 years ago
Kirill Solomko	b7c22618c8	MT#57987 /api/rewriterules calculate priority on create ... * when a new rewrite rule is created and the priority attribute is not specified, only the first rewrite rule of the same rewrite rule set is set as 50, and the following are as: "MAX(priority) of the same rewrite rule set"+1 Change-Id: I1f1ae275e00918a34a625409987f21044b3b940f	2 years ago
Kirill Solomko	6953de937c	MT#33041 add reseller max subscribers support ... * Max subscribers can now be defined in the Reseller contract * Max subscribers is now shown in int Reseller's "Reseller Contract" Details (with an indictaion of how many subscribers are created out of the defined max subscribers, as well as when the limit is reached (similar to the Customer's Details page) * Add reseller subscribers count checks on the UI Create Subscriber page * Add reseller subscribers count checks in /api/contracts POST/PUT * Prevent max_subscribers definition for Peering contracts in /api/contracts POST/PUT Change-Id: I1561d4eb7da5b1a0a0c99acabd18d2a9cd98dec7	2 years ago
Rene Krenn	8fbd46e5fc	MT#57382 DELETE /api/faxes/id ... Change-Id: If578cd842d83e3471659164826d3e0305018cc29	2 years ago
Marco Capetta	967bc581fe	TT#179901 Discontinue iNew dedicated features and code (part 2) ... Remove party_call_control feature Change-Id: I6ea1c725a463ee62696de93a7ee52080515cc2b7	2 years ago
Rene Krenn	cde01e7d66	MT#53849 peer/reseller invoicing ... Change-Id: I0d869edb697779e7d02caaea70c237f0c87f4d50	2 years ago
Donat Zenichev	fd796a91ba	MT#56845 HG: introduce new field `Cancel Mode` ... This field controls a behavior upon cancelling unsuccessful legs: - terminate legs with CANCEL (default way) - terminate legs with BYE Change-Id: I2ff5c758c319714f0e6636db8b8ba5c0fd495e1f	2 years ago
Kirill Solomko	22a8e95c29	MT#57708 sound set/file use READ COMMITTED ... * as changes to sound sets and sound files cause internal triggers + SP to be invoked, the gap locking should be reduced to avoid possible deadlocks, hence READ COMMITTED transaction isolation level is used for all sound sets and sound files change operations. * fix a condition that caused an evaluation error when both old_parent_id and parent_id are undef. Change-Id: I7e69a0a0e5878c03b086977933315e532aaa2a29	2 years ago
Kirill Solomko	9d9c0d0669	MT#57580 add expose_to_customer support for NCOS ... * NCOS Levels and NCOS Sets now have expose_to_customer option (boolean). If enabled, the NCOS Level/Set can be seen and used by Customers in their and their subscribers' preferences * NCOS Levels and NCOS Sets with expose_to_customer = 0 (default) are not visible anymore to subscribers. * API GET /api/ncoslevels is now accessible by 'subscriberadmin' role and returns a list of NCOS Levels that belong to the same reseller and with expose_to_customer = 1 (fields are limited to id,name,description). * When NCOS Level is expose_to_customer is set from 1 to 0, all assigned ncos preferences for contracts and subscribers are that contain the NCOS Level are removed. Change-Id: Id7c444b4a0834939a128179ded6670705258519b	2 years ago
Kirill Solomko	19f5c68bce	MT#56693 fix /api/soundfiles without Content-Type ... * prevent an error if /api/soundfiles is called without the Content-Type header Change-Id: I1c0844c789839ad4dabedef216336b1387db074e	2 years ago
Marco Capetta	28340ce871	MT#56181 Fix link of AutoAttendant edit slots ... From the very origin of the AA module the link used in panel to create/edit the AA slots were '/preferences/speeddial/edit'. This is wrong and most probably coming from a copy and paste of the speeddial feature. The commit fix the link and it is now chaged to the following '/preferences/autoattendant/edit'. Change-Id: I095b433cad78fb0175b0551fcfdea85815f73cdf	2 years ago
Kirill Solomko	391aa3fbc3	MT#57564 convert deprecated timezone names ... * timezone names are converted to their links, and if a link is found (means that the current name is deprecated), it's validated and stored as the link. Change-Id: I6348659178400a96eaadd70f79b792c4fa25d7d4	2 years ago
Marco Capetta	be7193e75b	MT#57469 Fix kamailio lcr reload on PATCH/PUT APIs ... When calling a PATCH or PUT API on a peering group or outbound rule the reload of the kamailio lcr module was triggered before the update of the database, thus the kamailio status was not updated. Change-Id: I59ed863c85219e62d6f5b5a2af80db8ef952844c	2 years ago
Kirill Solomko	89173442f3	MT#57223 improve sems audio cache invalidation ... * clear_audio_cache is now invoked also from: - when a sound file is added (to reflect use_parent/potential child sets) - when a parent is changed for a sound set (to reflect current and potential child sets) - when a sound set is removed (to reflect potential child sets) * clear_audio_cache() is reworked - clear_audio_cache() now calls virtual_child_sound_sets to fetch all potentially affected child sound sets and also clears audio cache for them. if the amount of fetched sound_sets is greater than 10000 then the the whole audio cache is invalidated * _clear_audio_cache_service() is reworked - supports/expects a list of sound sets and sends them as a string with ':' separator - if both sound handle and sound sets are provided it calls clearFiles (so that only the specific sound handle is cleared) - if only sound sets are provided it calls clearSets (so that all of the cached files beloning to the sets are removed) - if none of the above are provided it calls clearAll to invalidate the whole cache Change-Id: Ie85f208e27183e88665803b93bb16d7de8e3d7ac	2 years ago
Kirill Solomko	7bc5ec093f	MT#57216 fix advanced cf sets selection for admins ... * $c->user->id was wrongly used in the advanced cfs selection and now changed to $prov_subscriber->id to filter it regardless of the user editing the cfs Change-Id: I8fa65bbce625d4b21dbb620a1f92919ed7fe2a88	2 years ago
Kirill Solomko	0370507310	MT#57155 /api/rewriterules add filter by direction,field ... * filter by direction and field (caller or callee) Change-Id: I0205ead6cf2a1d51532992f67a5add63cdeb51e0	2 years ago
Rene Krenn	5e2f599eb9	MT#57171 speedup DELETE /api/lnpnumbers/id ... Change-Id: I2b3f817b95e311b922e935453f659893004c5be4	2 years ago
Kirill Solomko	407d6f3f3b	MT#56693 /api/soundets fix DELETE subscriberadmin access ... * subscriberadmin can only delete items that belong to the same contract_id, otherwise 'read-only' forbidden error is returned Change-Id: I3ef2716039626bc1b208a5c7af06cf87f69cad73	2 years ago
Kirill Solomko	c58a8b9b1f	MT#57100 avoid where ambiguity for query_types search_eq,search_like ... * uses prefix 'me.' for query types search_eq and search_like in the where condition to avoid ambiguity if the search_rs has joins that with the same column names Change-Id: I90fef80970aa4415480b00bbed2fb9fbee1f1ccc	2 years ago
Kirill Solomko	c5b288a9da	MT#57085 fix /api/peeringroups form operations ... * API now has own GroupAPI form with the correct fields for API * db/form field name conversion is moved to the newly added resource_from_item() and process_form_resource() functions * simplify code for GET/POST/PUT/PATCH operations Change-Id: I99b76801a2894c8a4821513186796627db728189	2 years ago
Kirill Solomko	6a922c5cfb	MT#56693 parent_name, allow empty sound files, sems audio cache ... * /api/soundsets new parent_name field * /api/soundfiles now allow POST to be done without the upload, for cases when an empty record needs to be added to define "use_parent" behaviour * improve sems audio cache clear on sound files change, now sems instances that are not available (not running/request timeout) are skipped instead of raising an error Change-Id: I83af2ee2fd3672ab35cf330464ace68416ab52be	2 years ago
Kirill Solomko	0a4d5e4628	MT#56693 fix parent sound sets list for sound set creation ... * in a scenario when a sound set was "edited" and then a new one created, in the creation dialog the previously edited sound set was missing in the list of available parents Change-Id: I8d7652a9f7f881be6d700dc4f6cf77dc426261e7	2 years ago
Kirill Solomko	44ec794db2	MT#56693 add parent sound set support ... * sound sets can now use other sound sets as parents, in this case if a sound is missing for a sound set, it's taken from the parent one if it exists there, chained parents are also supported with the available sound files "accumulated" across them. * add "expose_to_customer" field to sound sets, it enables exposing system sound sets to customers so they can be used as a parent or assigned to the 'sound_set' preference by 'subscriberadmin'. * add "use_parent" field to sound set files, it's true by default (for existing or missing sound files) and if set to 0, then parents are not used for this particular sound file. * use_parent column is hidden on the UI if a sound set does not have a parent assigned * improve sound set handles list on the UI - Upload is renamed to Add - empty record are shown in the filename column as localised "(empty)" and Edit/Delete action buttons * API /api/soundsets new 'parent_id' field, default null * API /api/soundfiles new 'use_parent' field, default 1 * API /api/soundsets new 'expose_to_customer' field, default 0 * API /api/soundsets customer_id field now contains the customer id for 'subscriberadmin' role and 'null' if it's a system sound set * system sound sets with expose_to_customer == 1 and within the same reseller are now visible to 'subscriberadmin' on the UI and via the API in read-only mode, same with the sound files that belong to the sound set. If a system sound set expose_to_customer is set back to 0, this sound set is automatically removed from all contract sound sets where it was assigned as a parent as well as from all subscriber 'sound_set' preferences. * contract_sound_set|sound_set preference API updates now have tigher checks for contract_id and also if the system sound set is exposed to the customer and belongs to the same reseller Change-Id: I4908fd15e9c224d4c30794ceb8dae1b444bbf56a	2 years ago
Marco Capetta	16a82cb09d	MT#56403 Add new internal preferences to show/hide CSC menus ... * csc_registered_devices * csc_conversations * csc_device_provisioning * csc_hunt_groups Change-Id: I396d6a5f2d39b1b37389e79d3d0e8a73e2f7f13b	2 years ago
Rene Krenn	a9b1ba896b	MT#56917 fix rwr 'description' filter ... a 500 error results when specifying the RewriteRule "description" filter because of ambigous field names. Change-Id: I9c0a9f6c84ec62fca4c77ce904fb07c4dadef13b	2 years ago
Marco Capetta	0274ab04c3	MT#56776 Fix peer deletion when not enabled ... Deletion of a disabled peer was not working because panel was trying to get the correspondant ID from the LCR table, while the entry is not there because peer was in fact disabled. To fix it an additional check has been added to evaluate if the peer is enabled or not at the moment of the deletion. Change-Id: I3c488a8711c5f7b486b6c0a3950738fb8689bb07	2 years ago
Marco Capetta	26b63e88f0	MT#56835 Fix device provisioning when external_number is in use ... In case device is provisioned with lines that use the external_number feature, then the provisioning system uses the pilot subscriber username instead. This because the external_number is not properly passed to the provisioning templates. Change-Id: I48e494b303db318d504578f10e8b44aa9b64ddc5	2 years ago
Marco Capetta	257364e4df	MT#56740 Discontinue jitsi autoprovisioning ... The feature is not used and most probably not working at all since we don't support the jitsi client anymore. Change-Id: I2ce4c56e30d604ea840a44b09021d14937777159	2 years ago
Marco Capetta	549861e5fb	MT#56739 Remove already deprecated preference 'enable_t38' ... The 'enable_t38' preference was added long time ago to provision of phones that support fax services with t38. We don't support those devices since long time. Additionally the preference creates confusion with real subscriber feature of enable t38 for mailtofax/faxtomail service. Due to those reason the preference can be removed. Change-Id: Ib9f4f37354a62ad59ba8c5b63ae476142b36e717	2 years ago
Marco Capetta	35949e9a59	MT#56526 Discontinue dialogic setting/provisioning ... The feature was never really used and no customer is using it at the moment. Change-Id: Id90a1cacbc238312066c02cbbfd8a423b77c24a4	2 years ago
Kirill Solomko	fa82bac3ca	MT#56455 fix peering groups timeset relation ... * fix wrong timeset relation name from timeset.name to time_set.name Change-Id: Iaeb20310943ca4c0c2254f2f4d53c770739bdbe2	2 years ago
Kirill Solomko	b850771110	MT#56432 UI prevent ncos level timeset to have different reseller_id ... Change-Id: Ic4874d48e59a4104ddc297ee29fc136a8faf7c37	2 years ago
Kirill Solomko	2a0b8dcc1e	MT#56432 add time set support to ncos levels ... * add NCOS Levels UI Time Set support * add NCOS Levels API Time Set support Change-Id: I03201c09462f0f0ceff39da271bcf8ca1fc797b8	2 years ago
Kirill Solomko	dee6b60c6e	MT#56208 additional inherited cfs improvements for subscribers ... * API: GET collection returns only distinct cf sets * UI: inherited cf sets are now shown in the advanced view and having suffix '(inherited)' to distinguish them from the own ones as they are not available in the "Manage Sets" edit dialog. Change-Id: Ifd8c1a46fcb4c2c66f8f63268a1e91b80792c216	2 years ago
Kirill Solomko	519de11d8c	MT#55931 add autoprov field device target_number support ... * the UI field device edit form now contains a checkbox that, when checked, replaces the subscriber devices dropdown with an input text (only [0-9#*] chars are allowed) * aligned the related script code to automatically detect and handle switching between the sub number / target_number Change-Id: I70ae5cf5bb81f5953d25a760fbf0efe6c418f6cb	2 years ago
Marco Capetta	36ae8cedb9	MT#55931 Add new speeddial, forward, transfer device buttons ... Change-Id: I0b9c1f3ddb0d4cd3fe28995b170e9104c668a553	2 years ago
Kirill Solomko	e90ba9d517	MT#56208 allow subscriber role access to cf sets ... * subscriber role can now GET call forward sets that does not belong to the user but used in call forwards assigned to the user * the user can only GET the sets but cannot update/delete them (403 Forbidden is raised in case of attempt) Change-Id: I391b802d962f4bbeae991e3046ac3f132a19edb6	2 years ago