5489 Commits (75bd22b8c46df9a409d3f614bffe25700bb994e7)

 

All Branches   

Search

Author	SHA1	Message	Date
Rene Krenn	75bd22b8c4	MT#61646 fix phoenbook .csv encoding ... Change-Id: Iaf7e6a0d13f34459fb00478dc6285875fba52cfb (cherry picked from commit 8a11b8e996)	2 weeks ago
Marco Capetta	ab34a06fe8	MT#62546 Fix permanent registration nat flags ... Due to changes in how kamailio manage the NAT contacts and the corresponding natping, the flags that the API or web interface sets while a permanent registration is created have to be updated. Before: * Default cflag is set to 0 (natping disabled) * If nat option, then cflag is set to 64 New: * Default cflag is set to 256 (netping disabled) * If nat option, then cflag is set to 128 Change-Id: I39b1d7a697ef72267fd8a05edf0552d2c1403733 (cherry picked from commit 1be3f5a257)	3 weeks ago
Kirill Solomko	ae5a3b73fe	MT#62178 fix external_id, profile auto removal for subscriber roles ... * fix 'subscriber' and 'subscriberadmin' roles using PATCH to cause external_id, and profile fields removed. * remove profile_id field from the 'subscriber' and 'subscriberadmin' form Change-Id: Id8bb068ca7fcac2c0c5954f2ed79e841d18ac398 (cherry picked from commit 97e457c92b)	2 months ago
Kirill Solomko	4899e86fdb	MT#61572 allow subscriber to GET resellerbrandinglogos ... * 'subscriber' role can now GET resellerbrandinglogos * fix 'subscriberadmin' role access to POST resellerbrandinglogos Change-Id: I4002117e15e5557dfbfe887dea3773d8704aeb14 (cherry picked from commit 989e7b5640)	2 months ago
Kirill Solomko	af4d120e94	MT#62223 improve error response handling when log_response is off ... * log_response: 0 is reworked, it now always logs the response but in case if it's off the body is not logged. * adjust error logging, the error in the body is correctly logged in the response even if log_response: 0 Change-Id: I6dfddeccffb5464b830133235bf63c5e82ae6073 (cherry picked from commit e8f41aba50)	2 months ago
Kirill Solomko	1a8210f3d4	MT#62223 API unhandled internal errors cause 500 error ... * unhandled internal errors (such as DBI error) are now properly returned as 500 Internal Server Error instead of 200 OK Change-Id: Iabc80cd200c9091dd249bc90aa586d5d7b616b69 (cherry picked from commit cbc4e57d45)	2 months ago
Kirill Solomko	8c69ddf504	MT#62180 /api/subscribers prevent subscribers from POST/DELETE ... * regular subscribers should not be able to use POST as they are not allowed to create other subscribers, nor other PBX groups. resource. * they should not be able to use DELETE as they cannot delete themselves nor other subscribers, nor PBX groups. Change-Id: Idaacb344b65ff8c5da9f4c3649a9b4089938a82c (cherry picked from commit 4eace822b5)	2 months ago
Richard Fuchs	a54248e1c5	MT#59979 defuse license logs ... A missing license is allowable on CE systems. Don't log errors if license is missing. Don't die if sysopen() fails. Change-Id: I00c8ecf361548da6452f1b631d308d9aa8901368 (cherry picked from commit 015ee893d9)	2 months ago
Kirill Solomko	25381e726b	MT#62093 return 403 Banned for banned users ... * add banned user redirect for API requests Change-Id: I0b09879c2e0802c8cc649c92c239449742314b56 (cherry picked from commit d5fd8679fe)	3 months ago
Nico Schedel	9efae5da25	MT#55677 fix contact and customer tests ... Change-Id: I437095587bb772b20a52853c82ec4dbab74c87f8 (cherry picked from commit 72f483ae0a)	3 months ago
Nico Schedel	21be931798	MT#55677 fix contact and customer selenium tests ... Change-Id: I9702610be02e0b566aff0e0cc616ce3274b8080e (cherry picked from commit aaa834db91)	3 months ago
Rene Krenn	55b06ee835	MT#61558 fix reseller (branding) license restriction ... some rails got disabled when introducing the fine-grained license restrictions in api/panel, ie. reseller branding. Change-Id: I0b3690d8e0353c31f2c8680db63c4dd4df7600fe (cherry picked from commit 9f4c50c5dd)	4 months ago
Kirill Solomko	56d5094cb3	MT#61673 /api/calllists fix missing type response field ... * The 'type' field is now present in the reponse as it's described in the form and also the search params but was not rendered correctly because in the database it is as 'call_type' Change-Id: If7b69a33ed9578be6873462dbab79c9a2079b076 (cherry picked from commit 1873193814)	5 months ago
Rene Krenn	f3efcc36cc	MT#61513 prevent duplicates in GET /api/callrecordings ... callrecording metakeys such as "uuid" for the involved call party is present multiple times by nature. the ?subscriber_id= query param will then narrow down the result. alongside an implicit role filtering (reseller/subscriber), the sql join and filtering for the uuid key is present 2 times however, and multiplied records slip through. this can be prevented with DISTINCT. to avoid performance impacts and consider other metakeys orrcuring multiple times, it will be applied only if a filter is present. Change-Id: I08047aaee265e2e0a706220e03fd4617da16d33c (cherry picked from commit 598f7dbaf4)	5 months ago
Rene Krenn	6db10cc3f7	MT#60197 support deleting call recordings per subscriber ... admin panel will no longer delete callrecordings for all parties of the call, but the single subscriber only. rest-api, behaves the same way, if the ?subscriber_id= parameter is provided. when a callrecording is deleted by all call parties, the remaining records and recording files will be dropped. Change-Id: I61f667bdb074a935a8a04473a3685b10e5e09222 (cherry picked from commit 1c09e2773a)	5 months ago
Mykola Malkov	e06fd6e004	MT#58444 Set correct permissions/ownership for ssl files ... Key and csr files should be 640. All other files 644. Ownership for all files should be root:ssl-cert. Change-Id: Ie4c0c8070d856d881b9d47aa65f953869537ee1e (cherry picked from commit a8476ad20d)	6 months ago
Marco Capetta	2dddd7ec82	MT#60864 Fix Sync Email Templates button behavior ... The 'Sync Email Templates' button is shown in the Email Templates page in case some templates is missing for a reseller. The problem is that the button takes into consideration also resellers that are already terminated and for which the template is not needed anymore. Thus the query has been in fixed in order adding: r.status != 'terminated' Change-Id: I2dd551166ae777c8967eae3bda989b669b46b5c0 (cherry picked from commit 97adbaf8e7)	7 months ago
Kirill Solomko	ad90357078	MT#60553 handle API subscriber timezone field separately ... * timezone field for SubscriberSubAdminAPI form is now Text instead of +NGCP::Panel::Field::TimezoneSelect because the template => 'helpers/datatables_field.tt' produces a field validation error, as well as the Field is designed for UI and not API. * add validate_timezone() field validation to SubscriberAPI and SubscriberSubAdminAPI forms. Change-Id: I6391694284477976d8d6cee71a81e2241bd94937 (cherry picked from commit e83588874b)	7 months ago
Marco Capetta	d2ef595fac	MT#61065 Fix 'cli' preference removal ... In commit b51c0c9698 the possibility to change the 'cli' preference by subscriber and subscriber_admin was added (under certain limits). On the other hand, the additiona of that part of code broke the possibility to remove the preference using the PATCH api. It is a very uncommon scenario though, but it seems anyway used by some customer. We may think to deprecate this possibility one day, but till then we don't have to create regression to customer. Change-Id: Ie695b567929eb79b1ba63d3c5a31ae5ce7b559bd (cherry picked from commit f9a328f83d)	7 months ago
Marco Capetta	c27388f218	MT#60756 Fix subscriberprofiles POST api call as reseller ... Administrators with reseller role were not able to create new subscriberprofiles because API was fialing with 500 error. In particular: LOG="«DBIx::Class::Row::store_column(): No such column 'reseller_id' on NGCP::Panel::Model::DB::voip_subscriber_profiles at /usr/share/perl5/NGCP/Panel/Controller/API/SubscriberProfiles.pm line 172» The error was caused by the addition of the reseller_id info in the $resourse even if not needed. Change-Id: I7970a2716d7af959639937a9a844160ab73a9176 (cherry picked from commit d40126ef0a)	8 months ago
Marco Capetta	7d626ad3e0	MT#60860 Update new favicon in png format ... Firefox requires a png format of the favicon instead of an ico version, so this format has been added as well in all the possible supported sizes. Change-Id: I69ccb339f01953e32a89eeded6587030fe05cfeb (cherry picked from commit a02cac37c3)	8 months ago
Marco Capetta	dc9f70f0b1	MT#60860 Update new sipwise logo ... The new sipwise logo has been updated in: * AUI header * CSC header * AUI/CSC favicon * AUI default invoice template Change-Id: I9367c72615d210c66f35ee27a378aa427021ab56 (cherry picked from commit 43a1be5aee)	8 months ago
Kirill Solomko	afb2dba6d5	MT#59449 fix perform_auth to send correct realm to ban check ... * perform_auth $realm is in a form of a subrealm, e.g. api_admin_http api_admin_jwt, etc. where for bans check it's 'admin' realm. Therefore, user_is_banned() is now called from there using explicit 'admin' realm as the argument. Change-Id: I3a10a9b492bf9dbe83ddd34a8851e83b23f90587 (cherry picked from commit a3945269fc)	8 months ago
Kirill Solomko	226b7eb42d	MT#60558 invoke max subscribers/group license check only on POST ... * max subscribers/group license check is invoked only on POST to enable clients to modify existing entries even if the threshold is reached. Change-Id: I858b42ada5c95c179f901e43837b15358027011b (cherry picked from commit e09de1e781)	8 months ago
Marco Capetta	45752b2fbd	MT#59449 Fix selenium tests after password enforcements ... Change-Id: I6f7b4c5598acf126008a6e72bc8021e1007ff2ac (cherry picked from commit 463969b2a8)	9 months ago
Sipwise Jenkins Builder	c809e02eda	Release new version 12.5.2.0+0~mr12.5.2.0	9 months ago
Marco Capetta	4828b02c20	MT#59979 permit GET on resellers and billing profiles items even without license ... In some cases the UI requires to GET information from a specific reseller or billing profile because needed to show/created other endpoints (for example 'customers'). Due to that it has been added the possiiblity to do the GET not only of the list of the resellers and biling profiles, but also of each specific item. Change-Id: Iebbbbc494ce71e616d8e41ca20e97bebce7998b8 (cherry picked from commit a2a01d4690)	9 months ago
Kirill Solomko	69867edb2c	MT#60300 fix sound sets list rendering for reseller ... * fix code typo that prevented correct rendering of the sound sets list for reseller roles Change-Id: I35ea38a37932b8dd563a0b95f7e2481a5c45cdbe (cherry picked from commit c7ae8c1dcf)	9 months ago
Kirill Solomko	8009635013	MT#59449 fix subscriber auth attempts without username ... * subscriber login attempts without Basic Auth are now correctly intercepted and returned as 403 Forbidden Change-Id: I3deb60d8ac4f107bccd6422d27426e39a39e50f1 (cherry picked from commit 0a9fb5d28b)	9 months ago
Kirill Solomko	03b28a3f72	MT#60558 fix max_pbx_groups $c argument typo ... Change-Id: Id0c4d2078c98d20d236851e977439959624d1491 (cherry picked from commit c4c710e7dc)	9 months ago
Kirill Solomko	73468cabde	MT#60558 move max license checks for POST /api/subscribers ... * the relevant max license checkes are moved from Controller::API::Subscribers::POST to Utils::Subscribers::prepare_resource because there we fetch customer_id from the pilot subscriber in case of pbx subscriberadmin requests that is neccessary for PBX subscribers max license check. Change-Id: I2d1c212d73fe5b9295d1595b4fffebeb67b61e5a (cherry picked from commit e2e1776090)	9 months ago
Kirill Solomko	6ba0c24142	MT#60601 obfuscate password/webpassword in API valdiation errors ... * plain text passwords are obfuscated in validation errors returned by API Change-Id: Iff989696ce09faff34692eaa129aee6981340a97 (cherry picked from commit 65ae07a97b)	9 months ago
Kirill Solomko	354791c369	MT#59449 sub auth fix possible username without undef domain ... * perform_subscriber_auth(): check if domain is undefined and use only $user, otherwise $user . @ . $domain. Change-Id: I3d342fb2c4768c2b7b3e0c08ea41e429b83e9683 (cherry picked from commit 4a9a632da1)	9 months ago
Kirill Solomko	4edd8bdc7c	MT#59449 add progressive user bans support ... * users are now progressively banned. * ban_min_time is used to ban a user for the first time. * consecutive ban is ban_min_time + ban_increment * ban_increment_stage * ban_max_time is the absolute maximum ban time that is not increased any further. * a successful login resets the ban_increment_stage. Change-Id: I4d7e1a93d7a21d21a0dcf69d856a872d2ed75ea0 (cherry picked from commit 2972d3b62d)	9 months ago
Kirill Solomko	7c74eef55a	MT#60595 add expand by package_id ... * package_id field can now be expanded Change-Id: I6555134fbc5c50aae49a64876712fcc8678385f2 (cherry picked from commit f383837ea9)	9 months ago
Kirill Solomko	c71fe13057	MT#59449 fix password validation enabled/disabled, admins ... * correctly detect and skip password validation when sip_validatation or web_validation is not enabled respectively * better detect web password for admin users * /api/admins PUT/PATCH now also correctly checks last used passwords Change-Id: I9a6fa9b8e30ae2b81d2852dec0e1f9d858be13ef (cherry picked from commit e6b29d3e7b)	9 months ago
Sipwise Jenkins Builder	6247e7167f	Release new version 12.5.1.0+0~mr12.5.1.0	9 months ago
Kirill Solomko	cfe0a44b8d	MT#60585 add user ban by IP address, ban JWT invalid attempts ... * ban users by IP addresses * ban invalid JWT attempts Change-Id: I0c7746aa751ca96cba0ce4d1388646ba4890a422	9 months ago
Kirill Solomko	60fa23cb68	MT#60585 add user ban support ... * users for admin/subscriber realms are now banned if failed to login X amount of times (UI/API). * rework Redis connection and it's now a Catalyst plugin NGCP::Redis accessed by $c->redis_get_connection({database => 19}), the connection per database, per worker process is established only once and then reused (with auto built-in reconnect support). * remove Utils::Redis.pm as it does not have any code/logic anymore. * ban values are taken from $config->{security}{login} as - ban_enable: 1 - ban_expire_time: 3600 ban expire time in seconds - max_attempts: 5 * if max_attempts set to 0, the ban functionality is disabled as it requires to be at least 1 to work. * upon successful login or ban, the failed attempts counter is removed * the failed attempts counter is also removed automatically with the expire time equals "ban_expire_time" or otherwise 3600 seconds. * user bans are logged into panel.log * banned user receives exactly the same return page/codes as per invalid logic. Change-Id: I05cc68c623ee289488fc64f1af50527004dcaae1	9 months ago
Kirill Solomko	d9f283cbc8	MT#59449 enhance password validation and handling ... * passwords are now validated based on - minlen - maxlen - min lower case chars - min uppper case chars - min digits - min special chars * Data::Password::zxcvbn is used to calculate password score and reject passwords with score < 3 as weak (this library is ported from the Dropbox password validation) * Add password journals and check last used passwords in the journals * Improve password generator javascript function to generate a password with at least 4 of each of the char group types. * Currently affected are subcriber and admin entry creation or modification via UI/API * NGCP::Utils::Auth add optional bcrypt_cost support as last argument for generate_salted_hash and get_usr_salted_pass Change-Id: I100c25107d91741d5101bc58d29a3fa558b0b017	9 months ago
Kirill Solomko	43d112bd5e	MT#60558 add max subscribers/groups license checks ... * max_subscribers, max_pbx_subscribers, max_pbx_groups license checks are added for subscriber/group creation in UI/API * new accessor $c->license_meta that returns meta license flags hashref * new accessor $c->license_max_subscribers * new accessor $c->license_max_pbx_subscribers * new accessor $c->license_max_pbx_groups * the new accessors (except license_meta) return -1 instead of 'unlimited' to ease off comprarsion * 403 Forbidden is returned by the API if a license is violated. Change-Id: I3f5a949efc84bf85b76b33404b37b362ec484d5f	9 months ago
Kirill Solomko	9d021be65a	MT#59979 add license control ... * UI and API parts are now under license control * new Util::License::get_license($c, $name) - fetches license status by name (1 if enabled, and also if /proc/ngcp/check if 'ok') * add Catalyst::Plugins::NGCP::License with license($name) to fetch valid license by name from anywhere using $c->license('pbx') or from the templates using c.license('pbx'). It internally uses Util::License::get_license($c, $name) * License::get_license_status($c) now requires $c as first argument as well logs license status check errors. * new ActionRoles::License that enables usage of :Does(License) RequiresLicense('pbx') LicenseDetachTo('/denied_page') in the Controller chains * Add license control for UI elements and return 403 Forbidden if a resource is covered by licenses and the license is not active * Hide UI elements if a license is not active * API/Entities/Entities new $c->set_config key: - per endpoint: $c->set_config({ required_licenses => [qw/pbx device_provisioning/] } - or per method: $c->set_config({ required_licenses => { POST => [qw/pbx device_provisioning/] } } } * In case if an API endpoint does not have a license: 403 Forbidden "Invalid license" reply is returned. * Add license based restrictions to API endpoints * /api documentation: - completely hide endpoints that do not have an active license - hide only methods that does not have an active license Change-Id: Iba45fc5068b02306a617fed7b5405f2210574b61	9 months ago
Rene Krenn	9c103302c8	MT#60575 dynamically load provisioning templates module ... Change-Id: Ibff509825f82a75c9b0221505a1673d78b401989	9 months ago
Marco Capetta	551cc2fb98	MT#60515 rename hm inbound/outbound directions to a_inbound/a_outbound ... inbound/outbound no longer represent the "full" direction and belong only to A leg, so they are renamed to a_inbound/a_outbound accordingly. Change-Id: I639b799c3649c9b3ca78eee831b49ef0cfa14287	10 months ago
Rene Krenn	0fd36ace55	MT#60520 prov templates: fix lookup of items ... item (contract, contact, subscriber) lookup will pick the first matching element (an arbitrary one if multiple are matching). ie. when lookup identifiers are too loose (f.ex. subscribers without domain in a multidomain setup) it might pick a wrong item - which is ok (supposed to bail out at a later step) unless that wrong item is a *terminated* one, causing to proceed checks on a terminated record (which can never happen from API or UI side since those hide terminated items), which produces a misleading 500 error in the end. we prevent this now by ensuring that looked up items are not terminated ones. even if the looked up items is not the desired one, becasue of an inaccurate template. Change-Id: I6691937c2e62b05915c7eac9980224abe2185b2c	10 months ago
Marco Capetta	fefa5ea173	MT#60511 Form/Header/Rule add direction "b_outbound" ... This is needed to perform manipulations to the SIP message just before it leaves the system on the B-Leg side. Change-Id: If93d0277582a086253b84088a93adc4ecfa187b1	10 months ago
Kirill Solomko	10a88cf669	MT#58964 /api/platforminfo add license_meta ... * new Utils::License::get_license_meta($c) to fetch license meta ({} by default) that contains license related metadata such as current and max amount of subcsribers and license valid until date. currently the following data is fetched from /proc/ngcp check current_calls current_pbx_groups current_pbx_subscribers current_registered_subscribers current_subscribers license_valid_until max_calls max_pbx_groups max_pbx_subscribers max_registered_subscribers max_subscribers valid * Controller::API::Root platforminfo now also returns license_meta Change-Id: I323cdfd646335a408e0150ecd69ad950fa0461ab	10 months ago
Kirill Solomko	524a264850	MT#60498 add search by not_null, change null param ... * add search by not_null for fields that ends with _id and integers, that adds "IS NOT NULL" to the SQL search query by the field. * null and not null values are expected now as $null and $not_null to avoid conflicts when user searches by null strings that may be a valid case. Change-Id: I8e8b8c9060e985dfe2b94cbfcca1587f05477fe9	10 months ago
Kirill Solomko	6cb38f0971	MT#58964 do not render licenses for public platforminfo ... * public access (no user) to /api/platforminfo gets only the default public json file without licenses rendering Change-Id: I636e042944c7c18a08db22e9142a8624c67332c7	10 months ago
Kirill Solomko	522fd97020	MT#58964 /api/platforminfo add licenses info ... * NGCP::Utils::License new function get_licenses() that reads /proc/ngcp/flags/ and returns all files with content 1. * api/platforminfo.tt template now calls a stashed callback (coderef) that decodes provided json file, includes licenses and returns encoded the json back. * ngcp-panel.service changes # Files + directories not directly associated are made invisible in the /proc/ file system # ProcSubset=pid # Disabled: MT#58964, to be able to read /proc/ngcp/flags/ # Processes owned by other users are hidden from /proc/ # ProtectProc=invisible # Disabled: MT#58964, to be able to read /proc/ngcp/flags/ Change-Id: I84b6707a918e3f4f271e32b9353f320753c5ae68	10 months ago