5430 Commits (1ed7f56bee5339f9de396ebe01d308a862ef1caf)

 

All Branches   

Search

Author	SHA1	Message	Date
Kirill Solomko	1ed7f56bee	MT#60300 fix sound sets list rendering for reseller ... * fix code typo that prevented correct rendering of the sound sets list for reseller roles Change-Id: I35ea38a37932b8dd563a0b95f7e2481a5c45cdbe (cherry picked from commit c7ae8c1dcf)	10 months ago
Rene Krenn	0f49754134	MT#60520 prov templates: fix lookup of items ... item (contract, contact, subscriber) lookup will pick the first matching element (an arbitrary one if multiple are matching). ie. when lookup identifiers are too loose (f.ex. subscribers without domain in a multidomain setup) it might pick a wrong item - which is ok (supposed to bail out at a later step) unless that wrong item is a *terminated* one, causing to proceed checks on a terminated record (which can never happen from API or UI side since those hide terminated items), which produces a misleading 500 error in the end. we prevent this now by ensuring that looked up items are not terminated ones. even if the looked up items is not the desired one, becasue of an inaccurate template. Change-Id: I6691937c2e62b05915c7eac9980224abe2185b2c (cherry picked from commit 0fd36ace55)	10 months ago
Sipwise Jenkins Builder	13a1e7485b	Release new version 12.4.2.0+0~mr12.4.2.0	12 months ago
Sipwise Jenkins Builder	4cd3b98666	Release new version 12.4.1.0+0~mr12.4.1.0	1 year ago
Kirill Solomko	f2478178f0	MT#60119 allow pbxfielddeveicepreferences to subscriberadmin role ... * subscriberadmin role can now CRUD preferences for devices that are assigned to the customer. Change-Id: I09fe3c3b2ed670f0411970dc6402486a3cf6d4be	1 year ago
Rene Krenn	941c75ebe1	MT#59078 ?create_primary_acli= query param ... creating or updating subscriber (-aliases) will modify the allowedcli (acli) preference, if the auto_allow_cli config option is set. the primary number will also be part of the acli list. when specifying ?create_primary_acli=false or ?create_primary_acli=0, the primary alias will no longer be added to acli. Change-Id: I4641e2b973de2afe2e36805140b1546cac2a699a	1 year ago
Donat Zenichev	844a9e5920	MT#59011 Cleanup panel from the reference to "sip:localuser" ... An outdated and not used implementation for the "sip:localuser" in the ngcp-panel. Change-Id: I7c83bee0da07f7fafe7b1cb669a8c5080bc8565e	1 year ago
Marco Capetta	42f8747a6f	MT#59749 Add use_redirection flag to Call Forwards configuration ... This new flag controls wether the CF is processed as usual (flag with value 0, default) or generates a 302 redirect message back to the caller (flag with value 1). The implementation cover both the UI and the API. Change-Id: Idf945262e17de0d77bb612101d268fd6ea7a309e	1 year ago
Michael Prokop	c8766cd567	MT#48844 Minor typo fixes ... s/paramaters/parameters/ s/wihout/without/ s/If it mathes/If it matches/ s/ in in / in / s/the the/the/ (note: fixes translation issue which was introduced with commit 2b7a1a33 and fixed in 072e897c for the original, but missed for the german translation) Change-Id: I4186bf3f42b1fac11bb7d7fe801f860d2d59adc1	1 year ago
Kirill Solomko	c6aaaddd87	MT#56301 move lock_provisioning_voip_subscriber before underrun_lock ... * POST /api/subscribers/ invoke lock_provisioning_voip_subscriber() before underrun_lock(), so that if the subscriber is about to be locked due to customer balance costs, the lock_provisioning_lock_subscriber() invocation will not unlock it back straight after Change-Id: I55020f844c9aa76df2e2f057a88b2ae7c9ebbfcc	1 year ago
Kirill Solomko	e4cda08bd4	MT#59835 /api/billingzones fix HAL ngcp:billingfees relation ... * billing fees relation was rendering all associated billing fees and that was causing huge data sets to be returned if a billing zones had many fees, now instead a single link is returned /api/billingfees/?billing_zone_id=:id. this is also on par with other links like /api/billingfees/:id Change-Id: Iabb7afb3bf43abf9a22c71750d45a1962a7f16ec	1 year ago
Rene Krenn	df670f501f	MT#56301 set locklevel of created subscribers only if specified ... Change-Id: I90f2d68dee50ab240de4eb5af7495ddd551c00d8	1 year ago
Marco Capetta	8945b8a5ac	MT#56301 Fix API creation of an active subscriber with lock ... Using API is possibile to edit an existing subscriber and set status: active and lock: 2. It is instead impossbile to create a new subscriber with the same configuration because the 'lock' param is not taken into account. The only way to properly setup lock level it is to set the status to 'locked' and this is in fact wrong. The fix address this issue and allow now to create a new subscriber with status: active and lock: 2. Change-Id: Id18e40bc001c5a7de30f5d148231bda93a3b1b3d	1 year ago
Kirill Solomko	c006e9efc1	MT#59806 add missing cfdestinationsets HAL link type ... * add missing: "_links" : { "ngcp:cftimesets" : [ .... ], in the collection representation Change-Id: I59fade61ae2679833c43fd5501d14ca45a376572	1 year ago
Kirill Solomko	b2a1bc00d1	MT#59806 adapt /api/cfdestinationsets to Entities ... * Entites logic is used for GET/POST/PUT/PATCH/DELETE * Utils::CallForwards::check_destinations() do not obfuscate destinations that are returned in the response as all logged data is obfuscated anyways Change-Id: Ia79f9e236c966410e2640d719c3a7f5784cc4c2a	1 year ago
Kirill Solomko	1872f342a0	MT#59478 Entities/EntitiesItem more $c->has_errors checks ... * additional $c->has_errors checks for post/patch/put/delete to cover all possible expected called inherited methods scenarios and returns. Change-Id: I0e09ba62bcaa51d582315d9cbb672a4cf11bacf0	1 year ago
Kirill Solomko	9e3653341a	MT#59478 adapt /api/cftimesets to global transactions, more fixes ... * /api/cftimesets now fully use Entities/EntitiesItem * EntitiesItem: delete(): fix delete_item() expression processing * Entities/EntitiesItem: post/put/patch/delete: go to TX_END in scenarios where after a method call (e.g. update_item()) there is a normal return from the function but errors in $c->error, so that they are also caught correctly Change-Id: I3bef409ded590796c2bba4f30acd28b02e99065b	1 year ago
Kirill Solomko	91f1dcf37e	MT#59478 /api/ root error handling ... * clear errors in Controller::API::Root::end so that they are not interfere with generated ones * API::error(): add $c->stash->{is_api_error_response} = 1 to track it in log_response() * API::log_response(): distinguish and correctly correct errors for cases when is_api_response == 1 and also when there were $c->error('error') calls in the code, to log them correctly in both cases Change-Id: Id922b8219832c1b99815d9d608309035b9b25cff	1 year ago
Kirill Solomko	4e2e141308	MT#59478 Entities fix non-existing $item handling in put/patch/delete ... * the error produced by item_id_is_valid() is returned instead of a new one is generated * fix incorrect expression on delete_item() in delete() Change-Id: Ic8e4e24c70bbcd99ec414d901eb2842ee39ae7de	1 year ago
Kirill Solomko	bf249f9d96	MT#59797 /api/headerruleconditions (actions) fix reseller role ... * fix resultset when user role is reseller so that reseller_id is joined correctly and a db error is not produced anymore. Change-Id: I2a1b357037d983f23770bb59519fc2cb8b68a7e4	1 year ago
Kirill Solomko	9d598d4502	MT#59478 improve MSG, LOG log string data storing ... * $c->error array now contains the $message as the first element instead, so that it's possible to obtain all the error data in the code when fetching it from @{$c->error}. the first element is not logged in the error log. * api_response $c->response_body part is now stored in MSG= and possible errors / other log data is now stored in LOG= to: - reduce amount of log lines when an API error response occurs from 2 to 1 - the message part usually contains either HTTP response message (e.g. Internal Server Error) or a validation message string, so it belongs to the MSG= part of the log line, where as the internal log data is more related to the LOG= part - both MSG= and LOG= parts are escaped for GDPR related obfuscation * Utils::Messag::info(): $msg is now also obfuscated if it's detected as a reference (also because logging is moved for the API part to $msg), as well as truncated for possible new-line char and white-spaces. Change-Id: I3b670b2251ec3060037ed6863f18d95975120b8d	1 year ago
Kirill Solomko	9dbd6b0e88	MT#59478 /api/contracts address $now and hal_from_contract ... * the following changes resolve an issue where $now in Role/Contracts resource_from_item appeared as an object and failed subsequent logic: - hal_from_contract is renamed to hal_from_item to match correctly the parent method - call hal_from_item and pass $now string there correctly as $params { now => $now } Change-Id: I5c02d5f7df5d9000550505ad120b9531f87e8d65	1 year ago
Rene Krenn	14e5b918b3	MT#59748 drop ngcp-provisioning-template test dbhost ... Change-Id: I7218ed36cff2f51f5a6f862f41e5da94ff0d464b	1 year ago
Kirill Solomko	205b27a267	MT#59478 API better transaction and error handling ... * Role/Entities*: POST/PUT/PATCH/DELETE methods changes: - support deadlock detection and transaction retry (2 retry attempts at the moment) - improve transaction control, use local $guard instead of saving the ref to $c->stash, as in that case it went out of scope too late and also reported an error message into the log about abnormal $guard out of scope interruption - move all non transaction related code outside of the scope - add error handling when methods such as update_item, and a like do not return the expected data, instead of simply going out of scope and resulting in an uncontrolled reply * Role/API: - rework transaction control: + get_transaction_control() is renamed to start_transaction() to better reflect what it does + complete_transaction() is renamed to commit_transaction() + remove unused %params arg + pass $guard into commit_transaction() instead of having it stored as $c->stash->{transaction_guard) that caused the $guard ref to be destroyed much late than expected (there was also a typo as transaction_quard, which is not relevant anymore with the changes + add check_deadlock() that is invoked when an exception is caught or an $c->errors contain an error, and if the error message represents a transaction error, the transaction block is re-invoked via "goto TX_START" - rework error(): + it now accepts args as following: ($self, $c, $code, $message, @errors) # code -> returned as HTTP code in the reply # message -> returned as HTTP message in the reply # errors -> contain errors for internal logging, last element often contains a DBIx exception + populates all @errors into $c->error so they are available on demend in the code via $c->error or $c->last_error + $c->log->error is not invoked now as the errors become printed in log_response() - log_response() now prints collected errors from $c->error correctly as a separate log line, that is alike to the other api logs so that those can be looked up by the request's tx_id, also all errors are now printed only into api.log * Adjust all $self->error() calls in catch($e) to include $e as the last argument, as well as the duplicate $c->log->error is removed from those ocassions * Remove all $c->log->error() calls as they are replaced with either $self->error() (that logs it correctly into api.log) or $c->error('err') that also adds it correctly into api.log * API::CallForwards: rework to use Entities/EntitiesItem * API::Contracts: rework POST to use Entities * API::PeeringGroups: rework POST to use Entities * API::SubscriberRegistrations: rework POST to use Entities * API::RewriteRuleSets: improve create_item() functionality * Utils/Message: add 'api_retry' log type * $c->session->{api_request_tx_id} is changed to $c->stash->{api_request_tx_id} because sometimes the session ref is different and a different tx_id becomes used Change-Id: I633ce7a8047b1bf00a2f6889003088edf0825dcd	1 year ago
Nico Schedel	1fdaa6bd47	MT#55677 fix all ngcp-panel-selenium tests ... Change-Id: I7f1f1e5fe9632dad233818b3a43b78a54ff97b98	1 year ago
Nico Schedel	b22d2d824c	MT#59624 update firefox in docker to fix segfaults ... Change-Id: I48690f8f2eddf7dc00df0f62437956d6d8f7c38e	1 year ago
Sipwise Jenkins Builder	e7b131247e	Release new version 12.4.0.0+0~mr12.4.0.0	1 year ago
Kirill Solomko	aef4c89197	MT#59662 enhance subscriber assigned header rules/sets handling ... * POST /api/headerrules now supports either 'set_id' or 'subscriber_id'. When 'subsriber_id' is specified, a subscriber assigned header rule set is automatically created if it does not exist, as well as automatically removed when its last header rule is deleted. * It is now possible to directly GET and DELETE /api/headerrules/:id where :id is a subscriber assigned header rule. * It is now possible to directly GET and DELETE /api/headerrulesets/:id where :id is a subscriber assigned header rule set. * Improve /api/headerrules data validation and duplicate header rule detection. * It is now possible to expand by /api/headerrules/?expand=set_id field Change-Id: I681bc61c2eed47a8e54847f07f31134f643930c2	1 year ago
Kirill Solomko	1fb8d04136	MT#59615 /api/subscribers skip primary number processing if unchanged ... * if the primary numner during /api/subscribers update request is unchanged, the primary number processing related logic is not invoked, as otherwise it's a redundant and in some cases (pilot subscriber) time consuming operation. Change-Id: I4cbb0387011f5241fcbdaab1efbb0d4a5caa2143	1 year ago
Rene Krenn	868e2657b6	MT#59597 fix remove trailing+leading % entirely for "wildcard" params ... Change-Id: I371e2d41ff27b2801ead391778d9a2bdef914563	1 year ago
Michael Prokop	3ccdaaa20f	MT#59492 Use reserved IPs following RFC5737 ... Usage of IP addresses like 1.2.3.4 is not recommended, as they might point to actually used and non-reserved IPs. Quoting from RFC 5737 AKA "IPv4 Address Blocks Reserved for Documentation" (see https://datatracker.ietf.org/doc/html/rfc5737): | The blocks 192.0.2.0/24 (TEST-NET-1), 198.51.100.0/24 (TEST-NET-2), and | 203.0.113.0/24 (TEST-NET-3) are provided for use in documentation. So use 203.0.113.0/24 instead. Change-Id: I4b85120e1409af306c52693211bd86ea01ec19df	1 year ago
Rene Krenn	9ba93e69a5	MT#59597 remove trailing+leading % entirely for "wildcard" param types ... this code is not run by legacy panel, so the check for "/api" request can be removed. Change-Id: I29410fbbf046a8f00443138720b940de0f09f416	1 year ago
Rene Krenn	aa6760228e	MT#59363 retain trailing+leading wildcard for legacy panel only ... all api query param filters that were harmonized to "wildcard" also appended leading+trailing wildcard (this was from the original idea to make adminUI and legacy panel search behave the same). Change-Id: I017473b84f2844d14a11b4ec8b437df5335c24d0	1 year ago
Rene Krenn	48b71e68c5	MT#59363 fix /api/domains/?domain= filter pattern behaviour ... this filter is another spot, where leading/trailing wildcards were added unintentionally, during harmonization. Change-Id: Id23114f8e7ebca018ad222e35b39d8260f1da92f	1 year ago
Sipwise Jenkins Builder	56c0d86d19	TT#4166 I18N dump: snapshot 2024.03.01-23.20.50 ... Change-Id: Ibe09b01a1ae6887aa3867b81d55871c3a20a1a64	1 year ago
Kirill Solomko	7aeaf0f16d	MT#59363 /api/subscriberregistrations change socket field to Text ... * socket field is changed to text for the API endpoint as by default in the LocationEntry form that is used by the UI the field is a prebuilt options list that comes from config.yml extra_sockets, and that severely limits the usage for the API. Change-Id: I71ee1f77dbf458c12655f840282375cee62b7534	1 year ago
Kirill Solomko	0202996756	MT#59537 create_invoice() add existing balance check ... * if no balance is found for the provided period a 422 error is returned: showdetails => $c->loc('period start=[_1] end=[_2].', $stime, $etime), error => 'Could not find active balance.', httpcode => HTTP_UNPROCESSABLE_ENTITY, instead of a 500 server because of access to undefined $balance value Change-Id: Icccb9f253d117327641b6803ac0d2cdb09cf030f	1 year ago
Rene Krenn	740bb764e5	MT#59434 always take aliases from voip_numbers ... in case the DB shows discrepancy because of missing primary provisioning.voip_dbaliases records, align with legacy panel behaviour and also take the restapi aliases list from voip_numbers, instead of voip_dbaliases. .. while trying to keep the performance gain from https://gerrit.mgm.sipwise.com/c/ngcp-panel/+/65086. Change-Id: Ibd7f8c8bc6a39ae2c31b4e8818080674ab77d66c	1 year ago
Kirill Solomko	80f8b1da0b	MT#59238 fix rewrite rules transaction control for PATCH,DELETE ... * /api/rewriterules PATCH, DELETE methods used the generic transaction, which conflicted with the xmlrpc reload command. * own_transaction_control was only set for PUT and now also extended to PATCH, DELETE to ensure that dialplan_sip_reload() is called properly after $guard->commit. Change-Id: I7313b4f6d1f6699bf38ae34749c5383a3943f61d	1 year ago
Rene Krenn	c837dc1043	MT#56817 MT#56362 fix query param sorting for regulary chained rs ... Change-Id: I82d3a0ce67ffb61273fc716016885f6431852eff	1 year ago
Rene Krenn	aae0b7e071	MT#56817 MT#56362 fix query param sorting for rs chained the regular way ... Change-Id: I0dab56ae07666eb695d7f30ef633a876ff8258fb	1 year ago
Rene Krenn	672a3110bc	MT#59216 restore appending wildcard behaviour ... with the change to harmonize wildcard symbols % and * to * in query param filters across all restapi rails, only - /api/subscribers?alias= - /api/subscribers?pbx_extension= - /api/subscribers?primary_number= - /api/pbxdevices?pbx_extension= are supposed to include implicit leading an trailing wildcards. panel UI uses trailing wildcard by default everywhere, and so should the databales of the new Admin UI. external_id were used to support patterns, but must not include a trailing wildcard in rest API, as this can break logic that rely on unique api request results. we now therefore no longer append wildcards in particular to: - /api/voicemails?folder= - /api/voicemailgreetings?type= - /api/subscribers?subscriber_external_id= - /api/subscribers?customer_external_id= - /api/subscribers?display_name= - /api/subscribers?domain= - /api/profilepackages?profile_name= - /api/profilepackages?network_name= - /api/pbxdevices?display_name= - /api/faxserversettings?name_or_password= Change-Id: I40ef1912d7224a56c6d14619d258c70e447ab23d	1 year ago
Rene Krenn	a15d00894a	MT#56817 MT#56362 fix errors from nondetermistic query param ordering ... the /api/callists rail supports the "call_id" query parameter to match calls with a callid prefix. this filter also adds an implicity ordering ORDER BY length(call_id) ASC, 'start_time' ASC. the /api/callists api rail also requires the query parameter "susbcriber_id", which renders a (fast) compound SQL query to list matching incoming (query1) and outgoing calls (query2) using UNION ALL (instead of a slow OR query). query1 UNION ALL query2 this is supported by the https://metacpan.org/pod/DBIx::Class::Helper::ResultSet::SetOperations module, which however generates invalid SQL syntax if query1 or query2 contains an ORDER BY. this is exactly what caused the 500 error of the customer who applied both "call_id" and "susbcriber_id" parameter in the request at the same time. ... ORDER BY length(call_id) ASC, `start_time` ASC UNION ALL SELECT `me`.`id`... the error happens randomly, because query parameters are stored in a hash (which by definition has no deterministic order of the entries). when the "call_id" parameter is applied at last, it worked as expected. so the issue can be adressed by strictly ordering the UNION ALL result, and prohibit ORDER BY in query1 and query1. the latter was added already with commit b2dfe28eed, and could be hotfixed. however, the ORDER BY of "call_id" query param is lost, and should be properly handled by forcing strict ordering of how query parameters are applied. the fix will introduce paramater ordering according to their order of definition in the code. Change-Id: I165d341b5c20e9bb750bd1fba88c836b393e80bd	1 year ago
Kirill Solomko	a4d54b10e4	MT#58709 rework NGCP::Utils::Sound::get_handlers_rs ... * get_handlers_rs() is renamed into get_file_handles() and reworked from an indented 'from' resultset into 2 separate resultsets, one fetching all the handles and another one files for the sound set, it is now returned as an array with the similar data. Reason for this rework is the deprecated use of 'from', that resulted in a lot of warnings in panel-fcgi.log: DBIx::Class::SQLMaker::ClassicExtensions::_join_condition(): ResultSet {from} structures with conditions not conforming to the SQL::Abstract::Classic syntax are deprecated: you either need to stop abusing {from} altogether, or express the condition properly using the { -ident => ... } * adjust file_handles data key names to better follow the naming conventions and readability, e.g.: groupname -> group_name, fileid -> file_id Change-Id: Ia91c9104c0b4dc79ee5bc359eb0b6e035e56ef3e	1 year ago
Guillem Jover	a87bf2b6c3	MT#59163 Stop using deprecated given/when perl construct ... This experimental perl construct has been marked as deprecated in perl 5.38 and targeted for removal in a later release. Switch its usage to a normal cascaded if/elsif and avoid future surprises. Change-Id: I268f6e17482bfa356fed8d1e003b317d24324f2f	1 year ago
Sipwise Jenkins Builder	909523b9cb	Release new version 12.3.0.0+0~mr12.3.0.0	1 year ago
Kirill Solomko	b6b453d69d	MT#59001 improve phonebook csv upload ... * the expected csv fields are as following: - /api/resellerphonebookentries/?reseller_id=1 name,number - /api/customerphonebookentries/?customer_id=1 name,number - /api/subscriberphonebookentries/?subscriber_id=1 name,number,shared - /api/resellerphonebookentries/ name,number,reseller_id - /api/customerphonebookentries/ name,number,contract_id - /api/customerphonebookentries/ name,number,shared,subcriber_id (note: the fields are taken from the leftmost side as the minimum required fields, so if one provides as: - /api/resellerphonebookentries/?reseller_id=1 name,number,reseller_id this line will be uploaded and columns after 'number' are ignored in this case. this is for convenience if you have a prepared upload for different customers/resellers for instance, you can upload it under one customer/reseller when needed * user access scope is now validated, e.g.: resellers cannot upload phonebook entries to another resellers, etc. * fix csv upload for /api/customerphonebookentries/?customer_id=1 Change-Id: I970ac36fdb8b366adff15515a48d296e8abeff13	1 year ago
Rene Krenn	1e9f223276	MT#59025 fix peering groups name filter ... Change-Id: I329e644c937058069c5932abf8e897dce48a8c10	1 year ago
Kirill Solomko	1dabb6051d	MT#58989 /api/customers add type query param ... * add 'type' query param to filter by customer type 'sipaccount' or 'pbxaccount' Change-Id: If372cc69cf16c92551824504da7695a65dc867b3	1 year ago
Rene Krenn	cc8fd8928d	MT#58890 force cft_ringtimeout as number ... Change-Id: I4df4fbf6522d28a30731c87a36c95ae8350830fa	1 year ago