30 Commits (master)

Author	SHA1	Message	Date
Kirill Solomko	205b27a267	MT#59478 API better transaction and error handling ... * Role/Entities*: POST/PUT/PATCH/DELETE methods changes: - support deadlock detection and transaction retry (2 retry attempts at the moment) - improve transaction control, use local $guard instead of saving the ref to $c->stash, as in that case it went out of scope too late and also reported an error message into the log about abnormal $guard out of scope interruption - move all non transaction related code outside of the scope - add error handling when methods such as update_item, and a like do not return the expected data, instead of simply going out of scope and resulting in an uncontrolled reply * Role/API: - rework transaction control: + get_transaction_control() is renamed to start_transaction() to better reflect what it does + complete_transaction() is renamed to commit_transaction() + remove unused %params arg + pass $guard into commit_transaction() instead of having it stored as $c->stash->{transaction_guard) that caused the $guard ref to be destroyed much late than expected (there was also a typo as transaction_quard, which is not relevant anymore with the changes + add check_deadlock() that is invoked when an exception is caught or an $c->errors contain an error, and if the error message represents a transaction error, the transaction block is re-invoked via "goto TX_START" - rework error(): + it now accepts args as following: ($self, $c, $code, $message, @errors) # code -> returned as HTTP code in the reply # message -> returned as HTTP message in the reply # errors -> contain errors for internal logging, last element often contains a DBIx exception + populates all @errors into $c->error so they are available on demend in the code via $c->error or $c->last_error + $c->log->error is not invoked now as the errors become printed in log_response() - log_response() now prints collected errors from $c->error correctly as a separate log line, that is alike to the other api logs so that those can be looked up by the request's tx_id, also all errors are now printed only into api.log * Adjust all $self->error() calls in catch($e) to include $e as the last argument, as well as the duplicate $c->log->error is removed from those ocassions * Remove all $c->log->error() calls as they are replaced with either $self->error() (that logs it correctly into api.log) or $c->error('err') that also adds it correctly into api.log * API::CallForwards: rework to use Entities/EntitiesItem * API::Contracts: rework POST to use Entities * API::PeeringGroups: rework POST to use Entities * API::SubscriberRegistrations: rework POST to use Entities * API::RewriteRuleSets: improve create_item() functionality * Utils/Message: add 'api_retry' log type * $c->session->{api_request_tx_id} is changed to $c->stash->{api_request_tx_id} because sometimes the session ref is different and a different tx_id becomes used Change-Id: I633ce7a8047b1bf00a2f6889003088edf0825dcd	1 year ago
Rene Krenn	308a974059	MT#58762 harmonize restapi wildcard filters ... - all standard LIKE search are migrated - will avoid LIKE unless a pattern (* wildcard) is used as a search term. this encourage db index usage, will be faster - supports wildcard escape sequence \\* - harmonize swagger UI descriptions of filters Change-Id: Iea155871c9be6c284e6970a562d4e6af73fedc4b	1 year ago
Kirill Solomko	b7c22618c8	MT#57987 /api/rewriterules calculate priority on create ... * when a new rewrite rule is created and the priority attribute is not specified, only the first rewrite rule of the same rewrite rule set is set as 50, and the following are as: "MAX(priority) of the same rewrite rule set"+1 Change-Id: I1f1ae275e00918a34a625409987f21044b3b940f	2 years ago
Kirill Solomko	0370507310	MT#57155 /api/rewriterules add filter by direction,field ... * filter by direction and field (caller or callee) Change-Id: I0205ead6cf2a1d51532992f67a5add63cdeb51e0	2 years ago
Rene Krenn	a9b1ba896b	MT#56917 fix rwr 'description' filter ... a 500 error results when specifying the RewriteRule "description" filter because of ambigous field names. Change-Id: I9c0a9f6c84ec62fca4c77ce904fb07c4dadef13b	2 years ago
Irina Peshinskaya	0d4d8cdb23	TT#28460 Format: Remove excrescent empty lines ... Change-Id: I5ff73d92bf62451fb6dbdae85ca07428c3f5af5d	7 years ago
Irina Peshinskaya	d28b6b688c	TT#28460 Adapt already customized configs ... Change-Id: Ia5c6201e7ff59081a8a9a15d2ef4f24b4e8a550a	7 years ago
Irina Peshinskaya	c0940df9db	TT#17638 Rewrite Rule API to set priority ... Change-Id: I84099ab6d4869ee232532668fa15f1cc40501fb8	8 years ago
Rene Krenn	72d9c10650	TT#13973 fix http method override ... the factory Catalyst::ActionRole::HTTPMethods action role is set for any action, and in race with our own NGCP::Panel::Role::HTTPMethods. the testcase could have been misleading ever since, as it uses DELETE /api/customers, which was present when implemting the method override initially, but dropped on the road to 4.5. the issue is resolved by overriding Catalyst::Controller::gather_default_action_roles. until the class hierachy refactoring is completed, only consistent way is to add the override to each api controller. the action_roles config attribute can therefore be removed. using Plack::Middleware::MethodOverride as an alternative from upstream has the drawback to work only with POST. but a required usecase is to also support translation DELETE requests to PATCH. Change-Id: I204ba59869a8327bdd5db8a867fbbb061d1c9e7c	8 years ago
Irina Peshinskaya	2073b9e760	TT#9309 Introduce local version of the Data::HAL::Link ... Change-Id: Ifdf95cef32f0d118330c20316ed447e00c6dae3c	8 years ago
Irina Peshinskaya	41f32401a7	TT#9309 Introduce local version of the Data::HAL with default forcearray ... Change-Id: Ie33396a75fc6d27fd28fe8f7717caba0a476c776	8 years ago
Rene Krenn	64cf8d64fc	TT#7930 consider rewriterule formhandler inflate/defalte in api ... Change-Id: I2ad0bbd708a380188b760331e162f45739bef855	8 years ago
Gerhard Jungwirth	b34a7df2e1	MT#21193 use Sipwise::Base in api modules ... which implies, among others, strict and warnings. these should never be omitted and are one of the most frequent complaints of perlcritic currently. as a result TryCatch can be removed (imported by Sipwise::Base). also, "no Moose" is removed (has no effect). Change-Id: I901b6a9f0f6d426f62b73e68f2c5ad6365c1eeef	9 years ago
Rene Krenn	3e57109750	MT#19419 custom action role to support http method override ... Change-Id: I2d9fbf1f4feca76b91bdf73d4184ea707cc04e78	9 years ago
Guillem Jover	0632585eba	MT#18443 Use parent instead of base module ... Switch from the discouraged base module to the light-weight parent module. Also remove some surrounding BEGIN blocks from 'use parent' which are completely unnecessary. Change-Id: I3a669e8024f098819be45030ca9d1afa8756105c	9 years ago
Irina Peshinskaya	0272c297b8	MT#17173 Remove Moose Roles from API ... Conflicts: lib/NGCP/Panel/Controller/API/MetaConfigDefs.pm lib/NGCP/Panel/Controller/API/Root.pm Change-Id: I25597baebbec6e2436b15776da17bd6d1bfef838	9 years ago
Andreas Granig	0562ab53f8	MT#17623 Reload dialplan cache on rwr changes ... In panel, the reload was missing for set clone/delete In API, it was missing everywhere Change-Id: Ib474d56cf3f1ace5e3e2eb66fdb109014a4ed756	9 years ago
Irina Peshinskaya	81bb0509dc	MT#15633 API for peering groups, servers, rules ... Change-Id: Ic39751a622240f12c5d790ee15ea3a329d731807	9 years ago
Irina Peshinskaya	56234716ee	MT#17137 Rewrite rules documentation enchancement ... Change-Id: I27c51191ff7a02ceaa848d8ab718a996b739273c	9 years ago
Andreas Granig	04a64e1493	MT#16465 partly remove namespace::sweep and others ... Remove namespace::sweep Remove MooseX stuff Remove perl5i Remove Moose where possible Change-Id: I4f873afb466f4e58a04c3304ff74df2185470b03	10 years ago
Andreas Granig	1306ba53c6	MT#8561 API: filter write ops for r/o users	11 years ago
Gerhard Jungwirth	1b0f0ead8f	MT#7119 remove redundant collection sort	11 years ago
Gerhard Jungwirth	83d37c5d23	MT#7119 API order_by for collections ... most collections support ordering by the column names of their primary table now	11 years ago
Gerhard Jungwirth	21a5d7ee37	MT#6195 API rwr: Give proper reseller access ... see also MT#6479	11 years ago
Andreas Granig	861e38b649	MT#6283 Add more query params to existing colls	11 years ago
Andreas Granig	45a42b9b61	MT#6479 API: Allow resellers to access some funcs.	11 years ago
Gerhard Jungwirth	6f368e820f	MT#6195 API: rewriterule/rewriteruleset: DELETE ... and remove some redundant checks (done by formhandler)	11 years ago
Gerhard Jungwirth	c7c1e012a9	MT#6195 API: adapt RewriteRules to search framework ... see MT#6283	11 years ago
Gerhard Jungwirth	ede3d43a42	MT#6195 API: rewriterule/rewriteruleset: POST	11 years ago
Gerhard Jungwirth	36f2be7689	MT#6195 API: rewrite: GET, PUT and PATCH implemented	11 years ago