5742 Commits (master)

 

All Branches   

Search

Author	SHA1	Message	Date
Kirill Solomko	1836eaac09	MT#65991 add recusrive expand filters support ... * it is now possible to filter by expanded object fields, recursively. e.g.: /api/pbxdevices/?expand=profile_id.config_id&profile_id_expand.config_id=29 * the filter logic also checks allowed_roles and skips controllers that the user do not have access to. * expand_field(): fix allowed_roles usage to use get_allowed_roles() so that allowed_roles definitions that are not an array but a HASH with method => roles are also properly used. * get_allowed_roles(): do not delete the $roles_config->{Default} as this method can be called multiple times per endpoint (in case of the expand logic). * the expand filter logic only knows about the form defined expand => "class" and therefore tries to convert the class from Role::API to Controller::API, assuming that the Controller::API:: has the name is the same. For cases where the name is different, expand => "controller_class" should be explicitly defined in the form, then the logic picks it first and only then falls back to the "class". Change-Id: I76d1ed16f26c1a0f7e55bd421c3a51b89eb6a389	3 days ago
Marco Capetta	45aafa74bb	MT#65904 report rejected CSV rows on calllistsuppressions API ... A CSV upload to /api/calllistsuppressions/ answered with a success status even when rows were rejected, so a user had no way to notice that the import was incomplete. The rejected rows are reported with a 422 now, whose message tells how many rows were imported and which line numbers were skipped, the same information the web interface shows. Change-Id: I7ab235227a3f69c8739e8ff2b199debf6fa8a304	4 days ago
Marco Capetta	6ff94fced0	MT#66024 Report license warnings/errors even if not enforced ... At the moment we are gathering the license information from /proc/ngcp/check, /proc/ngcp/valid and /prox/ngcp/flags/*. The output of those files is affected by the license enforcement: if not enforced then the outpup will be always ok, even if there are license issues. The commit fixes the issue reading the corresponding 'raw_' values that are always reporting the real status even when the license is not enforced. Change-Id: I597d2853d48d151ac6c08d25f0b1acaa2f9c1133	1 week ago
Rene Krenn	ae0be66a54	MT#65953 add status/not_status filters to contracts API ... Allow comma-separated status and not_status query params on GET /api/contracts/, matching /api/customers. Change-Id: Ic7857dd08bc04806ee8a42fcfe5c125df614578e	1 week ago
Kirill Solomko	e4a0c7b734	MT#66012 add collections filter by resource ID ... * all GET "collection" now can search by the resource ID as /?id=123. this is beneficial for when a filtering logic needs to filter by various params and one of them is the id, as querying by /:id also returns a different type of the response. * the id is only injected into the accepted query params if it doesn't exist there (some endpoints might have it already). * the id is also injected (on top) into the API documentation as: id => 'Filter the collection by resource ID' Change-Id: I96fa5a96e55c3b1cd38cafd7c9f05b27aaa32f7d	2 weeks ago
Kirill Solomko	3966cdb484	MT#66009 /api/admins safeguard links for nonexisting reseller_id ... * prevent a 500 errors and suppress reseller_id hal links if there is a rare scenario whree reseller_id = null for the admin user. Change-Id: Iaef880a537271ff654fbd852a0a5f3657023ce0c	2 weeks ago
Sipwise Jenkins Builder	16f107fafc	TT#4166 I18N dump: snapshot 2026.09.10-22.19.00 ... Change-Id: Ic658caea830ef112c1a00f86a4232a78ff818736	2 weeks ago
Kirill Solomko	db77631c79	MT#65239 enhance /api/platforminfo with meta release info ... * /api/platforminfo now returns a new 'release_info' section that contains info about: - latest NGCP release - latest NGCP LTS release - info about the current release such as expiration dates, lts, supported flags. - 'this' subsection contains current release version and also a platform type * caching support, the info is retrieved and parsed only once after the ngcp-panel service restart and then once every hour and only if the content is changed. * NGCP::Panel add Catalyst::Cache and Plugin::Cache support accessible via $c->cache Change-Id: I50c58e2563db5962f498d3523db95b4f6372596c	2 weeks ago
Rene Krenn	871f002b95	MT#65713 include contract_cnt and voucher_cnt in profilepackages ... * expose already-selected contract and voucher counts on GET responses * document them as readonly PackageAPI fields and strip on write * apply the same limit+1 count cap (default 10) as billingprofiles Change-Id: If1644a3b7f9824c4ce03a68c2a8fec166e3ec3ef	2 weeks ago
Kirill Solomko	d12b794b21	MT#65906 /api/platforminfo returns call_flow data ... * call_flow ip:port info is returned for admin users Change-Id: Ie98222672beab61d2d02fc6b182f8fb3a667df55	3 weeks ago
Marco Capetta	f7ac7d96be	MT#65890 Fix regression on PATCH calls to CallForwardsItem api ... Add missing "add" and "remove" operations for /api/callforwardsitem PATCH When the endpoint was refactored in commit 205b27a26 to use the EntitiesItem, this block was dropped - my $json = $self->get_valid_patch_data( - c => $c, - id => $id, - media_type => 'application/json-patch+json', - ops => [qw/add replace remove copy/], - ); And by default EntitiesItem allows only "replace, copy" operations. They missing operations are added back using set_config({ PATCH => { ops => [qw/add replace remove copy/] }, }) Change-Id: Id9c131d679511efa1eeef040373ae7b53a4f93f8	3 weeks ago
Marco Capetta	5cf446e477	MT#65852 support wildcard search on calllistsuppressions domain ... The domain query parameter of GET /api/calllistsuppressions/ now uses the wildcard query type, so "*" can be used the same way as in the pattern and label filters, e.g. domain=*word*, domain=word* and domain=*word. A value without any "*" still matches exactly, and an empty value still filters for the suppressions applying to any domain. Change-Id: Ib1b03faefdf9dba69168fb3b0a4273b5bff5756f	1 month ago
Kirill Solomko	ed41c13926	MT#65799 customercontacts, systemcontacts expand terminated contacts ... * when expand is used to expand a contact_id, it now expands contacts that are in any state (including terminated). * direct use of /api/customercontacts and /api/systemcontacts remains unchanged. Change-Id: I89738968fafd061d8a516aeab82c7a0fddd5c64b	1 month ago
Kirill Solomko	eba04a32f8	MT#65383 add auth token validation support ... * auth tokens are now validated in Credentials/JWT and rejected if an auth token is used for anything else but /login_jwt. Change-Id: I17d3c0a7418e79b0981c030ed343062bf03d6c23	1 month ago
Rene Krenn	3af6080c76	MT#65586 add expand for profilepackages profile mapping arrays ... * allow expanding initial_profiles, topup_profiles and underrun_profiles * inline billing profile and billing network resources on each mapping * return success after expanding repeatable nested id fields Change-Id: I15ec66b04931f8c9065ad5826886ee2011e3f6fc	1 month ago
Marco Capetta	50b518c259	MT#51865 support CSV upload and download on calllistsuppressions API ... Add the CSV bulk import and export already offered by the web interface to the /api/calllistsuppressions/ collection. The suppressions are downloaded by requesting the collection with an "Accept: text/csv" header. The suppressions are uploaded by POSTing the CSV in the request body with the "text/csv" content type, optionally together with a "purge_existing=true" parameter. The columns are domain, direction, pattern, mode and label, without a header row. Change-Id: I000de048b95d7cba6cb38a986914c49810cf626e	1 month ago
Marco Capetta	6a942068be	MT#51865 add calllistsuppressions API endpoint ... Expose the global call list suppressions (billing.call_list_suppressions) via /api/calllistsuppressions/, so far only manageable through the admin web interface. Supports GET, POST, PUT, PATCH and DELETE, and is restricted to the admin role. The already existing but so far unreferenced form CallListSuppression::SuppressionAPI is reused for validation and API documentation. The domain/direction/pattern uniqueness of the table is enforced in check_duplicate, which covers both create and update. Journaling is enabled for create, update and delete operations. Change-Id: I11be61ace5c64610644b714baa45d984313f647c	1 month ago
Sipwise Jenkins Builder	b369fa37d8	Release new version 26.3.0.0+0~mr26.3.0.0	2 months ago
Marco Capetta	8042d9f4d1	MT#65665 return redirect credentials on pbxdevicemodels on GET API ... The bootstrap_config_redirect_*_user and _password values are stored in provisioning.autoprov_redirect_credentials, while _profile is a sync parameter in provisioning.autoprov_sync. resource_from_item only called devmod_sync_parameters_prefetch_api, so GET returned the profile but silently dropped the credentialsm. Add devmod_sync_credentials_prefetch_api, mirroring the read-back the web UI already does in Controller::Device, and call it from resource_from_item for the admin and reseller roles only, which are the roles allowed to write these fields. Subscriber and subscriberadmin GETs keep them hidden. Change-Id: I02a8975fbf9fe60796832cf281d054e634ce6c00	2 months ago
Rene Krenn	f3ba2dfa02	MT#65652 update primary number when only cc/ac/sn split changes ... Skip primary number processing only when cc/ac/sn parts match, so a resplit with the same concatenated CLI still updates voip_numbers. Change-Id: I69e1c4e69ea9fd7df111ee2d371c8e99c478c04f	2 months ago
Marco Capetta	d01cff87ba	MT#65224 renumber voicemail msgnum on folder change and delete ... Asterisk uses its built-in ODBC voicemail storage against kamailio.voicemail_spool, which expects msgnum to be contiguous 0..N-1 within each (mailboxuser, dir) folder. Asterisk maintains that invariant itself, but the panel rewrote dir (or deleted a row) without ever touching msgnum, leaving gaps and duplicates that make asterisk mis-play and mis-count the messages. Add two helpers to Utils::Subscriber reproducing the asterisk semantics: * renumber_voicemail_folder() compacts a single folder to 0..N-1 ordered by (msgnum, id). It skips greetings, which live in the same table with msgnum -1. * move_voicemail_to_folder() appends the message at the end of the target folder the way asterisk does (last_msg_index + 1), then compacts both the source and the target folder. Both run inside a transaction, so the web UI paths that have no transaction guard of their own are covered as well. Use them in all four affected paths: * PATCH/PUT /api/voicemails/{id} (Role::API::Voicemails) * DELETE /api/voicemails/{id} (Controller::API::VoicemailsItem) * mark_voicemail_read() for the CSC/admin listen action * delete_voicemail() in the subscriber web UI The compaction is deliberately self-healing, so it also repairs folders already corrupted by the previous behaviour. Change-Id: I665de1966bc37c1069ff56fb30c99da85f224f71	2 months ago
Rene Krenn	22623e7c2f	MT#65618 require contract/subscriber sections in prov templates ... Validate that dependent template sections only appear together with their parent contract or subscriber section. Change-Id: I3150ca1844b633ab80ffd501fcf587d08f9ebdf8	2 months ago
Marco Capetta	cc34719693	MT#56865 Fix autoprovisioning of Grandstream devices ... The autoprovisioning of Grandstream devices was not working since a while or even never really worked. In the SOAP request to register the new device in the GAPS server was missing the '$query_string' parameter, thus the server responded back with: response=200; page={"code":7,"desc":"try to http base authorization failed","ret":null,"time":1785401492}#012; err=try to http base authorization failed; This change should not affect the provisioning of other vendors because the '$query_string' parameter is set to an empty string by default. Change-Id: I6637ce82351c46ec631c1047ec50ccb5404228e1	2 months ago
Rene Krenn	9767845c0a	MT#65579 use JSON::Types::bool for is_devid in resource_from_item ... Keep journal-safe JSON booleans after moving resource_from_item into Utils::Subscriber, matching the previous Role/API behaviour. Change-Id: I357a4f5f4a25f8a7295341dcbff80a14d3cb6f51	2 months ago
Rene Krenn	e485aff6b4	MT#65579 fix is_devid boolean conversion in resource_from_item ... Avoid the ambiguous bareword "bool" call that 500s subscriber API responses when alias is_devid is a plain DB integer. Change-Id: I8829e064ee658ae35676aa8414c58c0e16ffd5fa	2 months ago
Rene Krenn	a0bfa9377c	MT#65579 support updating existing subscribers via prov templates ... Reuse shared resource_from_item/update_subscriber helpers so templates can match by identifier, fill missing fields from the DB item, and update instead of only creating. Change-Id: I5fa9be12914677c3b6ef5c4c0617cb75447b45c9	2 months ago
Kirill Solomko	f677173e70	MT#65572 fix api-test2 duplicate cftimeset name ... * duplicate time set names are not allowed anymore and there was a typo in the test. Change-Id: I1d6946ddbf8c9142d6389f1764418a073f8babd4	2 months ago
Kirill Solomko	7256474e72	MT#65572 fix api-test2 duplicate cfdestinationset name ... * duplicate destination set names are not allowed anymore and there was a typo in the test. Change-Id: I7d0817103ece1ccbe1227498ef4634a9fae092f5	2 months ago
Kirill Solomko	79817b3529	MT#65573 change order of check_resource() and check_duplicate() ... * check_duplicate() call must be after check_resource() by default as check_resource usually validates the vital values, such as subscriber_id, reseller_id whereas the duplicates check can already operate with the "trustworthy" subscriber_id for the duplicate checks part. Change-Id: I3361c143a6e00f9c168a3b02e23feb4ca57c85f0	2 months ago
Kirill Solomko	9470652038	MT#65572 rework call forward sets resource validation ... * streamline the validation behaviour among all the call forward set endpoints to be the same: - all of them contain process_form_resource() check_resource() check_duplicate() and also update_item() calls those functions in the exact order * subscriber_id validation is performed in check_resource only once and removed from the other places. * subscriberadmin role now uses the same Form as the admin users (that contains the subscriber_id field). * subscriberadmin role is now allowed to provide with the subscriber_id, otherwise if undefined, the user's id is taken. * check_resource() now checks for subscriberadmin if the subscriber_id belongs to the same customer. * check_duplicate() only contains the duplicate entry check. * the following above fix inconsistent validation that produces different results, minimises the amount of sql queries as well as extends the functionality to enable the subscriberadmin role to create call forward sets on behalf of the own subscribers. Change-Id: I60ddd5aa2bd5228efeca9f8c1a593d24179b959a	2 months ago
Kirill Solomko	7f9af10416	MT#65553 add check duplicates for call forward sets ... * add check_duplicates() for destination, bnumber, time sets. * adjust duplicate set error messages. Change-Id: I8ee958df97f6e53f0e64283a0a9c2f85330aa9d1	2 months ago
Sipwise Jenkins Builder	9c1b762c82	TT#4166 I18N dump: snapshot 2026.07.21-22.28.18 ... Change-Id: I9b1175e0d649bb4323fc28e1c9f81ac8c3fad03b	2 months ago
Kirill Solomko	51876d2b8f	MT#65550 restore swagger doc id parameter for GET /{id} path ... * restore missing swagger doc id parameter for GET /{id} path Change-Id: I32d76034c85aa36ad95c235f55ca9aac3579d6d5	2 months ago
Kirill Solomko	deeaa10794	MT#64924 add PUT|PATCH cfmappings delete_unused_sets support ... * with PUT or PATCH /api/cfmappings/:id/?delete_unused_sets=1, all sets that become unused after the request and also a) not used by another subscriber b) belong to the same subscriber are are automatically deleted. * add query_params "delete_unused_sets" doc for PUT and PATCH Change-Id: I1485d35e905de391ed3e92d0fe75f3e72155a239	2 months ago
Kirill Solomko	67f7eaa65b	MT#65550 add PUT,PATCH,DELETE swagger query_params support ... * with a snippet as: __PACKAGE__->set_config({ ... DELETE => { query_params => [ { param => 'foo', description => 'Description', query_type => 'integer', }, ], }, }); it renders the query parameter on the API swagger documentation. * query_type must be according to the swagger API, of ommitted it falls back to 'string'. Change-Id: I9345a97ad9a4c674e757cd032fb719f51c25f5b6	2 months ago
Kirill Solomko	0c9f3e5ed0	MT#65549 add cf sets DELETE ?unassign_first=1 support ... * it is now possible to invoke the following endpoints as: - DELETE /api/cfbnumbersets/:id?unassign_first=1 - DELETE /api/cfsourcesets/:id?unassign_first=1 - DELETE /api/cftimesets/:id?unassign_first=1 in which case before the actual deletion, the cf set is unassigned from the cf_mappings, so that the cf_mappings are not automatically deleted by the constraints. Change-Id: I7fa40eba2790edcc62d8430ebbe6f752b13353f9	2 months ago
Kirill Solomko	331dcd604a	MT#65548 cf sets add usage_count field ... * usage_count field is returned for all the call forward sets and indicates how many cf mappings use the cf set. Change-Id: Ib8f31370fd4cfae3356c683981be7b9d0da0a73a	2 months ago
Rene Krenn	70d5c894a6	MT#65464 Fix LDAP OTP registration crash on /api/otpsecret ... LDAP login stored a raw DB::admins row as $c->user, so API response logging failed when fetching the OTP QR after an invalid OTP on login_jwt. Wrap the admin in RoleFromRealm, pass the admin auth realm to set_authenticated, logout on OTP failure, and make Message logging tolerate raw user rows or role lookup failures. Change-Id: I29fda2324eadc7fb1f25f06ae6418ab594b69fa0	2 months ago
Michael Prokop	a9bc9cdc78	TT#76552 Apply more strict systemd hardening ... In commit 31429319e7 we had to reduce our systemd hardening because ngcp-panel used the sendmail(1) interface for sending mails. Now that we switched from sendmail(1) to SMTP in commit 5993a1e1bc, we can finally re-apply the systemd hardening again. Original situation: [sipwise-lab-trunk] sipwise@sp1:~§ sudo SYSTEMD_COLORS=0 PAGER= COLUMNS=100 unbuffer systemd-analyze security ngcp-panel | grep -v '✓' NAME DESCRIPTION EXPOSURE [...] → Overall exposure level for ngcp-panel.service: 8.1 EXPOSED 🙁 [sipwise-lab-trunk] root@spce:~# New situation: [sipwise-lab-trunk] sipwise@sp1:~§ sudo SYSTEMD_COLORS=0 PAGER= COLUMNS=100 unbuffer systemd-analyze security ngcp-panel | grep -v '✓' NAME DESCRIPTION EXPOSURE ✗ SystemCallFilter=~@resources System call allow list defined for service,… 0.2 ✗ SystemCallFilter=~@privileged System call allow list defined for service,… 0.2 ✗ RootDirectory=/RootImage= Service runs within the host's root directo… 0.1 ✗ RestrictAddressFamilies=~AF_UNIX Service may allocate local sockets 0.1 ✗ RestrictAddressFamilies=~AF_(INET|INET6) Service may allocate Internet sockets 0.3 ✗ ProtectProc= Service has full access to process tree (/p… 0.2 ✗ ProcSubset= Service has full access to non-process /pro… 0.1 ✗ PrivateNetwork= Service has access to the host's network 0.5 ✗ PrivateUsers= Service has access to other users 0.2 ✗ DeviceAllow= Service has a device ACL with some special … 0.1 ✗ IPAddressDeny= Service does not define an IP address allow… 0.2 → Overall exposure level for ngcp-panel.service: 1.6 OK 🙂 [sipwise-lab-trunk] sipwise@sp1:~§ Change-Id: Id68cb73204ec9a20ebf54071ef41560c3f666407	3 months ago
Michael Prokop	ca8a56755a	MT#65478 ngcp-panel-tools: add missing perl dependencies ... The scripts rely on several dependencies that are satisfied only because we ship them on our NGCP systems due to dependencies elsewhere. Ensure we have the essential ones available, so it works also when someones installs ngcp-panel-tools only. libconfig-general-perl: # ./ngcp-api-generate-doc --help Can't locate Config/General.pm in @INC [snip] libfile-slurp-perl: # ./ngcp-api-generate-doc --help Can't locate File/Slurp.pm in @INC [snip] libxml-simple-perl: # ./ngcp-api-generate-doc --help Can't locate XML/Simple.pm in @INC [snip] libngcp-schema-perl: # ./ngcp-api-generate-doc --help Can't locate NGCP/Schema/Config.pm in @INC [snip] libjson-perl: # ./ngcp-create-testusers --help Can't locate JSON.pm in @INC [snip] libipc-shareable-perl: # ./ngcp-create-testusers --help Can't locate IPC/Shareable.pm in @INC [snip] libcryptx-perl: # ./ngcp-panel-create-keys Can't locate Crypt/PK/RSA.pm in @INC [snip] NOTE: there are further dependencies on e.g. NGCP::API::Client, NGCP::Panel::* + NGCP::Schema* that are satisfied only when having the full ngcp-panel package in place, this is a known issue for now. Change-Id: I0fd519d421c6dc970cbcbbad19d0a45156e0e124	3 months ago
Rene Krenn	19ed6c93f5	MT#65173 billing networks optional usage columns ... Change-Id: I730950af2d53570faff1a68ddc2e8c13952279f3 Co-authored-by: Cursor <cursoragent@cursor.com>	3 months ago
Rene Krenn	12d2906b31	MT#65173 billing profiles DELETE usage checks ... Change-Id: I359e5d74fb8f46c5892584d11fd22ccab1a09f52 Co-authored-by: Cursor <cursoragent@cursor.com>	3 months ago
Rene Krenn	3e1d3c09a5	MT#65464 fix LDAP login 500 when user lookup fails ... get_user_dn called ->dn on an undefined search result when LDAP lookup failed, causing login_jwt to crash instead of returning 403. Return early when no entry is found and log a clear message when the LDAP URI is missing or the connection fails. Change-Id: I5f00df840d304e4da2b35750c9c1f2e6972f1edb	3 months ago
Sipwise Jenkins Builder	fd4b1b99d4	TT#4166 I18N dump: snapshot 2026.07.07-22.21.15 ... Change-Id: Ifd8c089ef9f4eac0a69671d0d8428022f213da91	3 months ago
Rene Krenn	99a92aab95	MT#65377 fix ngcp-provisioning-template Catalyst stub missing license methods ... The CLI mock context lacked $c->license() and related helpers used by Subscriber.pm during provisioning, causing "Can't locate object method license" when processing PBX templates. Change-Id: I7485a425effb2d1d26e676191aff75ddd2d802d3	3 months ago
Rene Krenn	9714863a98	MT#65173 add optional usage columns to billing profiles API ... load contract_cnt, contract_exists, and package_cnt only when requested via query params, matching the web UI ajax behavior while keeping update validation working for interval field changes. Change-Id: Ie1d889fcac3227e81f37031c55fcf765e489cf9a	3 months ago
Sipwise Jenkins Builder	3296f04867	TT#4166 I18N dump: snapshot 2026.07.06-22.34.19 ... Change-Id: I15773b36caf07c74673659a808eee7ac37c5c968	3 months ago
Kirill Solomko	64bf49cd53	MT#65406 api-balanceintervals.t primary_number + thread id ... * include thread id as a part of the primary_number's 'ac' to make the subscribers creation within different threads unique. Change-Id: Id56961088a2b4e14df8cc08abd5d3527ada8c2f3	3 months ago
Kirill Solomko	b256a90abe	MT#65406 api-balanceintervals.t fix dynamic primary_number ... * fix dynamic primary_number allocation for the api-balanceintervals.t Change-Id: If965a8c4c2843c4d841120c0566a5e2876663057	3 months ago
Kirill Solomko	49139121cb	MT#65406 fix primary_number uniqness for tests ... * fix primary_number uniqness for t/api-rest/api-balanceintervals.t t/api-rest/api-customercontacts.t t/api-rest/api-topuplogs.t as _create_subscriber() is called multiple times there * t/api-rest/api-subscribers.t fix tests related to primary_number removal, as it can no longer be removed, also add a test that checks that the primary_number removal correctly triggers 422 error. Change-Id: I233474010a8bdcca9b9ab5975a0d2ba0c76313b6	3 months ago