MT#7119 remove redundant collection sort

ipeshinskaya/InvoiceTemplate5
Gerhard Jungwirth 12 years ago
parent 7ee9aa3f7a
commit 1b0f0ead8f

@ -69,7 +69,7 @@ sub GET :Allow {
my $subscribers = $self->item_rs($c);
(my $total_count, $subscribers) = $self->paginate_order_collection($c, $subscribers);
my (@embedded, @links);
for my $subscriber ($subscribers->search({}, {order_by => {-asc => 'me.id'}})->all) {
for my $subscriber ($subscribers->all) {
push @embedded, $self->hal_from_item($c, $subscriber);
push @links, Data::HAL::Link->new(
relation => 'ngcp:'.$self->resource_name,

@ -91,7 +91,7 @@ sub GET :Allow {
(my $total_count, $dsets) = $self->paginate_order_collection($c, $dsets);
my (@embedded, @links);
for my $dset ($dsets->search({}, {order_by => {-asc => 'me.id'}})->all) {
for my $dset ($dsets->all) {
push @embedded, $self->hal_from_item($c, $dset, "cfdestinationsets");
push @links, Data::HAL::Link->new(
relation => 'ngcp:'.$self->resource_name,

@ -68,7 +68,7 @@ sub GET :Allow {
(my $total_count, $items) = $self->paginate_order_collection($c, $items);
my (@embedded, @links);
for my $subs ($items->search({}, {order_by => {-asc => 'me.id'}})->all) {
for my $subs ($items->all) {
push @embedded, $self->hal_from_item($c, $subs, "cfmappings");
push @links, Data::HAL::Link->new(
relation => 'ngcp:'.$self->resource_name,

@ -91,7 +91,7 @@ sub GET :Allow {
(my $total_count, $timesets) = $self->paginate_order_collection($c, $timesets);
my (@embedded, @links);
for my $tset ($timesets->search({}, {order_by => {-asc => 'me.id'}})->all) {
for my $tset ($timesets->all) {
push @embedded, $self->hal_from_item($c, $tset, "cftimesets");
push @links, Data::HAL::Link->new(
relation => 'ngcp:'.$self->resource_name,

@ -102,7 +102,7 @@ sub GET :Allow {
(my $total_count, $items) = $self->paginate_order_collection($c, $items);
my (@embedded, @links);
my $form = $self->get_form($c);
for my $item ($items->search({}, {order_by => {-asc => 'me.id'}})->all) {
for my $item ($items->all) {
push @embedded, $self->hal_from_item($c, $item, $form);
push @links, Data::HAL::Link->new(
relation => 'ngcp:'.$self->resource_name,

@ -88,7 +88,7 @@ sub GET :Allow {
(my $total_count, $contacts) = $self->paginate_order_collection($c, $contacts);
my (@embedded, @links);
my $form = $self->get_form($c);
for my $contact ($contacts->search({}, {order_by => {-asc => 'me.id'}, prefetch => ['reseller']})->all) {
for my $contact ($contacts->search({}, {prefetch => ['reseller']})->all) {
push @embedded, $self->hal_from_contact($c, $contact, $form);
push @links, Data::HAL::Link->new(
relation => 'ngcp:'.$self->resource_name,

@ -82,7 +82,7 @@ sub GET :Allow {
return unless $query_string;
my (@embedded, @links);
my $error_flag = 0;
for my $dev ($field_devs->search({}, {order_by => {-asc => 'me.id'}})->all) {
for my $dev ($field_devs->all) {
my $hal = $self->hal_from_item($c, $dev);
$error_flag = 1 unless $hal;
push @embedded, $hal;

@ -58,7 +58,7 @@ sub GET :Allow {
my $domains = $self->item_rs($c, "domains");
(my $total_count, $domains) = $self->paginate_order_collection($c, $domains);
my (@embedded, @links);
for my $domain ($domains->search({}, {order_by => {-asc => 'me.id'}})->all) {
for my $domain ($domains->all) {
push @embedded, $self->hal_from_item($c, $domain, "domains");
push @links, Data::HAL::Link->new(
relation => 'ngcp:'.$self->resource_name,

@ -90,7 +90,7 @@ sub GET :Allow {
(my $total_count, $domains) = $self->paginate_order_collection($c, $domains);
my (@embedded, @links);
my $form = $self->get_form($c);
for my $domain ($domains->search({}, {order_by => {-asc => 'me.id'}})->all) {
for my $domain ($domains->all) {
push @embedded, $self->hal_from_item($c, $domain, $form);
push @links, Data::HAL::Link->new(
relation => 'ngcp:'.$self->resource_name,

@ -77,7 +77,7 @@ sub GET :Allow {
(my $total_count, $items) = $self->paginate_order_collection($c, $items);
my (@embedded, @links);
my $form = $self->get_form($c);
for my $item ($items->search({}, {order_by => {-asc => 'me.id'}, prefetch => ['reseller']})->all) {
for my $item ($items->search({}, {prefetch => ['reseller']})->all) {
push @embedded, $self->hal_from_item($c, $item, $form);
push @links, Data::HAL::Link->new(
relation => 'ngcp:'.$self->resource_name,

@ -88,7 +88,7 @@ sub GET :Allow {
(my $total_count, $field_devs) = $self->paginate_order_collection($c, $field_devs);
my (@embedded, @links);
for my $dev ($field_devs->search({}, {order_by => {-asc => 'me.id'}})->all) {
for my $dev ($field_devs->all) {
push @embedded, $self->hal_from_item($c, $dev);
push @links, Data::HAL::Link->new(
relation => 'ngcp:'.$self->resource_name,

@ -88,7 +88,7 @@ sub GET :Allow {
(my $total_count, $field_devs) = $self->paginate_order_collection($c, $field_devs);
my (@embedded, @links);
for my $dev ($field_devs->search({}, {order_by => {-asc => 'me.id'}})->all) {
for my $dev ($field_devs->all) {
push @embedded, $self->hal_from_item($c, $dev);
push @links, Data::HAL::Link->new(
relation => 'ngcp:'.$self->resource_name,

@ -77,7 +77,7 @@ sub GET :Allow {
(my $total_count, $field_devs) = $self->paginate_order_collection($c, $field_devs);
my (@embedded, @links);
for my $dev ($field_devs->search({}, {order_by => {-asc => 'me.id'}})->all) {
for my $dev ($field_devs->all) {
push @embedded, $self->hal_from_item($c, $dev);
push @links, Data::HAL::Link->new(
relation => 'ngcp:'.$self->resource_name,

@ -99,7 +99,7 @@ sub GET :Allow {
(my $total_count, $field_devs) = $self->paginate_order_collection($c, $field_devs);
my (@embedded, @links);
for my $dev ($field_devs->search({}, {order_by => {-asc => 'me.id'}})->all) {
for my $dev ($field_devs->all) {
push @embedded, $self->hal_from_item($c, $dev);
push @links, Data::HAL::Link->new(
relation => 'ngcp:'.$self->resource_name,

@ -81,7 +81,7 @@ sub GET :Allow {
(my $total_count, $items) = $self->paginate_order_collection($c, $items);
my (@embedded, @links);
my $form = $self->get_form($c);
for my $item ($items->search({}, {order_by => {-asc => 'me.id'}})->all) {
for my $item ($items->all) {
push @embedded, $self->hal_from_item($c, $item, $form);
push @links, Data::HAL::Link->new(
relation => 'ngcp:'.$self->resource_name,

@ -99,7 +99,7 @@ sub GET :Allow {
my $rwr_set = $self->item_rs($c, "rulesets");
(my $total_count, $rwr_set) = $self->paginate_order_collection($c, $rwr_set);
my (@embedded, @links);
for my $set ($rwr_set->search({}, {order_by => {-asc => 'me.id'}})->all) {
for my $set ($rwr_set->all) {
push @embedded, $self->hal_from_item($c, $set, "rewriterulesets");
push @links, Data::HAL::Link->new(
relation => 'ngcp:'.$self->resource_name,

@ -88,7 +88,7 @@ sub GET :Allow {
(my $total_count, $rules) = $self->paginate_order_collection($c, $rules);
my (@embedded, @links);
for my $rule ($rules->search({}, {order_by => {-asc => 'me.id'}})->all) {
for my $rule ($rules->all) {
push @embedded, $self->hal_from_item($c, $rule, "rewriterules");
push @links, Data::HAL::Link->new(
relation => 'ngcp:'.$self->resource_name,

@ -77,7 +77,7 @@ sub GET :Allow {
(my $total_count, $items) = $self->paginate_order_collection($c, $items);
my (@embedded, @links);
my $form = $self->get_form($c);
for my $item ($items->search({}, {order_by => {-asc => 'me.id'}})->all) {
for my $item ($items->all) {
push @embedded, $self->hal_from_item($c, $item, $form);
push @links, Data::HAL::Link->new(
relation => 'ngcp:'.$self->resource_name,

@ -88,7 +88,7 @@ sub GET :Allow {
(my $total_count, $items) = $self->paginate_order_collection($c, $items);
my (@embedded, @links);
my $form = $self->get_form($c);
for my $item ($items->search({}, {order_by => {-asc => 'me.id'}})->all) {
for my $item ($items->all) {
push @embedded, $self->hal_from_item($c, $item, $form);
push @links, Data::HAL::Link->new(
relation => 'ngcp:'.$self->resource_name,

@ -83,7 +83,7 @@ sub GET :Allow {
my $subscribers = $self->item_rs($c);
(my $total_count, $subscribers) = $self->paginate_order_collection($c, $subscribers);
my (@embedded, @links);
for my $subscriber ($subscribers->search({}, {order_by => {-asc => 'me.id'}})->all) {
for my $subscriber ($subscribers->all) {
push @embedded, $self->hal_from_item($c, $subscriber);
push @links, Data::HAL::Link->new(
relation => 'ngcp:'.$self->resource_name,

@ -58,7 +58,7 @@ sub GET :Allow {
my $subscribers = $self->item_rs($c, "subscribers");
(my $total_count, $subscribers) = $self->paginate_order_collection($c, $subscribers);
my (@embedded, @links);
for my $subscriber ($subscribers->search({}, {order_by => {-asc => 'me.id'}})->all) {
for my $subscriber ($subscribers->all) {
next unless($subscriber->provisioning_voip_subscriber);
push @embedded, $self->hal_from_item($c, $subscriber, "subscribers");
push @links, Data::HAL::Link->new(

@ -77,7 +77,7 @@ sub GET :Allow {
(my $total_count, $items) = $self->paginate_order_collection($c, $items);
my (@embedded, @links);
my $form = $self->get_form($c);
for my $item ($items->search({}, {order_by => {-asc => 'me.id'}, prefetch => ['reseller']})->all) {
for my $item ($items->search({}, {prefetch => ['reseller']})->all) {
push @embedded, $self->hal_from_item($c, $item, $form);
push @links, Data::HAL::Link->new(
relation => 'ngcp:'.$self->resource_name,

@ -77,7 +77,7 @@ sub GET :Allow {
(my $total_count, $items) = $self->paginate_order_collection($c, $items);
my (@embedded, @links);
my $form = $self->get_form($c);
for my $item ($items->search({}, {order_by => {-asc => 'me.id'}})->all) {
for my $item ($items->all) {
push @embedded, $self->hal_from_item($c, $item, $form);
push @links, Data::HAL::Link->new(
relation => 'ngcp:'.$self->resource_name,

@ -85,7 +85,7 @@ sub GET :Allow {
(my $total_count, $items) = $self->paginate_order_collection($c, $items);
my (@embedded, @links);
my $form = $self->get_form($c);
for my $item ($items->search({}, {order_by => {-asc => 'me.id'}})->all) {
for my $item ($items->all) {
my $halitem = $self->hal_from_item($c, $item, $form);
next unless($halitem);
push @embedded, $halitem;

@ -144,7 +144,7 @@ sub GET :Allow {
(my $total_count, $subscribers) = $self->paginate_order_collection($c, $subscribers);
my (@embedded, @links);
my $form = $self->get_form($c);
for my $subscriber ($subscribers->search({}, {order_by => {-asc => 'me.id'}})->all) {
for my $subscriber ($subscribers->all) {
my $resource = $self->resource_from_item($c, $subscriber, $form);
push @embedded, $self->hal_from_item($c, $subscriber, $resource, $form);
push @links, Data::HAL::Link->new(

@ -77,7 +77,7 @@ sub GET :Allow {
(my $total_count, $contacts) = $self->paginate_order_collection($c, $contacts);
my (@embedded, @links);
my $form = $self->get_form($c);
for my $contact ($contacts->search({}, {order_by => {-asc => 'me.id'}, prefetch => ['reseller']})->all) {
for my $contact ($contacts->search({}, {prefetch => ['reseller']})->all) {
push @embedded, $self->hal_from_contact($c, $contact, $form);
push @links, Data::HAL::Link->new(
relation => 'ngcp:'.$self->resource_name,

@ -81,7 +81,7 @@ sub GET :Allow {
(my $total_count, $items) = $self->paginate_order_collection($c, $items);
my (@embedded, @links);
my $form = $self->get_form($c);
for my $item ($items->search({}, {order_by => {-asc => 'me.id'}})->all) {
for my $item ($items->all) {
push @embedded, $self->hal_from_item($c, $item, $form);
push @links, Data::HAL::Link->new(
relation => 'ngcp:'.$self->resource_name,

@ -77,7 +77,7 @@ sub GET :Allow {
my $items = $self->item_rs($c);
(my $total_count, $items) = $self->paginate_order_collection($c, $items);
my (@embedded, @links);
for my $item ($items->search({}, {order_by => {-asc => 'me.id'}})->all) {
for my $item ($items->all) {
push @embedded, $self->hal_from_item($c, $item);
push @links, Data::HAL::Link->new(
relation => 'ngcp:'.$self->resource_name,

Loading…
Cancel
Save