fixed subscriber display for subscribers without E.164 number

lib/admin/Controller/subscriber.pm

@@ -128,12 +128,15 @@ sub detail : Local {
                                                             },
                                                             \$preferences
                                                           );
-        return unless $c->model('Provisioning')->call_prov( $c, 'voip', 'get_subscriber_voicebox_preferences',
-                                                            { username => $c->session->{subscriber}{username},
-                                                              domain   => $c->session->{subscriber}{domain},
-                                                            },
-                                                            \$c->session->{subscriber}{voicebox_preferences}
-                                                          );
+        # voicebox requires a number
+        if(length $c->session->{subscriber}{sn}) {
+          return unless $c->model('Provisioning')->call_prov( $c, 'voip', 'get_subscriber_voicebox_preferences',
+                                                              { username => $c->session->{subscriber}{username},
+                                                                domain   => $c->session->{subscriber}{domain},
+                                                              },
+                                                              \$c->session->{subscriber}{voicebox_preferences}
+                                                            );
+        }
         my $regcon;
         return unless $c->model('Provisioning')->call_prov( $c, 'voip', 'get_registered_contacts',
                                                             { username => $c->session->{subscriber}{username},

root/tt/subscriber_detail.tt

@@ -346,6 +346,8 @@
           </form>
         </div>
 
+    [% IF subscriber.voicebox_preferences %]
+
         <h3 id="vboxprefs">Voicebox Preferences</h3>
 
       [% UNLESS Catalyst.session.admin.read_only %]
@@ -392,3 +394,5 @@
           </form>
         </div>
 
+    [% END %]
+