From e1ab86787fdb45714832c58f0496d93252c7b9bb Mon Sep 17 00:00:00 2001
From: Daniel Tiefnig <dtiefnig@sipwise.com>
Date: Wed, 13 May 2009 23:38:29 +0000
Subject: [PATCH] fixed subscriber display for subscribers without E.164 number

---
 lib/admin/Controller/subscriber.pm | 15 +++++++++------
 root/tt/subscriber_detail.tt       |  4 ++++
 2 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/lib/admin/Controller/subscriber.pm b/lib/admin/Controller/subscriber.pm
index 1272eba..bd5ffff 100644
--- a/lib/admin/Controller/subscriber.pm
+++ b/lib/admin/Controller/subscriber.pm
@@ -128,12 +128,15 @@ sub detail : Local {
                                                             },
                                                             \$preferences
                                                           );
-        return unless $c->model('Provisioning')->call_prov( $c, 'voip', 'get_subscriber_voicebox_preferences',
-                                                            { username => $c->session->{subscriber}{username},
-                                                              domain   => $c->session->{subscriber}{domain},
-                                                            },
-                                                            \$c->session->{subscriber}{voicebox_preferences}
-                                                          );
+        # voicebox requires a number
+        if(length $c->session->{subscriber}{sn}) {
+          return unless $c->model('Provisioning')->call_prov( $c, 'voip', 'get_subscriber_voicebox_preferences',
+                                                              { username => $c->session->{subscriber}{username},
+                                                                domain   => $c->session->{subscriber}{domain},
+                                                              },
+                                                              \$c->session->{subscriber}{voicebox_preferences}
+                                                            );
+        }
         my $regcon;
         return unless $c->model('Provisioning')->call_prov( $c, 'voip', 'get_registered_contacts',
                                                             { username => $c->session->{subscriber}{username},
diff --git a/root/tt/subscriber_detail.tt b/root/tt/subscriber_detail.tt
index 8e05c65..10e40d8 100644
--- a/root/tt/subscriber_detail.tt
+++ b/root/tt/subscriber_detail.tt
@@ -346,6 +346,8 @@
           </form>
         </div>
 
+    [% IF subscriber.voicebox_preferences %]
+
         <h3 id="vboxprefs">Voicebox Preferences</h3>
 
       [% UNLESS Catalyst.session.admin.read_only %]
@@ -392,3 +394,5 @@
           </form>
         </div>
 
+    [% END %]
+