Give more information relevant when fixing the reports, state the
perlcritic tag, and the line that triggered the error.
In addition point to the Sipwise overrides that we are applying so
that it is clear when we diverge from the suggested best practices.
Change-Id: I795a29306d0f9923a402170c93cca73bbf730f14
Set a baseline of severity 4 for now that we can all agree with, which
does not impair development. Further incremental additions can be
discussed later on, and in case some are contentious, they can always
be enabled per project.
This implies the following check changes:
,---
-2 ControlStructures::ProhibitUntilBlocks [core cosmetic pbp]
-2 References::ProhibitDoubleSigils [core cosmetic pbp]
-2 ValuesAndExpressions::ProhibitEscapedCharacters [core cosmetic pbp]
-3 CodeLayout::ProhibitHardTabs [core cosmetic pbp]
+4 CodeLayout::RequireConsistentNewlines [bugs core]
+4 ControlStructures::ProhibitLabelsWithSpecialBlockNames [bugs core]
+4 InputOutput::ProhibitExplicitStdin [core maintenance pbp]
+4 Modules::RequireEndWithOne [bugs certrule core pbp]
+4 Modules::RequireExplicitPackage [bugs core]
+4 Variables::ProhibitAugmentedAssignmentInDeclaration [bugs core]
+4 Variables::ProhibitMatchVars [core pbp performance]
-4 ValuesAndExpressions::ProhibitConstantPragma [bugs core pbp]
+5 Modules::ProhibitEvilModules [bugs certrule core]
+5 Modules::RequireBarewordIncludes [core portability]
+5 Modules::RequireFilenameMatchesPackage [bugs core]
+5 Subroutines::ProhibitNestedSubs [bugs core]
+5 Subroutines::ProhibitReturnSort [bugs certrule core]
+5 Variables::ProhibitConditionalDeclarations [bugs core]
`---
Change-Id: I4986736cb075521dbe54826de8cc0b65f6d6a14d
We can't just modify the output format because perlcritic_tap
expects a specific format currently. Also some configurations
aren't supported on perlcritic as present on Debian/wheezy.
Change-Id: Ief61b9ad3109f3c3fc200b9abbc23d684ce007ea
It is a popular test, trying to keep the small Docker image size.
The image will be used to migrate all Jenkins tap-tests to Docker.
It will unblock the nodes "jenkins-slave*" migration to Debian stretch.
Later we will be able to switch jenkins on "NGCP release specific Docker images"
(using Docker tags like we do for all other Docker images)
and then upgrade Docker image to Debian stretch in trunk
(while we still be able to keep jessie for some Git repos
in case of emergency).
The script checkbashisms.pl extracted manually
because the package "devscripts" has too big dependencies list which
increases the Docker image size three times (till ~600Mb).
Also we have to use "/code/source" while normally we have just "/code"
because tap_tool_dispatcher from jenkins-debian-glue is strict to the folder name:
> if ! [ -d source ] ; then
> echo "Error: no source directory found, please run inside Jenkins." >&2
> exit 1
>fi
Change-Id: I21fb5c088db3f2966b2e374647061059dda11329
Checks:
- static configuration: passing the option "net.ifnames=0" to the
kernel during boot
- check if there are such devices ("eth*") in the system when running
Change-Id: I7d17777463d4dee7c067d1bf3e08080f91898b45
- Rename the file so that it makes more sense with the new checks.
- Improve the directory contents check to be more robust against
changes in ls output (ideally goss would support this directly
with the contains directive).
Change-Id: I8bebb929240e3147627a1ec5db246f73f948799e
- Bump debhelper compatibility version 10.
- Switch from Priority extra to optional.
- Update debian/.gitignore file.
Change-Id: If2e0f59104735b2d2f1fbc481bf785848ae471f6
This is a plan for mr5.5* as we have no resources to migrate them now.
Sure later in trunk we should confider to migrate on mariadb configs and split my.cnf probably.
Change-Id: Ib97d2734c26d73996bc0b063f087ed6cfdf89f2e
The old test doesn't work for the freshly installed system
when DB has no subscribes. Old command reported nothing
which fails the test.
Change-Id: I1501f407ab8561fd83b1d21f6c3ac8e306ff1231
Stretch glusterfs 3.8.5 has a confirmed bug with port bumping on every restart:
c3dee6d353967a77ed4d
We are trying to upgrade glusterfs to version 3.11 or fix port bumping upstream for 3.8.5
so far we have to disable the port check here for now.
Change-Id: I512465fc10b8250d6c4ad861c384fc01ca6ae05b
goss was reverted in a previous commit to goss 0.3.1 while
it looks like every goss version sice 0.2.6 are affected:
https://github.com/aelsabbahy/goss/issues/267
So, reverting revert here and updating to the latest 0.3.3 version
(to test and report upstream the latest goss version).
Change-Id: Ife6aec7883fd6d83e3645f728805feaab12c4a06
Unify all templates into a single tree, no more CE vs PRO distinction.
Handle inactive nodes, and CARRIER systems.
Change-Id: Id2800e0cc746233cb69a1b9a09769f26aa9c2a5d
We always want these to overwrite the previously installed files, even
if locally modified, otherwise bad things happen.
We are not concerned about possibly losing data, because on NGCP /etc is
always managed with git, so the whole history is always available.
Change-Id: I7f1af4eab0da5a3bb4bae6e83472e3da8df23f5c
New goss version looks unstable and from time to time gives false positive result
This reverts commit 2a04d50113.
Change-Id: I36a5e2ae75b3b5e31c0d45add8af7985ce1f6952
Guillem Jover
Gerhard Jungwirth
Michael Prokop
Victor Seva
Manuel Montecelo
Alexander Lutay
Sipwise Jenkins Builder
Richard Fuchs
Sergii Kipot