To get better backtraces we should build with -ggdb and -O0. And to
avoid gcc's ASAN implementation erroring out due to libasan not being
passed first as part of LD_PRELOAD, we disable the check via
ASAN_OPTIONS.
Change-Id: I6e8c422fef3c8fdcdc20e815292ffca4f6d6becb
We need to pass these on through environment otherwise we are overriding
the whole build flags.
Change-Id: I3fd856af2624f84afe73427dfb359e8bfc3acaa8
Fixes: commit f791bf03f9
The Ubuntu release used does not have the required package, so we need
to disable it via our build-profile.
Change-Id: I7b929bf5b8cfc60a75e72cbd3b92036cb28d4066
Fixes: commit f791bf03f9
Rename the workflow, as this is only in charge of running the shellcheck
tests. Having a workflow per checker also makes them more modular, and
easier to reuse in other projects by simply copying the files around.
And makes it easier to see what checks are currently available from
the filenames.
Rename the job to "test", for correctness, as it has implicit ordering
and meaning within the GitHub action built-in stages.
Change-Id: I3987fc03111d94a8bc64e9103e43cb4d05925e12
Since dh_auto_test doesn't execute the test suites through make
directly, but instead runs `make -s -n` and then executes the output,
the integrated build tests fail since the sub-make doesn't return an
error as it should when attempting to build with the wrong .h
alternative, resulting in always the first .h alternative being used.
Fix this by using a wrapper script instead.
Also adjust some other related minor build details.
closes#1202
Change-Id: I4b6436295c6b39117bd06df53aa5afc7118ad6a1
If we receive an SDP with a DTLS fingerprint, by default we adopt the
hash function used for that fingerprint in subsequent communication with
that peer. However, if the SDP is an answer, and we previously used a
different hash function in the offer towards that peer, then a later
re-invite offer would be sent with a different fingerprint, causing an
unexpected DTLS restart. Instead, make sure we don't change fingerprints
if one was already sent.
Change-Id: I603bb86ce2d7121556c161749ed08128dd0b63b2
We simplify the function so that we do not need to meddle with pointers
and data sizes.
Change-Id: I3e653b44b28347053cc7a1053de8220c80250816
Warned-by: lgtm
While the code is not threaded, better be future-proof and use safer
APIs, which in addition has less side-effects as it does not set the
global TZ related variables.
Also check for failures.
Change-Id: I083d2b5ad6901ac1a91d42d1ab7fe3e0989b02a0
Warned-by: lgtm
The ntohs() function returns uint16_t, which will always fit within an
int (including in excess for the signed bit) on the platform we support.
Thus the check for negative values is never going to hit.
Change-Id: Ie9d5bcfe5709c50260098f91ff111755ded72921
Warned-by: lgtm
The tracker.most array is of unsigned char, so pt which gets
unconditionally assigned will always be >= 0.
Change-Id: I8adc06fc6c65aa0e33ef6614eb77c67b0dc07517
Warned-by: lgtm
Whether a bit-field is signed or unsigned is implementation specific, so
we should be explicit about this.
Change-Id: I744df3d24bc08e95fa816ba4135f19cd3a5dcb17
Warned-by: lgtm
Richard Fuchs
Julien Chavanton
Julien Chavanton
Dup4
Dennis Yurasov
Guillem Jover
Huseyin Dikme
Damir Nedžibović