30 Commits (96cb2e8f732988a0f8b7b7caf15df5773be661af)

Author	SHA1	Message	Date
Donat Zenichev	423d7bf824	MT#59086 Unify header files. ... In the header files follow the rules: 1. Firstly goes ifndef/define construction, then one empty row. 2. Secondly go system headers, so in angle-brackets, then one empty row. 3. If there are important pre-processor definitions, which affect the following custom file headers, they are added next, then one empty row. 4. Thirdly custom header files, so in double quotes, then at least one empty row. 5. If there is "xt_RTPENGINE.h", it's mentioned next, but separately, then one empty row. 6. Then pre-processor definitions, and one empty row before the code. In some situations it's allowed to step aside from the rules, when inclusions are dependent on each other, so on specific sequence, and also possibly on some inline objects definitions. But, if possible to follow the rules, it should be done. Change-Id: I6bec69b508653947c04e7785775373d21112eb58	2 years ago
Richard Fuchs	c9c6117c66	MT#55283 update all flags to 64 bit ... Change-Id: I8635c29cab5843b5bf8092f30a093871eeb37f29	2 years ago
Richard Fuchs	e969a79428	MT#55283 check DTLS src/dst addressses ... Check addresses of received DTLS packets against known ICE pairs if ICE is in use. Ignore packets that don't correspond to known ICE pairs. Credit to the the team at EnableSecurity.com for disclosure. Ref: https://github.com/EnableSecurity/advisories/tree/master/ES2023-03-rtpengine-dtls-hello-race Change-Id: I45197c50aedeb078763f2f444225ddbda78d9349	2 years ago
Richard Fuchs	cd4f6608cd	MT#55283 convert struct stream_fd to typedef ... Change-Id: I1435a5f755cb99833535d995871f1e9050f0ec73	2 years ago
Richard Fuchs	2975b2131d	MT#55283 convert struct call to typedef ... Change-Id: I1f01fdf74d6d3952413ebc02dfdb9770b324481c	2 years ago
Richard Fuchs	08727c5cb4	MT#55283 use typed GHashTable for ICE ... Change-Id: I6adb1dcc3efc31b612d55f59d1ba7fb865652c7b	2 years ago
Richard Fuchs	cbaa0c106a	MT#55283 use typed GQueue for ICE lists ... Change-Id: Ieb4168cc7959347940831b5b83dce82ba1fe1965	2 years ago
Richard Fuchs	6685fb6efd	MT#55283 use g_auto for sdp_streams/sessions ... Introduce sdp_streams_q and sdp_sessions_q as their own types (typed GQueue) Change-Id: Iee99a4ccd9aba57c49d449963a7cd77f8e20adcc	2 years ago
Richard Fuchs	575d86816f	MT#55283 turn ng_buffer into typedef ... Change-Id: I278cb1b81d9c23074cf159901668221f52d239dd	2 years ago
Richard Fuchs	bc61caf2cc	MT#55283 turn sdp_ng_flags into a typedef ... ... and introduce types.h to contain typedefs and forward declarations of their structs. Change-Id: I579eaf188a0adab13e4a9cca703f8575ac45cca8	2 years ago
Orgad Shaneh	1a28b73a2d	MT#55283 Rename aux -> helpers ... Windows doesn't allow a file to be named aux, so checkout fails. closes #1686 Change-Id: I4667561f430ec8d4767d2313890839754be77322	2 years ago
Richard Fuchs	b90edf0ecf	MT#55283 looper thread bool return type ... Make it possible for a looper thread function to break out of the loop by returning an appropriate status code. Change-Id: I22e7789270eed4bf3340e7dae941929de58700ea	3 years ago
Richard Fuchs	15709a62a6	MT#55283 refactor loop thread creation ... Change-Id: Id94a6bfc69ad5b49a3ffd9ac7a655d81dfc07a07	3 years ago
Donat Zenichev	d818b7ab65	MT#57379 move `ice_slow_timer()` to a separate thread ... Move the `ice_slow_timer()` functionality to a separate thread, so that we do the work more efficiently, and not be dependent on the call_timer runs by poller. Furthermore it makes more sense to keep in the `ice.c`, since it obviously has to do with ice timing. Additionally: Update the test-stats due to these changes in the `call_timer()` We have to call the `ice_slow_timer()` now explicitely from the test-stats.c, because the `call_timer()` is not anymore responsible for providing stats counters rate calculations. Change-Id: I03377dd59ea71c27497e1f4d30164075f05165cd	3 years ago
Richard Fuchs	dca7a84566	MT#56447 switch to trickle_ice_update() ... Defer handling of trickle ICE updates to the appropriate function, which also handles queuing up the updates in case they're processed before the call or call party has been fully created. Change-Id: I2489cb0ee96fba35003765bbdd692f02caed7055	3 years ago
Richard Fuchs	e561a1cc0c	MT#56447 refactor trickle ICE handling ... Move trickle ICE handling out of __media_init_from_flags and into a higher-level function. This obsoletes the special magic return value to indicate a trickle ICE failure. All methods accepting trickle ICE updates must now explicitly call the trickle ICE update function. The requirement to have a full dialogue for trickle ICE updates is removed as trickle ICE only affects one side. Change-Id: I0850e1858876ca7bcdd39b7144b53b5a4afed53e	3 years ago
Richard Fuchs	a590831bd0	MT#56447 move ICE fragment handle ... Moving code for handling (queuing, dequeuing) trickle ICE fragments into ice.c, where it makes no sense. No functional changes. Change-Id: Ib68f82e8d58efe066fdc48cd32ca9869cdeab846	3 years ago
Richard Fuchs	24ed84357a	TT#14008 keep track of ICE candidates based on their priorities ... Change-Id: Ibb248d634d498bc68497be7d036be54956b1de61	4 years ago
Richard Fuchs	e59c062108	TT#14008 allow ICE reset only during an offer ... Change-Id: Ic2daaeba4d14867ffc96ab13f1d9493082ce0bd2	4 years ago
Richard Fuchs	f5a148f268	TT#14008 change local ICE ufrag/pwd after ICE restart ... Implements RFC 5245 9.2.1.1 Also reset ICE role after a restart closes #786 Change-Id: Idc7ec9f409b70598e2840fb7d0a31a12f9db3c21	4 years ago
Richard Fuchs	b0c97e4ccc	TT#89352 support extended ICE candidate syntax ... Change-Id: Ib0d116d69297459a0ec8e3c06f5497df4bb7dbfb	4 years ago
Guillem Jover	07695d2abb	TT#111150 Use modern <stdint.h> uint<bits>_t types ... The u_int<bits>_t are BSD legacy types, while the new ones are specified by C99 and SUSv3. Change-Id: Ia748cabc33a7e5adc2c7a6049ad1e55be0c788a8	5 years ago
Richard Fuchs	89666c8021	TT#14008 fix ICE if ICE completes before SDP comes in ... Change-Id: I3085e67a81fb8adeeb4334db2e0e894716107937	5 years ago
Guillem Jover	68797f4195	TT#111150 Mark bit-fields explicitly with as unsigned ... Whether a bit-field is signed or unsigned is implementation specific, so we should be explicit about this. Change-Id: I744df3d24bc08e95fa816ba4135f19cd3a5dcb17 Warned-by: lgtm	5 years ago
Richard Fuchs	1d34c40276	TT#101201 support optional ICE-lite mode ... closes #1106 Change-Id: I4a83ed2630889d8b17a0c40d971ec7946c1ed3a2	5 years ago
Richard Fuchs	54a39db40f	TT#84804 start DTLS as soon as ICE can communicate ... closes #1035 Change-Id: I5cce8ab986f7d75d7ad88c53b4cc3b48f99a206a	5 years ago
Stefan Mititelu	8ba5d162dd	Fix Valgrind "still reachable" for a few others ... log, ice, media_player, jitter_buffer, statistics, codeclib, call_interfaces	6 years ago
Richard Fuchs	6431cde151	TT#64601 fix some compiler warnings ... stun.c: In function ‘stun_error_len’: stun.c:388:62: warning: taking address of packed member of ‘struct header’ may result in an unaligned pointer value [-Waddress-of-packed-member] 388 | output_init(&mh, iov, &hdr, STUN_BINDING_ERROR_RESPONSE, req->transaction); | ~~~^~~~~~~~~~~~~ stun.c: In function ‘stun_binding_success’: stun.c:479:64: warning: taking address of packed member of ‘struct header’ may result in an unaligned pointer value [-Waddress-of-packed-member] 479 | output_init(&mh, iov, &hdr, STUN_BINDING_SUCCESS_RESPONSE, req->transaction); | ~~~^~~~~~~~~~~~~ stun.c: In function ‘__stun_success’: stun.c:540:42: warning: taking address of packed member of ‘struct header’ may result in an unaligned pointer value [-Waddress-of-packed-member] 540 | return ice_response(sfd, sin, attrs, req->transaction); | ~~~^~~~~~~~~~~~~ stun.c: In function ‘__stun_error’: stun.c:545:42: warning: taking address of packed member of ‘struct header’ may result in an unaligned pointer value [-Waddress-of-packed-member] 545 | return ice_response(sfd, sin, attrs, req->transaction); | ~~~^~~~~~~~~~~~~ redis.c: In function ‘redis_hash_get_sdes_params.isra.0’: redis.c:1095:39: warning: ‘_tag’ directive output may be truncated writing 4 bytes into a region of size between 1 and 32 [-Wformat-truncation=] 1095 | snprintf(tagkey, sizeof(tagkey), "%s_tag", kk); | ^~~~ In file included from /usr/include/stdio.h:867, from ../lib/str.h:9, from ../lib/compat.h:16, from ../include/redis.h:8, from redis.c:1: /usr/include/x86_64-linux-gnu/bits/stdio2.h:67:10: note: ‘__builtin___snprintf_chk’ output between 5 and 36 bytes into a destination of size 32 67 | return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 68 | __bos (__s), __fmt, __va_arg_pack ()); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: I214458fd3f596e565b1bba9d88808b7c99f9c876	6 years ago
Richard Fuchs	d96dbdea17	TT#50652 split timer thread functions into separate file ... Change-Id: I445f3e2556ce647bf7e245e9612f4babcf04e388	7 years ago
Richard Fuchs	d64c888a0e	TT#36301 transcoding unit tests ... Change-Id: If48e5afe5a343b557183b6e87441f52424dd2c6a	8 years ago