TT#64601 fix some compiler warnings

stun.c: In function ‘stun_error_len’:
stun.c:388:62: warning: taking address of packed member of ‘struct header’ may result in an unaligned pointer value [-Waddress-of-packed-member]
  388 |  output_init(&mh, iov, &hdr, STUN_BINDING_ERROR_RESPONSE, req->transaction);
      |                                                           ~~~^~~~~~~~~~~~~
stun.c: In function ‘stun_binding_success’:
stun.c:479:64: warning: taking address of packed member of ‘struct header’ may result in an unaligned pointer value [-Waddress-of-packed-member]
  479 |  output_init(&mh, iov, &hdr, STUN_BINDING_SUCCESS_RESPONSE, req->transaction);
      |                                                             ~~~^~~~~~~~~~~~~
stun.c: In function ‘__stun_success’:
stun.c:540:42: warning: taking address of packed member of ‘struct header’ may result in an unaligned pointer value [-Waddress-of-packed-member]
  540 |  return ice_response(sfd, sin, attrs, req->transaction);
      |                                       ~~~^~~~~~~~~~~~~
stun.c: In function ‘__stun_error’:
stun.c:545:42: warning: taking address of packed member of ‘struct header’ may result in an unaligned pointer value [-Waddress-of-packed-member]
  545 |  return ice_response(sfd, sin, attrs, req->transaction);
      |                                       ~~~^~~~~~~~~~~~~

redis.c: In function ‘redis_hash_get_sdes_params.isra.0’:
redis.c:1095:39: warning: ‘_tag’ directive output may be truncated writing 4 bytes into a region of size between 1 and 32 [-Wformat-truncation=]
 1095 |   snprintf(tagkey, sizeof(tagkey), "%s_tag", kk);
      |                                       ^~~~
In file included from /usr/include/stdio.h:867,
                 from ../lib/str.h:9,
                 from ../lib/compat.h:16,
                 from ../include/redis.h:8,
                 from redis.c:1:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:67:10: note: ‘__builtin___snprintf_chk’ output between 5 and 36 bytes into a destination of size 32
   67 |   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   68 |        __bos (__s), __fmt, __va_arg_pack ());
      |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Change-Id: I214458fd3f596e565b1bba9d88808b7c99f9c876
changes/44/33744/3
Richard Fuchs 6 years ago
parent 4d99ba8f09
commit 6431cde151

@ -1137,7 +1137,7 @@ static int __check_succeeded_complete(struct ice_agent *ag) {
/* call is locked in R */
int ice_response(struct stream_fd *sfd, const endpoint_t *src,
struct stun_attrs *attrs, u_int32_t transaction[3])
struct stun_attrs *attrs, void *transaction)
{
struct ice_candidate_pair *pair, *opair;
struct ice_agent *ag;

@ -1086,7 +1086,7 @@ err:
return -1;
}
static int redis_hash_get_sdes_params(GQueue *out, const struct redis_hash *h, const char *k) {
char key[32], tagkey[32];
char key[32], tagkey[64];
const char *kk = k;
unsigned int tag;
unsigned int iter = 0;

@ -241,7 +241,7 @@ out:
}
static void output_init(struct msghdr *mh, struct iovec *iov,
struct header *hdr, unsigned short code, u_int32_t *transaction)
struct header *hdr, unsigned short code, void *transaction)
{
ZERO(*mh);

@ -158,7 +158,7 @@ void ice_thread_run(void *);
int ice_request(struct stream_fd *, const endpoint_t *, struct stun_attrs *);
int ice_response(struct stream_fd *, const endpoint_t *src,
struct stun_attrs *attrs, u_int32_t transaction[3]);
struct stun_attrs *attrs, void *transaction);

Loading…
Cancel
Save