Richard Fuchs
46a4ba0185
MT#55283 fix regression from fe9d1f5ae3
...
poller_new used to have the side effect of initialising rtpe_now.
Restore this side effect explicitly in the startup code, so that timers
are launched with the correst start time instead of zero.
Change-Id: I590061a9665b52c4aed00c06dc330d2a226c73d3
(cherry picked from commit 8458652d5f )
2 years ago
Richard Fuchs
cb193ca336
MT#55283 safeguard against kmalloc failure
...
closes #1797
Change-Id: I8036cad421d996b09e95946094fd43a55324778e
(cherry picked from commit 6bdedc54ae )
2 years ago
Richard Fuchs
b252da7c26
MT#55283 reset read events after loop cap
...
Partial backport of 6a8c523d5
If we hit the maximul allowed loop iterations when reading packets and
end up aborting the loop, we must set active_read_events back to zero,
so that the next time a read event is received we actually do the
processing instead of thinking there's still an active thread.
Change-Id: I2da17e67ab132ea2d3e1beb399c939195eeaa2f4
2 years ago
Sipwise Jenkins Builder
ba141be541
Release new version 11.5.1.21+0~mr11.5.1.21
2 years ago
Richard Fuchs
834acb2cc4
MT#55283 fix potential deadlock
...
Fix a regression from 4291c858
send_timer_rtcp() does its own locking of the SSRC. Release the lock
before calling it.
Change-Id: I185fb2fb4b47a343ab4be00d16629b5f330ee965
2 years ago
Richard Fuchs
d099cc1809
MT#55283 add rtcp-fb tests
...
Change-Id: I856c00269008d128f653a731bebece7af4e3fb39
2 years ago
Sipwise Jenkins Builder
f4ef08e156
Release new version 11.5.1.20+0~mr11.5.1.20
2 years ago
Richard Fuchs
a199df49d9
MT#55283 fix typo
...
Check the correct field against "*"
Change-Id: I12e3b91f974d3acd9798c93f10491ef6dae43c1a
(cherry picked from commit 5fb74f1e43 )
(cherry picked from commit db095377ee )
2 years ago
Sipwise Jenkins Builder
81884b776a
Release new version 11.5.1.19+0~mr11.5.1.19
2 years ago
Richard Fuchs
6cc7ceb1e2
MT#57977 fix skb leak
...
Change-Id: Id59309311c4dc80f216d556481bf2077640a377a
(cherry picked from commit 25a3693019 )
2 years ago
Richard Fuchs
0acfd8bd56
MT#55283 add IPv4 fallback
...
Try open an IPv4 socket if IPv6 fails with EAFNOSUPPORT in order to
support kernels without IPv6 support.
closes #1784
Change-Id: I2cf4065450a8b19b738c572e7d9ad6f8548ecc04
2 years ago
Richard Fuchs
75bdc27aab
MT#55283 add failure mode for dtmf_init
...
Change-Id: I4896953586ef8c81ce56dca05523dabd9e2773e6
(cherry picked from commit 339c705469 )
2 years ago
Richard Fuchs
4cc2731b77
MT#55283 fix missing return
...
Things go boom without this.
Change-Id: I405e2d0f18da3d7089e82e6d588dfbb5adee9a48
2 years ago
Chris Hofstaedtler
0f0e9e2d57
MT#55283 install files into /usr (DEP17 M2)
...
Use the variable from pkg-config as install location for systemd
units/links.
Change-Id: I504eea66b874f70897e8fe0e2527653d56e604c2
Ref: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1060282
(cherry picked from commit 7e140e8a31 )
2 years ago
Richard Fuchs
4f1ba66b21
MT#55283 use escaped command strings for Graphite
...
Graphite isn't able to deal with spaces in the metric names delivered to
it. Introduce special version of the command strings with spaces
replaced by underscores.
closes #1780
Change-Id: Ie8bcec5ca4f2d427e92901f6fa76b985df6e459e
(cherry picked from commit c6a5b53912 )
2 years ago
Richard Fuchs
def99c6a6f
MT#55283 fix possible mem leak
...
Warned-by: Coverity
Change-Id: I6a1f398272be2929f1157ed0ecdb667e26d3797a
(cherry picked from commit a968afcd1d )
2 years ago
Richard Fuchs
3b7ff5ed72
MT#55283 protect read with mutex
...
Reading learned_endpoint must also be protected by the mutex.
Warned-by: Coverity
Change-Id: I9909d58e7f06806f7398c16c750a6063e923d766
(cherry picked from commit e439a27def )
2 years ago
Sipwise Jenkins Builder
40d51d2c41
Release new version 11.5.1.18+0~mr11.5.1.18
2 years ago
Donat Zenichev
aaf7c6850c
MT#58636 Fix a defect detected by Coverity Scan
...
** CID 1574844: Null pointer dereferences (FORWARD_NULL)
/daemon/call.c: 2416 in codecs_offer()
*** CID 1574844: Null pointer dereferences (FORWARD_NULL)
/daemon/call.c: 2416 in codecs_offer()
2410
2411 if (update_answerer) {
2412 // update/create answer/receiver side
2413 ilogs(codec, LOG_DEBUG, "Updating offer codecs for answerer " STR_FORMAT " #%u",
2414 STR_FMT(&media->monologue->tag),
2415 media->index);
>>> CID 1574844: Null pointer dereferences (FORWARD_NULL)
>>> Dereferencing null pointer "flags".
2416 if (flags->static_codecs && media->codecs.codec_prefs.length)
2417 ilogs(codec, LOG_DEBUG, "Leaving answerer codecs alone");
2418 else if (flags && flags->reuse_codec)
2419 codec_store_populate_reuse(&media->codecs, &sp->codecs,
2420 .merge_cs = &sp->codecs);
2421 else
** CID 1574843: Null pointer dereferences (REVERSE_INULL)
/daemon/call.c: 2418 in codecs_offer()
*** CID 1574843: Null pointer dereferences (REVERSE_INULL)
/daemon/call.c: 2418 in codecs_offer()
2412 // update/create answer/receiver side
2413 ilogs(codec, LOG_DEBUG, "Updating offer codecs for answerer " STR_FORMAT " #%u",
2414 STR_FMT(&media->monologue->tag),
2415 media->index);
2416 if (flags->static_codecs && media->codecs.codec_prefs.length)
2417 ilogs(codec, LOG_DEBUG, "Leaving answerer codecs alone");
>>> CID 1574843: Null pointer dereferences (REVERSE_INULL)
>>> Null-checking "flags" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
2418 else if (flags && flags->reuse_codec)
2419 codec_store_populate_reuse(&media->codecs, &sp->codecs,
2420 .merge_cs = &sp->codecs);
2421 else
2422 codec_store_populate(&media->codecs, &sp->codecs,
2423 .allow_asymmetric = !!(flags && flags->allow_asymmetric_codecs),
Change-Id: Ife9ad5fdf9481fb74bbc4e7c5ac5a784bb564d4b
(cherry picked from commit acd303cd56 )
2 years ago
Sipwise Jenkins Builder
4c45a185e4
Release new version 11.5.1.17+0~mr11.5.1.17
2 years ago
Richard Fuchs
952a81bd93
MT#58636 add new option 'static codecs'
...
Change-Id: Ife8ef86ff0c6dd8733fd063d8ce19f6baaa30e58
(cherry picked from commit 76203fdce9 )
2 years ago
Sipwise Jenkins Builder
22dcd6d588
Release new version 11.5.1.16+0~mr11.5.1.16
2 years ago
Richard Fuchs
8b2a4c4780
MT#55283 check DTLS src/dst addressses
...
Check addresses of received DTLS packets against known ICE pairs if ICE
is in use. Ignore packets that don't correspond to known ICE pairs.
Credit to the the team at EnableSecurity.com for disclosure.
Ref: https://github.com/EnableSecurity/advisories/tree/master/ES2023-03-rtpengine-dtls-hello-race
Change-Id: I45197c50aedeb078763f2f444225ddbda78d9349
(cherry picked from commit e969a79428 )
2 years ago
Michal Hajek
d73ce33206
MT#55283 leave SRTP keys in place after DTLS shut
...
closes #1772
Change-Id: Iaf80e7314730537ca56112cd5f9e1f9c85ca6e3c
(cherry picked from commit afd85a4f94 )
2 years ago
Richard Fuchs
b1b5659205
MT#55283 verify "zero" DTLS cert
...
... instead of "current" if available
closes #1771
Change-Id: Id1b742b2446d4d59b3de251a1d1a5dcbed86834a
(cherry picked from commit 8fba68f2c9 )
2 years ago
Sipwise Jenkins Builder
2c84ff03f5
Release new version 11.5.1.15+0~mr11.5.1.15
2 years ago
Richard Fuchs
47c7d0d39e
MT#55283 backport fix for I2ce02e92debce0b
...
Change-Id: Ib88765ee02b2d83175c41034dc1f3a6895808777
2 years ago
Richard Fuchs
747b0b4f3c
MT#55283 fix missing unlock
...
Change-Id: I2ce02e92debce0ba33b6a271ba831d7ba67e622b
2 years ago
Richard Fuchs
7a8d3b3749
MT#55283 update tests for new ffmpeg
...
These single bit differences are due to a change in ffmpeg encoding.
Change-Id: Ica0dc157f7494be1a0f4e4de9a795273a29d74e7
2 years ago
Richard Fuchs
dd56ca0f40
MT#54294 update to codec-chain framework
...
Change-Id: Ic6286494fad459df4a77665aae66f1af03e9664b
2 years ago
Richard Fuchs
f880739ab8
MT#55283 restrict ifunc usage to glibc
...
probably fixes #1751
Change-Id: Id78d91ef74d60be58e537db85c54bc9447406e34
(cherry picked from commit 96691305a8 )
2 years ago
Richard Fuchs
195d4d725a
MT#55283 fix possible mem leak
...
... and slightly improve log printing by including the PT number
Change-Id: Ie3aae38a32ac6cbab54b6471e2f029db6432c4ed
(cherry picked from commit f24f59efb9 )
2 years ago
Sipwise Jenkins Builder
2e73a356e7
Release new version 11.5.1.14+0~mr11.5.1.14
2 years ago
Richard Fuchs
d02c099206
MT#55283 fix media array building
...
The index j we get is not the position in the output array/list, but
rather the index into the source array. Simply append each new element
to the array in order.
Also make sure we don't skip over empty elements in the array when
building the JSON list, so that the order is preserved.
Change-Id: Id6577410e114f0ddbea745977118f1bab2e38fa9
2 years ago
Richard Fuchs
7d9c263b3a
MT#55283 fix use-after-free
...
Grab the correct list link when inserting in the middle of the list.
Change-Id: I4ae484ba05f5e4be827101193952653c21c47ad3
(cherry picked from commit 3f5a22d2a5 )
2 years ago
Sipwise Jenkins Builder
f736c0bf54
Release new version 11.5.1.13+0~mr11.5.1.13
2 years ago
Richard Fuchs
64374ee1d6
MT#56008 increment EVS decoder frame count
...
Change-Id: I91e6bc52b33d19de04b6ddb8ef5a955c38f0b152
(cherry picked from commit 72b053bf3a )
2 years ago
Sipwise Jenkins Builder
8ef6e05562
Release new version 11.5.1.12+0~mr11.5.1.12
2 years ago
Richard Fuchs
0567baf609
MT#55283 add desired_family to call_monologue
...
This is required to look up the correct interface during Redis restore.
Change-Id: I0ea67576deba95b4201c6384fdcf8051b84f879e
(cherry picked from commit 531e720fd4 )
2 years ago
Sipwise Jenkins Builder
51248ea85f
Release new version 11.5.1.11+0~mr11.5.1.11
2 years ago
Richard Fuchs
b3eb1fd7f9
MT#56471 rework mix-buffer tests
...
Use int16_t literals instead of strings to solve failing tests on big
endian systems
Change-Id: Ie9e5b31ef2ae8f7b3b8277d4520e62540629baa2
2 years ago
Richard Fuchs
4b0af919bd
MT#55283 selectively stop codec handlers
...
If we're updating the handlers for one particular source -> sink flow,
only stop/reset the handlers matching this flow.
Change-Id: I1d046f47f8d26cac47c5d0f4318498eacb6c5677
(cherry picked from commit e24bacaa4c )
2 years ago
Sipwise Jenkins Builder
f0a686312e
Release new version 11.5.1.10+0~mr11.5.1.10
2 years ago
Richard Fuchs
e19dab44e6
MT#55283 fix possible use without initialiser
...
Change-Id: I7d08d549aedc3c6b5075062d898c3726902fe302
(cherry picked from commit 3b1493a6bc )
2 years ago
Richard Fuchs
0b47847912
MT#55283 fix possible NULL dereferences
...
Change-Id: I4abd23c834d133c8f20f0a8038a78aa214cbc879
(cherry picked from commit 5171fd8901 )
2 years ago
Richard Fuchs
9a7a649cbe
MT#55283 add missing send_timer locks
...
ps->out_lock must be held when sending packets, and the SSRC lock must
be held for sending RTCP
Change-Id: I19fe85762e330a9b8a03658a828f735db6eb6cb7
(cherry picked from commit 6c7277a84f )
2 years ago
Richard Fuchs
d02dc4ac15
MT#55283 add missing (re-) initialiser
...
Change-Id: Iae96dc8018d646aadce8e7c229bcd7ee65b206bd
(cherry picked from commit 8e149723c0 )
2 years ago
Richard Fuchs
7d694ee8e4
MT#55283 fix typo
...
Change-Id: I713cf8a2783f2af24771db3de0b1a30aa37df483
(cherry picked from commit 8cacdcc8d3 )
2 years ago
Richard Fuchs
5bf2f5c0c3
MT#55283 fix kernel versioning mixup
...
The wrong version was used in the version test
Change-Id: I0706a13074ce574c0ec73af6e72069147b499b80
(cherry picked from commit 928e51a964 )
2 years ago
Sipwise Jenkins Builder
24c3c3d0f0
Release new version 11.5.1.9+0~mr11.5.1.9
2 years ago