sipwise
/
rtpengine
mirror of https://github.com/sipwise/rtpengine.git
1
0
Fork 0
Code Issues Releases Wiki Activity

MT#55283 protect read with mutex

Browse Source 
Reading learned_endpoint must also be protected by the mutex.

Warned-by: Coverity
Change-Id: I9909d58e7f06806f7398c16c750a6063e923d766
pull/1783/head
Richard Fuchs 2 years ago
parent ea59f28e53
commit e439a27def
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File

7
daemon/media_socket.c
Unescape View File

@ -2426,11 +2426,10 @@ static bool media_packet_address_check(struct packet_handler_ctx *phc)
/* do not pay attention to source addresses of incoming packets for asymmetric streams */ /* do not pay attention to source addresses of incoming packets for asymmetric streams */
if (MEDIA_ISSET(phc->mp.media, ASYMMETRIC) || phc->mp.stream->el_flags == EL_OFF) { if (MEDIA_ISSET(phc->mp.media, ASYMMETRIC) || phc->mp.stream->el_flags == EL_OFF) {
PS_SET(phc->mp.stream, CONFIRMED); PS_SET(phc->mp.stream, CONFIRMED);
if (MEDIA_ISSET(phc->mp.media, ASYMMETRIC) && !phc->mp.stream->learned_endpoint.address.family) { mutex_lock(&phc->mp.stream->out_lock);
mutex_lock(&phc->mp.stream->out_lock); if (MEDIA_ISSET(phc->mp.media, ASYMMETRIC) && !phc->mp.stream->learned_endpoint.address.family)
phc->mp.stream->learned_endpoint = phc->mp.fsin; phc->mp.stream->learned_endpoint = phc->mp.fsin;
mutex_unlock(&phc->mp.stream->out_lock); mutex_unlock(&phc->mp.stream->out_lock);
}
} }
/* confirm sinks for unidirectional streams in order to kernelize */ /* confirm sinks for unidirectional streams in order to kernelize */

Write Preview
Loading…
Cancel
Save