Rtpengine starts even if redis is down

Rtpengine will start with a warning message if redis is configured, but is
not up and running.

daemon/redis.c

@@ -233,24 +233,21 @@ struct redis *redis_new(const endpoint_t *ep, int db, const char *auth, enum red
 	r->db = db;
 	r->auth = auth;
 	r->role = role;
+	r->state = REDIS_STATE_DISCONNECTED;
 	mutex_init(&r->lock);
 
-	if (redis_connect(r, 10))
+	if (redis_connect(r, 10)) {
-		goto err;
+		rlog(LOG_WARN, "Starting with no initial connection to Redis %s !",
-
-	// redis is connected
-	if (r->state == REDIS_STATE_DISCONNECTED) {
-		rlog(LOG_INFO, "Established connection to Redis %s",
 			endpoint_print_buf(&r->endpoint));
-		r->state = REDIS_STATE_CONNECTED;
+		return r;
 	}
 
-	return r;
+	// redis is connected
+	rlog(LOG_INFO, "Established initial connection to Redis %s",
+		endpoint_print_buf(&r->endpoint));
+	r->state = REDIS_STATE_CONNECTED;
 
-err:
+	return r;
-	mutex_destroy(&r->lock);
-	g_slice_free1(sizeof(*r), r);
-	return NULL;
 }
 
 

daemon/redis.h

@@ -20,8 +20,10 @@ enum redis_role {
 	ANY_REDIS_ROLE = 2,
 };
 
-#define REDIS_STATE_DISCONNECTED	0
+enum redis_state {
-#define REDIS_STATE_CONNECTED		1
+	REDIS_STATE_DISCONNECTED = 0,
+	REDIS_STATE_CONNECTED = 1,
+};
 
 struct callmaster;
 struct call;