MT#55283 improve skew calculation

Instead of taking an average, take the minimum over the last X frames.
This fixes skew calculation in situations where the encoder is expected
to produce burst output (e.g. G.726).

Probably the exception for media playback can also be removed.

Change-Id: I92e03916c04c670f6e8e72ad243a67d675504690

daemon/codec.c

@@ -2534,17 +2534,26 @@ void codec_output_rtp(struct media_packet *mp, struct codec_scheduler *csch,
 
 	ts_diff_us = p->ttq_entry.when - rtpe_now;
 
-	if (!csch->is_media_playback)
+	if (!csch->is_media_playback) {
-		csch->output_skew = csch->output_skew * 15 / 16 + ts_diff_us / 16;
+		if (ts_diff_us >= 0) {
-
+			csch->skew_samples++;
-	if (csch->output_skew > 50000 && ts_diff_us > 10000) { // arbitrary value, 50 ms, 10 ms shift
+			csch->output_skew = MIN(csch->output_skew, ts_diff_us);
-		ilogs(transcoding, LOG_DEBUG, "Steady clock skew of %li.%01li ms detected, shifting send timer back by 10 ms",
+		}
-			csch->output_skew / 1000,
+	}
-			(csch->output_skew % 1000) / 100);
+
-		p->ttq_entry.when -= 10000;
+	// arbitrary values, min 25 samples of at least 50 ms
-		csch->output_skew -= 10000;
+	if (csch->skew_samples >= 25) {
-		csch->first_send_ts += handler->dest_pt.clock_rate / 100;
+		if (csch->output_skew > 50000) {
-		ts_diff_us = p->ttq_entry.when - rtpe_now;
+			ilogs(transcoding, LOG_DEBUG, "Steady clock skew of %li.%01li ms detected, shifting send timer back by 10 ms",
+				csch->output_skew / 1000,
+				(csch->output_skew % 1000) / 100);
+			p->ttq_entry.when -= 10000;
+			csch->output_skew -= 10000;
+			csch->first_send_ts += handler->dest_pt.clock_rate / 100;
+			ts_diff_us = p->ttq_entry.when - rtpe_now;
+		}
+		csch->skew_samples = 0;
+		csch->output_skew = 0;
 	}
 	else if (ts_diff_us < 0) {
 		ts_diff_us *= -1;
@@ -2553,6 +2562,7 @@ void codec_output_rtp(struct media_packet *mp, struct codec_scheduler *csch,
 			(ts_diff_us % 1000) / 100);
 		p->ttq_entry.when += ts_diff_us;
 		csch->output_skew = 0;
+		csch->skew_samples = 0;
 		csch->first_send_ts -= (int64_t) handler->dest_pt.clock_rate * ts_diff_us / 1000000;
 		ts_diff_us = p->ttq_entry.when - rtpe_now; // should be 0 now
 	}

include/codec.h

@@ -110,6 +110,7 @@ struct codec_scheduler {
 	int64_t first_send;
 	unsigned long first_send_ts;
 	long output_skew;
+	unsigned int skew_samples;
 	bool is_media_playback; // used to track media playback so we can skip skew calculation
 };