mirror of https://github.com/sipwise/ngcpcfg.git
The previous code had three including loops: - loop over all folders ${CONFIG_POOL} - run find to get list of all files - loop over all files in list - check if no files requested (build all) then remember file - loop over all requested files - check if file was requested then remember file - process further with all files we remembered above The new logic is much simpler and faster: - loop over all folders ${CONFIG_POOL}, remove missing - run find on all available folders to get list of all files 'filelist_allfiles' - check IF no files requested (build all) - THEN just use all files from list 'filelist_allfiles' - ELSE loop over all requested by user files (normally one/several) - grep requested file from 'filelist_allfiles' - process further with all files we remembered above The two main ideas here: - just use all files if we build all files, no need to loop one by one - grep requested files from "all files" instead of searching them in loop At the end we are 30% faster in case if we build one file only: > Command: time ngcpcfg build /etc/default/ngcp-roles > Old code: real 0m1.587s > New code: real 0m1.060s Change-Id: I206557b004ff95c0607150a61a9e6e743ab8cd29changes/07/33607/6
parent
2f69005c43
commit
ef9ebde2f3
Loading…
Reference in new issue