You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Kirill Solomko 205b27a267 MT#59478 API better transaction and error handling ... * Role/Entities*: POST/PUT/PATCH/DELETE methods changes: - support deadlock detection and transaction retry (2 retry attempts at the moment) - improve transaction control, use local $guard instead of saving the ref to $c->stash, as in that case it went out of scope too late and also reported an error message into the log about abnormal $guard out of scope interruption - move all non transaction related code outside of the scope - add error handling when methods such as update_item, and a like do not return the expected data, instead of simply going out of scope and resulting in an uncontrolled reply * Role/API: - rework transaction control: + get_transaction_control() is renamed to start_transaction() to better reflect what it does + complete_transaction() is renamed to commit_transaction() + remove unused %params arg + pass $guard into commit_transaction() instead of having it stored as $c->stash->{transaction_guard) that caused the $guard ref to be destroyed much late than expected (there was also a typo as transaction_quard, which is not relevant anymore with the changes + add check_deadlock() that is invoked when an exception is caught or an $c->errors contain an error, and if the error message represents a transaction error, the transaction block is re-invoked via "goto TX_START" - rework error(): + it now accepts args as following: ($self, $c, $code, $message, @errors) # code -> returned as HTTP code in the reply # message -> returned as HTTP message in the reply # errors -> contain errors for internal logging, last element often contains a DBIx exception + populates all @errors into $c->error so they are available on demend in the code via $c->error or $c->last_error + $c->log->error is not invoked now as the errors become printed in log_response() - log_response() now prints collected errors from $c->error correctly as a separate log line, that is alike to the other api logs so that those can be looked up by the request's tx_id, also all errors are now printed only into api.log * Adjust all $self->error() calls in catch($e) to include $e as the last argument, as well as the duplicate $c->log->error is removed from those ocassions * Remove all $c->log->error() calls as they are replaced with either $self->error() (that logs it correctly into api.log) or $c->error('err') that also adds it correctly into api.log * API::CallForwards: rework to use Entities/EntitiesItem * API::Contracts: rework POST to use Entities * API::PeeringGroups: rework POST to use Entities * API::SubscriberRegistrations: rework POST to use Entities * API::RewriteRuleSets: improve create_item() functionality * Utils/Message: add 'api_retry' log type * $c->session->{api_request_tx_id} is changed to $c->stash->{api_request_tx_id} because sometimes the session ref is different and a different tx_id becomes used Change-Id: I633ce7a8047b1bf00a2f6889003088edf0825dcd		1 year ago
..
AdminCerts.pm	…
Admins.pm	MT#59478 API better transaction and error handling	1 year ago
ApplyRewrites.pm	…
AuthTokens.pm	…
AutoAttendants.pm	MT#59478 API better transaction and error handling	1 year ago
BalanceIntervals.pm	MT#56239 api/callrecordings support filtering multiple metakeys	2 years ago
BannedIps.pm	…
BannedUsers.pm	…
BillingFees.pm	…
BillingNetworks.pm	MT#59478 API better transaction and error handling	1 year ago
BillingProfiles.pm	MT#59478 API better transaction and error handling	1 year ago
BillingZones.pm	…
CCMapEntries.pm	MT#59478 API better transaction and error handling	1 year ago
CFBNumberSets.pm	MT#59478 API better transaction and error handling	1 year ago
CFDestinationSets.pm	MT#59478 API better transaction and error handling	1 year ago
CFMappings.pm	MT#58890 force cft_ringtimeout as number	1 year ago
CFSourceSets.pm	MT#59478 API better transaction and error handling	1 year ago
CFTimeSets.pm	MT#59478 API better transaction and error handling	1 year ago
CallControls.pm	…
CallForwards.pm	MT#59478 API better transaction and error handling	1 year ago
CallLists.pm	…
CallQueues.pm	MT#59478 API better transaction and error handling	1 year ago
CallRecordingStreams.pm	…
CallRecordings.pm	MT#56239 api/callrecordings support filtering multiple metakeys	2 years ago
Calls.pm	…
Capabilities.pm	…
Contracts.pm	MT#59478 API better transaction and error handling	1 year ago
Conversations.pm	MT#56239 api general caller/callee wildcard search support	2 years ago
CustomerBalances.pm	…
CustomerContacts.pm	MT#57564 convert deprecated timezone names	2 years ago
CustomerFraudEvents.pm	MT#59478 API better transaction and error handling	1 year ago
CustomerFraudPreferences.pm	MT#59478 API better transaction and error handling	1 year ago
CustomerLocations.pm	MT#59478 API better transaction and error handling	1 year ago
CustomerPhonebookEntries.pm	MT#59478 API better transaction and error handling	1 year ago
CustomerZoneCosts.pm	MT#58936 fix customerzonecosts resourcename	1 year ago
Customers.pm	MT#59478 API better transaction and error handling	1 year ago
Domains.pm	…
EmailTemplates.pm	MT#59478 API better transaction and error handling	1 year ago
EmergencyMappingContainers.pm	MT#59478 API better transaction and error handling	1 year ago
EmergencyMappings.pm	MT#59478 API better transaction and error handling	1 year ago
Events.pm	…
FaxRecordings.pm	…
Faxes.pm	…
FaxserverSettings.pm	MT#59478 API better transaction and error handling	1 year ago
HeaderRuleActions.pm	MT#58834 fix headerrule conditions/actions dp_id check	1 year ago
HeaderRuleConditions.pm	MT#58861 /api/headerruleconditions accept values as a list of strings	1 year ago
HeaderRuleSets.pm	MT#59662 enhance subscriber assigned header rules/sets handling	1 year ago
HeaderRules.pm	MT#59662 enhance subscriber assigned header rules/sets handling	1 year ago
Interceptions.pm	MT#59478 API better transaction and error handling	1 year ago
InvoiceTemplates.pm	MT#59478 API better transaction and error handling	1 year ago
Invoices.pm	…
LnpCarriers.pm	MT#59478 API better transaction and error handling	1 year ago
LnpNumbers.pm	MT#59478 API better transaction and error handling	1 year ago
MailToFaxSettings.pm	MT#59478 API better transaction and error handling	1 year ago
MaliciousCalls.pm	…
ManagerSecretary.pm	MT#59478 API better transaction and error handling	1 year ago
NcosLevels.pm	MT#59478 API better transaction and error handling	1 year ago
NcosLnpCarriers.pm	MT#59478 API better transaction and error handling	1 year ago
NcosLnpPatterns.pm	MT#59478 API better transaction and error handling	1 year ago
NcosPatterns.pm	MT#59478 API better transaction and error handling	1 year ago
Numbers.pm	…
PartyCallControls.pm	…
PasswordRecovery.pm	…
PasswordReset.pm	…
PbxDeviceConfigs.pm	MT#59478 API better transaction and error handling	1 year ago
PbxDeviceFirmwares.pm	MT#59478 API better transaction and error handling	1 year ago
PbxDeviceModelImages.pm	…
PbxDeviceModels.pm	MT#59478 API better transaction and error handling	1 year ago
PbxDeviceProfiles.pm	MT#59478 API better transaction and error handling	1 year ago
PbxDevices.pm	MT#59478 API better transaction and error handling	1 year ago
PeeringGroups.pm	MT#59478 API better transaction and error handling	1 year ago
PeeringInboundRules.pm	MT#59478 API better transaction and error handling	1 year ago
PeeringRules.pm	MT#59478 API better transaction and error handling	1 year ago
PeeringServers.pm	MT#59478 API better transaction and error handling	1 year ago
Preferences.pm	…
PreferencesMetaEntries.pm	…
ProfilePackages.pm	MT#59478 API better transaction and error handling	1 year ago
ProvisioningTemplates.pm	…
Reminders.pm	MT#59478 API better transaction and error handling	1 year ago
ResellerBrandingLogos.pm	MT#32992 fix /api/resellerbrandnglogos	2 years ago
ResellerBrandings.pm	MT#59478 API better transaction and error handling	1 year ago
ResellerPhonebookEntries.pm	MT#59478 API better transaction and error handling	1 year ago
Resellers.pm	…
RewriteRuleSets.pm	MT#59478 API better transaction and error handling	1 year ago
RewriteRules.pm	…
SIPCaptures.pm	…
SMS.pm	…
SoundFiles.pm	MT#59478 API better transaction and error handling	1 year ago
SoundGroups.pm	…
SoundHandles.pm	…
SoundSets.pm	MT#59478 API better transaction and error handling	1 year ago
SpeedDials.pm	MT#59478 API better transaction and error handling	1 year ago
SubscriberLocationMappings.pm	MT#59478 API better transaction and error handling	1 year ago
SubscriberPhonebookEntries.pm	MT#59478 API better transaction and error handling	1 year ago
SubscriberProfileSets.pm	MT#59478 API better transaction and error handling	1 year ago
SubscriberProfiles.pm	MT#59478 API better transaction and error handling	1 year ago
SubscriberRegistrations.pm	MT#57606 subscriberadmin can manage other subscribers' registrations	2 years ago
Subscribers.pm	MT#59478 API better transaction and error handling	1 year ago
SystemContacts.pm	MT#57564 convert deprecated timezone names	2 years ago
TimeSets.pm	MT#59478 API better transaction and error handling	1 year ago
TopupLogs.pm	…
TrustedSources.pm	MT#59478 API better transaction and error handling	1 year ago
UpnRewriteSets.pm	MT#59478 API better transaction and error handling	1 year ago
UserInfo.pm	…
VoicemailGreetings.pm	…
VoicemailRecordings.pm	…
VoicemailSettings.pm	MT#59478 API better transaction and error handling	1 year ago
Voicemails.pm	…
Vouchers.pm	MT#59478 API better transaction and error handling	1 year ago