775 Commits (205b27a2676efa51df1ee51a6731c7fe9942422a)

Author	SHA1	Message	Date
Kirill Solomko	205b27a267	MT#59478 API better transaction and error handling ... * Role/Entities*: POST/PUT/PATCH/DELETE methods changes: - support deadlock detection and transaction retry (2 retry attempts at the moment) - improve transaction control, use local $guard instead of saving the ref to $c->stash, as in that case it went out of scope too late and also reported an error message into the log about abnormal $guard out of scope interruption - move all non transaction related code outside of the scope - add error handling when methods such as update_item, and a like do not return the expected data, instead of simply going out of scope and resulting in an uncontrolled reply * Role/API: - rework transaction control: + get_transaction_control() is renamed to start_transaction() to better reflect what it does + complete_transaction() is renamed to commit_transaction() + remove unused %params arg + pass $guard into commit_transaction() instead of having it stored as $c->stash->{transaction_guard) that caused the $guard ref to be destroyed much late than expected (there was also a typo as transaction_quard, which is not relevant anymore with the changes + add check_deadlock() that is invoked when an exception is caught or an $c->errors contain an error, and if the error message represents a transaction error, the transaction block is re-invoked via "goto TX_START" - rework error(): + it now accepts args as following: ($self, $c, $code, $message, @errors) # code -> returned as HTTP code in the reply # message -> returned as HTTP message in the reply # errors -> contain errors for internal logging, last element often contains a DBIx exception + populates all @errors into $c->error so they are available on demend in the code via $c->error or $c->last_error + $c->log->error is not invoked now as the errors become printed in log_response() - log_response() now prints collected errors from $c->error correctly as a separate log line, that is alike to the other api logs so that those can be looked up by the request's tx_id, also all errors are now printed only into api.log * Adjust all $self->error() calls in catch($e) to include $e as the last argument, as well as the duplicate $c->log->error is removed from those ocassions * Remove all $c->log->error() calls as they are replaced with either $self->error() (that logs it correctly into api.log) or $c->error('err') that also adds it correctly into api.log * API::CallForwards: rework to use Entities/EntitiesItem * API::Contracts: rework POST to use Entities * API::PeeringGroups: rework POST to use Entities * API::SubscriberRegistrations: rework POST to use Entities * API::RewriteRuleSets: improve create_item() functionality * Utils/Message: add 'api_retry' log type * $c->session->{api_request_tx_id} is changed to $c->stash->{api_request_tx_id} because sometimes the session ref is different and a different tx_id becomes used Change-Id: I633ce7a8047b1bf00a2f6889003088edf0825dcd	1 year ago
Kirill Solomko	aef4c89197	MT#59662 enhance subscriber assigned header rules/sets handling ... * POST /api/headerrules now supports either 'set_id' or 'subscriber_id'. When 'subsriber_id' is specified, a subscriber assigned header rule set is automatically created if it does not exist, as well as automatically removed when its last header rule is deleted. * It is now possible to directly GET and DELETE /api/headerrules/:id where :id is a subscriber assigned header rule. * It is now possible to directly GET and DELETE /api/headerrulesets/:id where :id is a subscriber assigned header rule set. * Improve /api/headerrules data validation and duplicate header rule detection. * It is now possible to expand by /api/headerrules/?expand=set_id field Change-Id: I681bc61c2eed47a8e54847f07f31134f643930c2	1 year ago
Rene Krenn	740bb764e5	MT#59434 always take aliases from voip_numbers ... in case the DB shows discrepancy because of missing primary provisioning.voip_dbaliases records, align with legacy panel behaviour and also take the restapi aliases list from voip_numbers, instead of voip_dbaliases. .. while trying to keep the performance gain from https://gerrit.mgm.sipwise.com/c/ngcp-panel/+/65086. Change-Id: Ibd7f8c8bc6a39ae2c31b4e8818080674ab77d66c	1 year ago
Rene Krenn	cc8fd8928d	MT#58890 force cft_ringtimeout as number ... Change-Id: I4df4fbf6522d28a30731c87a36c95ae8350830fa	1 year ago
Rene Krenn	2101e2246d	MT#58936 fix customerzonecosts resourcename ... Change-Id: I22b052bc6931e5426e1aa982396c446cb1c67883	1 year ago
Rene Krenn	853bc9f535	MT#58936 direction filter param for /api/customerzonecosts ... Change-Id: Ie831381576ffdb2a08375cf73bc66c1c5e6d2076	1 year ago
Kirill Solomko	462bfedc43	MT#58861 /api/headerruleconditions accept values as a list of strings ... * {"values:", ["value1", "value2"]} is not accepted by /api/headerruleconditions * the previous behaviour of {"values": [{"value": "value1"},{"value": "value2"}]} is preserved Change-Id: I7d9540d20ed0ecbb2712f1905a7d9e6f7af7e06d	1 year ago
Kirill Solomko	8985839509	MT#58834 fix headerrule conditions/actions dp_id check ... * address a 500 error when rwr_set_id is specified but empty and dp_id is also specified Change-Id: I0160a3c2f6b3cf139935c4e2daf7e1635dafb99a	1 year ago
Rene Krenn	8e82715eb8	MT#56239 api/callrecordings support filtering multiple metakeys ... filtering an Entity-Attribute-Value model cannot be done as simple conjunctions, but requires either INTERSECT set operation, or joining the same table multiple times. Change-Id: I5ce1ae1ece9406b6610487654f09d768a233b122	2 years ago
Kirill Solomko	1231cae638	MT#58746 /api/phonebookentries fix duplicate check ... * all reseller_id-number entries are checked for POST * reseller_id-number pairs that != item->id are checked for PUT/PATCH Change-Id: I93a8b7fe22ed63d2d84e2d45291981d09b4af156	2 years ago
Rene Krenn	9c3a549094	MT#56239 api general caller/callee wildcard search support ... various api rails will need to support ?caller= and ?callee= url query parameters. since this involves SQL queries against potentially large database tables, special care is taken with wildcard search to prevent slow queries: - the ?wildcards=true query parameter has to be specified to accept search patterns that contain wildcard symbols, so wildcards are not accepted by default. WARNING: a search string with a leading wildcard will always force a *slow* full db table scan! - the * symbol is used as a wildcard symbol - \ (backslash) is used as escape character to search for a literal '*' Change-Id: Ie6065b0cfa883f7963e1dc8259fffea9a1edfdfe	2 years ago
Rene Krenn	5eff0601b5	MT#58346 fix conversations voicemail timestamp filter ... Change-Id: I86fc4db7d5efddf73f6c0b068b1c9e79913fddaf	2 years ago
Rene Krenn	ae612eb401	MT#58346 caller/callee filters for conversations ... the conversation list now supports ?caller= and ?callee= url query parameters. since this involves SQL queries against potentially large database tables, special care is taken with wildcard search to prevent slow queries: - the ?wildcard=true query parameter has to be specified to accept search patterns that contain wildcard symbols, so wilddcards are not accepted by default. WARNING: a search string with a leading wildcard will always force a *slow* full db table scan! - the * symbol is used as a wildcard symbol - \ (backslash) is used as escape character to search for a literal '*' Change-Id: I792d2ea9c649c69c4b5cc98076097cb96467d4bc	2 years ago
Marco Capetta	a7f82c264b	MT#57129 Anonymize caller in conversation list when clir is equal to 1 ... In case a susbcriber or subscriber admin get the conversation list using the API, the caller is not properly anonymized when clir is set to 1. This is a big security hole. With the fix, the caller is authomatically anonymized. Of course, administrators and resellers can still see the original caller number. Change-Id: I9bc676718e38ae1d462f43176e4c6611528f7e54	2 years ago
Kirill Solomko	cec12f7b1e	MT#58333 rework /api/phonebookentries ... * /api/phonebookentries is now split into 3 parts * /api/resellerphonebookentries * /api/customerphonebookentries * /api/subscriberphonebookentries main reason is because there are 3 different contexts (tables) that in the end return "id" which is also a resource identifier and it is not unique because the contexts handle their own ids, another reason is to simplify code and access definitions, as well as to have solid and easy representation. * /api/resllerphonebookentries * can be accessed by 'admin', 'reseller' roles * /api/customerphonebookentries * can be accessed by 'admin', 'reseller', 'subscriberadmin' roles * fix contract_id field to be correctly represented as 'customer_id' * /api/subscriberphonebookentries * can be accessed by 'admin', 'reseller', 'subscriberadmin', 'subscriber' roles * add 'shared' query filter * all the new endpoints * no more required query param fields * customer_id is now optional query parameter filter * add valid/existing resource checks for POST/PATCH/PUT ops * add correct auto filtering based on the user's role * various major code simplifications, fixes and code style improvements * csv download now also allows query param filters to be applied * fix documentation Change-Id: I735df96b7a7e18006a46b82a4fcc603e400ad9e6	2 years ago
Kirill Solomko	6953de937c	MT#33041 add reseller max subscribers support ... * Max subscribers can now be defined in the Reseller contract * Max subscribers is now shown in int Reseller's "Reseller Contract" Details (with an indictaion of how many subscribers are created out of the defined max subscribers, as well as when the limit is reached (similar to the Customer's Details page) * Add reseller subscribers count checks on the UI Create Subscriber page * Add reseller subscribers count checks in /api/contracts POST/PUT * Prevent max_subscribers definition for Peering contracts in /api/contracts POST/PUT Change-Id: I1561d4eb7da5b1a0a0c99acabd18d2a9cd98dec7	2 years ago
Donat Zenichev	fd796a91ba	MT#56845 HG: introduce new field `Cancel Mode` ... This field controls a behavior upon cancelling unsuccessful legs: - terminate legs with CANCEL (default way) - terminate legs with BYE Change-Id: I2ff5c758c319714f0e6636db8b8ba5c0fd495e1f	2 years ago
Kirill Solomko	ba78e193e9	MT#57753 fix /api/mailtofaxsettings secret_key change ... * secret_key can not be correctly set/updated and unset * last_secret_key_modify behaviour is changed, if "secret_key" is provided in the data, the value is updated, otherwise it points to the last time when the key was updated (or unset) Change-Id: Ib6d7f78d4e93240ac36750fc1685f1c4c765bf55	2 years ago
Kirill Solomko	22a8e95c29	MT#57708 sound set/file use READ COMMITTED ... * as changes to sound sets and sound files cause internal triggers + SP to be invoked, the gap locking should be reduced to avoid possible deadlocks, hence READ COMMITTED transaction isolation level is used for all sound sets and sound files change operations. * fix a condition that caused an evaluation error when both old_parent_id and parent_id are undef. Change-Id: I7e69a0a0e5878c03b086977933315e532aaa2a29	2 years ago
Kirill Solomko	c2fe092004	MT#57801 /api/phonebookentries fix get_form() ... * address an issue where get_form() logic did not return any $form value because of the if ($params) block was falsely used. Change-Id: I77f03ac7914c1b4a8f072269cf2c98b99657fa52	2 years ago
Kirill Solomko	9d9c0d0669	MT#57580 add expose_to_customer support for NCOS ... * NCOS Levels and NCOS Sets now have expose_to_customer option (boolean). If enabled, the NCOS Level/Set can be seen and used by Customers in their and their subscribers' preferences * NCOS Levels and NCOS Sets with expose_to_customer = 0 (default) are not visible anymore to subscribers. * API GET /api/ncoslevels is now accessible by 'subscriberadmin' role and returns a list of NCOS Levels that belong to the same reseller and with expose_to_customer = 1 (fields are limited to id,name,description). * When NCOS Level is expose_to_customer is set from 1 to 0, all assigned ncos preferences for contracts and subscribers are that contain the NCOS Level are removed. Change-Id: Id7c444b4a0834939a128179ded6670705258519b	2 years ago
Marco Capetta	7853ae16fb	MT#57668 Add support for implicit reseller_id on phonebookentries api ... A reseller was not able to edit a phonebook entry unless it specified the reseller_id. This should not be required since the reseller could not know it. Change-Id: I347c676e291659e9a8b2a97632531dc7b06e055a	2 years ago
Marco Capetta	e88d03f9eb	MT#57606 subscriberadmin can manage other subscribers' registrations ... subscriberadmin is now be able to get, edit and delete registrations of the other subscribers belonging to the same customer. This is necessary to extend the CSC features and give the PBX administrator more flexibility in device configuration. Change-Id: If83c1adb9af6590111c14800d83fb7d1eafaa9d3	2 years ago
Kirill Solomko	391aa3fbc3	MT#57564 convert deprecated timezone names ... * timezone names are converted to their links, and if a link is found (means that the current name is deprecated), it's validated and stored as the link. Change-Id: I6348659178400a96eaadd70f79b792c4fa25d7d4	2 years ago
Marco Capetta	be7193e75b	MT#57469 Fix kamailio lcr reload on PATCH/PUT APIs ... When calling a PATCH or PUT API on a peering group or outbound rule the reload of the kamailio lcr module was triggered before the update of the database, thus the kamailio status was not updated. Change-Id: I59ed863c85219e62d6f5b5a2af80db8ef952844c	2 years ago
Marco Capetta	ce6884ebab	MT#57342 /api/subscribers fix field role inconsistency ... When the subscriber preferences API is called by a subscriber admin of a normal (not PBX) customer, then some values are removed from the output. In all the other cases those values are instead returned. This fix let expose the profile_id, domain_id, status and webpassword to all the types of subscribers because necessary in the CSC context. Change-Id: I629475e7f51d747a55ebfbc44232fb94a54fed06	2 years ago
Kirill Solomko	89173442f3	MT#57223 improve sems audio cache invalidation ... * clear_audio_cache is now invoked also from: - when a sound file is added (to reflect use_parent/potential child sets) - when a parent is changed for a sound set (to reflect current and potential child sets) - when a sound set is removed (to reflect potential child sets) * clear_audio_cache() is reworked - clear_audio_cache() now calls virtual_child_sound_sets to fetch all potentially affected child sound sets and also clears audio cache for them. if the amount of fetched sound_sets is greater than 10000 then the the whole audio cache is invalidated * _clear_audio_cache_service() is reworked - supports/expects a list of sound sets and sends them as a string with ':' separator - if both sound handle and sound sets are provided it calls clearFiles (so that only the specific sound handle is cleared) - if only sound sets are provided it calls clearSets (so that all of the cached files beloning to the sets are removed) - if none of the above are provided it calls clearAll to invalidate the whole cache Change-Id: Ie85f208e27183e88665803b93bb16d7de8e3d7ac	2 years ago
Marco Capetta	b013f3560a	MT#57240 Allow '+' char in device line number definition ... Change-Id: I0234d7fd3a34d55cd1370a65f93171264eb7f44f	2 years ago
Kirill Solomko	158def3bb6	MT#56735 /api/billingprofiles fix reseller_id on update ... * /api/billingprofiles PUT/PATCH reseller_id for "reseller" roles is forced to the user one, to address an issue when reseller_id becomes required on PUT/PATCH Change-Id: I3fa556c5db5556c75bf481d18b51df6c400a1944	2 years ago
Kirill Solomko	c5b288a9da	MT#57085 fix /api/peeringroups form operations ... * API now has own GroupAPI form with the correct fields for API * db/form field name conversion is moved to the newly added resource_from_item() and process_form_resource() functions * simplify code for GET/POST/PUT/PATCH operations Change-Id: I99b76801a2894c8a4821513186796627db728189	2 years ago
Kirill Solomko	6a922c5cfb	MT#56693 parent_name, allow empty sound files, sems audio cache ... * /api/soundsets new parent_name field * /api/soundfiles now allow POST to be done without the upload, for cases when an empty record needs to be added to define "use_parent" behaviour * improve sems audio cache clear on sound files change, now sems instances that are not available (not running/request timeout) are skipped instead of raising an error Change-Id: I83af2ee2fd3672ab35cf330464ace68416ab52be	2 years ago
Marco Capetta	da628f6e0f	MT#56691 Extend Contract Soundsets with all the announcements ... The pre-call announcements and the ringback tone are not under the subscriber administrator control. This make difficult for PBX customers to modify those announcements. Due to that now all the announcement's handle are exposed also to contract soundsets. Change-Id: Ie6c98a6a6ed4de18b267bd553f33afc9eb72f995	2 years ago
Kirill Solomko	44ec794db2	MT#56693 add parent sound set support ... * sound sets can now use other sound sets as parents, in this case if a sound is missing for a sound set, it's taken from the parent one if it exists there, chained parents are also supported with the available sound files "accumulated" across them. * add "expose_to_customer" field to sound sets, it enables exposing system sound sets to customers so they can be used as a parent or assigned to the 'sound_set' preference by 'subscriberadmin'. * add "use_parent" field to sound set files, it's true by default (for existing or missing sound files) and if set to 0, then parents are not used for this particular sound file. * use_parent column is hidden on the UI if a sound set does not have a parent assigned * improve sound set handles list on the UI - Upload is renamed to Add - empty record are shown in the filename column as localised "(empty)" and Edit/Delete action buttons * API /api/soundsets new 'parent_id' field, default null * API /api/soundfiles new 'use_parent' field, default 1 * API /api/soundsets new 'expose_to_customer' field, default 0 * API /api/soundsets customer_id field now contains the customer id for 'subscriberadmin' role and 'null' if it's a system sound set * system sound sets with expose_to_customer == 1 and within the same reseller are now visible to 'subscriberadmin' on the UI and via the API in read-only mode, same with the sound files that belong to the sound set. If a system sound set expose_to_customer is set back to 0, this sound set is automatically removed from all contract sound sets where it was assigned as a parent as well as from all subscriber 'sound_set' preferences. * contract_sound_set|sound_set preference API updates now have tigher checks for contract_id and also if the system sound set is exposed to the customer and belongs to the same reseller Change-Id: I4908fd15e9c224d4c30794ceb8dae1b444bbf56a	2 years ago
Kirill Solomko	2a0b8dcc1e	MT#56432 add time set support to ncos levels ... * add NCOS Levels UI Time Set support * add NCOS Levels API Time Set support Change-Id: I03201c09462f0f0ceff39da271bcf8ca1fc797b8	2 years ago
Kirill Solomko	dee6b60c6e	MT#56208 additional inherited cfs improvements for subscribers ... * API: GET collection returns only distinct cf sets * UI: inherited cf sets are now shown in the advanced view and having suffix '(inherited)' to distinguish them from the own ones as they are not available in the "Manage Sets" edit dialog. Change-Id: Ifd8c1a46fcb4c2c66f8f63268a1e91b80792c216	2 years ago
Kirill Solomko	36974efa03	MT#55931 add /api/pbxdevices target_number support ... * target_number is now supported and it must contain only [0-9#*]+ Change-Id: I9b1548c2dd0f644c1f21668471599c34347f1109	2 years ago
Marco Capetta	36ae8cedb9	MT#55931 Add new speeddial, forward, transfer device buttons ... Change-Id: I0b9c1f3ddb0d4cd3fe28995b170e9104c668a553	2 years ago
Kirill Solomko	e90ba9d517	MT#56208 allow subscriber role access to cf sets ... * subscriber role can now GET call forward sets that does not belong to the user but used in call forwards assigned to the user * the user can only GET the sets but cannot update/delete them (403 Forbidden is raised in case of attempt) Change-Id: I391b802d962f4bbeae991e3046ac3f132a19edb6	2 years ago
Kirill Solomko	766cab0f9c	MT#56286 fix subscriberprofile api attribute field ... * update_item(): check that $resource->{attributes} contains data and an array before processing it * api-journals.t: fix subscriberprofile 'attributes' field Change-Id: I28a2e22859cd998f99277e88037dff23981038f3	2 years ago
Kirill Solomko	45d9fb34b5	MT#56286 fix subscriber profiles form and api update ... * subscriber profile form is fixed so that the attributes list is now correctly shown in the old UI * /api/subscriberprofiles update, attribute values are now correctly transformed for the validation and processing Change-Id: I4418250d4a0e702d75524ab5999eb47429be5a04	2 years ago
Kirill Solomko	6c179dd5c4	MT#56234 get_usr_preference changes ... * as_admin param is no longer needed as get_usr_preference() fetches actually set preference for a susbcriber and used only by the code (not exposed directly to 'subscriber', 'subscriberadmin' roles * with the aforedescribed, get_usr_preference() no longer filters by expose_to_customer, expose_to_subscriber for 'subscriber' and 'subscriberadmin' roles * refactor get_usr_preferences() to be simple and in line with the other get_*_preferences() as it's mainly responsible for fetching the preference as requested by the internal code Change-Id: Ia52d8f4ebfd854901bf446e29fb475dea1fba866	2 years ago
Kirill Solomko	6d487452bb	MT#56234 susbcriber preferences related changes ... * fix customer_view role name typo so that it's correctly limited to for 'subscriberadmin' role * revert behaviour of get_usr_preference_rs() to return undef if no preference is found (no access) * get_usr_preference_rs() now also fetches all internal preferences for internal work for 'subscriber' and 'subscriberadmin' roles but they remain invisible for them and not accesible for direct changes (only when requested by internal logic) * new get_usr_preference_rs() 'as_admin' parameter that enables for internal requests to return the preference value for 'subscriberadmin' and 'subscriber' roles, currently used to show 'lock' status and 'display_name', which are otherwise inaccessible as those preferences do not have expose_to_customer, expose_to_subscriber flags * fix api_prference_defs() correct filtering of preferences for 'subscriber' and 'subscriberadmin' roles Change-Id: I1a0e51ace1c649f9061deaccb7d6e9f8459f0ed8	2 years ago
Kirill Solomko	34eeac7fc2	MT#56068 fix /api/resellerbrandings reseller_id field ... * reseller_id is now only mandatory for the 'admin' role Change-Id: Idd090332ed2877b2a2c06c9cce741757cc718737	2 years ago
Kirill Solomko	e2afe2ea06	MT#56087 fix /api/callforwards sets auto creation ... * with PUT/PATCH data source and bnumber quick sets are correctly automatically created now Change-Id: Ia6f3be8958081f1611a1473b35c73826a9ed8784	2 years ago
Kirill Solomko	4f8603d15f	MT#56068 /api/resellerbrandings/:id change ... * :id is now the brainding's id instead of reseller_id. That was rather a bug and now fixed and consistent with the rest of the endpoints. Change-Id: I794e577499050a95ed68c21af3f963f9f8e9c274	3 years ago
Kirill Solomko	f942b07a1e	MT#32992 fix /api/resellerbrandnglogos ... * add described query_params 'subscriber_id', 'reseller_id' so they are avaialable on the doc * remove search by param from Role::ResellerBrandingLogos::_item_rs() * fix Role::ResellerBrandingLogos::_item_rs() queries * Controller::API::ResellerBrandingLogos* - now always returns the binary data containing the logo and with the Content-Type header - change NOT_FOUND message to indicate that the ResellerBrandingLogo is either not found or does not have image/image_type * do not log response queries * fix allowed_role to be: admin, reseller, subsscriberadmin Change-Id: Iaadb47fb2d72886a8d9244a523d5914500a4dd20	3 years ago
Kirill Solomko	2904de66b9	MT#56028 /api/cftimesets subscriberadmin role change ... * subscriberadmin is now able to fetch cftimesets of other subsribers that belong to the customer Change-Id: If7931e154ab825a6ebca25bec49b8ea28d87bafd	3 years ago
Kirill Solomko	ae32c62fd1	MT#56027 /api/cfdestinationsets subscriberadmin role change ... * subscriberadmin is now able to fetch cfdestinationsets of other subsribers that belong to the customer Change-Id: I212f0e31a8e77caa6f681f227771e0b11efb5f62	3 years ago
Kirill Solomko	018dc08be6	MT#56026 /api/cfsourcesets subscriberadmin role change ... * subscriberadmin is now able to fetch cfsourcesets of other subsribers that belong to the customer Change-Id: I95217587430c52cd7078e1604ffec549ae2dd6b5	3 years ago
Kirill Solomko	4c1a9d9c11	MT#56029 /api/cfbnumbersets subscriberadmin role change ... * subscriberadmin is now able to fetch cfbnumbersets of other subsribers that belong to the customer Change-Id: Ib92c161f320257ba2d6614e10d9eaf03247e7014	3 years ago