5407 Commits (205b27a2676efa51df1ee51a6731c7fe9942422a)

 

All Branches   

Search

Author	SHA1	Message	Date
Kirill Solomko	205b27a267	MT#59478 API better transaction and error handling ... * Role/Entities*: POST/PUT/PATCH/DELETE methods changes: - support deadlock detection and transaction retry (2 retry attempts at the moment) - improve transaction control, use local $guard instead of saving the ref to $c->stash, as in that case it went out of scope too late and also reported an error message into the log about abnormal $guard out of scope interruption - move all non transaction related code outside of the scope - add error handling when methods such as update_item, and a like do not return the expected data, instead of simply going out of scope and resulting in an uncontrolled reply * Role/API: - rework transaction control: + get_transaction_control() is renamed to start_transaction() to better reflect what it does + complete_transaction() is renamed to commit_transaction() + remove unused %params arg + pass $guard into commit_transaction() instead of having it stored as $c->stash->{transaction_guard) that caused the $guard ref to be destroyed much late than expected (there was also a typo as transaction_quard, which is not relevant anymore with the changes + add check_deadlock() that is invoked when an exception is caught or an $c->errors contain an error, and if the error message represents a transaction error, the transaction block is re-invoked via "goto TX_START" - rework error(): + it now accepts args as following: ($self, $c, $code, $message, @errors) # code -> returned as HTTP code in the reply # message -> returned as HTTP message in the reply # errors -> contain errors for internal logging, last element often contains a DBIx exception + populates all @errors into $c->error so they are available on demend in the code via $c->error or $c->last_error + $c->log->error is not invoked now as the errors become printed in log_response() - log_response() now prints collected errors from $c->error correctly as a separate log line, that is alike to the other api logs so that those can be looked up by the request's tx_id, also all errors are now printed only into api.log * Adjust all $self->error() calls in catch($e) to include $e as the last argument, as well as the duplicate $c->log->error is removed from those ocassions * Remove all $c->log->error() calls as they are replaced with either $self->error() (that logs it correctly into api.log) or $c->error('err') that also adds it correctly into api.log * API::CallForwards: rework to use Entities/EntitiesItem * API::Contracts: rework POST to use Entities * API::PeeringGroups: rework POST to use Entities * API::SubscriberRegistrations: rework POST to use Entities * API::RewriteRuleSets: improve create_item() functionality * Utils/Message: add 'api_retry' log type * $c->session->{api_request_tx_id} is changed to $c->stash->{api_request_tx_id} because sometimes the session ref is different and a different tx_id becomes used Change-Id: I633ce7a8047b1bf00a2f6889003088edf0825dcd	2 years ago
Nico Schedel	1fdaa6bd47	MT#55677 fix all ngcp-panel-selenium tests ... Change-Id: I7f1f1e5fe9632dad233818b3a43b78a54ff97b98	2 years ago
Nico Schedel	b22d2d824c	MT#59624 update firefox in docker to fix segfaults ... Change-Id: I48690f8f2eddf7dc00df0f62437956d6d8f7c38e	2 years ago
Sipwise Jenkins Builder	e7b131247e	Release new version 12.4.0.0+0~mr12.4.0.0	2 years ago
Kirill Solomko	aef4c89197	MT#59662 enhance subscriber assigned header rules/sets handling ... * POST /api/headerrules now supports either 'set_id' or 'subscriber_id'. When 'subsriber_id' is specified, a subscriber assigned header rule set is automatically created if it does not exist, as well as automatically removed when its last header rule is deleted. * It is now possible to directly GET and DELETE /api/headerrules/:id where :id is a subscriber assigned header rule. * It is now possible to directly GET and DELETE /api/headerrulesets/:id where :id is a subscriber assigned header rule set. * Improve /api/headerrules data validation and duplicate header rule detection. * It is now possible to expand by /api/headerrules/?expand=set_id field Change-Id: I681bc61c2eed47a8e54847f07f31134f643930c2	2 years ago
Kirill Solomko	1fb8d04136	MT#59615 /api/subscribers skip primary number processing if unchanged ... * if the primary numner during /api/subscribers update request is unchanged, the primary number processing related logic is not invoked, as otherwise it's a redundant and in some cases (pilot subscriber) time consuming operation. Change-Id: I4cbb0387011f5241fcbdaab1efbb0d4a5caa2143	2 years ago
Rene Krenn	868e2657b6	MT#59597 fix remove trailing+leading % entirely for "wildcard" params ... Change-Id: I371e2d41ff27b2801ead391778d9a2bdef914563	2 years ago
Michael Prokop	3ccdaaa20f	MT#59492 Use reserved IPs following RFC5737 ... Usage of IP addresses like 1.2.3.4 is not recommended, as they might point to actually used and non-reserved IPs. Quoting from RFC 5737 AKA "IPv4 Address Blocks Reserved for Documentation" (see https://datatracker.ietf.org/doc/html/rfc5737): | The blocks 192.0.2.0/24 (TEST-NET-1), 198.51.100.0/24 (TEST-NET-2), and | 203.0.113.0/24 (TEST-NET-3) are provided for use in documentation. So use 203.0.113.0/24 instead. Change-Id: I4b85120e1409af306c52693211bd86ea01ec19df	2 years ago
Rene Krenn	9ba93e69a5	MT#59597 remove trailing+leading % entirely for "wildcard" param types ... this code is not run by legacy panel, so the check for "/api" request can be removed. Change-Id: I29410fbbf046a8f00443138720b940de0f09f416	2 years ago
Rene Krenn	aa6760228e	MT#59363 retain trailing+leading wildcard for legacy panel only ... all api query param filters that were harmonized to "wildcard" also appended leading+trailing wildcard (this was from the original idea to make adminUI and legacy panel search behave the same). Change-Id: I017473b84f2844d14a11b4ec8b437df5335c24d0	2 years ago
Rene Krenn	48b71e68c5	MT#59363 fix /api/domains/?domain= filter pattern behaviour ... this filter is another spot, where leading/trailing wildcards were added unintentionally, during harmonization. Change-Id: Id23114f8e7ebca018ad222e35b39d8260f1da92f	2 years ago
Sipwise Jenkins Builder	56c0d86d19	TT#4166 I18N dump: snapshot 2024.03.01-23.20.50 ... Change-Id: Ibe09b01a1ae6887aa3867b81d55871c3a20a1a64	2 years ago
Kirill Solomko	7aeaf0f16d	MT#59363 /api/subscriberregistrations change socket field to Text ... * socket field is changed to text for the API endpoint as by default in the LocationEntry form that is used by the UI the field is a prebuilt options list that comes from config.yml extra_sockets, and that severely limits the usage for the API. Change-Id: I71ee1f77dbf458c12655f840282375cee62b7534	2 years ago
Kirill Solomko	0202996756	MT#59537 create_invoice() add existing balance check ... * if no balance is found for the provided period a 422 error is returned: showdetails => $c->loc('period start=[_1] end=[_2].', $stime, $etime), error => 'Could not find active balance.', httpcode => HTTP_UNPROCESSABLE_ENTITY, instead of a 500 server because of access to undefined $balance value Change-Id: Icccb9f253d117327641b6803ac0d2cdb09cf030f	2 years ago
Rene Krenn	740bb764e5	MT#59434 always take aliases from voip_numbers ... in case the DB shows discrepancy because of missing primary provisioning.voip_dbaliases records, align with legacy panel behaviour and also take the restapi aliases list from voip_numbers, instead of voip_dbaliases. .. while trying to keep the performance gain from https://gerrit.mgm.sipwise.com/c/ngcp-panel/+/65086. Change-Id: Ibd7f8c8bc6a39ae2c31b4e8818080674ab77d66c	2 years ago
Kirill Solomko	80f8b1da0b	MT#59238 fix rewrite rules transaction control for PATCH,DELETE ... * /api/rewriterules PATCH, DELETE methods used the generic transaction, which conflicted with the xmlrpc reload command. * own_transaction_control was only set for PUT and now also extended to PATCH, DELETE to ensure that dialplan_sip_reload() is called properly after $guard->commit. Change-Id: I7313b4f6d1f6699bf38ae34749c5383a3943f61d	2 years ago
Rene Krenn	c837dc1043	MT#56817 MT#56362 fix query param sorting for regulary chained rs ... Change-Id: I82d3a0ce67ffb61273fc716016885f6431852eff	2 years ago
Rene Krenn	aae0b7e071	MT#56817 MT#56362 fix query param sorting for rs chained the regular way ... Change-Id: I0dab56ae07666eb695d7f30ef633a876ff8258fb	2 years ago
Rene Krenn	672a3110bc	MT#59216 restore appending wildcard behaviour ... with the change to harmonize wildcard symbols % and * to * in query param filters across all restapi rails, only - /api/subscribers?alias= - /api/subscribers?pbx_extension= - /api/subscribers?primary_number= - /api/pbxdevices?pbx_extension= are supposed to include implicit leading an trailing wildcards. panel UI uses trailing wildcard by default everywhere, and so should the databales of the new Admin UI. external_id were used to support patterns, but must not include a trailing wildcard in rest API, as this can break logic that rely on unique api request results. we now therefore no longer append wildcards in particular to: - /api/voicemails?folder= - /api/voicemailgreetings?type= - /api/subscribers?subscriber_external_id= - /api/subscribers?customer_external_id= - /api/subscribers?display_name= - /api/subscribers?domain= - /api/profilepackages?profile_name= - /api/profilepackages?network_name= - /api/pbxdevices?display_name= - /api/faxserversettings?name_or_password= Change-Id: I40ef1912d7224a56c6d14619d258c70e447ab23d	2 years ago
Rene Krenn	a15d00894a	MT#56817 MT#56362 fix errors from nondetermistic query param ordering ... the /api/callists rail supports the "call_id" query parameter to match calls with a callid prefix. this filter also adds an implicity ordering ORDER BY length(call_id) ASC, 'start_time' ASC. the /api/callists api rail also requires the query parameter "susbcriber_id", which renders a (fast) compound SQL query to list matching incoming (query1) and outgoing calls (query2) using UNION ALL (instead of a slow OR query). query1 UNION ALL query2 this is supported by the https://metacpan.org/pod/DBIx::Class::Helper::ResultSet::SetOperations module, which however generates invalid SQL syntax if query1 or query2 contains an ORDER BY. this is exactly what caused the 500 error of the customer who applied both "call_id" and "susbcriber_id" parameter in the request at the same time. ... ORDER BY length(call_id) ASC, `start_time` ASC UNION ALL SELECT `me`.`id`... the error happens randomly, because query parameters are stored in a hash (which by definition has no deterministic order of the entries). when the "call_id" parameter is applied at last, it worked as expected. so the issue can be adressed by strictly ordering the UNION ALL result, and prohibit ORDER BY in query1 and query1. the latter was added already with commit b2dfe28eed, and could be hotfixed. however, the ORDER BY of "call_id" query param is lost, and should be properly handled by forcing strict ordering of how query parameters are applied. the fix will introduce paramater ordering according to their order of definition in the code. Change-Id: I165d341b5c20e9bb750bd1fba88c836b393e80bd	2 years ago
Kirill Solomko	a4d54b10e4	MT#58709 rework NGCP::Utils::Sound::get_handlers_rs ... * get_handlers_rs() is renamed into get_file_handles() and reworked from an indented 'from' resultset into 2 separate resultsets, one fetching all the handles and another one files for the sound set, it is now returned as an array with the similar data. Reason for this rework is the deprecated use of 'from', that resulted in a lot of warnings in panel-fcgi.log: DBIx::Class::SQLMaker::ClassicExtensions::_join_condition(): ResultSet {from} structures with conditions not conforming to the SQL::Abstract::Classic syntax are deprecated: you either need to stop abusing {from} altogether, or express the condition properly using the { -ident => ... } * adjust file_handles data key names to better follow the naming conventions and readability, e.g.: groupname -> group_name, fileid -> file_id Change-Id: Ia91c9104c0b4dc79ee5bc359eb0b6e035e56ef3e	2 years ago
Guillem Jover	a87bf2b6c3	MT#59163 Stop using deprecated given/when perl construct ... This experimental perl construct has been marked as deprecated in perl 5.38 and targeted for removal in a later release. Switch its usage to a normal cascaded if/elsif and avoid future surprises. Change-Id: I268f6e17482bfa356fed8d1e003b317d24324f2f	2 years ago
Sipwise Jenkins Builder	909523b9cb	Release new version 12.3.0.0+0~mr12.3.0.0	2 years ago
Kirill Solomko	b6b453d69d	MT#59001 improve phonebook csv upload ... * the expected csv fields are as following: - /api/resellerphonebookentries/?reseller_id=1 name,number - /api/customerphonebookentries/?customer_id=1 name,number - /api/subscriberphonebookentries/?subscriber_id=1 name,number,shared - /api/resellerphonebookentries/ name,number,reseller_id - /api/customerphonebookentries/ name,number,contract_id - /api/customerphonebookentries/ name,number,shared,subcriber_id (note: the fields are taken from the leftmost side as the minimum required fields, so if one provides as: - /api/resellerphonebookentries/?reseller_id=1 name,number,reseller_id this line will be uploaded and columns after 'number' are ignored in this case. this is for convenience if you have a prepared upload for different customers/resellers for instance, you can upload it under one customer/reseller when needed * user access scope is now validated, e.g.: resellers cannot upload phonebook entries to another resellers, etc. * fix csv upload for /api/customerphonebookentries/?customer_id=1 Change-Id: I970ac36fdb8b366adff15515a48d296e8abeff13	2 years ago
Rene Krenn	1e9f223276	MT#59025 fix peering groups name filter ... Change-Id: I329e644c937058069c5932abf8e897dce48a8c10	2 years ago
Kirill Solomko	1dabb6051d	MT#58989 /api/customers add type query param ... * add 'type' query param to filter by customer type 'sipaccount' or 'pbxaccount' Change-Id: If372cc69cf16c92551824504da7695a65dc867b3	2 years ago
Rene Krenn	cc8fd8928d	MT#58890 force cft_ringtimeout as number ... Change-Id: I4df4fbf6522d28a30731c87a36c95ae8350830fa	2 years ago
Rene Krenn	2101e2246d	MT#58936 fix customerzonecosts resourcename ... Change-Id: I22b052bc6931e5426e1aa982396c446cb1c67883	2 years ago
Rene Krenn	73a967bfb6	MT#58762 adjust restpi tests v2 to harmonized wildcard filters #1 ... Change-Id: Icdf581f425f5e28ba22480424f04355181b4f3b3	2 years ago
Rene Krenn	bad2e32802	MT#58762 adjust restpi tests v2 to harmonized wildcard filters ... Change-Id: Ie100612c9f284e9acad6b305345751bb07adfab9	2 years ago
Rene Krenn	853bc9f535	MT#58936 direction filter param for /api/customerzonecosts ... Change-Id: Ie831381576ffdb2a08375cf73bc66c1c5e6d2076	2 years ago
Kirill Solomko	462bfedc43	MT#58861 /api/headerruleconditions accept values as a list of strings ... * {"values:", ["value1", "value2"]} is not accepted by /api/headerruleconditions * the previous behaviour of {"values": [{"value": "value1"},{"value": "value2"}]} is preserved Change-Id: I7d9540d20ed0ecbb2712f1905a7d9e6f7af7e06d	2 years ago
Kirill Solomko	8985839509	MT#58834 fix headerrule conditions/actions dp_id check ... * address a 500 error when rwr_set_id is specified but empty and dp_id is also specified Change-Id: I0160a3c2f6b3cf139935c4e2daf7e1635dafb99a	2 years ago
Kirill Solomko	f399f3cb4d	MT#58826 enable expand by rwr_set_id ... * add global expand by rwr_set_id field * adjust rwr_set_id, rule_id in Condition and Action forms to have correct type (as they were inherited as Hidden) Change-Id: Id2529c67919b496303cee24da2a2c63f22df23e9	2 years ago
Marco Capetta	1474584b60	MT#58762 Fix typo in swagger documentation ... Fix typo of commit 308a974059 that was causing to fail the generation of the the swagger documentation with the message: ngcp-panel: ERROR: Couldn't render template "api/root.tt: file error - parse error - api/root/collection.tt line 112: unexpected token (=)#012 [% IF f.query_type = 'wildcard' %]" Change-Id: I35882b97b2a86a7f54829f017ab1cb19b3b9f6e5	2 years ago
Sipwise Jenkins Builder	ee3ba7bb2b	Release new version 12.2.0.0+0~mr12.2.0.0	2 years ago
Kirill Solomko	08fb96c5a6	MT#58813 adjust header rule conditions/actions filters ... * remove filter by subscriber_id as it's not possible there * add filters by rule_id, set_id Change-Id: I6dac0a24dad56564dbe2ed648f4507888e0a5c94	2 years ago
Rene Krenn	aa2d07ef29	MT#58762 adjust restpi tests to harmonized wildcard filters ... Change-Id: I68b2199a3487fedb388803012c950c3abca1a8b3	2 years ago
Sipwise Jenkins Builder	ec9b58a5a9	TT#4166 I18N dump: snapshot 2023.11.16-23.20.45 ... Change-Id: Ic5bfe2ea09b93e36906fc991311817b1b7841ec4	2 years ago
Rene Krenn	bbb964f422	MT#58765 expand zones in billing fees response ... Change-Id: I91b4ccdcc2146581e56310ef1c7af0ebb1f656d9	2 years ago
Rene Krenn	308a974059	MT#58762 harmonize restapi wildcard filters ... - all standard LIKE search are migrated - will avoid LIKE unless a pattern (* wildcard) is used as a search term. this encourage db index usage, will be faster - supports wildcard escape sequence \\* - harmonize swagger UI descriptions of filters Change-Id: Iea155871c9be6c284e6970a562d4e6af73fedc4b	2 years ago
Sipwise Jenkins Builder	0430303145	TT#4166 I18N dump: snapshot 2023.11.15-23.20.49 ... Change-Id: I4311a7bec88c4a5f5afd9e5512686ffb8c54c2e9	2 years ago
Rene Krenn	71480acfa3	MT#56239 avoid ambersand symbol in apidoc descriptions ... Change-Id: Ic024d16c008648cb4d9cf14ae0e58d1ebe8febe9	2 years ago
Rene Krenn	8e82715eb8	MT#56239 api/callrecordings support filtering multiple metakeys ... filtering an Entity-Attribute-Value model cannot be done as simple conjunctions, but requires either INTERSECT set operation, or joining the same table multiple times. Change-Id: I5ce1ae1ece9406b6610487654f09d768a233b122	2 years ago
Kirill Solomko	1231cae638	MT#58746 /api/phonebookentries fix duplicate check ... * all reseller_id-number entries are checked for POST * reseller_id-number pairs that != item->id are checked for PUT/PATCH Change-Id: I93a8b7fe22ed63d2d84e2d45291981d09b4af156	2 years ago
Rene Krenn	7370f0e967	MT#58675 add /api/billingfees missing fields ... Change-Id: I661e3bcebe07bbc92ba6e4c8eda05f5aefeaa5df	2 years ago
Rene Krenn	9c3a549094	MT#56239 api general caller/callee wildcard search support ... various api rails will need to support ?caller= and ?callee= url query parameters. since this involves SQL queries against potentially large database tables, special care is taken with wildcard search to prevent slow queries: - the ?wildcards=true query parameter has to be specified to accept search patterns that contain wildcard symbols, so wildcards are not accepted by default. WARNING: a search string with a leading wildcard will always force a *slow* full db table scan! - the * symbol is used as a wildcard symbol - \ (backslash) is used as escape character to search for a literal '*' Change-Id: Ie6065b0cfa883f7963e1dc8259fffea9a1edfdfe	2 years ago
Rene Krenn	5eff0601b5	MT#58346 fix conversations voicemail timestamp filter ... Change-Id: I86fc4db7d5efddf73f6c0b068b1c9e79913fddaf	2 years ago
Rene Krenn	d546387651	MT#58346 fix panel datatable filtering ... Change-Id: I4ce2e07a3ffa0715e385d811737f850aacaa5d90	2 years ago
Rene Krenn	ae612eb401	MT#58346 caller/callee filters for conversations ... the conversation list now supports ?caller= and ?callee= url query parameters. since this involves SQL queries against potentially large database tables, special care is taken with wildcard search to prevent slow queries: - the ?wildcard=true query parameter has to be specified to accept search patterns that contain wildcard symbols, so wilddcards are not accepted by default. WARNING: a search string with a leading wildcard will always force a *slow* full db table scan! - the * symbol is used as a wildcard symbol - \ (backslash) is used as escape character to search for a literal '*' Change-Id: I792d2ea9c649c69c4b5cc98076097cb96467d4bc	2 years ago