40 Commits (b0b646db5b91d42c9f043340b1b41614cd4edac9)

Author	SHA1	Message	Date
Kirill Solomko	6543743992	MT#60162 improve expand functionality for collections ... * in general expand collection now performs only 1 sql query to per expand field to fetch all items by the ids instead of fetching them for every single collection item, that should significantly increase performance in case of large databases and reduce work for the database * introduce $c->stash->{expand_cache} that contains cached data for the expand fields to avoid multiple same calculations * expand_field() and expand_field_data() have been reworked to support expand_cache * new method expand_prepare_collection() is called for all API GET collection methods before preparing resource hal fields, to change the expand logic to only cache the data instead of fetching it from the database * new method expand_collection_fields() that is called in all API GET collection methods after the @embedded data is prepared to finalise the expand collection fields * for expand collection there is only 1 SQL request per expand field that fetches all items -in [ids to expand] and then the expand_collection_fields() uses the cached items_by_ids with O(1) fetch from the cache by id Change-Id: Ie7c6115472878febf0d8c9b4d833f5c23b15c78b	11 months ago
Kirill Solomko	205b27a267	MT#59478 API better transaction and error handling ... * Role/Entities*: POST/PUT/PATCH/DELETE methods changes: - support deadlock detection and transaction retry (2 retry attempts at the moment) - improve transaction control, use local $guard instead of saving the ref to $c->stash, as in that case it went out of scope too late and also reported an error message into the log about abnormal $guard out of scope interruption - move all non transaction related code outside of the scope - add error handling when methods such as update_item, and a like do not return the expected data, instead of simply going out of scope and resulting in an uncontrolled reply * Role/API: - rework transaction control: + get_transaction_control() is renamed to start_transaction() to better reflect what it does + complete_transaction() is renamed to commit_transaction() + remove unused %params arg + pass $guard into commit_transaction() instead of having it stored as $c->stash->{transaction_guard) that caused the $guard ref to be destroyed much late than expected (there was also a typo as transaction_quard, which is not relevant anymore with the changes + add check_deadlock() that is invoked when an exception is caught or an $c->errors contain an error, and if the error message represents a transaction error, the transaction block is re-invoked via "goto TX_START" - rework error(): + it now accepts args as following: ($self, $c, $code, $message, @errors) # code -> returned as HTTP code in the reply # message -> returned as HTTP message in the reply # errors -> contain errors for internal logging, last element often contains a DBIx exception + populates all @errors into $c->error so they are available on demend in the code via $c->error or $c->last_error + $c->log->error is not invoked now as the errors become printed in log_response() - log_response() now prints collected errors from $c->error correctly as a separate log line, that is alike to the other api logs so that those can be looked up by the request's tx_id, also all errors are now printed only into api.log * Adjust all $self->error() calls in catch($e) to include $e as the last argument, as well as the duplicate $c->log->error is removed from those ocassions * Remove all $c->log->error() calls as they are replaced with either $self->error() (that logs it correctly into api.log) or $c->error('err') that also adds it correctly into api.log * API::CallForwards: rework to use Entities/EntitiesItem * API::Contracts: rework POST to use Entities * API::PeeringGroups: rework POST to use Entities * API::SubscriberRegistrations: rework POST to use Entities * API::RewriteRuleSets: improve create_item() functionality * Utils/Message: add 'api_retry' log type * $c->session->{api_request_tx_id} is changed to $c->stash->{api_request_tx_id} because sometimes the session ref is different and a different tx_id becomes used Change-Id: I633ce7a8047b1bf00a2f6889003088edf0825dcd	1 year ago
Flaviu Mates	f4cb6933b4	TT#119550 Allow subscribers to manage their registrations ... * give access to subscribers roles to see, create and update own registrations * subscriberadmins can manage all registrations of subscribers under same customer Change-Id: I643121da901b0ed99fc718106a1632da4e1e1936	4 years ago
Flaviu Mates	2741e9ec79	TT#98650 Fix /api/subscriberregistration gateway timeout ... *Introduce pagination in redis scanning; previously all the registrations where dumped in an array and then spliced by page/rows; this was causing huge loading time for big redis DB's hence the timeout Change-Id: I1409c48b520d8d860cd8c11aea1a543286aa0334	5 years ago
Rene Krenn	186ddabb17	TT#98650 ?suppress_flush=1 parameter ... suppress executing "ul.flush" kamailio xmlrpc after "ul.add" or "ul.rm", as it seems to be another source of timeouts. Change-Id: I8faf907c4cbfd6adbe3e3645f5c32069df2eb999	5 years ago
Kirill Solomko	ce664263b2	TT#65101 add ccareadmin ccare roles ... * ccareadmin and ccare roles have full access to Customers, Subscribers and their preferences/settings, and read-only access to BillingProfiles,InvoceTemplates, EmailTemplates * ccare role is restricted to the related reseller Change-Id: I6cf7d3adf912f0fa98d1ef5c02abea2f4331ec4b	6 years ago
Irina Peshinskaya	39bc7eb75d	TT#48198 Fix order_by functionality in api ... - All item_rs modifications should be done before we get rows, so apply order_by before pager - We can't distinguish if subscriberregistrations really has column or not if we return true for all columns. We will use has_column only in cases when it returns something really meaningful. - Subscriberregistrations can't order by nat and subscriber_id Change-Id: I04b7bb719ee058590a7705c6411cb08bcfb15387	6 years ago
Irina Peshinskaya	667522fafc	TT#47268 Use order_by_cols to avoid item_rs call for api doc gen ... Change-Id: Ia2fccedeaa4ee513fb4ef9d77c4ea724f49820f7	6 years ago
Irina Peshinskaya	1fe6db943d	TT#48198 Use items array from paginations in all api controllers ... Change-Id: I1856cd4f073d32b4465d0778baf5f9f7c708f78c	6 years ago
Kirill Solomko	f976fe03fb	TT#35714 use collection_nav_links in all API controllers ... * colelction_nav_links() should be used instead of the old self/prev/next href link code * Entities.pm fix colletion_nav_links() to pass missing $c->request->params * collection_nav_links() use default $c->request->path and $c->request->params if those arguments are not specified Change-Id: Icca5afac812f2e06e6927ba6f4e91057f9745d21	7 years ago
Kirill Solomko	ad04649ece	TT#26652 addditional subscriberregistrations error checks ... * return HTTP_UNPROCESSABLE_ENTRY if form data is not valid or a susbcriber is not found * POST: do not commit transaction if update_item fails Change-Id: I7149922d4e4d701213ce351112cc67e611c3d910	7 years ago
Andreas Granig	5e76543664	TT#32972 Fix non-numeric item id for subscriberreg ... If fetched from Redis, it's going to be the ruid instead of a MySQL auto-increment id. Change-Id: Ie3e04e7a1a4c249b6a38e04d622a78f48136a15d	7 years ago
Andreas Granig	3a1d30bee6	TT#32972 Fetch location data from redis ... Change-Id: Id4edc72e2e7748ff6e9adb4c3370720232065ab6	7 years ago
Irina Peshinskaya	2b8ae95170	TT#28460 Remove unused libraries ... require Catalyst::ActionRole::ACL; require Catalyst::ActionRole::CheckTrailingSlash; require NGCP::Panel::Role::HTTPMethods; require Catalyst::ActionRole::RequireSSL; Change-Id: I3880fcb10067810d5e2de10a0c14bf6b15e34710	7 years ago
Irina Peshinskaya	0d4d8cdb23	TT#28460 Format: Remove excrescent empty lines ... Change-Id: I5ff73d92bf62451fb6dbdae85ca07428c3f5af5d	7 years ago
Irina Peshinskaya	75d6edbcd9	TT#28460 Format: add line between subs in API controllers ... Change-Id: I67f11fef716941dc965dffd4e8fbb1a211791bbf	7 years ago
Irina Peshinskaya	9fa2a19b4f	TT#28460 Replace configs - not journalized ... Change-Id: I9843a780817922f23faa91041d3fab9b7336b2a3	7 years ago
Irina Peshinskaya	92e6215b71	TT#28460 Remove gather_default_action_roles ... Change-Id: Ie8080a9ac3b5b1004de456fe0ece7b31ed1541fe	7 years ago
Irina Peshinskaya	2498c8810e	TT#28460 Remove copy-pasted sub HEAD and sub end ... Change-Id: Ia06320ead891945eebe715fa34012a14d5529f17	7 years ago
Irina Peshinskaya	05774c2338	TT#28460 Remove copy-pasted sub OPTIONS ... Change-Id: I2b00ea267edcc3caa00eaac5753638794a13398c	7 years ago
Irina Peshinskaya	a113cbf1d0	TT#28460 Remove copy-pasted sub auto ... Without config changes - all custom subs are in place Change-Id: I23e50e7d1fcb02c245bc995a26e16e97308177c8	7 years ago
Irina Peshinskaya	b14f34f008	TT#28460 Change parents in API controllers ... Use Entities and EntitiesItem respectively Change-Id: I5d32b010cc51810acee42d14c5c24ce3d4267602	7 years ago
Gerhard Jungwirth	24de4232e6	TT#30507 remove DataHal workaround layer ... (NGCP::Panel was loaded every time this was used) Change-Id: I62861e0756aaaf548c9be42b4842e9a06127119c	7 years ago
Kirill Solomko	53532fd5e8	TT#30500 Fix /api/subscriberregistrations POST method ... * POST method is adapted to the new behaviour of update_item() and fetch_item() Change-Id: I35cc5d4e8c97cd415e9d6d31a6811d1f8cce84a9	7 years ago
Andreas Granig	0d3bf6b1ce	TT#22827 Implement form factory ... This patch reuses existing forms by clearing them, rather than re-instantiating them again and again. Also, panel start time should be better due to less package pre-loading. Change-Id: Ia3e64fd4b4084bb5ec35a669c5840c9fc3c58f2e	8 years ago
Rene Krenn	72d9c10650	TT#13973 fix http method override ... the factory Catalyst::ActionRole::HTTPMethods action role is set for any action, and in race with our own NGCP::Panel::Role::HTTPMethods. the testcase could have been misleading ever since, as it uses DELETE /api/customers, which was present when implemting the method override initially, but dropped on the road to 4.5. the issue is resolved by overriding Catalyst::Controller::gather_default_action_roles. until the class hierachy refactoring is completed, only consistent way is to add the override to each api controller. the action_roles config attribute can therefore be removed. using Plack::Middleware::MethodOverride as an alternative from upstream has the drawback to work only with POST. but a required usecase is to also support translation DELETE requests to PATCH. Change-Id: I204ba59869a8327bdd5db8a867fbbb061d1c9e7c	8 years ago
Irina Peshinskaya	2073b9e760	TT#9309 Introduce local version of the Data::HAL::Link ... Change-Id: Ifdf95cef32f0d118330c20316ed447e00c6dae3c	8 years ago
Irina Peshinskaya	41f32401a7	TT#9309 Introduce local version of the Data::HAL with default forcearray ... Change-Id: Ie33396a75fc6d27fd28fe8f7717caba0a476c776	8 years ago
Gerhard Jungwirth	b34a7df2e1	MT#21193 use Sipwise::Base in api modules ... which implies, among others, strict and warnings. these should never be omitted and are one of the most frequent complaints of perlcritic currently. as a result TryCatch can be removed (imported by Sipwise::Base). also, "no Moose" is removed (has no effect). Change-Id: I901b6a9f0f6d426f62b73e68f2c5ad6365c1eeef	9 years ago
Rene Krenn	3e57109750	MT#19419 custom action role to support http method override ... Change-Id: I2d9fbf1f4feca76b91bdf73d4184ea707cc04e78	9 years ago
Guillem Jover	0632585eba	MT#18443 Use parent instead of base module ... Switch from the discouraged base module to the light-weight parent module. Also remove some surrounding BEGIN blocks from 'use parent' which are completely unnecessary. Change-Id: I3a669e8024f098819be45030ca9d1afa8756105c	9 years ago
Irina Peshinskaya	0272c297b8	MT#17173 Remove Moose Roles from API ... Conflicts: lib/NGCP/Panel/Controller/API/MetaConfigDefs.pm lib/NGCP/Panel/Controller/API/Root.pm Change-Id: I25597baebbec6e2436b15776da17bd6d1bfef838	9 years ago
Andreas Granig	04a64e1493	MT#16465 partly remove namespace::sweep and others ... Remove namespace::sweep Remove MooseX stuff Remove perl5i Remove Moose where possible Change-Id: I4f873afb466f4e58a04c3304ff74df2185470b03	10 years ago
Irina Peshinskaya	dd9365f0e8	MT#14739 Get newly created kamailio user location after flush ... MT#14779 Add default value for the q parameter MT#14891 Consider form validation for the POST request (create location) MT#14789 Remove user_agent registration parameter Change-Id: I9f81ec3ec5c308c731b3dfe6aa5f075c7d7b50ab	10 years ago
Irina Peshinskaya	0c26c90685	MT#10041 Query_params raised multidomain request in not multidomain env. ... Let's query_params to know config	11 years ago
Andreas Granig	1306ba53c6	MT#8561 API: filter write ops for r/o users	11 years ago
Gerhard Jungwirth	1b0f0ead8f	MT#7119 remove redundant collection sort	11 years ago
Gerhard Jungwirth	83d37c5d23	MT#7119 API order_by for collections ... most collections support ordering by the column names of their primary table now	11 years ago
Andreas Granig	1cc0aa69f4	MT#7039 API: link subscriberregistrations ... - Properly join voip_subscribers and voip_domains - Link relations to subscriber	11 years ago
Andreas Granig	7df32a993b	MT#7039 API: implement SIP registration handling	11 years ago