5417 Commits (6aa1663baab2026edc6bed15ae3257c4a9b39949)

 

All Branches   

Search

Author	SHA1	Message	Date
Mykola Malkov	6aa1663baa	MT#58444 Set correct permissions/ownership for ssl files ... Key and csr files should be 640. All other files 644. Ownership for all files should be root:ssl-cert. Change-Id: Ie4c0c8070d856d881b9d47aa65f953869537ee1e (cherry picked from commit a8476ad20d) (cherry picked from commit 83d2eca316)	1 year ago
Sipwise Jenkins Builder	b7afde6509	Release new version 11.5.1.30+0~mr11.5.1.30	1 year ago
Rene Krenn	b2589bf8a5	MT#59597 fix remove trailing+leading % entirely for "wildcard" params ... Change-Id: I371e2d41ff27b2801ead391778d9a2bdef914563 (cherry picked from commit 868e2657b6) (cherry picked from commit 16e4b06c75)	1 year ago
Rene Krenn	5f4bce9652	MT#59597 remove trailing+leading % entirely for "wildcard" param types ... this code is not run by legacy panel, so the check for "/api" request can be removed. Change-Id: I29410fbbf046a8f00443138720b940de0f09f416 (cherry picked from commit 9ba93e69a5) (cherry picked from commit fb22a340b9)	1 year ago
Rene Krenn	2301a409d9	MT#59363 retain trailing+leading wildcard for legacy panel only ... all api query param filters that were harmonized to "wildcard" also appended leading+trailing wildcard (this was from the original idea to make adminUI and legacy panel search behave the same). Change-Id: I017473b84f2844d14a11b4ec8b437df5335c24d0 (cherry picked from commit aa6760228e) (cherry picked from commit 92d3106484)	1 year ago
Rene Krenn	9eaf851f7e	MT#59363 fix /api/domains/?domain= filter pattern behaviour ... this filter is another spot, where leading/trailing wildcards were added unintentionally, during harmonization. Change-Id: Id23114f8e7ebca018ad222e35b39d8260f1da92f (cherry picked from commit 48b71e68c5) (cherry picked from commit 8dfc9b1eb3)	1 year ago
Sipwise Jenkins Builder	8b4943f22a	Release new version 11.5.1.29+0~mr11.5.1.29	1 year ago
Marco Capetta	4f8accb38b	MT#60864 Fix Sync Email Templates button behavior ... The 'Sync Email Templates' button is shown in the Email Templates page in case some templates is missing for a reseller. The problem is that the button takes into consideration also resellers that are already terminated and for which the template is not needed anymore. Thus the query has been in fixed in order adding: r.status != 'terminated' Change-Id: I2dd551166ae777c8967eae3bda989b669b46b5c0 (cherry picked from commit 97adbaf8e7) (cherry picked from commit 4006915bdb)	1 year ago
Kirill Solomko	eb35287a56	MT#60553 handle API subscriber timezone field separately ... * timezone field for SubscriberSubAdminAPI form is now Text instead of +NGCP::Panel::Field::TimezoneSelect because the template => 'helpers/datatables_field.tt' produces a field validation error, as well as the Field is designed for UI and not API. * add validate_timezone() field validation to SubscriberAPI and SubscriberSubAdminAPI forms. Change-Id: I6391694284477976d8d6cee71a81e2241bd94937 (cherry picked from commit e83588874b) (cherry picked from commit 8eba05ed0e)	1 year ago
Sipwise Jenkins Builder	0a0a9f6005	Release new version 11.5.1.28+0~mr11.5.1.28	1 year ago
Marco Capetta	d7c4c585af	MT#61065 Fix 'cli' preference removal ... In commit b51c0c9698 the possibility to change the 'cli' preference by subscriber and subscriber_admin was added (under certain limits). On the other hand, the additiona of that part of code broke the possibility to remove the preference using the PATCH api. It is a very uncommon scenario though, but it seems anyway used by some customer. We may think to deprecate this possibility one day, but till then we don't have to create regression to customer. Change-Id: Ie695b567929eb79b1ba63d3c5a31ae5ce7b559bd (cherry picked from commit f9a328f83d) (cherry picked from commit 59f56f4e6a)	1 year ago
Sipwise Jenkins Builder	c80eeea559	Release new version 11.5.1.27+0~mr11.5.1.27	1 year ago
Marco Capetta	1569e45da8	MT#60756 Fix subscriberprofiles POST api call as reseller ... Administrators with reseller role were not able to create new subscriberprofiles because API was fialing with 500 error. In particular: LOG="«DBIx::Class::Row::store_column(): No such column 'reseller_id' on NGCP::Panel::Model::DB::voip_subscriber_profiles at /usr/share/perl5/NGCP/Panel/Controller/API/SubscriberProfiles.pm line 172» The error was caused by the addition of the reseller_id info in the $resourse even if not needed. Change-Id: I7970a2716d7af959639937a9a844160ab73a9176 (cherry picked from commit d40126ef0a) (cherry picked from commit 0d4467e291)	1 year ago
Sipwise Jenkins Builder	94e971f916	Release new version 11.5.1.26+0~mr11.5.1.26	1 year ago
Kirill Solomko	ec2f8bbd70	MT#60300 fix sound sets list rendering for reseller ... * fix code typo that prevented correct rendering of the sound sets list for reseller roles Change-Id: I35ea38a37932b8dd563a0b95f7e2481a5c45cdbe (cherry picked from commit c7ae8c1dcf) (cherry picked from commit 04def03994)	1 year ago
Sipwise Jenkins Builder	8b7040b379	Release new version 11.5.1.25+0~mr11.5.1.25	1 year ago
Rene Krenn	9d53086137	MT#60520 prov templates: fix lookup of items ... item (contract, contact, subscriber) lookup will pick the first matching element (an arbitrary one if multiple are matching). ie. when lookup identifiers are too loose (f.ex. subscribers without domain in a multidomain setup) it might pick a wrong item - which is ok (supposed to bail out at a later step) unless that wrong item is a *terminated* one, causing to proceed checks on a terminated record (which can never happen from API or UI side since those hide terminated items), which produces a misleading 500 error in the end. we prevent this now by ensuring that looked up items are not terminated ones. even if the looked up items is not the desired one, becasue of an inaccurate template. Change-Id: I6691937c2e62b05915c7eac9980224abe2185b2c (cherry picked from commit 0fd36ace55) (cherry picked from commit 5ba2af4a0e)	1 year ago
Sipwise Jenkins Builder	cd2a7f89b7	Release new version 11.5.1.24+0~mr11.5.1.24	2 years ago
Kirill Solomko	7295a51d05	MT#59363 /api/subscriberregistrations change socket field to Text ... * socket field is changed to text for the API endpoint as by default in the LocationEntry form that is used by the UI the field is a prebuilt options list that comes from config.yml extra_sockets, and that severely limits the usage for the API. Change-Id: I71ee1f77dbf458c12655f840282375cee62b7534 (cherry picked from commit 7aeaf0f16d) (cherry picked from commit ae01a91508)	2 years ago
Sipwise Jenkins Builder	31b3fcbcf1	Release new version 11.5.1.23+0~mr11.5.1.23	2 years ago
Kirill Solomko	cc7ba9e24f	MT#56301 move lock_provisioning_voip_subscriber before underrun_lock ... * POST /api/subscribers/ invoke lock_provisioning_voip_subscriber() before underrun_lock(), so that if the subscriber is about to be locked due to customer balance costs, the lock_provisioning_lock_subscriber() invocation will not unlock it back straight after Change-Id: I55020f844c9aa76df2e2f057a88b2ae7c9ebbfcc (cherry picked from commit c6aaaddd87) (cherry picked from commit 8d016b0bdd)	2 years ago
Rene Krenn	521d25f094	MT#56301 set locklevel of created subscribers only if specified ... Change-Id: I90f2d68dee50ab240de4eb5af7495ddd551c00d8 (cherry picked from commit df670f501f) (cherry picked from commit a1fb2bfd4b)	2 years ago
Marco Capetta	b9974aad50	MT#56301 Fix API creation of an active subscriber with lock ... Using API is possibile to edit an existing subscriber and set status: active and lock: 2. It is instead impossbile to create a new subscriber with the same configuration because the 'lock' param is not taken into account. The only way to properly setup lock level it is to set the status to 'locked' and this is in fact wrong. The fix address this issue and allow now to create a new subscriber with status: active and lock: 2. Change-Id: Id18e40bc001c5a7de30f5d148231bda93a3b1b3d (cherry picked from commit 8945b8a5ac) (cherry picked from commit 26456c99a7)	2 years ago
Sipwise Jenkins Builder	abf2c85f9b	Release new version 11.5.1.22+0~mr11.5.1.22	2 years ago
Nico Schedel	85874a4d08	MT#55677 fix all ngcp-panel-selenium tests ... Change-Id: I7f1f1e5fe9632dad233818b3a43b78a54ff97b98	2 years ago
Sipwise Jenkins Builder	0c88ee0afb	Release new version 11.5.1.21+0~mr11.5.1.21	2 years ago
Kirill Solomko	624053a259	MT#59835 /api/billingzones fix HAL ngcp:billingfees relation ... * billing fees relation was rendering all associated billing fees and that was causing huge data sets to be returned if a billing zones had many fees, now instead a single link is returned /api/billingfees/?billing_zone_id=:id. this is also on par with other links like /api/billingfees/:id Change-Id: Iabb7afb3bf43abf9a22c71750d45a1962a7f16ec (cherry picked from commit e4cda08bd4)	2 years ago
Sipwise Jenkins Builder	c407a79769	Release new version 11.5.1.20+0~mr11.5.1.20	2 years ago
Kirill Solomko	271126f1fc	MT#59797 /api/headerruleconditions (actions) fix reseller role ... * fix resultset when user role is reseller so that reseller_id is joined correctly and a db error is not produced anymore. Change-Id: I2a1b357037d983f23770bb59519fc2cb8b68a7e4 (cherry picked from commit bf249f9d96)	2 years ago
Sipwise Jenkins Builder	c76160ee0f	Release new version 11.5.1.19+0~mr11.5.1.19	2 years ago
Rene Krenn	bbb3f98d4a	MT#59748 drop ngcp-provisioning-template test dbhost ... Change-Id: I7218ed36cff2f51f5a6f862f41e5da94ff0d464b (cherry picked from commit 14e5b918b3)	2 years ago
Sipwise Jenkins Builder	bbe9b852a0	Release new version 11.5.1.18+0~mr11.5.1.18	2 years ago
Rene Krenn	a11b5d2d08	MT#56817 MT#56362 fix query param sorting for regulary chained rs ... Change-Id: I82d3a0ce67ffb61273fc716016885f6431852eff (cherry picked from commit c837dc1043)	2 years ago
Rene Krenn	180b75f6d7	MT#56817 MT#56362 fix query param sorting for rs chained the regular way ... Change-Id: I0dab56ae07666eb695d7f30ef633a876ff8258fb (cherry picked from commit aae0b7e071)	2 years ago
Rene Krenn	0e732ef469	MT#56817 MT#56362 fix errors from nondetermistic query param ordering ... the /api/callists rail supports the "call_id" query parameter to match calls with a callid prefix. this filter also adds an implicity ordering ORDER BY length(call_id) ASC, 'start_time' ASC. the /api/callists api rail also requires the query parameter "susbcriber_id", which renders a (fast) compound SQL query to list matching incoming (query1) and outgoing calls (query2) using UNION ALL (instead of a slow OR query). query1 UNION ALL query2 this is supported by the https://metacpan.org/pod/DBIx::Class::Helper::ResultSet::SetOperations module, which however generates invalid SQL syntax if query1 or query2 contains an ORDER BY. this is exactly what caused the 500 error of the customer who applied both "call_id" and "susbcriber_id" parameter in the request at the same time. ... ORDER BY length(call_id) ASC, `start_time` ASC UNION ALL SELECT `me`.`id`... the error happens randomly, because query parameters are stored in a hash (which by definition has no deterministic order of the entries). when the "call_id" parameter is applied at last, it worked as expected. so the issue can be adressed by strictly ordering the UNION ALL result, and prohibit ORDER BY in query1 and query1. the latter was added already with commit b2dfe28eed, and could be hotfixed. however, the ORDER BY of "call_id" query param is lost, and should be properly handled by forcing strict ordering of how query parameters are applied. the fix will introduce paramater ordering according to their order of definition in the code. Change-Id: I165d341b5c20e9bb750bd1fba88c836b393e80bd (cherry picked from commit a15d00894a)	2 years ago
Rene Krenn	e09b432049	MT#59216 restore appending wildcard behaviour ... with the change to harmonize wildcard symbols % and * to * in query param filters across all restapi rails, only - /api/subscribers?alias= - /api/subscribers?pbx_extension= - /api/subscribers?primary_number= - /api/pbxdevices?pbx_extension= are supposed to include implicit leading an trailing wildcards. panel UI uses trailing wildcard by default everywhere, and so should the databales of the new Admin UI. external_id were used to support patterns, but must not include a trailing wildcard in rest API, as this can break logic that rely on unique api request results. we now therefore no longer append wildcards in particular to: - /api/voicemails?folder= - /api/voicemailgreetings?type= - /api/subscribers?subscriber_external_id= - /api/subscribers?customer_external_id= - /api/subscribers?display_name= - /api/subscribers?domain= - /api/profilepackages?profile_name= - /api/profilepackages?network_name= - /api/pbxdevices?display_name= - /api/faxserversettings?name_or_password= Change-Id: I40ef1912d7224a56c6d14619d258c70e447ab23d (cherry picked from commit 672a3110bc)	2 years ago
Sipwise Jenkins Builder	0bf28ce60a	Release new version 11.5.1.17+0~mr11.5.1.17	2 years ago
Rene Krenn	743486e443	MT#59434 always take aliases from voip_numbers ... in case the DB shows discrepancy because of missing primary provisioning.voip_dbaliases records, align with legacy panel behaviour and also take the restapi aliases list from voip_numbers, instead of voip_dbaliases. .. while trying to keep the performance gain from https://gerrit.mgm.sipwise.com/c/ngcp-panel/+/65086. Change-Id: Ibd7f8c8bc6a39ae2c31b4e8818080674ab77d66c (cherry picked from commit 740bb764e5)	2 years ago
Sipwise Jenkins Builder	759f3fc49e	Release new version 11.5.1.16+0~mr11.5.1.16	2 years ago
Kirill Solomko	84f6f22025	MT#59238 fix rewrite rules transaction control for PATCH,DELETE ... * /api/rewriterules PATCH, DELETE methods used the generic transaction, which conflicted with the xmlrpc reload command. * own_transaction_control was only set for PUT and now also extended to PATCH, DELETE to ensure that dialplan_sip_reload() is called properly after $guard->commit. Change-Id: I7313b4f6d1f6699bf38ae34749c5383a3943f61d (cherry picked from commit 80f8b1da0b)	2 years ago
Sipwise Jenkins Builder	d1496ea28e	Release new version 11.5.1.15+0~mr11.5.1.15	2 years ago
Kirill Solomko	2341735b55	MT#58709 rework NGCP::Utils::Sound::get_handlers_rs ... * get_handlers_rs() is renamed into get_file_handles() and reworked from an indented 'from' resultset into 2 separate resultsets, one fetching all the handles and another one files for the sound set, it is now returned as an array with the similar data. Reason for this rework is the deprecated use of 'from', that resulted in a lot of warnings in panel-fcgi.log: DBIx::Class::SQLMaker::ClassicExtensions::_join_condition(): ResultSet {from} structures with conditions not conforming to the SQL::Abstract::Classic syntax are deprecated: you either need to stop abusing {from} altogether, or express the condition properly using the { -ident => ... } * adjust file_handles data key names to better follow the naming conventions and readability, e.g.: groupname -> group_name, fileid -> file_id Change-Id: Ia91c9104c0b4dc79ee5bc359eb0b6e035e56ef3e (cherry picked from commit a4d54b10e4)	2 years ago
Sipwise Jenkins Builder	b68d72ed96	Release new version 11.5.1.14+0~mr11.5.1.14	2 years ago
Rene Krenn	94caa43950	MT#58890 force cft_ringtimeout as number ... Change-Id: I4df4fbf6522d28a30731c87a36c95ae8350830fa (cherry picked from commit cc8fd8928d)	2 years ago
Sipwise Jenkins Builder	b30d9d7cca	Release new version 11.5.1.13+0~mr11.5.1.13	2 years ago
Rene Krenn	d1bc3017dc	MT#59025 fix peering groups name filter ... Change-Id: I329e644c937058069c5932abf8e897dce48a8c10 (cherry picked from commit 1e9f223276)	2 years ago
Rene Krenn	da4ca9e0c4	MT#58762 adjust restpi tests v2 to harmonized wildcard filters #1 ... Change-Id: Icdf581f425f5e28ba22480424f04355181b4f3b3 (cherry picked from commit 73a967bfb6) (cherry picked from commit 704cd6550c)	2 years ago
Rene Krenn	54876dac3d	MT#58762 adjust restpi tests v2 to harmonized wildcard filters ... Change-Id: Ie100612c9f284e9acad6b305345751bb07adfab9 (cherry picked from commit bad2e32802) (cherry picked from commit 30c97564a8)	2 years ago
Sipwise Jenkins Builder	5ba7a09592	Release new version 11.5.1.12+0~mr11.5.1.12	2 years ago
Rene Krenn	e4a0067cef	MT#58936 fix customerzonecosts resourcename ... Change-Id: I22b052bc6931e5426e1aa982396c446cb1c67883 (cherry picked from commit 2101e2246d)	2 years ago