5261 Commits (67a7a774c70a527c19c4a4a5789828c788d02b40)

 

All Branches   

Search

Author	SHA1	Message	Date
Sipwise Jenkins Builder	67a7a774c7	Release new version 10.5.9.0+0~mr10.5.9.0	8 months ago
Rene Krenn	d21b0c3c88	MT#58485 invoice: use UTC tz when filtering for start_time ... Change-Id: I967d06f17418c352fb8ae173e8a8af864b33ae66 (cherry picked from commit f6b934bfc6)	8 months ago
Marco Capetta	5d270020e0	MT#60756 Fix subscriberprofiles POST api call as reseller ... Administrators with reseller role were not able to create new subscriberprofiles because API was fialing with 500 error. In particular: LOG="«DBIx::Class::Row::store_column(): No such column 'reseller_id' on NGCP::Panel::Model::DB::voip_subscriber_profiles at /usr/share/perl5/NGCP/Panel/Controller/API/SubscriberProfiles.pm line 172» The error was caused by the addition of the reseller_id info in the $resourse even if not needed. Change-Id: I7970a2716d7af959639937a9a844160ab73a9176 (cherry picked from commit d40126ef0a)	9 months ago
Rene Krenn	71f36fb564	MT#59597 fix remove trailing+leading % entirely for "wildcard" params ... Change-Id: I371e2d41ff27b2801ead391778d9a2bdef914563 (cherry picked from commit 868e2657b6)	11 months ago
Rene Krenn	f96194ff14	MT#59597 remove trailing+leading % entirely for "wildcard" param types ... this code is not run by legacy panel, so the check for "/api" request can be removed. Change-Id: I29410fbbf046a8f00443138720b940de0f09f416 (cherry picked from commit 9ba93e69a5)	11 months ago
Rene Krenn	8a4407845b	MT#59363 retain trailing+leading wildcard for legacy panel only ... all api query param filters that were harmonized to "wildcard" also appended leading+trailing wildcard (this was from the original idea to make adminUI and legacy panel search behave the same). Change-Id: I017473b84f2844d14a11b4ec8b437df5335c24d0 (cherry picked from commit aa6760228e)	11 months ago
Rene Krenn	3d476c4f77	MT#59363 fix /api/domains/?domain= filter pattern behaviour ... this filter is another spot, where leading/trailing wildcards were added unintentionally, during harmonization. Change-Id: Id23114f8e7ebca018ad222e35b39d8260f1da92f (cherry picked from commit 48b71e68c5)	11 months ago
Rene Krenn	7804c9e388	MT#56817 MT#56362 fix query param sorting for regulary chained rs ... Change-Id: I82d3a0ce67ffb61273fc716016885f6431852eff (cherry picked from commit c837dc1043)	11 months ago
Rene Krenn	60e5deb114	MT#56817 MT#56362 fix query param sorting for rs chained the regular way ... Change-Id: I0dab56ae07666eb695d7f30ef633a876ff8258fb (cherry picked from commit aae0b7e071)	11 months ago
Rene Krenn	275d47b3ab	MT#59216 restore appending wildcard behaviour ... with the change to harmonize wildcard symbols % and * to * in query param filters across all restapi rails, only - /api/subscribers?alias= - /api/subscribers?pbx_extension= - /api/subscribers?primary_number= - /api/pbxdevices?pbx_extension= are supposed to include implicit leading an trailing wildcards. panel UI uses trailing wildcard by default everywhere, and so should the databales of the new Admin UI. external_id were used to support patterns, but must not include a trailing wildcard in rest API, as this can break logic that rely on unique api request results. we now therefore no longer append wildcards in particular to: - /api/voicemails?folder= - /api/voicemailgreetings?type= - /api/subscribers?subscriber_external_id= - /api/subscribers?customer_external_id= - /api/subscribers?display_name= - /api/subscribers?domain= - /api/profilepackages?profile_name= - /api/profilepackages?network_name= - /api/pbxdevices?display_name= - /api/faxserversettings?name_or_password= Change-Id: I40ef1912d7224a56c6d14619d258c70e447ab23d (cherry picked from commit 672a3110bc)	11 months ago
Rene Krenn	2d78375e9a	MT#56817 MT#56362 fix errors from nondetermistic query param ordering ... the /api/callists rail supports the "call_id" query parameter to match calls with a callid prefix. this filter also adds an implicity ordering ORDER BY length(call_id) ASC, 'start_time' ASC. the /api/callists api rail also requires the query parameter "susbcriber_id", which renders a (fast) compound SQL query to list matching incoming (query1) and outgoing calls (query2) using UNION ALL (instead of a slow OR query). query1 UNION ALL query2 this is supported by the https://metacpan.org/pod/DBIx::Class::Helper::ResultSet::SetOperations module, which however generates invalid SQL syntax if query1 or query2 contains an ORDER BY. this is exactly what caused the 500 error of the customer who applied both "call_id" and "susbcriber_id" parameter in the request at the same time. ... ORDER BY length(call_id) ASC, `start_time` ASC UNION ALL SELECT `me`.`id`... the error happens randomly, because query parameters are stored in a hash (which by definition has no deterministic order of the entries). when the "call_id" parameter is applied at last, it worked as expected. so the issue can be adressed by strictly ordering the UNION ALL result, and prohibit ORDER BY in query1 and query1. the latter was added already with commit b2dfe28eed, and could be hotfixed. however, the ORDER BY of "call_id" query param is lost, and should be properly handled by forcing strict ordering of how query parameters are applied. the fix will introduce paramater ordering according to their order of definition in the code. Change-Id: I165d341b5c20e9bb750bd1fba88c836b393e80bd (cherry picked from commit a15d00894a)	11 months ago
Kirill Solomko	2c58f1867d	MT#60162 improve expand functionality for collections ... * in general expand collection now performs only 1 sql query to per expand field to fetch all items by the ids instead of fetching them for every single collection item, that should significantly increase performance in case of large databases and reduce work for the database * introduce $c->stash->{expand_cache} that contains cached data for the expand fields to avoid multiple same calculations * expand_field() and expand_field_data() have been reworked to support expand_cache * new method expand_prepare_collection() is called for all API GET collection methods before preparing resource hal fields, to change the expand logic to only cache the data instead of fetching it from the database * new method expand_collection_fields() that is called in all API GET collection methods after the @embedded data is prepared to finalise the expand collection fields * for expand collection there is only 1 SQL request per expand field that fetches all items -in [ids to expand] and then the expand_collection_fields() uses the cached items_by_ids with O(1) fetch from the cache by id Change-Id: Ie7c6115472878febf0d8c9b4d833f5c23b15c78b (cherry picked from commit 6543743992)	12 months ago
Sipwise Jenkins Builder	b527ea73a7	Release new version 10.5.8.0+0~mr10.5.8.0	1 year ago
Kirill Solomko	4f39d4d20c	MT#56301 move lock_provisioning_voip_subscriber before underrun_lock ... * POST /api/subscribers/ invoke lock_provisioning_voip_subscriber() before underrun_lock(), so that if the subscriber is about to be locked due to customer balance costs, the lock_provisioning_lock_subscriber() invocation will not unlock it back straight after Change-Id: I55020f844c9aa76df2e2f057a88b2ae7c9ebbfcc (cherry picked from commit c6aaaddd87)	1 year ago
Rene Krenn	e5ea0bad56	MT#56301 set locklevel of created subscribers only if specified ... Change-Id: I90f2d68dee50ab240de4eb5af7495ddd551c00d8 (cherry picked from commit df670f501f)	1 year ago
Marco Capetta	a31f0f0fba	MT#56301 Fix API creation of an active subscriber with lock ... Using API is possibile to edit an existing subscriber and set status: active and lock: 2. It is instead impossbile to create a new subscriber with the same configuration because the 'lock' param is not taken into account. The only way to properly setup lock level it is to set the status to 'locked' and this is in fact wrong. The fix address this issue and allow now to create a new subscriber with status: active and lock: 2. Change-Id: Id18e40bc001c5a7de30f5d148231bda93a3b1b3d (cherry picked from commit 8945b8a5ac)	1 year ago
Kirill Solomko	0d9c469789	MT#59835 /api/billingzones fix HAL ngcp:billingfees relation ... * billing fees relation was rendering all associated billing fees and that was causing huge data sets to be returned if a billing zones had many fees, now instead a single link is returned /api/billingfees/?billing_zone_id=:id. this is also on par with other links like /api/billingfees/:id Change-Id: Iabb7afb3bf43abf9a22c71750d45a1962a7f16ec (cherry picked from commit e4cda08bd4)	1 year ago
Kirill Solomko	46338fb9d1	MT#59797 /api/headerruleconditions (actions) fix reseller role ... * fix resultset when user role is reseller so that reseller_id is joined correctly and a db error is not produced anymore. Change-Id: I2a1b357037d983f23770bb59519fc2cb8b68a7e4 (cherry picked from commit bf249f9d96)	1 year ago
Rene Krenn	0cefd1075f	MT#59748 drop ngcp-provisioning-template test dbhost ... Change-Id: I7218ed36cff2f51f5a6f862f41e5da94ff0d464b (cherry picked from commit 14e5b918b3)	1 year ago
Rene Krenn	3d745dc2d1	MT#59025 fix peering groups name filter ... Change-Id: I329e644c937058069c5932abf8e897dce48a8c10 (cherry picked from commit 1e9f223276)	1 year ago
Rene Krenn	10f3b93075	MT#58762 adjust restpi tests v2 to harmonized wildcard filters #1 ... Change-Id: Icdf581f425f5e28ba22480424f04355181b4f3b3 (cherry picked from commit 73a967bfb6)	2 years ago
Rene Krenn	eb44ad88a0	MT#58762 adjust restpi tests v2 to harmonized wildcard filters ... Change-Id: Ie100612c9f284e9acad6b305345751bb07adfab9 (cherry picked from commit bad2e32802)	2 years ago
Marco Capetta	65a9a52c87	MT#58762 Fix typo in swagger documentation ... Fix typo of commit 308a974059 that was causing to fail the generation of the the swagger documentation with the message: ngcp-panel: ERROR: Couldn't render template "api/root.tt: file error - parse error - api/root/collection.tt line 112: unexpected token (=)#012 [% IF f.query_type = 'wildcard' %]" Change-Id: I35882b97b2a86a7f54829f017ab1cb19b3b9f6e5 (cherry picked from commit 1474584b60)	2 years ago
Rene Krenn	6ab7c0b942	MT#58762 adjust restpi tests to harmonized wildcard filters ... Change-Id: I68b2199a3487fedb388803012c950c3abca1a8b3 (cherry picked from commit aa2d07ef29)	2 years ago
Rene Krenn	aacf44c605	MT#58762 harmonize restapi wildcard filters ... - all standard LIKE search are migrated - will avoid LIKE unless a pattern (* wildcard) is used as a search term. this encourage db index usage, will be faster - supports wildcard escape sequence \\* - harmonize swagger UI descriptions of filters Change-Id: Iea155871c9be6c284e6970a562d4e6af73fedc4b (cherry picked from commit 308a974059)	2 years ago
Sipwise Jenkins Builder	ce35d341dd	Release new version 10.5.7.0+0~mr10.5.7.0	2 years ago
Rene Krenn	827fbd1cbc	MT#57070 ignore undef enum.default_val ... while provisioning.voip_preference_enums.default_val is supposed to be a flag variable, it is NULL for some prefs. we prevent a 500 error when editing such value in this case now. Change-Id: Idc5e0f1f0de93f9d0b6645982025c8b45bae1ec4 (cherry picked from commit dd9d57c33b)	2 years ago
Rene Krenn	b62da79a0e	MT#56239 avoid ambersand symbol in apidoc descriptions ... Change-Id: Ic024d16c008648cb4d9cf14ae0e58d1ebe8febe9 (cherry picked from commit 71480acfa3)	2 years ago
Rene Krenn	c57231de40	MT#56239 api/callrecordings support filtering multiple metakeys ... filtering an Entity-Attribute-Value model cannot be done as simple conjunctions, but requires either INTERSECT set operation, or joining the same table multiple times. Change-Id: I5ce1ae1ece9406b6610487654f09d768a233b122 (cherry picked from commit 8e82715eb8)	2 years ago
Kirill Solomko	d9ee558764	MT#57100 avoid where ambiguity for query_types search_eq,search_like ... * uses prefix 'me.' for query types search_eq and search_like in the where condition to avoid ambiguity if the search_rs has joins that with the same column names Change-Id: I90fef80970aa4415480b00bbed2fb9fbee1f1ccc (cherry picked from commit c58a8b9b1f)	2 years ago
Rene Krenn	f9dc78a25e	MT#56239 api general caller/callee wildcard search support ... various api rails will need to support ?caller= and ?callee= url query parameters. since this involves SQL queries against potentially large database tables, special care is taken with wildcard search to prevent slow queries: - the ?wildcards=true query parameter has to be specified to accept search patterns that contain wildcard symbols, so wildcards are not accepted by default. WARNING: a search string with a leading wildcard will always force a *slow* full db table scan! - the * symbol is used as a wildcard symbol - \ (backslash) is used as escape character to search for a literal '*' Change-Id: Ie6065b0cfa883f7963e1dc8259fffea9a1edfdfe (cherry picked from commit 9c3a549094)	2 years ago
Rene Krenn	b1c216ee71	MT#58346 fix conversations voicemail timestamp filter ... Change-Id: I86fc4db7d5efddf73f6c0b068b1c9e79913fddaf (cherry picked from commit 5eff0601b5)	2 years ago
Rene Krenn	eb7d5ca2a1	MT#58346 fix panel datatable filtering ... Change-Id: I4ce2e07a3ffa0715e385d811737f850aacaa5d90 (cherry picked from commit d546387651)	2 years ago
Rene Krenn	f5b6615680	MT#58346 caller/callee filters for conversations ... the conversation list now supports ?caller= and ?callee= url query parameters. since this involves SQL queries against potentially large database tables, special care is taken with wildcard search to prevent slow queries: - the ?wildcard=true query parameter has to be specified to accept search patterns that contain wildcard symbols, so wilddcards are not accepted by default. WARNING: a search string with a leading wildcard will always force a *slow* full db table scan! - the * symbol is used as a wildcard symbol - \ (backslash) is used as escape character to search for a literal '*' Change-Id: I792d2ea9c649c69c4b5cc98076097cb96467d4bc (cherry picked from commit ae612eb401)	2 years ago
Marco Capetta	77232ab1c7	MT#54356 Fix swagger documentation for 'calllist' api ... The 'duration' field is reported in the documentation as 'number' but in fact it is a string, for example: "0:00:16.495". In the commit the definition of the parameter is changed from PosInteger to Text Change-Id: I317006f5bbb5c4b7ffea0abe29dc0b175d8f95e6 (cherry picked from commit 958e40e2ca)	2 years ago
Fabricio Santolin da Silva	b2529fb613	MT#58468 Fix special characters incorrectly interpreted by paps ... Change-Id: I15682d0e3bbe53cc372a5eb1a162e7592e9a3b11 (cherry picked from commit 3c5cf0b537)	2 years ago
Kirill Solomko	53f28f4b93	MT#58157 escape uri refs in body.tt ... * URI that comes from c.req.uri must be escaped as Catalyst provides c.req.uri unescaped. * new Catalyst::NGCP::Plugin::EscapeURI with escape_uri() function * new NGCP::Panel::Utils::Generic::escape_uri() that uses URI::Escape::uri::escape_utf8() * c.req.uri and c.req.path occurrences in layout/body.tt are now escaped with c.escape_uri() Change-Id: Id0483fa6e570a0ff8db84b1d470caf5405cc0886 (cherry picked from commit c826fccb29)	2 years ago
Sipwise Jenkins Builder	17b756d68f	Release new version 10.5.6.0+0~mr10.5.6.0	2 years ago
Marco Capetta	adf47c1587	MT#56181 Fix link of AutoAttendant edit slots ... From the very origin of the AA module the link used in panel to create/edit the AA slots were '/preferences/speeddial/edit'. This is wrong and most probably coming from a copy and paste of the speeddial feature. The commit fix the link and it is now chaged to the following '/preferences/autoattendant/edit'. Change-Id: I095b433cad78fb0175b0551fcfdea85815f73cdf (cherry picked from commit 28340ce871)	2 years ago
Nico Schedel	40909df586	MT#55491 fix tests for mr10.5 point releases ... Change-Id: Ib34b731edf79c26a38905a7ffa8beabb66df4cca	2 years ago
Marco Capetta	1a6567c648	MT#57469 Fix kamailio lcr reload on PATCH/PUT APIs ... When calling a PATCH or PUT API on a peering group or outbound rule the reload of the kamailio lcr module was triggered before the update of the database, thus the kamailio status was not updated. Change-Id: I59ed863c85219e62d6f5b5a2af80db8ef952844c (cherry picked from commit be7193e75b)	2 years ago
Marco Capetta	51e549b9a5	MT#57342 /api/subscribers fix field role inconsistency ... When the subscriber preferences API is called by a subscriber admin of a normal (not PBX) customer, then some values are removed from the output. In all the other cases those values are instead returned. This fix let expose the profile_id, domain_id, status and webpassword to all the types of subscribers because necessary in the CSC context. Change-Id: I629475e7f51d747a55ebfbc44232fb94a54fed06 (cherry picked from commit ce6884ebab)	2 years ago
Sipwise Jenkins Builder	792339d8b2	Release new version 10.5.5.0+0~mr10.5.5.0	2 years ago
Marco Capetta	1d2b91fb6b	MT#56776 Fix peer deletion when not enabled ... Deletion of a disabled peer was not working because panel was trying to get the correspondant ID from the LCR table, while the entry is not there because peer was in fact disabled. To fix it an additional check has been added to evaluate if the peer is enabled or not at the moment of the deletion. Change-Id: I3c488a8711c5f7b486b6c0a3950738fb8689bb07 (cherry picked from commit 0274ab04c3)	2 years ago
Kirill Solomko	afc6a7ed69	MT#56802 fix preferences default values selection ... * preferences form with enum values now set the default one as selected if no preference is set yet. * disable autocomplete for the preferences table fields. this addresses Firefox using incorrect selected values even though the correct data is sent by the server. Change-Id: I6865eec05c085b89e651b125a7f35724859ccbc2 (cherry picked from commit 3c1842c122) (cherry picked from commit 33e39cdac5)	2 years ago
Rene Krenn	4176e8820d	MT#56417 make Provisioning Templates "contract_contact" and "contract" sections optional ... to better fit the usecase of *updating* subscribers, we make the contract and contract_contact sections no longer mandatory. Change-Id: If3c34f2cd3a5201cf7da2729369fd6b1003f1a80 (cherry picked from commit 7cbf2f64bd)	2 years ago
Sipwise Jenkins Builder	1c252518c7	Release new version 10.5.4.0+0~mr10.5.4.0	2 years ago
Rene Krenn	423e084ddc	MT#55694 MT#55419 provide generated datatable search tooltips ... the search field of admin-panel datatables was tuned/configured over time to allow fastest possible search, "as-you-type". for large tabels it eg. will only include indexed columns, which never was transparent to the users. the UI will now display tooltip texts with detailed hints about included columns, wildcard support, etc. Change-Id: I737732a55003d50068236bb0150a2f47d06deaf5 (cherry picked from commit ff198cef49)	3 years ago
Rene Krenn	9d21a5dd87	MT#55972 support wildcard search for customer external_id ... Change-Id: I8287f7650f68dab2e806259ec00ffad2ba45fe1a (cherry picked from commit e9367e0cfe)	3 years ago
Kirill Solomko	1a1fb8f4ff	MT#56087 fix /api/callforwards sets auto creation ... * with PUT/PATCH data source and bnumber quick sets are correctly automatically created now Change-Id: Ia6f3be8958081f1611a1473b35c73826a9ed8784 (cherry picked from commit e2afe2ea06)	3 years ago