5721 Commits (22623e7c2f495441663a359fc1ee5fb98ff9010b)

 

All Branches   

Search

Author	SHA1	Message	Date
Rene Krenn	22623e7c2f	MT#65618 require contract/subscriber sections in prov templates ... Validate that dependent template sections only appear together with their parent contract or subscriber section. Change-Id: I3150ca1844b633ab80ffd501fcf587d08f9ebdf8	24 hours ago
Marco Capetta	cc34719693	MT#56865 Fix autoprovisioning of Grandstream devices ... The autoprovisioning of Grandstream devices was not working since a while or even never really worked. In the SOAP request to register the new device in the GAPS server was missing the '$query_string' parameter, thus the server responded back with: response=200; page={"code":7,"desc":"try to http base authorization failed","ret":null,"time":1785401492}#012; err=try to http base authorization failed; This change should not affect the provisioning of other vendors because the '$query_string' parameter is set to an empty string by default. Change-Id: I6637ce82351c46ec631c1047ec50ccb5404228e1	2 days ago
Rene Krenn	9767845c0a	MT#65579 use JSON::Types::bool for is_devid in resource_from_item ... Keep journal-safe JSON booleans after moving resource_from_item into Utils::Subscriber, matching the previous Role/API behaviour. Change-Id: I357a4f5f4a25f8a7295341dcbff80a14d3cb6f51	3 days ago
Rene Krenn	e485aff6b4	MT#65579 fix is_devid boolean conversion in resource_from_item ... Avoid the ambiguous bareword "bool" call that 500s subscriber API responses when alias is_devid is a plain DB integer. Change-Id: I8829e064ee658ae35676aa8414c58c0e16ffd5fa	4 days ago
Rene Krenn	a0bfa9377c	MT#65579 support updating existing subscribers via prov templates ... Reuse shared resource_from_item/update_subscriber helpers so templates can match by identifier, fill missing fields from the DB item, and update instead of only creating. Change-Id: I5fa9be12914677c3b6ef5c4c0617cb75447b45c9	5 days ago
Kirill Solomko	f677173e70	MT#65572 fix api-test2 duplicate cftimeset name ... * duplicate time set names are not allowed anymore and there was a typo in the test. Change-Id: I1d6946ddbf8c9142d6389f1764418a073f8babd4	1 week ago
Kirill Solomko	7256474e72	MT#65572 fix api-test2 duplicate cfdestinationset name ... * duplicate destination set names are not allowed anymore and there was a typo in the test. Change-Id: I7d0817103ece1ccbe1227498ef4634a9fae092f5	1 week ago
Kirill Solomko	79817b3529	MT#65573 change order of check_resource() and check_duplicate() ... * check_duplicate() call must be after check_resource() by default as check_resource usually validates the vital values, such as subscriber_id, reseller_id whereas the duplicates check can already operate with the "trustworthy" subscriber_id for the duplicate checks part. Change-Id: I3361c143a6e00f9c168a3b02e23feb4ca57c85f0	1 week ago
Kirill Solomko	9470652038	MT#65572 rework call forward sets resource validation ... * streamline the validation behaviour among all the call forward set endpoints to be the same: - all of them contain process_form_resource() check_resource() check_duplicate() and also update_item() calls those functions in the exact order * subscriber_id validation is performed in check_resource only once and removed from the other places. * subscriberadmin role now uses the same Form as the admin users (that contains the subscriber_id field). * subscriberadmin role is now allowed to provide with the subscriber_id, otherwise if undefined, the user's id is taken. * check_resource() now checks for subscriberadmin if the subscriber_id belongs to the same customer. * check_duplicate() only contains the duplicate entry check. * the following above fix inconsistent validation that produces different results, minimises the amount of sql queries as well as extends the functionality to enable the subscriberadmin role to create call forward sets on behalf of the own subscribers. Change-Id: I60ddd5aa2bd5228efeca9f8c1a593d24179b959a	1 week ago
Kirill Solomko	7f9af10416	MT#65553 add check duplicates for call forward sets ... * add check_duplicates() for destination, bnumber, time sets. * adjust duplicate set error messages. Change-Id: I8ee958df97f6e53f0e64283a0a9c2f85330aa9d1	1 week ago
Sipwise Jenkins Builder	9c1b762c82	TT#4166 I18N dump: snapshot 2026.07.21-22.28.18 ... Change-Id: I9b1175e0d649bb4323fc28e1c9f81ac8c3fad03b	1 week ago
Kirill Solomko	51876d2b8f	MT#65550 restore swagger doc id parameter for GET /{id} path ... * restore missing swagger doc id parameter for GET /{id} path Change-Id: I32d76034c85aa36ad95c235f55ca9aac3579d6d5	1 week ago
Kirill Solomko	deeaa10794	MT#64924 add PUT|PATCH cfmappings delete_unused_sets support ... * with PUT or PATCH /api/cfmappings/:id/?delete_unused_sets=1, all sets that become unused after the request and also a) not used by another subscriber b) belong to the same subscriber are are automatically deleted. * add query_params "delete_unused_sets" doc for PUT and PATCH Change-Id: I1485d35e905de391ed3e92d0fe75f3e72155a239	1 week ago
Kirill Solomko	67f7eaa65b	MT#65550 add PUT,PATCH,DELETE swagger query_params support ... * with a snippet as: __PACKAGE__->set_config({ ... DELETE => { query_params => [ { param => 'foo', description => 'Description', query_type => 'integer', }, ], }, }); it renders the query parameter on the API swagger documentation. * query_type must be according to the swagger API, of ommitted it falls back to 'string'. Change-Id: I9345a97ad9a4c674e757cd032fb719f51c25f5b6	2 weeks ago
Kirill Solomko	0c9f3e5ed0	MT#65549 add cf sets DELETE ?unassign_first=1 support ... * it is now possible to invoke the following endpoints as: - DELETE /api/cfbnumbersets/:id?unassign_first=1 - DELETE /api/cfsourcesets/:id?unassign_first=1 - DELETE /api/cftimesets/:id?unassign_first=1 in which case before the actual deletion, the cf set is unassigned from the cf_mappings, so that the cf_mappings are not automatically deleted by the constraints. Change-Id: I7fa40eba2790edcc62d8430ebbe6f752b13353f9	2 weeks ago
Kirill Solomko	331dcd604a	MT#65548 cf sets add usage_count field ... * usage_count field is returned for all the call forward sets and indicates how many cf mappings use the cf set. Change-Id: Ib8f31370fd4cfae3356c683981be7b9d0da0a73a	2 weeks ago
Rene Krenn	70d5c894a6	MT#65464 Fix LDAP OTP registration crash on /api/otpsecret ... LDAP login stored a raw DB::admins row as $c->user, so API response logging failed when fetching the OTP QR after an invalid OTP on login_jwt. Wrap the admin in RoleFromRealm, pass the admin auth realm to set_authenticated, logout on OTP failure, and make Message logging tolerate raw user rows or role lookup failures. Change-Id: I29fda2324eadc7fb1f25f06ae6418ab594b69fa0	3 weeks ago
Michael Prokop	a9bc9cdc78	TT#76552 Apply more strict systemd hardening ... In commit 31429319e7 we had to reduce our systemd hardening because ngcp-panel used the sendmail(1) interface for sending mails. Now that we switched from sendmail(1) to SMTP in commit 5993a1e1bc, we can finally re-apply the systemd hardening again. Original situation: [sipwise-lab-trunk] sipwise@sp1:~§ sudo SYSTEMD_COLORS=0 PAGER= COLUMNS=100 unbuffer systemd-analyze security ngcp-panel | grep -v '✓' NAME DESCRIPTION EXPOSURE [...] → Overall exposure level for ngcp-panel.service: 8.1 EXPOSED 🙁 [sipwise-lab-trunk] root@spce:~# New situation: [sipwise-lab-trunk] sipwise@sp1:~§ sudo SYSTEMD_COLORS=0 PAGER= COLUMNS=100 unbuffer systemd-analyze security ngcp-panel | grep -v '✓' NAME DESCRIPTION EXPOSURE ✗ SystemCallFilter=~@resources System call allow list defined for service,… 0.2 ✗ SystemCallFilter=~@privileged System call allow list defined for service,… 0.2 ✗ RootDirectory=/RootImage= Service runs within the host's root directo… 0.1 ✗ RestrictAddressFamilies=~AF_UNIX Service may allocate local sockets 0.1 ✗ RestrictAddressFamilies=~AF_(INET|INET6) Service may allocate Internet sockets 0.3 ✗ ProtectProc= Service has full access to process tree (/p… 0.2 ✗ ProcSubset= Service has full access to non-process /pro… 0.1 ✗ PrivateNetwork= Service has access to the host's network 0.5 ✗ PrivateUsers= Service has access to other users 0.2 ✗ DeviceAllow= Service has a device ACL with some special … 0.1 ✗ IPAddressDeny= Service does not define an IP address allow… 0.2 → Overall exposure level for ngcp-panel.service: 1.6 OK 🙂 [sipwise-lab-trunk] sipwise@sp1:~§ Change-Id: Id68cb73204ec9a20ebf54071ef41560c3f666407	3 weeks ago
Michael Prokop	ca8a56755a	MT#65478 ngcp-panel-tools: add missing perl dependencies ... The scripts rely on several dependencies that are satisfied only because we ship them on our NGCP systems due to dependencies elsewhere. Ensure we have the essential ones available, so it works also when someones installs ngcp-panel-tools only. libconfig-general-perl: # ./ngcp-api-generate-doc --help Can't locate Config/General.pm in @INC [snip] libfile-slurp-perl: # ./ngcp-api-generate-doc --help Can't locate File/Slurp.pm in @INC [snip] libxml-simple-perl: # ./ngcp-api-generate-doc --help Can't locate XML/Simple.pm in @INC [snip] libngcp-schema-perl: # ./ngcp-api-generate-doc --help Can't locate NGCP/Schema/Config.pm in @INC [snip] libjson-perl: # ./ngcp-create-testusers --help Can't locate JSON.pm in @INC [snip] libipc-shareable-perl: # ./ngcp-create-testusers --help Can't locate IPC/Shareable.pm in @INC [snip] libcryptx-perl: # ./ngcp-panel-create-keys Can't locate Crypt/PK/RSA.pm in @INC [snip] NOTE: there are further dependencies on e.g. NGCP::API::Client, NGCP::Panel::* + NGCP::Schema* that are satisfied only when having the full ngcp-panel package in place, this is a known issue for now. Change-Id: I0fd519d421c6dc970cbcbbad19d0a45156e0e124	3 weeks ago
Rene Krenn	19ed6c93f5	MT#65173 billing networks optional usage columns ... Change-Id: I730950af2d53570faff1a68ddc2e8c13952279f3 Co-authored-by: Cursor <cursoragent@cursor.com>	3 weeks ago
Rene Krenn	12d2906b31	MT#65173 billing profiles DELETE usage checks ... Change-Id: I359e5d74fb8f46c5892584d11fd22ccab1a09f52 Co-authored-by: Cursor <cursoragent@cursor.com>	3 weeks ago
Rene Krenn	3e1d3c09a5	MT#65464 fix LDAP login 500 when user lookup fails ... get_user_dn called ->dn on an undefined search result when LDAP lookup failed, causing login_jwt to crash instead of returning 403. Return early when no entry is found and log a clear message when the LDAP URI is missing or the connection fails. Change-Id: I5f00df840d304e4da2b35750c9c1f2e6972f1edb	3 weeks ago
Sipwise Jenkins Builder	fd4b1b99d4	TT#4166 I18N dump: snapshot 2026.07.07-22.21.15 ... Change-Id: Ifd8c089ef9f4eac0a69671d0d8428022f213da91	3 weeks ago
Rene Krenn	99a92aab95	MT#65377 fix ngcp-provisioning-template Catalyst stub missing license methods ... The CLI mock context lacked $c->license() and related helpers used by Subscriber.pm during provisioning, causing "Can't locate object method license" when processing PBX templates. Change-Id: I7485a425effb2d1d26e676191aff75ddd2d802d3	4 weeks ago
Rene Krenn	9714863a98	MT#65173 add optional usage columns to billing profiles API ... load contract_cnt, contract_exists, and package_cnt only when requested via query params, matching the web UI ajax behavior while keeping update validation working for interval field changes. Change-Id: Ie1d889fcac3227e81f37031c55fcf765e489cf9a	4 weeks ago
Sipwise Jenkins Builder	3296f04867	TT#4166 I18N dump: snapshot 2026.07.06-22.34.19 ... Change-Id: I15773b36caf07c74673659a808eee7ac37c5c968	4 weeks ago
Kirill Solomko	64bf49cd53	MT#65406 api-balanceintervals.t primary_number + thread id ... * include thread id as a part of the primary_number's 'ac' to make the subscribers creation within different threads unique. Change-Id: Id56961088a2b4e14df8cc08abd5d3527ada8c2f3	4 weeks ago
Kirill Solomko	b256a90abe	MT#65406 api-balanceintervals.t fix dynamic primary_number ... * fix dynamic primary_number allocation for the api-balanceintervals.t Change-Id: If965a8c4c2843c4d841120c0566a5e2876663057	4 weeks ago
Kirill Solomko	49139121cb	MT#65406 fix primary_number uniqness for tests ... * fix primary_number uniqness for t/api-rest/api-balanceintervals.t t/api-rest/api-customercontacts.t t/api-rest/api-topuplogs.t as _create_subscriber() is called multiple times there * t/api-rest/api-subscribers.t fix tests related to primary_number removal, as it can no longer be removed, also add a test that checks that the primary_number removal correctly triggers 422 error. Change-Id: I233474010a8bdcca9b9ab5975a0d2ba0c76313b6	4 weeks ago
Kirill Solomko	7eccb120a3	MT#65406 adjust t/api-rest certain primary numbers ... * make primary_numbers in t/api-rest/api-balanceintervals.t t/api-rest/api-customercontacts.t t/api-rest/api-journals.t t/api-rest/api-topuplogs.t longer to avoid ambiguity and preserve uniqness Change-Id: Iff03efff197e16b3fd9ee0dd8dd7113558baa827	4 weeks ago
Kirill Solomko	9a12bc2ddf	MT#65445 autosync "cli" on update with the same primary_number ... * on /api/subscribers PUT/PATCH if the "auto_sync_cli" config option is enabled and the primary_number is unchanged, check and sync the "cli" preference value if it differs from the primary number. * Controller::API::Subscribers remove incorrect "last" occurences. * /api/subscribers return "primary_number: null if it's not defined. * api-subscribers.t fix exists to defined for the $resource->{primary_number} check as it might be there as undef. * api-rest/tests fix primary_number to be unique for ceratin failing tests. Change-Id: I10c784ee6d3e2544d97dfaa66dc7aae10ba1990a	4 weeks ago
Kirill Solomko	b4974dc191	MT#65406 api-journals assign different primary_number ... * adjust the primary_number to be unique for the created subscribers. Change-Id: I3e906322da5d04ef5eaf803f30aa35f80a2f45a8	4 weeks ago
Kirill Solomko	76f383772f	MT#65406 include primary_number in api-journals.t ... * fix missing (now required) primary_number. Change-Id: Ib0a0878b97282c931675965aa11b4d711a108f2f	4 weeks ago
Kirill Solomko	2a1770de08	MT#65406 remove e164 field required flag ... * the primary_number validation happens in Utils::Subscriber::prepare_resource and this field must be optional (to enable pbx extensions creation that do not provide the primary_number). Change-Id: I0297bd0b94814da26c61db1f67ca5dcdb824654d	4 weeks ago
Kirill Solomko	863a8053bd	MT#65406 Adjust subscriber primary_number validation ... * Form::Subscriber 'e164' field is back to be optional * Utils::Subscriber add primary_number validation for PBX Susbcribers (Pilot Only) and SIP Subscribers and return 422 error upon failing the validation. * This enables the primary_number validation to be skipped for the PBX extensions as they automatically inherit the pilot's primary number as the base. * adjust tests to include the primary_number creation for test subscribers (api-balanceintervals, api-topuplogs). Change-Id: I4b1615d78700510f5f10c322373604e14f632171	4 weeks ago
Kirill Solomko	3711b5d108	MT#65426 E164 field cc must be greater than zero ... * when cc is undefined, the rest of the E164 number does not work as expected, as well as cc (country code) is not valid as 0 as it does not exist. specifically the primary_number cannot work without cc > 0 and not stored, nor pbx extensions copy the primary_number part correctly because of that. Change-Id: Ia3583dd42826e10e718df9ec1aecd8f1f9c3b620	4 weeks ago
Kirill Solomko	f7f2d4f58c	MT#65406 /api/subscribers e164 (primary_number) field is mandatory ... * e164 (primary_number) field is now mandatory as otherwise subscribers without the primary_number, while valid in general are having certain primary_number features not working as intended. * this change does not affect already existing subscribers without a primary_number. Change-Id: I7d0468a01da34acb17be8d625555f5ab5dee5c64	4 weeks ago
Kirill Solomko	44cab5c602	MT#65092 fix /api/voicemails $q variable typo ... Change-Id: I7e662960b873124762dcc3711636fc9a243fe0fa	1 month ago
Kirill Solomko	8089861097	MT#65092 address query param string pattern match in certain endpoints ... * new function Generic::Utils::parse_query_string($str) that performs the following: - escapes unescaped '%' and '_' occurrences when needed (as they are reserved internally for the "like" operation - converts all unescaped '*' and '?' chars to their "sql like op" '%' and '_' counterparts. * change endpoints that used escape_search_string_pattern() to use parse_query_string() instead, to avoid: a) overescaping b) automatic string wrapping with '*' that prevents strict match all sql builder queries that use $q after parse_query_string() use returned $op ('like', '=') as the operator, to easily set strict or like match. Change-Id: I961b5d032036f13a7460d91f8c197538ffba1997	1 month ago
Kirill Solomko	9e8b35fa44	MT#65382 timesets add missing own+subscriber_id in resource_from_item() ... * resource_from_item() for CFSourceSets, CFTimeSets, CFDestinationSets did not have either own flag or billing subscriber_id (or both), resulting in missing "expanded" data (as expand uses resource_from_item() internally). Change-Id: Ifeafcbc449f0e2417e3631b3e547c07a2837d856	1 month ago
Kirill Solomko	5f9d05ea24	MT#65382 add repeatable field expand support ... * repeatable fields can now be used for expand * add expand support for cfmappings repeatable fields Change-Id: Ia4f6c82c7f73d5112030dd1122fbdc13adb2c8c5	1 month ago
Kirill Solomko	f21064a2d4	MT#65368 fix UI /logout link ... * when /logout is used on the old UI, it no longer produces ERROR: Couldn't render template "logout/logout_index.tt" Change-Id: I94f29c8a400da509ca26ddf2f410ddc76edec55f	1 month ago
Rene Krenn	91ac920f8d	MT#65177 contract_id filter for CustomerLocations ... the contract_id query param allows to filter CustomerLocations by contract_id. Change-Id: I66e89fc65aa46a80c6a39fd5892c6410116da91a	1 month ago
Sipwise Jenkins Builder	ed55655704	Release new version 26.2.0.0+0~mr26.2.0.0	2 months ago
Kirill Solomko	a7f13331e8	MT#65048 check subscriber profile preferences on update ... * when subcsriber preferences are modified, keys are checked against a subscriber profile and if any of them is not accessible (disabled in the assigned profile) a 422 error is now raised. That is mostly relevant for PATCH "op":"add" that returned 204 OK before regardless. This change only affects access to /api/subscriberpreferences by the 'subscriber' and the 'subscriberadmin' roles * Controller::API::SubscriberPreferencesItem: remove unintended "last" from catch {}. * Utils::Preferences: remove 2 debug lines. Change-Id: Ie20e5b8d4420c814bc786c34ddd952ee13d355ae	2 months ago
Kirill Solomko	5d7e137ec9	MT#65243 Plugin::NGCP::Redis handle 'active-replica' state ... * Catalyst::Plugin::NGCP::Redis::_wait_for_master_role() only expected the 'master' value to be considered as OK, whereas with Redis/KeyDB the value can be also 'active-replica'. Therefore, consider both 'master' and 'active-replica' values as OK. Change-Id: I16a0657a3a78a2f2b3c892c21ce0d9d6ebec0a0c	2 months ago
Sipwise Jenkins Builder	c593702b0f	TT#4166 I18N dump: snapshot 2026.06.02-22.20.34 ... Change-Id: I38d357112ee83a1df2f835b9a8c5e108440a6bfe	2 months ago
Rene Krenn	baab52c682	MT#65218 prov templates: improve contract and subscriber lookup ... - when using "identifer" to lookup a contract, the prepare_billing_profile() you produce an error. - when using "identifier" to lookup a subscriber, the prepare_resource() could cause an error. - eliminate a "Old package separator deprecated" warning from JE::Destroyer. - the "now" variable was not properly exposed in the JS scripting language context Change-Id: I3253f92f345c1532f489fc87b3c91370e34a3066	2 months ago
Rene Krenn	908815904a	MT#60441 fix saving contract prefs with location_id ... for preference values discriminated by location_id, the location_id param (passed as as a query param) needs to be provided in each query. Change-Id: Id3938ae3c18c4cb108ff7726aaad4a3512550319	2 months ago
Guillem Jover	42a254e5ab	MT#65090 generate_invoices: Remove obsolete backwards compatibility code ... This is no longer used, so it can be removed. Change-Id: Ib21a1544ffc8783ce07788c6337056deb95a2e0e	2 months ago