ngcp-panel

Commit Graph

Author	SHA1	Message	Date
Kirill Solomko	205b27a267	MT#59478 API better transaction and error handling * Role/Entities: POST/PUT/PATCH/DELETE methods changes: - support deadlock detection and transaction retry (2 retry attempts at the moment) - improve transaction control, use local $guard instead of saving the ref to $c->stash, as in that case it went out of scope too late and also reported an error message into the log about abnormal $guard out of scope interruption - move all non transaction related code outside of the scope - add error handling when methods such as update_item, and a like do not return the expected data, instead of simply going out of scope and resulting in an uncontrolled reply Role/API: - rework transaction control: + get_transaction_control() is renamed to start_transaction() to better reflect what it does + complete_transaction() is renamed to commit_transaction() + remove unused %params arg + pass $guard into commit_transaction() instead of having it stored as $c->stash->{transaction_guard) that caused the $guard ref to be destroyed much late than expected (there was also a typo as transaction_quard, which is not relevant anymore with the changes + add check_deadlock() that is invoked when an exception is caught or an $c->errors contain an error, and if the error message represents a transaction error, the transaction block is re-invoked via "goto TX_START" - rework error(): + it now accepts args as following: ($self, $c, $code, $message, @errors) # code -> returned as HTTP code in the reply # message -> returned as HTTP message in the reply # errors -> contain errors for internal logging, last element often contains a DBIx exception + populates all @errors into $c->error so they are available on demend in the code via $c->error or $c->last_error + $c->log->error is not invoked now as the errors become printed in log_response() - log_response() now prints collected errors from $c->error correctly as a separate log line, that is alike to the other api logs so that those can be looked up by the request's tx_id, also all errors are now printed only into api.log * Adjust all $self->error() calls in catch($e) to include $e as the last argument, as well as the duplicate $c->log->error is removed from those ocassions * Remove all $c->log->error() calls as they are replaced with either $self->error() (that logs it correctly into api.log) or $c->error('err') that also adds it correctly into api.log * API::CallForwards: rework to use Entities/EntitiesItem * API::Contracts: rework POST to use Entities * API::PeeringGroups: rework POST to use Entities * API::SubscriberRegistrations: rework POST to use Entities * API::RewriteRuleSets: improve create_item() functionality * Utils/Message: add 'api_retry' log type * $c->session->{api_request_tx_id} is changed to $c->stash->{api_request_tx_id} because sometimes the session ref is different and a different tx_id becomes used Change-Id: I633ce7a8047b1bf00a2f6889003088edf0825dcd	1 year ago
Rene Krenn	308a974059	MT#58762 harmonize restapi wildcard filters - all standard LIKE search are migrated - will avoid LIKE unless a pattern (* wildcard) is used as a search term. this encourage db index usage, will be faster - supports wildcard escape sequence \\* - harmonize swagger UI descriptions of filters Change-Id: Iea155871c9be6c284e6970a562d4e6af73fedc4b	1 year ago
Kirill Solomko	a8bc49408a	TT#182053 Header Manipulations feature is hidden for CE * "Header Manipulations" UI is now hidden for CE * /api/headerrulesets is now hidden for CE * /api/headerrules is now hidden for CE * /api/headerruleconditions is now hidden for CE * /api/headerruleactions is now hidden for CE Change-Id: I717b9d3cdf693f01e32f81086b69aafce4f3113a	3 years ago
Flaviu Mates	1e7762e0b7	TT#74525 - Updgrade /api/headerrulesets * Introduce posibility to provision rule sets, rules, condition and actions at the same time using only the /api/headerrulesets endpoint; also rules can be modified with PUT/PATCH on /api/headerrulesets Change-Id: I8c054f72a2632d45fec76166774521f8c22aea05	5 years ago
Kirill Solomko	2a6dffa62e	TT#47010 add per subscriber header manipulations * UI: subscriber Preferences" page now contains a new "Header Manipulations" tab that enables setting header manipulation rules per subscriber. They are applied in the following order: - domain header rule set is applied (if defined) - subscriber header rules are applied (if defined) An internal header rule set is now created per subscriber automatically, if used from the UI * API: /api/headerrulesets now supports "subsriber_id", when a whole collection is fetched without ?subscriber_id only records where subscriber_id = NULL are returned by default * fix "read only" UI elements representation in the datable for header rule sets, rules, conditions, actions Change-Id: I3e80d1899c577055f3603e80bb3a13d70c5b22cf	6 years ago
Kirill Solomko	13d121618f	TT#47004 Implement Header Manipulation API endpoints Change-Id: Id15f087511e6c71b4507a73cdb03caf10d3661e6	6 years ago

6 Commits (205b27a2676efa51df1ee51a6731c7fe9942422a)