Also call agent request in the update_item method, to make it more safe.
And added lost transaction commit
Fix 500 response for the incorret x3_port input
Change-Id: Ic538ffdd4d7fff833ba5395934a1b2bc6cf71664
The codebase does not use autodie directly, it does indirectly via
Sipwise::Base, and the autodie module is part of the standard perl
distribution anyway. TryCatch is imported via Sipwise::Base, and
that depends on it. The rest are not used anymore in the codebase.
Change-Id: Ic08e246cc60d7d151381dff39e0eba517a492e06
+prohibit deletion of lnp providers if numbers are
still linked to it
+number+provider must be unique
+fixed other panel lnp page validation checks
+db constraints to stand concurrent inserts/updates
+fixup all txn_do die() calls in panel to properly
display the error
+bulk upload checks by db constraints
+lnp api testcase
Change-Id: I872b19f50d96e6c39c7fd5728b2a16555a397236
- the connector name is properly set when creating a reseller
- the network tag defaults to just (sip,xmpp,webrtc,...)
- rtcsessions doesn't accept network tag anymore
- an rtc-account is created for every network of the rtc-user
- the identifier in the rtc-account is set according to the specific connector
- api-rtc-full.t has been simplified for the user (no more need for domain_id)
- update available networks (in reseller api)
Change-Id: I2700c646726a06569cc5a70a5a30d4cb67eb1c80
+creation of profile packages with hour and minute
intervals was disabled in api-balanceintervals.t
Change-Id: Idd18ced9704522bf5d919155d866c91b81526b92
If no subscriber existed, first is a pilot, and doesn't consider groupmembers.
Also fix getting created hal, which was unconditionally overwritten by loaded
Change-Id: Ie2cf76624f125dbc9aaffc1ffab19319028c2c6f
by choosing "stable" (about 1m30s) or "fast" (about 30s) as second
argument of testrunner, only tests are run, which are currently
succeeding on a plain trunk vm using docker. (times are on my machine)
I hope we can in this way re-enable them on nightlies (or even in gerrit)
so that devs have some better feedback on the impact of our changes.
Current status of tests (in trunk):
| Problems:
| api-callforwards.t
| api-balanceintervals.t
| api-faxes.t
| api-journals.t
|
| Fixed:
| api-all-links.t
| api-contracts.t
| api-customercontacts.t
| api-customers.t
| api-rewriterulesets.t
| api-root.t
|
| Working:
| api-billingfees.t
| api-billingnetworks.t
| api-billingprofiles.t
| api-billingzones.t
| api-calllists.t
| api-calls.t
| api-cert-auth.t
| api-cfdestinationsets.t
| api-ncoslevels.t
| api-pbxdevicemodels.t
| api-pbxdevices.t
| api-peeringgroups.t
| api-peeringrules.t
| api-peeringservers.t
| api-preferences.t
| api-profilepackages.t
| api-resellers.t
| api-rewriterules.t
| api-soundsets.t
| api-subscriberregistrations.t
| api-subscribers.t
| api-systemcontacts.t
| api-threads.t
| api-topuplogs.t
| api-trustedsources.t
| api-valid-patch.t
| api-vouchers.t
Change-Id: I74e672d9dc6bcccfd3ace2fe233dbcf325c6fc4d
+input validation for verlapping time ranges
for both weekdays and special. can be disabled.
+root entiy locking
+peektime special is growing and not paginated,
so PUT/PATCH will get slower if special peektimes
are added on a regular basis. they can be removed
using the UI however
+testcase to check overlap detection
Change-Id: I935d943078ab5c81263da88ecd04e004deb26c8b
Otherwise we are failing with error:
> t/api-rest/api-faxes.t ..
> ok 1 - check faxserver feature state: disabled
> ok 2 - check error message in body: Faxserver feature is not active
> # Tests were run but no plan was declared and done_testing() was not seen.
> Dubious, test returned 254 (wstat 65024, 0xfe00)
> All 2 subtests passed
>
> Test Summary Report
> -------------------
> t/api-rest/api-faxes.t (Wstat: 65024 Tests: 2 Failed: 0)
> Non-zero exit status: 254
> Parse errors: No plan found in TAP output
Change-Id: Iff32b25ced931931af8cbaedc7fb054e48773667
Otherwise we are getting error:
> not ok 10 - Check existence of rating_status field
>
> # Failed test 'Check existence of rating_status field'
> # at t/api-rest/api-calllists.t line 50.
> # Total number of calls: 0
Change-Id: I257e198b740363d5d25d6d35a29a482f966377fb
+subscriber instead of source_subscriber typo fixed
+rudimentary test case to see if the filter works
+fixed in/out direction filter testcase: sum of in and
out calls should be >= total count of calls
Change-Id: Ibe4b8153f023c53bb463626ad9e6613992fc101d
+basically, the fix means to set
billing.contract_balances.start
billing.contract_balances.end
billing.contracts.create_timestamp
billing.contracts.modify_timestamp
to the 'local' timezone.
+test cases added
Change-Id: I203f8fc93df2b53c1cfe89bb1a90cdf6388e20b3
Fix faxserversettings PUT/PATCH processing found after faxes tests run
MT#15441 Tests for subscriber number changes
MT#12347 Test framework small fixes and additions
Some format changes and unused library removals
Add put_and_get method as common
Replace request_get & check 200 with check_item_get
Changes for API that doesn't return created object json after POST
Complete base_uri using replacement with normalize_uri
Change-Id: Ia31a97eb9511f1ca1de63c72bcbe380b89dfed34
any *attempt* of a top-up request should be
logged.
+create top-up log records for api
in order to record failed top-up requests as well,
the somewhat tricky thing is to have two
separate transactions here
+propery casting of topup request json field
values to numbers etc., so the transaction for
creating the log entry cannot fail and e.g.
requests with subscriber_id='blah' are recorded
correctly
+new "request_token" parameter for /api/topupvoucher
and /api/topupcash, to identify and filter for
particular requests.
+topup log api resource
+topup log api tests
+fix to correctly reject used vouchers
+topup log panel UI
+fix for balanceintervals.t threaded tests
Change-Id: I86eb845f6173803705b12cc7e5cdbac9a3153a0a
+refactoring recent failing api-balanceintervals.t test to
need only two concurrent transactions (instead of three,
see https://bugtracker.sipwise.com/view.php?id=15277
Change-Id: I4902e616c3adfae81676194fa5e2b99e4b516ed1
For usage instructions please look at the bottom of the Dockerfile,
usage similar to what we already have for the docker selenium tests.
Known problems:
1) In t/api-rest/api-journals.t there's a failure, though all the tests
actually seem to run fine then:
| encountered object 'true', but neither allow_blessed nor convert_blessed settings are enabled at /usr/share/perl5/JSON.pm line 154.
| # Tests were run but no plan was declared and done_testing() was not seen.
| # Looks like your test exited with 255 just after 1130.
| [...]
| t/api-rest/api-journals.t (Wstat: 65280 Tests: 1130 Failed: 0)
| Non-zero exit status: 255
| Parse errors: No plan found in TAP output
| Files=25, Tests=8363, 347 wallclock secs ( 1.14 usr 0.11 sys + 32.59 cusr 2.23 csys = 36.07 CPU)
2) Failures in t/api-rest/api-balanceintervals.t, might be caused by
timing issues/rerunning them, needs investigation though:
| t/api-rest/api-balanceintervals.t (Wstat: 65024 Tests: 1875 Failed: 318)
| Failed tests: 51, 56-59, 62, 67, 70, 75-80, 83, 88, 108-109
| [...]
Change-Id: I5d697cab4a1a4c6697857fc63c03b8d3fd8965d2
making tests finally compatible with jessie.
there is one test left using certificate auth now,
the others use password auth. this enables us to move
the certificate logic out of Module::Build.
also, sipwise::base has been mostly removed from the
modified files.
Change-Id: Id0d9172c2f3f7ca2b69eaa9f16eeb99dc1d6ea11
in short: whenever the contract_balances "cash_balance" is
about to decrease, it might drop below thresholds defined
by a contract's profile package. in that case, subscribers
are to be locked and/or underrun billing profile sets are
to be applied. this commit also contains some minor fixes:
+when creating/editing profile packages, all billing
profiles of initial, topup, underrun sets must show the
same interval_free_cash and interval_free_time values.
there was also a problem with adding profile sets to
packages that use profile with prepaid = 1 (see ticket
14301)
+when editing packages using the panel UI, the validation
was not properly invoked (!) +the frequency of topups has
to be limited to 1 per second.
+updating the "lock" subscriber prior to editing or viewing
it in the panel UI was added.
+topup cash and topup voucher panel UI added
+when aquiring multiple contract row locks at once, no
joined tables are used any mure. the number of row locks
is therefore minimal now (see ticket 14903)
+rework of updating prepaid subscriber preference
Change-Id: Ideb0fec2404ca10b3ac5d8735f53620d0c3a24ed
MT#14779 Add default value for the q parameter
MT#14891 Consider form validation for the POST request (create location)
MT#14789 Remove user_agent registration parameter
Change-Id: I9f81ec3ec5c308c731b3dfe6aa5f075c7d7b50ab
Irina Peshinskaya
Andreas Granig
Guillem Jover
Alexander Lutay
Gerhard Jungwirth
Rene Krenn
Kirill Solomko
Victor Seva
Michael Prokop