ngcp-panel

Commit Graph

Author	SHA1	Message	Date
Sipwise Jenkins Builder	7fe81764ef	Release new version 12.2.1.16+0~mr12.2.1.16	10 months ago
Kirill Solomko	ac3a3ceeab	MT#60300 fix sound sets list rendering for reseller * fix code typo that prevented correct rendering of the sound sets list for reseller roles Change-Id: I35ea38a37932b8dd563a0b95f7e2481a5c45cdbe (cherry picked from commit `c7ae8c1dcf`) (cherry picked from commit `943e289604`)	10 months ago
Sipwise Jenkins Builder	c5671745f8	Release new version 12.2.1.15+0~mr12.2.1.15	1 year ago
Kirill Solomko	c69c42c9bc	MT#56301 move lock_provisioning_voip_subscriber before underrun_lock * POST /api/subscribers/ invoke lock_provisioning_voip_subscriber() before underrun_lock(), so that if the subscriber is about to be locked due to customer balance costs, the lock_provisioning_lock_subscriber() invocation will not unlock it back straight after Change-Id: I55020f844c9aa76df2e2f057a88b2ae7c9ebbfcc (cherry picked from commit `c6aaaddd87`) (cherry picked from commit `c6faf74c2d`)	1 year ago
Rene Krenn	a77fd2c8d5	MT#56301 set locklevel of created subscribers only if specified Change-Id: I90f2d68dee50ab240de4eb5af7495ddd551c00d8 (cherry picked from commit `df670f501f`) (cherry picked from commit `86aae59d4a`)	1 year ago
Marco Capetta	c55220f7df	MT#56301 Fix API creation of an active subscriber with lock Using API is possibile to edit an existing subscriber and set status: active and lock: 2. It is instead impossbile to create a new subscriber with the same configuration because the 'lock' param is not taken into account. The only way to properly setup lock level it is to set the status to 'locked' and this is in fact wrong. The fix address this issue and allow now to create a new subscriber with status: active and lock: 2. Change-Id: Id18e40bc001c5a7de30f5d148231bda93a3b1b3d (cherry picked from commit `8945b8a5ac`) (cherry picked from commit `be2b9dd95d`)	1 year ago
Sipwise Jenkins Builder	cd4c789e3d	Release new version 12.2.1.14+0~mr12.2.1.14	1 year ago
Kirill Solomko	9d26f395fb	MT#59835 /api/billingzones fix HAL ngcp:billingfees relation * billing fees relation was rendering all associated billing fees and that was causing huge data sets to be returned if a billing zones had many fees, now instead a single link is returned /api/billingfees/?billing_zone_id=:id. this is also on par with other links like /api/billingfees/:id Change-Id: Iabb7afb3bf43abf9a22c71750d45a1962a7f16ec (cherry picked from commit `e4cda08bd4`)	1 year ago
Sipwise Jenkins Builder	d32cc0cada	Release new version 12.2.1.13+0~mr12.2.1.13	1 year ago
Nico Schedel	dfd0745f5d	MT#55677 fix all ngcp-panel-selenium tests Change-Id: I7f1f1e5fe9632dad233818b3a43b78a54ff97b98 (cherry picked from commit `1fdaa6bd47`)	1 year ago
Sipwise Jenkins Builder	48ff369a0a	Release new version 12.2.1.12+0~mr12.2.1.12	1 year ago
Kirill Solomko	a8365ac67e	MT#59806 add missing cfdestinationsets HAL link type * add missing: "_links" : { "ngcp:cftimesets" : [ .... ], in the collection representation Change-Id: I59fade61ae2679833c43fd5501d14ca45a376572 (cherry picked from commit `c006e9efc1`)	1 year ago
Sipwise Jenkins Builder	931ff1dc78	Release new version 12.2.1.11+0~mr12.2.1.11	1 year ago
Kirill Solomko	58d86e61d9	MT#59806 adapt /api/cfdestinationsets to Entities * Entites logic is used for GET/POST/PUT/PATCH/DELETE * Utils::CallForwards::check_destinations() do not obfuscate destinations that are returned in the response as all logged data is obfuscated anyways Change-Id: Ia79f9e236c966410e2640d719c3a7f5784cc4c2a (cherry picked from commit `b2a1bc00d1`)	1 year ago
Sipwise Jenkins Builder	aced482494	Release new version 12.2.1.10+0~mr12.2.1.10	1 year ago
Kirill Solomko	97cd36de77	MT#59478 Entities/EntitiesItem more $c->has_errors checks * additional $c->has_errors checks for post/patch/put/delete to cover all possible expected called inherited methods scenarios and returns. Change-Id: I0e09ba62bcaa51d582315d9cbb672a4cf11bacf0 (cherry picked from commit `1872f342a0`)	1 year ago
Kirill Solomko	d878e3568b	MT#59478 adapt /api/cftimesets to global transactions, more fixes * /api/cftimesets now fully use Entities/EntitiesItem * EntitiesItem: delete(): fix delete_item() expression processing * Entities/EntitiesItem: post/put/patch/delete: go to TX_END in scenarios where after a method call (e.g. update_item()) there is a normal return from the function but errors in $c->error, so that they are also caught correctly Change-Id: I3bef409ded590796c2bba4f30acd28b02e99065b (cherry picked from commit `9e3653341a`)	1 year ago
Sipwise Jenkins Builder	0399550c56	Release new version 12.2.1.9+0~mr12.2.1.9	1 year ago
Kirill Solomko	19440b68a3	MT#59478 /api/ root error handling * clear errors in Controller::API::Root::end so that they are not interfere with generated ones * API::error(): add $c->stash->{is_api_error_response} = 1 to track it in log_response() * API::log_response(): distinguish and correctly correct errors for cases when is_api_response == 1 and also when there were $c->error('error') calls in the code, to log them correctly in both cases Change-Id: Id922b8219832c1b99815d9d608309035b9b25cff (cherry picked from commit `91f1dcf37e`)	1 year ago
Kirill Solomko	a7b559c59b	MT#59478 Entities fix non-existing $item handling in put/patch/delete * the error produced by item_id_is_valid() is returned instead of a new one is generated * fix incorrect expression on delete_item() in delete() Change-Id: Ic8e4e24c70bbcd99ec414d901eb2842ee39ae7de (cherry picked from commit `4e2e141308`)	1 year ago
Sipwise Jenkins Builder	22f93afec8	Release new version 12.2.1.8+0~mr12.2.1.8	1 year ago
Kirill Solomko	d43c403efe	MT#59797 /api/headerruleconditions (actions) fix reseller role * fix resultset when user role is reseller so that reseller_id is joined correctly and a db error is not produced anymore. Change-Id: I2a1b357037d983f23770bb59519fc2cb8b68a7e4 (cherry picked from commit `bf249f9d96`)	1 year ago
Sipwise Jenkins Builder	b3384db6b4	Release new version 12.2.1.7+0~mr12.2.1.7	1 year ago
Kirill Solomko	27909d4eb3	MT#59478 improve MSG, LOG log string data storing * $c->error array now contains the $message as the first element instead, so that it's possible to obtain all the error data in the code when fetching it from @{$c->error}. the first element is not logged in the error log. * api_response $c->response_body part is now stored in MSG= and possible errors / other log data is now stored in LOG= to: - reduce amount of log lines when an API error response occurs from 2 to 1 - the message part usually contains either HTTP response message (e.g. Internal Server Error) or a validation message string, so it belongs to the MSG= part of the log line, where as the internal log data is more related to the LOG= part - both MSG= and LOG= parts are escaped for GDPR related obfuscation * Utils::Messag::info(): $msg is now also obfuscated if it's detected as a reference (also because logging is moved for the API part to $msg), as well as truncated for possible new-line char and white-spaces. Change-Id: I3b670b2251ec3060037ed6863f18d95975120b8d (cherry picked from commit `9d598d4502`)	1 year ago
Sipwise Jenkins Builder	a19b4e710a	Release new version 12.2.1.6+0~mr12.2.1.6	1 year ago
Kirill Solomko	bd0ae9f4aa	MT#59478 /api/contracts address $now and hal_from_contract * the following changes resolve an issue where $now in Role/Contracts resource_from_item appeared as an object and failed subsequent logic: - hal_from_contract is renamed to hal_from_item to match correctly the parent method - call hal_from_item and pass $now string there correctly as $params { now => $now } Change-Id: I5c02d5f7df5d9000550505ad120b9531f87e8d65 (cherry picked from commit `9dbd6b0e88`)	1 year ago
Sipwise Jenkins Builder	db11e56919	Release new version 12.2.1.5+0~mr12.2.1.5	1 year ago
Kirill Solomko	6855b3f5bf	MT#59478 API better transaction and error handling * Role/Entities: POST/PUT/PATCH/DELETE methods changes: - support deadlock detection and transaction retry (2 retry attempts at the moment) - improve transaction control, use local $guard instead of saving the ref to $c->stash, as in that case it went out of scope too late and also reported an error message into the log about abnormal $guard out of scope interruption - move all non transaction related code outside of the scope - add error handling when methods such as update_item, and a like do not return the expected data, instead of simply going out of scope and resulting in an uncontrolled reply Role/API: - rework transaction control: + get_transaction_control() is renamed to start_transaction() to better reflect what it does + complete_transaction() is renamed to commit_transaction() + remove unused %params arg + pass $guard into commit_transaction() instead of having it stored as $c->stash->{transaction_guard) that caused the $guard ref to be destroyed much late than expected (there was also a typo as transaction_quard, which is not relevant anymore with the changes + add check_deadlock() that is invoked when an exception is caught or an $c->errors contain an error, and if the error message represents a transaction error, the transaction block is re-invoked via "goto TX_START" - rework error(): + it now accepts args as following: ($self, $c, $code, $message, @errors) # code -> returned as HTTP code in the reply # message -> returned as HTTP message in the reply # errors -> contain errors for internal logging, last element often contains a DBIx exception + populates all @errors into $c->error so they are available on demend in the code via $c->error or $c->last_error + $c->log->error is not invoked now as the errors become printed in log_response() - log_response() now prints collected errors from $c->error correctly as a separate log line, that is alike to the other api logs so that those can be looked up by the request's tx_id, also all errors are now printed only into api.log * Adjust all $self->error() calls in catch($e) to include $e as the last argument, as well as the duplicate $c->log->error is removed from those ocassions * Remove all $c->log->error() calls as they are replaced with either $self->error() (that logs it correctly into api.log) or $c->error('err') that also adds it correctly into api.log * API::CallForwards: rework to use Entities/EntitiesItem * API::Contracts: rework POST to use Entities * API::PeeringGroups: rework POST to use Entities * API::SubscriberRegistrations: rework POST to use Entities * API::RewriteRuleSets: improve create_item() functionality * Utils/Message: add 'api_retry' log type * $c->session->{api_request_tx_id} is changed to $c->stash->{api_request_tx_id} because sometimes the session ref is different and a different tx_id becomes used Change-Id: I633ce7a8047b1bf00a2f6889003088edf0825dcd (cherry picked from commit `205b27a267`) (cherry picked from commit `92be5bb3df`)	1 year ago
Sipwise Jenkins Builder	ad86369ec9	Release new version 12.2.1.4+0~mr12.2.1.4	1 year ago
Rene Krenn	40942537dd	MT#59434 always take aliases from voip_numbers in case the DB shows discrepancy because of missing primary provisioning.voip_dbaliases records, align with legacy panel behaviour and also take the restapi aliases list from voip_numbers, instead of voip_dbaliases. .. while trying to keep the performance gain from https://gerrit.mgm.sipwise.com/c/ngcp-panel/+/65086. Change-Id: Ibd7f8c8bc6a39ae2c31b4e8818080674ab77d66c (cherry picked from commit `740bb764e5`)	1 year ago
Rene Krenn	f6e8550d9f	MT#56817 MT#56362 fix query param sorting for regulary chained rs Change-Id: I82d3a0ce67ffb61273fc716016885f6431852eff (cherry picked from commit `c837dc1043`)	1 year ago
Rene Krenn	5d27c6a368	MT#56817 MT#56362 fix query param sorting for rs chained the regular way Change-Id: I0dab56ae07666eb695d7f30ef633a876ff8258fb (cherry picked from commit `aae0b7e071`)	1 year ago
Rene Krenn	c4b867faf8	MT#56817 MT#56362 fix errors from nondetermistic query param ordering the /api/callists rail supports the "call_id" query parameter to match calls with a callid prefix. this filter also adds an implicity ordering ORDER BY length(call_id) ASC, 'start_time' ASC. the /api/callists api rail also requires the query parameter "susbcriber_id", which renders a (fast) compound SQL query to list matching incoming (query1) and outgoing calls (query2) using UNION ALL (instead of a slow OR query). query1 UNION ALL query2 this is supported by the https://metacpan.org/pod/DBIx::Class::Helper::ResultSet::SetOperations module, which however generates invalid SQL syntax if query1 or query2 contains an ORDER BY. this is exactly what caused the 500 error of the customer who applied both "call_id" and "susbcriber_id" parameter in the request at the same time. ... ORDER BY length(call_id) ASC, `start_time` ASC UNION ALL SELECT `me`.`id`... the error happens randomly, because query parameters are stored in a hash (which by definition has no deterministic order of the entries). when the "call_id" parameter is applied at last, it worked as expected. so the issue can be adressed by strictly ordering the UNION ALL result, and prohibit ORDER BY in query1 and query1. the latter was added already with commit `b2dfe28eed`, and could be hotfixed. however, the ORDER BY of "call_id" query param is lost, and should be properly handled by forcing strict ordering of how query parameters are applied. the fix will introduce paramater ordering according to their order of definition in the code. Change-Id: I165d341b5c20e9bb750bd1fba88c836b393e80bd (cherry picked from commit `a15d00894a`)	1 year ago
Rene Krenn	05f08564c4	MT#59216 restore appending wildcard behaviour with the change to harmonize wildcard symbols % and * to * in query param filters across all restapi rails, only - /api/subscribers?alias= - /api/subscribers?pbx_extension= - /api/subscribers?primary_number= - /api/pbxdevices?pbx_extension= are supposed to include implicit leading an trailing wildcards. panel UI uses trailing wildcard by default everywhere, and so should the databales of the new Admin UI. external_id were used to support patterns, but must not include a trailing wildcard in rest API, as this can break logic that rely on unique api request results. we now therefore no longer append wildcards in particular to: - /api/voicemails?folder= - /api/voicemailgreetings?type= - /api/subscribers?subscriber_external_id= - /api/subscribers?customer_external_id= - /api/subscribers?display_name= - /api/subscribers?domain= - /api/profilepackages?profile_name= - /api/profilepackages?network_name= - /api/pbxdevices?display_name= - /api/faxserversettings?name_or_password= Change-Id: I40ef1912d7224a56c6d14619d258c70e447ab23d (cherry picked from commit `672a3110bc`)	1 year ago
Sipwise Jenkins Builder	013cb7ab66	Release new version 12.2.1.3+0~mr12.2.1.3	1 year ago
Kirill Solomko	c01d977a0e	MT#59238 fix rewrite rules transaction control for PATCH,DELETE * /api/rewriterules PATCH, DELETE methods used the generic transaction, which conflicted with the xmlrpc reload command. * own_transaction_control was only set for PUT and now also extended to PATCH, DELETE to ensure that dialplan_sip_reload() is called properly after $guard->commit. Change-Id: I7313b4f6d1f6699bf38ae34749c5383a3943f61d (cherry picked from commit `80f8b1da0b`)	1 year ago
Sipwise Jenkins Builder	edd99beef1	Release new version 12.2.1.2+0~mr12.2.1.2	1 year ago
Kirill Solomko	a69a8ca46b	MT#58709 rework NGCP::Utils::Sound::get_handlers_rs * get_handlers_rs() is renamed into get_file_handles() and reworked from an indented 'from' resultset into 2 separate resultsets, one fetching all the handles and another one files for the sound set, it is now returned as an array with the similar data. Reason for this rework is the deprecated use of 'from', that resulted in a lot of warnings in panel-fcgi.log: DBIx::Class::SQLMaker::ClassicExtensions::_join_condition(): ResultSet {from} structures with conditions not conforming to the SQL::Abstract::Classic syntax are deprecated: you either need to stop abusing {from} altogether, or express the condition properly using the { -ident => ... } * adjust file_handles data key names to better follow the naming conventions and readability, e.g.: groupname -> group_name, fileid -> file_id Change-Id: Ia91c9104c0b4dc79ee5bc359eb0b6e035e56ef3e (cherry picked from commit `a4d54b10e4`)	1 year ago
Sipwise Jenkins Builder	48fd5127d4	Release new version 12.2.1.1+0~mr12.2.1.1	1 year ago
Sipwise Jenkins Builder	b4ae91816d	Release new version 12.2.1.0+0~mr12.2.1.0	1 year ago
Kirill Solomko	b6b453d69d	MT#59001 improve phonebook csv upload * the expected csv fields are as following: - /api/resellerphonebookentries/?reseller_id=1 name,number - /api/customerphonebookentries/?customer_id=1 name,number - /api/subscriberphonebookentries/?subscriber_id=1 name,number,shared - /api/resellerphonebookentries/ name,number,reseller_id - /api/customerphonebookentries/ name,number,contract_id - /api/customerphonebookentries/ name,number,shared,subcriber_id (note: the fields are taken from the leftmost side as the minimum required fields, so if one provides as: - /api/resellerphonebookentries/?reseller_id=1 name,number,reseller_id this line will be uploaded and columns after 'number' are ignored in this case. this is for convenience if you have a prepared upload for different customers/resellers for instance, you can upload it under one customer/reseller when needed * user access scope is now validated, e.g.: resellers cannot upload phonebook entries to another resellers, etc. * fix csv upload for /api/customerphonebookentries/?customer_id=1 Change-Id: I970ac36fdb8b366adff15515a48d296e8abeff13	1 year ago
Rene Krenn	1e9f223276	MT#59025 fix peering groups name filter Change-Id: I329e644c937058069c5932abf8e897dce48a8c10	1 year ago
Kirill Solomko	1dabb6051d	MT#58989 /api/customers add type query param * add 'type' query param to filter by customer type 'sipaccount' or 'pbxaccount' Change-Id: If372cc69cf16c92551824504da7695a65dc867b3	2 years ago
Rene Krenn	cc8fd8928d	MT#58890 force cft_ringtimeout as number Change-Id: I4df4fbf6522d28a30731c87a36c95ae8350830fa	2 years ago
Rene Krenn	2101e2246d	MT#58936 fix customerzonecosts resourcename Change-Id: I22b052bc6931e5426e1aa982396c446cb1c67883	2 years ago
Rene Krenn	73a967bfb6	MT#58762 adjust restpi tests v2 to harmonized wildcard filters #1 Change-Id: Icdf581f425f5e28ba22480424f04355181b4f3b3	2 years ago
Rene Krenn	bad2e32802	MT#58762 adjust restpi tests v2 to harmonized wildcard filters Change-Id: Ie100612c9f284e9acad6b305345751bb07adfab9	2 years ago
Rene Krenn	853bc9f535	MT#58936 direction filter param for /api/customerzonecosts Change-Id: Ie831381576ffdb2a08375cf73bc66c1c5e6d2076	2 years ago
Kirill Solomko	462bfedc43	MT#58861 /api/headerruleconditions accept values as a list of strings * {"values:", ["value1", "value2"]} is not accepted by /api/headerruleconditions * the previous behaviour of {"values": [{"value": "value1"},{"value": "value2"}]} is preserved Change-Id: I7d9540d20ed0ecbb2712f1905a7d9e6f7af7e06d	2 years ago
Kirill Solomko	8985839509	MT#58834 fix headerrule conditions/actions dp_id check * address a 500 error when rwr_set_id is specified but empty and dp_id is also specified Change-Id: I0160a3c2f6b3cf139935c4e2daf7e1635dafb99a	2 years ago

1 2 3 4 5 ...

5424 Commits (mr12.2.1) All Branches Search

5424 Commits (mr12.2.1)

All Branches