107 Commits (master)

Author	SHA1	Message	Date
Marco Capetta	f9a328f83d	MT#61065 Fix 'cli' preference removal ... In commit b51c0c9698 the possibility to change the 'cli' preference by subscriber and subscriber_admin was added (under certain limits). On the other hand, the additiona of that part of code broke the possibility to remove the preference using the PATCH api. It is a very uncommon scenario though, but it seems anyway used by some customer. We may think to deprecate this possibility one day, but till then we don't have to create regression to customer. Change-Id: Ie695b567929eb79b1ba63d3c5a31ae5ce7b559bd	7 months ago
Kirill Solomko	9d021be65a	MT#59979 add license control ... * UI and API parts are now under license control * new Util::License::get_license($c, $name) - fetches license status by name (1 if enabled, and also if /proc/ngcp/check if 'ok') * add Catalyst::Plugins::NGCP::License with license($name) to fetch valid license by name from anywhere using $c->license('pbx') or from the templates using c.license('pbx'). It internally uses Util::License::get_license($c, $name) * License::get_license_status($c) now requires $c as first argument as well logs license status check errors. * new ActionRoles::License that enables usage of :Does(License) RequiresLicense('pbx') LicenseDetachTo('/denied_page') in the Controller chains * Add license control for UI elements and return 403 Forbidden if a resource is covered by licenses and the license is not active * Hide UI elements if a license is not active * API/Entities/Entities new $c->set_config key: - per endpoint: $c->set_config({ required_licenses => [qw/pbx device_provisioning/] } - or per method: $c->set_config({ required_licenses => { POST => [qw/pbx device_provisioning/] } } } * In case if an API endpoint does not have a license: 403 Forbidden "Invalid license" reply is returned. * Add license based restrictions to API endpoints * /api documentation: - completely hide endpoints that do not have an active license - hide only methods that does not have an active license Change-Id: Iba45fc5068b02306a617fed7b5405f2210574b61	9 months ago
Kirill Solomko	0c4800fbb0	MT#58409 /api/profilepreferences fix filtering for admins ... * as now all profile preferences should be visible for admin users, the excessive _check_profile() filtering is removed, as well as it improves the performance due to less sql queries (was 1 extra query per preference). the preferences based on attributes are correctly filtered for subscriber and subscriberadmin 'roles'. Change-Id: Ifaa8c7de1f73d07fce3ef0df725a01f1c5d5d80c	2 years ago
Donat Zenichev	565c25481b	MT#57376 Add support of 'peer_auth_registrar_server' preference ... We have to support new preference for: - `create_peer_registration` - `update_peer_registration` - `delete_peer_registration` If there is no `peer_auth_registrar_server` value provided, then use a realm value instead. Change-Id: I39d3a917c9f11c1d4cfa0781fe5a3cee11d9eeea	2 years ago
Rene Krenn	dd9d57c33b	MT#57070 ignore undef enum.default_val ... while provisioning.voip_preference_enums.default_val is supposed to be a flag variable, it is NULL for some prefs. we prevent a 500 error when editing such value in this case now. Change-Id: Idc5e0f1f0de93f9d0b6645982025c8b45bae1ec4	2 years ago
Kirill Solomko	44ec794db2	MT#56693 add parent sound set support ... * sound sets can now use other sound sets as parents, in this case if a sound is missing for a sound set, it's taken from the parent one if it exists there, chained parents are also supported with the available sound files "accumulated" across them. * add "expose_to_customer" field to sound sets, it enables exposing system sound sets to customers so they can be used as a parent or assigned to the 'sound_set' preference by 'subscriberadmin'. * add "use_parent" field to sound set files, it's true by default (for existing or missing sound files) and if set to 0, then parents are not used for this particular sound file. * use_parent column is hidden on the UI if a sound set does not have a parent assigned * improve sound set handles list on the UI - Upload is renamed to Add - empty record are shown in the filename column as localised "(empty)" and Edit/Delete action buttons * API /api/soundsets new 'parent_id' field, default null * API /api/soundfiles new 'use_parent' field, default 1 * API /api/soundsets new 'expose_to_customer' field, default 0 * API /api/soundsets customer_id field now contains the customer id for 'subscriberadmin' role and 'null' if it's a system sound set * system sound sets with expose_to_customer == 1 and within the same reseller are now visible to 'subscriberadmin' on the UI and via the API in read-only mode, same with the sound files that belong to the sound set. If a system sound set expose_to_customer is set back to 0, this sound set is automatically removed from all contract sound sets where it was assigned as a parent as well as from all subscriber 'sound_set' preferences. * contract_sound_set|sound_set preference API updates now have tigher checks for contract_id and also if the system sound set is exposed to the customer and belongs to the same reseller Change-Id: I4908fd15e9c224d4c30794ceb8dae1b444bbf56a	2 years ago
Kirill Solomko	3c1842c122	MT#56802 fix preferences default values selection ... * preferences form with enum values now set the default one as selected if no preference is set yet. * disable autocomplete for the preferences table fields. this addresses Firefox using incorrect selected values even though the correct data is sent by the server. Change-Id: I6865eec05c085b89e651b125a7f35724859ccbc2	2 years ago
Kirill Solomko	80bf560b8d	MT#55687 add ncos_set preferences support ... * ncos_set preferences are now supported in the UI/API Change-Id: I0e479712d3f27a6ae5f8b77f06c616406e1742f5	2 years ago
Kirill Solomko	9254092a3f	MT#56234 get_usr_preference_rs and prov_subscriber ... * get_usr_prerefence_rs is streamlined to the other get_*_preference_rs functions and prov_subscriber param is now optional there, that allows to return a resultset of usr preferences matching the attribute name. * this fix also fixes DELETE soundset where if contract_id is defined, the logic tries to remove all 'contract_sound_set' usr_preference across all subscribers that have it assigned. Change-Id: Ia43327c8bcf93047d29da6401cbd97bce2971578	2 years ago
Kirill Solomko	673ac66c70	MT#56234 fix cli check for subscriber roles ... * cli preference assigned number is only checked when the user's role is subscriberadmin or subscriber Change-Id: I71f9207f4705eb1ae6f4ea0810dd3a1e541144cf	2 years ago
Kirill Solomko	b838c5d0e7	MT#56286 render all subscriber profiles with prof_pref = 1 ... * on the subscriber profile preferences page, only preferences that had enabled attributes plus had prof_pref = 1 were shown. that caused confusions as subscriber profile attributes are rendered from exposed_to_customer = 1 and do not use the prof_pref flag, whereas the rendered preferences do not use the expose_to_customer flag and use prof_pref = 1 instead. now to avoid the confusions, all voip_preferences that are not internal and have prof_pref = 1, shown in on the preferences page (and accessible via API). if the list needs to be reduced, then it must be properly done by removing the prof_pref flag for them. Change-Id: I7f2428e319d2c8d322ee5e4efd96615178c1f3ef	2 years ago
Kirill Solomko	8288a30f61	MT#56234 cli preference edit filter for subscriberadmin ... * Preferences::create_preference_form() now contains a check for 'cli' preference to only allow numbers that belong to the same customer if role is 'subscriberadmin' Change-Id: I8eb3bed928a943330ab0045d2893365b533b0c16	2 years ago
Kirill Solomko	6c179dd5c4	MT#56234 get_usr_preference changes ... * as_admin param is no longer needed as get_usr_preference() fetches actually set preference for a susbcriber and used only by the code (not exposed directly to 'subscriber', 'subscriberadmin' roles * with the aforedescribed, get_usr_preference() no longer filters by expose_to_customer, expose_to_subscriber for 'subscriber' and 'subscriberadmin' roles * refactor get_usr_preferences() to be simple and in line with the other get_*_preferences() as it's mainly responsible for fetching the preference as requested by the internal code Change-Id: Ia52d8f4ebfd854901bf446e29fb475dea1fba866	2 years ago
Kirill Solomko	6d487452bb	MT#56234 susbcriber preferences related changes ... * fix customer_view role name typo so that it's correctly limited to for 'subscriberadmin' role * revert behaviour of get_usr_preference_rs() to return undef if no preference is found (no access) * get_usr_preference_rs() now also fetches all internal preferences for internal work for 'subscriber' and 'subscriberadmin' roles but they remain invisible for them and not accesible for direct changes (only when requested by internal logic) * new get_usr_preference_rs() 'as_admin' parameter that enables for internal requests to return the preference value for 'subscriberadmin' and 'subscriber' roles, currently used to show 'lock' status and 'display_name', which are otherwise inaccessible as those preferences do not have expose_to_customer, expose_to_subscriber flags * fix api_prference_defs() correct filtering of preferences for 'subscriber' and 'subscriberadmin' roles Change-Id: I1a0e51ace1c649f9061deaccb7d6e9f8459f0ed8	2 years ago
Kirill Solomko	81d50cdce1	MT#56234 get_usr_preference_rs changes ... * get_usr_preference now always returns a ResultSet object as it expected. If there is no preference found an empty ResultSet object is returned that does not have ->first. That is now in line with how the usage of the function works in the current codebase and should not produce errors when there was a preference requested that did not exist and 'undef' was returned instead of an object. * remove 'skipping' debug code that caused a lot of spam in the panel-debug.log reporting skipped usr preferences for 'subscriberadmin' and 'subscriber' roles Change-Id: Ia9d033994e36afd48c2b6d91b08163f871a71b4c	2 years ago
Kirill Solomko	b51c0c9698	MT#56234 restrict cli preference allowed numbers for subscriberadmin ... * subscriberadmin can now only set numbers that belong to the customer as 'cli' Change-Id: Iecc2c5dc322e13292e1ec0d9262451c8947da671	2 years ago
Kirill Solomko	f1cc84c34f	MT#56234 add voip_preferences.expose_to_subscriber support ... * expose_to_subscriber is a new preferences flag that indicates that the preference can be read/modified by 'subscriber' role * expose_to_customer now only does the same as expose_to_subscriber but for 'subscriberadmin' role * get_usr_preference() not expects $params{$c} to be passed as an argument * fix update_voicemail_number() behaviour, it correctly updates number for subscribers of a subscriberadmin as well as no longer fails with an error if echo_voicemail_number or cli are not available (not set or not visible) Change-Id: I95fade92efb541146e9e56ba4f517af79fa71b5a	2 years ago
Rene Krenn	d7367fe1c3	TT#174407 support renaming in preference transformations ... in order to expose a pref "<current pref attribute>" in the rest-api under it's "<old pref attribute>" name, a preference "renaming" transformation can now be specified like this: www_admin: ... preference_in_transformations: ... <old pref attribute>: <current pref attribute> preference_out_transformations: ... <current pref attribute>: <old pref attribute> Change-Id: I17ad7d4f880d5760329465d60134df1c06f8fd08	3 years ago
Kirill Solomko	2efeb70e67	TT#179800 API peer server preferences fix reliance on reseller_id ... * peer server preferences such as rewrite_rule_set, header_rule_set, contract_sound_set, sound_set do not include reseller_id anymore when set for a peer server as peerings are platform wide Change-Id: I4276767649bc5f2f35aba3eacd0f566b960cf647	3 years ago
Rene Krenn	9d7990ef47	TT#178050 refactor /api/activesubscriberprefs impl ... Change-Id: I5c5e9ad3bd0c2331883b6857a2c3fd92baf31995	3 years ago
Kirill Solomko	23796e02b4	TT#158252 GET /api/subscriberpreferences fix ambiguous id ... * distinct alias name was missing in the prefetch structure Change-Id: I3a306160d96faa8a46bc8ae386d0c71f7d6cc59c	3 years ago
Kirill Solomko	38b48e860b	TT#158252 GET /api/subscriberpreferences performance ... * prepare_resource() use prefetch 'attribute' to address scenarios with high amount of preferences per subscriber Change-Id: I7a32ff9953ccf9a3cc7e482639c6bd3cdb28eb0f	3 years ago
Kirill Solomko	d7c7391644	Revert "TT#158252 API GET subscriberpreferences - fix DBI timeout" ... This reverts commit a6b5ac98c0. Change-Id: Ie9c70a0821db61cb2bc1634d54ae0f6d3a096a92	3 years ago
Rene Krenn	4df49f5639	TT#168050 fix allowed_cli check for duplicates ... Change-Id: I09874917c946b0e9be60ca1a0682f70c2d4f84df	3 years ago
Oleksandr Duts	a6b5ac98c0	TT#158252 API GET subscriberpreferences - fix DBI timeout ... * Add pref->attribute prefetching. * Remove unused contract balance calling. Change-Id: Idff3893beb42aa72bd04d6248a390ab6c89fe4a1	3 years ago
Oleksandr Duts	8af29b6470	TT#154351 Sound set propagation ... * Contract default sound set - subscriber propagation for cases: - New customer sound set is created as default. - Customer sound set is changed to default. - New subscriber creation - setting contract default sound set id. * The mentioned cases were implemented for both UI and API. Change-Id: Ia4733c972ae388d3457d0336e3f85b85eec6e9a2	3 years ago
Oleksandr Duts	ad6467561f	TT#149650 UI language handling ... * Change UI language workaround. Priority: 1. Parameter "lang". 2. Cookie "ngcp_panel_lang". 3. Default english - "i-default". * Add parameter "lang_save" - save the "lang" value at "ngcp_panel_lang" cookie. Change-Id: I0abc9e3ab564ba56d2e3f9b0dee47d32c27e0049	4 years ago
Kirill Solomko	da4278daa3	TT#145300 Adjust domains reseller_id handling ... * domains do not use billing.domain_resellers table anymore but instead the new domains.reseller_id field. That is to remove the unneeded many<>many relation through the additional table where the actual logic only supports one(reseller) to many(domains) relation Change-Id: I1b681543baf1901f19e10c2f6210e4cf6eeb8fbe	4 years ago
Donat Zenichev	df30292c6b	TT#66577 Add support of outbound registrations for SIP peerings ... We need to add an improvement, which fulfills the work of the registration mechanism for SIP peerings. Not only do we add here a registration tirggering for peerings, but also a 'type' is introduced, which is mostly needed for XMLRPC commands being sent towards SEMS, to let it understand to whom the $sid is related to. Plus a list of improvements: - de-register peering host on deletion ; - de-register peering host on disable / register of peering host on enable ; Change-Id: I035dfadf6709acb4d106a70f6124f024e719044f	4 years ago
Marco Capetta	7fc4e776bc	TT#82409 Add support of 'peer_auth_hf_user' preference in createRegistration ... Change-Id: I86bd04d19f12604cd64981ba07651526298b2b5f	4 years ago
Flaviu Mates	131fe8e270	TT#128850 Fix 500 eror on /api/preferencedefs ... * add quotation with ~ for square brackets ([]) comming from the database, as it is needed for I18N Change-Id: Ia1253e90d47858a930a4a9569c2d27993a0cd4bc	4 years ago
Flaviu Mates	f27eedf33c	TT#128253 Add localization support for /api/.+preferencedefs ... Change-Id: Ibee6b7c4952167a112c80d6972b7a9471a6ff958	4 years ago
Flaviu Mates	3d2df8b5d8	TT#110257 Implement blob preferences support in API ... * blobs can now be uploaded for blob type preferences using the following form: "some_blob_preference": { "content_type": "/application/data", "data": "<base64 encoded file content>" }, * upon requesting GET, the "data" field will contain the string "#blob" to avoid showing raw blob data; if GET is requested with query param 'preference=some_blob_pref', the blob will be downloaded Change-Id: Idcb6496db1f3244e8f5bae4d06301a6caf35b73f	4 years ago
Flaviu Mates	055751eb81	TT#109604 Implement blob preferences upload in Panel UI ... * Create upload and content type form fields for 'blob' type preferences * Implement blob preference upload/download to database * Show blob content in read only text area if content is text Change-Id: Ic4b800f84324eab0aadbf8eeb55c03c770ecc94f	4 years ago
Flaviu Mates	a1254c8027	TT#99565 Add preference group name to preference defs ... Change-Id: Ie706d459c82d87ec41523d6005f4d327792e3fd8	5 years ago
Flaviu Mates	88f70bd7ec	TT#93500 Restrict allowed_clis to unique numbers ... * Only allow unique values for allowed_clis in both Admin Panel and API PUT * In case of PATCH, check only if new clis are unique, since customers may have systems where allowed_clis are duplicated already * Fix tests Change-Id: I7253271081e7ecc0eae9690a3545ddb5324edac7	5 years ago
Rene Krenn	543533bde3	TT#89200 fix workaround logic for backward-incompatible prefs ... Change-Id: I2485d8cc4852fa83ee783c88e5a20b3dc884f666	5 years ago
Rene Krenn	db973da3be	TT#89200 workaround logic for backward-incompatible prefs ... unfortunately, preference types were changed over time, eg. some boolean prefs were turned into enum prefs. this requires an api client to adopt accordinngly. if this is not an option, this change allows to add simple workarounds in the rest-api directly, by registration of transformation functions for specific preferences. Change-Id: I215f0e19cd861c67c51e42fd1ab6560e56132041	5 years ago
Flaviu Mates	445197df53	TT#76360 - Implement /api/activesubscriberpreferences endpoint ... * A new endpoint is now available that will return subscriber's preferences and also the preferences that the subscriber inherits from its domain Change-Id: Iaa29fbe57d520f79ac7051dc8fd151d26df41384	5 years ago
Rene Krenn	93ef5083b2	TT#77206 accept 0/1 for boolean preferences ... Change-Id: I88714c590c15c27e2421fa7e61c5b0f937ea64f1	5 years ago
Rene Krenn	bfd2b4b5b1	TT#73364 batch provisioning ... implementation of config.yml-based "provisioning templates" for creating a subscriber setup with one click or batch-wise (.csv upload), currently comprising of: - contact - contract - contract prefs - subscriber - subscriber prefs - trusted sources - registrations Change-Id: I0c3c1ef93bbe0ca926bbe906a35346bef5094fac	5 years ago
Flaviu Mates	67f11e17c1	TT#61401 - Fix for adding empty string in 'allowed_ips' ... * Add validation in case 'allowed_ips' field is empty Change-Id: I68293e1a6681623aad8f19dba745f59bdf017df4	6 years ago
Rene Krenn	78a134ef15	TT#46955 reseller preferences ... Change-Id: I42afc5d33827e121e6551d01d9a1bd477d89137a	6 years ago
Kirill Solomko	87a1c782f6	TT#30387 implement Header Manipulations UI ... Change-Id: I17db3e4c1faa59089c8c7b7e2727a5062ffee89a	6 years ago
Irina Peshinskaya	8abd7babd9	TT#37459 Fix chained preference method names ... * improve default subscriber_lb_ptr assignment Change-Id: Id6cd80d3d5df30f15870c71a0e0aff0f551c8855	7 years ago
Irina Peshinskaya	5a504e97c1	TT#37459 Implement outbound lb_set/path for permanent registrations ... Change-Id: I5565eb20c61bd46dcdf888ee482a79b94c43813f	7 years ago
Gerhard Jungwirth	0b39b6e8b9	TT#37222 fix perlcritic errors ProhibitCommaSeparatedStatements ... one was actually a true positive. the others were false positives and are going to be silenced for the time being, while we try to find an upstream solution. more details can be found in the ticket. Change-Id: Iae8df7606774a9d26e4d44dbba557c9fe62d2252	7 years ago
Gerhard Jungwirth	6e8dd1a2a1	TT#37221 fix perlcritic error Subroutines::ProhibitExplicitReturnUndef ... this is to clean the Sipwise TAP tests for this repo the critical places where undef is really the intended return value (because a scalar should always be returned) the rule has been overridden Change-Id: I66e217a03a00e0f366db9c0cbc5007dd15cd9f96	7 years ago
Irina Peshinskaya	bfb760c3fb	TT#36402 Fix preferencesmetaentries enum processing ... And move form checking to the form validate method from API Change-Id: Ic66758666e04e60d784128ea807fc93daec6d52a	7 years ago
Gerhard Jungwirth	2b89431cca	TT#36404 restructure form-translation ... translate forms in NGCP::Panel::Form (the caching module) instead of in the templates. This gives us better control to avoid translating cached forms multiple times. Multiple translations lead to errors due to escaping of special symbols and simply fails from one (non-english) language to another. Change-Id: I234b22cb70dc068530e4a9f241cb9bb5653e1959	7 years ago