ngcp-panel

Commit Graph

Author	SHA1	Message	Date
Kirill Solomko	205b27a267	MT#59478 API better transaction and error handling * Role/Entities: POST/PUT/PATCH/DELETE methods changes: - support deadlock detection and transaction retry (2 retry attempts at the moment) - improve transaction control, use local $guard instead of saving the ref to $c->stash, as in that case it went out of scope too late and also reported an error message into the log about abnormal $guard out of scope interruption - move all non transaction related code outside of the scope - add error handling when methods such as update_item, and a like do not return the expected data, instead of simply going out of scope and resulting in an uncontrolled reply Role/API: - rework transaction control: + get_transaction_control() is renamed to start_transaction() to better reflect what it does + complete_transaction() is renamed to commit_transaction() + remove unused %params arg + pass $guard into commit_transaction() instead of having it stored as $c->stash->{transaction_guard) that caused the $guard ref to be destroyed much late than expected (there was also a typo as transaction_quard, which is not relevant anymore with the changes + add check_deadlock() that is invoked when an exception is caught or an $c->errors contain an error, and if the error message represents a transaction error, the transaction block is re-invoked via "goto TX_START" - rework error(): + it now accepts args as following: ($self, $c, $code, $message, @errors) # code -> returned as HTTP code in the reply # message -> returned as HTTP message in the reply # errors -> contain errors for internal logging, last element often contains a DBIx exception + populates all @errors into $c->error so they are available on demend in the code via $c->error or $c->last_error + $c->log->error is not invoked now as the errors become printed in log_response() - log_response() now prints collected errors from $c->error correctly as a separate log line, that is alike to the other api logs so that those can be looked up by the request's tx_id, also all errors are now printed only into api.log * Adjust all $self->error() calls in catch($e) to include $e as the last argument, as well as the duplicate $c->log->error is removed from those ocassions * Remove all $c->log->error() calls as they are replaced with either $self->error() (that logs it correctly into api.log) or $c->error('err') that also adds it correctly into api.log * API::CallForwards: rework to use Entities/EntitiesItem * API::Contracts: rework POST to use Entities * API::PeeringGroups: rework POST to use Entities * API::SubscriberRegistrations: rework POST to use Entities * API::RewriteRuleSets: improve create_item() functionality * Utils/Message: add 'api_retry' log type * $c->session->{api_request_tx_id} is changed to $c->stash->{api_request_tx_id} because sometimes the session ref is different and a different tx_id becomes used Change-Id: I633ce7a8047b1bf00a2f6889003088edf0825dcd	1 year ago
Kirill Solomko	514989cc5a	TT#184300 journals alawys write reseller_id * if $resource does not have reseller_id then the user's one is used to write into the journal entry Change-Id: I33ab6fe6271bd6be156b247c830eecea6e2f63ea	3 years ago
Kirill Solomko	ac94626f9e	TT#149456 fix and improve user role_id retreival, api tests * NGCP::Panel::Utils::UserRole::_field_to_name now supports both hash and object to parse the roles from * NGCP::Panel::Utils::UserRole::resolve_role_id returns undef if no roles has been passed or there are no entries for the role in the database * Fix NGCP::Panel::Utils::Journals to correctly fetch and set $journal{$role_id} * Adjust api-journals.t, remove tx_id, user_id, role_id from checks Change-Id: Ieff23bd4291f3b88ba92bbfc2b00b57f66bf76e1	3 years ago
Kirill Solomko	16b4dfe5dd	TT#149456 Journal allow empty role_id Change-Id: Ibfb2707a730839b43cd7bda15082fd309f67be76	3 years ago
Oleksandr Duts	747af33a7a	TT#151250 Write journal resource params: user_id, reseller_id, role_id, tx_id. Change-Id: Ie6ae9f3a49fbd4be4f302a568669f78aecfdfe25	3 years ago
Oleksandr Duts	8017805589	TT#124802 GET /api/admins/:id/journal - fixing * Admins with is_system and is_superuser are able to see the items for all roles. * Admin is able to see own journal. Change-Id: I3e5d459b08ff7ef218220f1ae11974351121c489	4 years ago
Rene Krenn	f6374026e0	TT#92700 print journal links of collection items Change-Id: I01f7632013cd38f99261a003fab323acf385dd46	5 years ago
Irina Peshinskaya	1fe6db943d	TT#48198 Use items array from paginations in all api controllers Change-Id: I1856cd4f073d32b4465d0778baf5f9f7c708f78c	6 years ago
Irina Peshinskaya	9ed0657d4c	TT#40503 Show journal links to allowed roles only Change-Id: I547b2db4767b1e383506bc812b6486db944fceec	7 years ago
Rene Krenn	fa967c4d92	TT#38150 fix and re-enable api-journals.t Change-Id: Ia5e73e6ba31c865f8a97d6711f24a113a2526d74	7 years ago
Rene Krenn	b003c214a7	TT#37706 fix journal HEAD Change-Id: Ie4884a3198a7e10d482cbc49d066eea2c15d8f19	7 years ago
Gerhard Jungwirth	6e8dd1a2a1	TT#37221 fix perlcritic error Subroutines::ProhibitExplicitReturnUndef this is to clean the Sipwise TAP tests for this repo the critical places where undef is really the intended return value (because a scalar should always be returned) the rule has been overridden Change-Id: I66e217a03a00e0f366db9c0cbc5007dd15cd9f96	7 years ago
Kirill Solomko	c93392e83d	TT#35714 fix collection_nav_links object name Change-Id: I152c2dc31b08af6223b9d8f5f6514acf1c61ef16	7 years ago
Kirill Solomko	f976fe03fb	TT#35714 use collection_nav_links in all API controllers * colelction_nav_links() should be used instead of the old self/prev/next href link code * Entities.pm fix colletion_nav_links() to pass missing $c->request->params * collection_nav_links() use default $c->request->path and $c->request->params if those arguments are not specified Change-Id: Icca5afac812f2e06e6927ba6f4e91057f9745d21	7 years ago
Irina Peshinskaya	05c2708832	TT#34567 Apply mandatory parameters to hal links Change-Id: I90dd7f7ae600ccfa589a7624681f35655ae9a098	7 years ago
Gerhard Jungwirth	24de4232e6	TT#30507 remove DataHal workaround layer (NGCP::Panel was loaded every time this was used) Change-Id: I62861e0756aaaf548c9be42b4842e9a06127119c	7 years ago
Irina Peshinskaya	2073b9e760	TT#9309 Introduce local version of the Data::HAL::Link Change-Id: Ifdf95cef32f0d118330c20316ed447e00c6dae3c	8 years ago
Irina Peshinskaya	41f32401a7	TT#9309 Introduce local version of the Data::HAL with default forcearray Change-Id: Ie33396a75fc6d27fd28fe8f7717caba0a476c776	8 years ago
Rene Krenn	7a89ab811d	MT#22992 journal time range query parameters +fix journal action method config Change-Id: I3e72e0928d185a5052ad556597661517920dd6b4	9 years ago
Irina Peshinskaya	e2264a840e	MT#17173 Fix forgotten journal_query_params Change-Id: Ia7c2133c2183e7115b3d6a33e59253b0dbdd6289	9 years ago
Irina Peshinskaya	0272c297b8	MT#17173 Remove Moose Roles from API Conflicts: lib/NGCP/Panel/Controller/API/MetaConfigDefs.pm lib/NGCP/Panel/Controller/API/Root.pm Change-Id: I25597baebbec6e2436b15776da17bd6d1bfef838	9 years ago
Rene Krenn	c378681a24	MT#13903 balance interval catchup and resize WIP + synchronized contract balance catchup + balance interval resizing upon profile package transitions + dynamic interval length, interval start, carry-over propagation, .. + end-of-month 'preserve' mode correction for strictly aligned month intervals for start_mode=customer "create" timestamp + new api/balanceintervals resource to inspect contracts' balance interval histories + updated affected panel UI controllers + test case with time warps using Time::Fake caveats: - creating an invoice for a given 'period' (month) has to be refactored to select a disitnct balance interval. right now it takes the last interval in the month specified. - generate_invoice.pl is broken and needs a major refactoring Change-Id: I7bb54a83b76e510b1baa573a986d05400a7fec1e	10 years ago
Rene Krenn	c411ece3a9	MT#11917 'must-have' api resources complete - ApplyRewrites + AutoAttendants ~ BillingFees OK + BillingProfiles + BillingZones - CallControls OK * CallForwards - CallLists - Calls OK * CCMapEntries OK * CFDestinationSets OK * CFMappings OK * CFTimeSets OK ~ Contracts + CustomerBalances OK * CustomerContacts OK * CustomerPreferences OK * Customers - CustomerZoneCosts + DomainPreferences OK + Domains ~ EmailTemplates OK * FaxserverSettings - Interceptions - Invoices ~ InvoiceTemplates + NcosLevels + NcosPatterns + PbxDeviceConfigFiles + PbxDeviceConfigs + PbxDeviceFirmwareBinaries ~ PbxDeviceFirmwares + PbxDeviceModelImages + PbxDeviceModels + PbxDeviceProfiles + PbxDevices OK * ProfilePreferences OK * Reminders OK ~ Resellers + RewriteRules + RewriteRuleSets - SoundFileRecordings ~ SoundFiles ~ SoundHandles OK * SoundSets OK * SpeedDials OK * SubscriberPreferences OK ~ SubscriberProfiles OK ~ SubscriberProfileSets - SubscriberRegistrations OK * Subscribers OK ~ SystemContacts OK * TrustedSources - VoicemailRecordings - Voicemails * VoicemailSettings Change-Id: Ibbaf8be32c6cda71637e16c40f345a15b8c1f530	10 years ago
Rene Krenn	83fdc85702	MT#11917 include journal in generated API doc page Change-Id: Iab13239e892823e2708f5b13b985db42be45d136	10 years ago
Rene Krenn	96c731a144	MT#11917 Journaling for first set of resources the journal module introduces a change history of resources modified by api invocations. the history of the 'customer' resource demo is accessible at /api/customers/x/journal. Change-Id: I4d5d11bc3e35160feed587ce4c1db565991866b2	10 years ago

25 Commits (master)