969 Commits (master)

Author	SHA1	Message	Date
Rene Krenn	3af6080c76	MT#65586 add expand for profilepackages profile mapping arrays ... * allow expanding initial_profiles, topup_profiles and underrun_profiles * inline billing profile and billing network resources on each mapping * return success after expanding repeatable nested id fields Change-Id: I15ec66b04931f8c9065ad5826886ee2011e3f6fc	5 days ago
Marco Capetta	6a942068be	MT#51865 add calllistsuppressions API endpoint ... Expose the global call list suppressions (billing.call_list_suppressions) via /api/calllistsuppressions/, so far only manageable through the admin web interface. Supports GET, POST, PUT, PATCH and DELETE, and is restricted to the admin role. The already existing but so far unreferenced form CallListSuppression::SuppressionAPI is reused for validation and API documentation. The domain/direction/pattern uniqueness of the table is enforced in check_duplicate, which covers both create and update. Journaling is enabled for create, update and delete operations. Change-Id: I11be61ace5c64610644b714baa45d984313f647c	2 weeks ago
Marco Capetta	8042d9f4d1	MT#65665 return redirect credentials on pbxdevicemodels on GET API ... The bootstrap_config_redirect_*_user and _password values are stored in provisioning.autoprov_redirect_credentials, while _profile is a sync parameter in provisioning.autoprov_sync. resource_from_item only called devmod_sync_parameters_prefetch_api, so GET returned the profile but silently dropped the credentialsm. Add devmod_sync_credentials_prefetch_api, mirroring the read-back the web UI already does in Controller::Device, and call it from resource_from_item for the admin and reseller roles only, which are the roles allowed to write these fields. Subscriber and subscriberadmin GETs keep them hidden. Change-Id: I02a8975fbf9fe60796832cf281d054e634ce6c00	3 weeks ago
Marco Capetta	d01cff87ba	MT#65224 renumber voicemail msgnum on folder change and delete ... Asterisk uses its built-in ODBC voicemail storage against kamailio.voicemail_spool, which expects msgnum to be contiguous 0..N-1 within each (mailboxuser, dir) folder. Asterisk maintains that invariant itself, but the panel rewrote dir (or deleted a row) without ever touching msgnum, leaving gaps and duplicates that make asterisk mis-play and mis-count the messages. Add two helpers to Utils::Subscriber reproducing the asterisk semantics: * renumber_voicemail_folder() compacts a single folder to 0..N-1 ordered by (msgnum, id). It skips greetings, which live in the same table with msgnum -1. * move_voicemail_to_folder() appends the message at the end of the target folder the way asterisk does (last_msg_index + 1), then compacts both the source and the target folder. Both run inside a transaction, so the web UI paths that have no transaction guard of their own are covered as well. Use them in all four affected paths: * PATCH/PUT /api/voicemails/{id} (Role::API::Voicemails) * DELETE /api/voicemails/{id} (Controller::API::VoicemailsItem) * mark_voicemail_read() for the CSC/admin listen action * delete_voicemail() in the subscriber web UI The compaction is deliberately self-healing, so it also repairs folders already corrupted by the previous behaviour. Change-Id: I665de1966bc37c1069ff56fb30c99da85f224f71	3 weeks ago
Rene Krenn	a0bfa9377c	MT#65579 support updating existing subscribers via prov templates ... Reuse shared resource_from_item/update_subscriber helpers so templates can match by identifier, fill missing fields from the DB item, and update instead of only creating. Change-Id: I5fa9be12914677c3b6ef5c4c0617cb75447b45c9	4 weeks ago
Kirill Solomko	79817b3529	MT#65573 change order of check_resource() and check_duplicate() ... * check_duplicate() call must be after check_resource() by default as check_resource usually validates the vital values, such as subscriber_id, reseller_id whereas the duplicates check can already operate with the "trustworthy" subscriber_id for the duplicate checks part. Change-Id: I3361c143a6e00f9c168a3b02e23feb4ca57c85f0	1 month ago
Kirill Solomko	9470652038	MT#65572 rework call forward sets resource validation ... * streamline the validation behaviour among all the call forward set endpoints to be the same: - all of them contain process_form_resource() check_resource() check_duplicate() and also update_item() calls those functions in the exact order * subscriber_id validation is performed in check_resource only once and removed from the other places. * subscriberadmin role now uses the same Form as the admin users (that contains the subscriber_id field). * subscriberadmin role is now allowed to provide with the subscriber_id, otherwise if undefined, the user's id is taken. * check_resource() now checks for subscriberadmin if the subscriber_id belongs to the same customer. * check_duplicate() only contains the duplicate entry check. * the following above fix inconsistent validation that produces different results, minimises the amount of sql queries as well as extends the functionality to enable the subscriberadmin role to create call forward sets on behalf of the own subscribers. Change-Id: I60ddd5aa2bd5228efeca9f8c1a593d24179b959a	1 month ago
Kirill Solomko	7f9af10416	MT#65553 add check duplicates for call forward sets ... * add check_duplicates() for destination, bnumber, time sets. * adjust duplicate set error messages. Change-Id: I8ee958df97f6e53f0e64283a0a9c2f85330aa9d1	1 month ago
Kirill Solomko	0c9f3e5ed0	MT#65549 add cf sets DELETE ?unassign_first=1 support ... * it is now possible to invoke the following endpoints as: - DELETE /api/cfbnumbersets/:id?unassign_first=1 - DELETE /api/cfsourcesets/:id?unassign_first=1 - DELETE /api/cftimesets/:id?unassign_first=1 in which case before the actual deletion, the cf set is unassigned from the cf_mappings, so that the cf_mappings are not automatically deleted by the constraints. Change-Id: I7fa40eba2790edcc62d8430ebbe6f752b13353f9	1 month ago
Kirill Solomko	331dcd604a	MT#65548 cf sets add usage_count field ... * usage_count field is returned for all the call forward sets and indicates how many cf mappings use the cf set. Change-Id: Ib8f31370fd4cfae3356c683981be7b9d0da0a73a	1 month ago
Rene Krenn	19ed6c93f5	MT#65173 billing networks optional usage columns ... Change-Id: I730950af2d53570faff1a68ddc2e8c13952279f3 Co-authored-by: Cursor <cursoragent@cursor.com>	2 months ago
Rene Krenn	9714863a98	MT#65173 add optional usage columns to billing profiles API ... load contract_cnt, contract_exists, and package_cnt only when requested via query params, matching the web UI ajax behavior while keeping update validation working for interval field changes. Change-Id: Ie1d889fcac3227e81f37031c55fcf765e489cf9a	2 months ago
Kirill Solomko	9a12bc2ddf	MT#65445 autosync "cli" on update with the same primary_number ... * on /api/subscribers PUT/PATCH if the "auto_sync_cli" config option is enabled and the primary_number is unchanged, check and sync the "cli" preference value if it differs from the primary number. * Controller::API::Subscribers remove incorrect "last" occurences. * /api/subscribers return "primary_number: null if it's not defined. * api-subscribers.t fix exists to defined for the $resource->{primary_number} check as it might be there as undef. * api-rest/tests fix primary_number to be unique for ceratin failing tests. Change-Id: I10c784ee6d3e2544d97dfaa66dc7aae10ba1990a	2 months ago
Kirill Solomko	9e8b35fa44	MT#65382 timesets add missing own+subscriber_id in resource_from_item() ... * resource_from_item() for CFSourceSets, CFTimeSets, CFDestinationSets did not have either own flag or billing subscriber_id (or both), resulting in missing "expanded" data (as expand uses resource_from_item() internally). Change-Id: Ifeafcbc449f0e2417e3631b3e547c07a2837d856	2 months ago
Kirill Solomko	5f9d05ea24	MT#65382 add repeatable field expand support ... * repeatable fields can now be used for expand * add expand support for cfmappings repeatable fields Change-Id: Ia4f6c82c7f73d5112030dd1122fbdc13adb2c8c5	2 months ago
Rene Krenn	91ac920f8d	MT#65177 contract_id filter for CustomerLocations ... the contract_id query param allows to filter CustomerLocations by contract_id. Change-Id: I66e89fc65aa46a80c6a39fd5892c6410116da91a	2 months ago
Kirill Solomko	ce12aed828	MT#64923 callforward sets add own boolean field ... * /api/callforwards (per set), /api/cfdestinationsets, /api/cfsourcesets, /api/cfbnumbersets, /api/cftimesets return "own" field for subscriber and subscriberadmin roles only, this field indicates if the call forward set belongs to the same subscriber that requests it. * /api/callforwards fix default value for 'cfr' and 'cfo' cftypes from null to {}, to match all the other cftype default values. Change-Id: I9c5c60dfb16301703341c1ba17c751079f79ae8b	3 months ago
Kirill Solomko	d1280015c4	MT#62339 /api/subscriberregistrations add total_count support ... * Panel::Utils::RedisLocationResultSet: - add total_count() that returns total count of all entries without pagination - add total count aggregation during _find(), _row_from_mapkey(), _scan() that aggregates total entries that can be shown without pagination * SubscriberRegistrations: - return correct total_count of all possible entries that can be shown (without pagination) - fix a 500 error when 'subscriber_id' contains a non-existing subscriber Change-Id: I914356a809a005c21bb662498ca78dd35affc0ee	5 months ago
Rene Krenn	47b5cc7b7b	MT#64594 prov templates: fraud preferences support ... this change introduces support to set contract fraud preferences via provisioning template, ie: fraud_preferences: fraud_interval_limit: "function { current_fraud_interval_source == 'profile' ? current_fraud_interval_limit : 10000; }" fraud_interval_lock: "function { current_fraud_interval_source == 'profile' ? current_fraud_interval_lock : 2; }" fraud_interval_notify: "function { current_fraud_interval_source == 'profile' ? current_fraud_interval_notify : 'jdoe@sipwise.com'; }" fraud_daily_limit: 500 fraud_daily_lock: 2 fraud_daily_notify: "jdoe@sipwise.com" Change-Id: Id7e67fd71e0b1d291ee5e2ea9e2ea9b6bae64781	6 months ago
Kirill Solomko	224aec5fc8	MT#64232 improve check_subscriberadmin_write_access ... * subscriberadmin can now edit own data in scenarios where it's a SIP customer subscriber * add a check to that the edited subscriber belongs to the same customer Change-Id: I69a84c481be413ac5604c74856e760eee648b637	7 months ago
Kirill Solomko	c417cc622d	MT#64295 better handling of via_route empty string ... * transform via_route empty string into undef and store it as undef without validating it against SIP-URI Change-Id: Iefae7b26910201183ae3d049b3785a68dc81ce64	7 months ago
Kirill Solomko	638b2f20ae	MT#64295 fix /api/peeringservers via_route validation ... * NGCP::Form::Peering::Server rework via_route URI check from a comma separated list to a single value as well as improve value transformation and validation logic * /api/peeringservers add via_route value transformation as pre_proccess_form_resource() Change-Id: I742a40534a4861dd30e0ccbc6684c02d2386f642	7 months ago
Guillem Jover	b6e2baa6c7	MT#63479 Remove prosody support ... Change-Id: I9d3e268450396c12e4058ac9394a80bb191d7635	8 months ago
Kirill Solomko	9d70f62f70	MT#64121 fix $c->error $c->error handling ... * errors coming from Utils::Preferences can have only 1 element in $c->error, the case is now correctly handled. Change-Id: I9f5d384da8b5cb50b78636309dbaab5efa9bdee2	9 months ago
Kirill Solomko	eae620f204	MT#64067 address deadlock detection for preferences ... * improve Role/API/Preferences err_code callback to check deadlocks (via $self->check_deadlock) and set $process_extras->{retry_tx} = 1 so that the outer caller can act upon it and restart the transaction. * increase deadlock attempts from 2 to 5 as some deadlocks seem to take longer time to resolve. * wait 1 second between deadlock retry attempts as otherwise if a deadlock takes more than 1 second and all the retries are done within less than a second it will cause an error. * EntitiesItem: add support for retry_tx and call goto TX_START if $process_extras->{retry_tx} (when check_deadlock is processed externally, like in Utils::Preferences::update_item in the err_code callback). Change-Id: Ib56383710041c21d72782047a852353296c22215	9 months ago
Kirill Solomko	6e2ca03a6e	MT#63997 make underrun lock on requests optional ... * a new ngcp_panel option $c->config->{api}{underrun_lock_on_request} is in place and if disabled - the underrun lock logic on GET contracts,customers,subscribers,subscriberpreferences, and POST subscribers is skipped. Change-Id: I5ea337ce42b3c979fe55b3df3516a19548b64f90	9 months ago
Kirill Solomko	d0783b1856	MT#63859 add expand by carrier_id ... * /api/lnpnumbers can now expand by carrier_id Change-Id: Ia484041c413a240800c1610f0bc92c141bded14d	9 months ago
Rene Krenn	f501fc1dcf	MT#63706 skip_locked for POST /api/subscriber/ ... add the SELECT .. SKIP LOCK mechanism for POST /api/subscriber/, to reduce lock wait timeouts when creating suscribers for the same customer in parallel. Change-Id: I067102b3dc726e5d12fa859613b548d007ce29ee	10 months ago
Rene Krenn	3ff0395cac	MT#61442 allow utf8 for creating data::hal links ... prevent api 500 error when building urls in data::hal from item data tha carry odd utf8 fields (ie. usernames of banned users) Change-Id: I0c2c0bf0170bf97bf8a05c35fdb343860b6aeef4	10 months ago
Kirill Solomko	d1686f5243	MT#63050 /api/customers email_template auto assign ... * POST /api/customers now assigns reseller's default email_templates that are not specified in the DTO. If reseller's default template does not exist (reseller that was created via UI v1 without values), it automatically created as a copy of the raw default template for the reseller, and then assigned to the customer. Change-Id: I0f74154724e1d053002ec4fcc59a5f99cedd322c	11 months ago
Rene Krenn	82b253973e	MT#63724 reduce contract_cnt limit to 10 ... select count(1) from (select 1 from Y .. limit X) can have a longer runtime, depending on order of rows in table Y. to better limit the runtime, X is reduced from 1000 to 10. the UI will show now "used by 10+ contracts" instead of "used by 1000+ contracts". Change-Id: I028b0569cd5f3325d4bd6bed314517b061e4659b	11 months ago
Kirill Solomko	0d3aac99a7	MT#63605 fix GET invoicetemplates without reseller_id ... * 'reseller' level invoice templates are correctly returned with reseller_id: null, instead of 500 error Change-Id: Ied1e7626fcbb2c28bf3850dd1788f06574ef892b	11 months ago
Kirill Solomko	67091cfb44	MT#63090 /api/conversations add phonebook entries support ... * new fields: caller_phonebook_id (id of the matched phonebook entry) caller_phonebook_name (matched name in the phonebook by the number) callee_phonebook_id (id of the matched phonebook entry) callee_phonebook_name (matched name in the phonebook by the number) * matching happens in the v_subscriber_phonebook (so all inherited entries are returned) * new private functions _get_call_phonebook() and _get_fax_voicemail_phonebook Change-Id: I321c59dce93a3c478a15ddea2155ff052713db20	12 months ago
Kirill Solomko	4a38eace57	MT#61804 /api/conversations add csv download support ... * "Accept: text/csv" enabled csv download (same as with other endpoints Change-Id: I84a229f6f1f8760d520f55da1bb250ed6dd1f228	1 year ago
Rene Krenn	eb6f74968e	MT#62987 transcript info - api ... Change-Id: Ifc83f65b36dfab3913492e8b764210da256f8004	1 year ago
Kirill Solomko	3bb3d9e4e4	MT#63182 /api/subscribers add lockwait and deadlock detection ... * API::check_deadlock() add lockwait detection. * lockwait and deadlock detection is now in place for ALL /api/subscribers endpoint methods. because of logic complexity it uses own deadlock detection instead of relying on Entities. It however uses $self->check_deadlock() and similar logic. Change-Id: Idc1876910711563fe14c878541e350ad373d6d31	1 year ago
Kirill Solomko	b8cd29ce32	MT#63062 /api/customercontacts fix PUT/PATCH reseller_id validation ... * add Form::Contact::AdminAPI that uses reseller_id field instead of reseller for better error message * update_contact() fix reseller_id validation for admin roles * update_contact() copy reseller_id from $old_resource for reseller roles so that further reseller_id checks can pass. Change-Id: Ic9559a944265f5c8bceada6077fcf8e14d6bc5d4	1 year ago
Kirill Solomko	a38cd246c4	MT#63066 /api/subscriberphonebook add filter by customer_id ... * customer_id is now present in the response * customer_id is supported as the query parameter Change-Id: Ia529fa653b165f743c006cb99f6518ae686e517c	1 year ago
Kirill Solomko	f7a3b1eab2	MT#63062 fix /api/customercontacts for reseller roles ... * fix logic in update_contact() that was performed with the reseller_id that became undef after form validation for reseller roles. Change-Id: I2e1d386f01b5d279188a7600d2d7f0d9d44b7853	1 year ago
Kirill Solomko	0ce365852d	MT#62890 fix and improve voicemailgreetings upload ... * any wav file is now accepted and converted to GSM 6.10, instead of having a strict requirement of GSM files only * provide error messages with single quotes instead of escaped double quotes * error messages do not contain code backtrace info anymore * temporary files are correctly removed on errors and on a successful upload Change-Id: I7b72dc623d231aa90d0a0f99f8d711c48d3d23f2	1 year ago
Kirill Solomko	4d26ca5c9a	MT#62705 improve peer_auth registrations support ... * DELETE /api/peeringgroups and PUT/PATCH/DELETE /api/peeringservers now call sip_create_peer_registration or delete_peer_registration correspondingly to correctly reflect the registartion on related changes * rework Panel::Utils::Peering create_peer_registration() and delete_peer_registration() - use provisioning peer db object in the argument instead of a separate hash to simplify its logic - adjust related UI parts that call these functions as well as cleanup now unnesessary code from there * Panel::Utils::Peering: remove '_' prefix from _sip* functions as they are not private but rather public class methods * Panel::Utils::Preferences - add suport for 'peer_auth' updates for type='peerings' (was only supported for 'subscribers') - remove '_' prefix from _is_peer_auth_active() * Panel::Utils::Sems - simplify peer registration by using the the db object (same as for subscribers) - only create/delete peer registration when the peering is enabled, otherwise there will be errors related to unavailable $prov_peer->lcr_gw->id Change-Id: I0fc79a6580fd17aa34df870fb7a93e33edfff15b	1 year ago
Marco Capetta	1be3f5a257	MT#62546 Fix permanent registration nat flags ... Due to changes in how kamailio manage the NAT contacts and the corresponding natping, the flags that the API or web interface sets while a permanent registration is created have to be updated. Before: * Default cflag is set to 0 (natping disabled) * If nat option, then cflag is set to 64 New: * Default cflag is set to 256 (netping disabled) * If nat option, then cflag is set to 128 Change-Id: I39b1d7a697ef72267fd8a05edf0552d2c1403733	1 year ago
Rene Krenn	6600d7c949	MT#53706 enable_2fa option for /api/admins ... Change-Id: I7de37482fed913551fc0a1c9b18f789b51b67a05	1 year ago
Rene Krenn	82af5cf518	MT#62283 "for update no lock" logic for GET /subscribers and /contracts ... to unblock the web UI on heavy loaded systems with call rating enabled, "select .. for update no lock" will no longer wait for acquiring locks when retrieving subscriber or contract contract pages. the contract_balance record creation is will be skipped for such contracts that are locked elsewhere. for rails such as /customerbalances, an explicit contract id row lock timeout is introduced, so it does not depend on the mariadb wait_timeout. Change-Id: I6e96342f3f761279a5876c871d2477977823a39e	1 year ago
Kirill Solomko	24d28676a1	MT#62289 /api/pbxusers add username and domain fields ... * username represents provisioning.voip_subscribers.username * domain represents provisionoing.voip_domains.domain Change-Id: I98f4043f9b044a7829603f2a350d1548be935ff1	1 year ago
Kirill Solomko	e8f41aba50	MT#62223 improve error response handling when log_response is off ... * log_response: 0 is reworked, it now always logs the response but in case if it's off the body is not logged. * adjust error logging, the error in the body is correctly logged in the response even if log_response: 0 Change-Id: I6dfddeccffb5464b830133235bf63c5e82ae6073	2 years ago
Kirill Solomko	cbc4e57d45	MT#62223 API unhandled internal errors cause 500 error ... * unhandled internal errors (such as DBI error) are now properly returned as 500 Internal Server Error instead of 200 OK Change-Id: Iabc80cd200c9091dd249bc90aa586d5d7b616b69	2 years ago
Kirill Solomko	97e457c92b	MT#62178 fix external_id, profile auto removal for subscriber roles ... * fix 'subscriber' and 'subscriberadmin' roles using PATCH to cause external_id, and profile fields removed. * remove profile_id field from the 'subscriber' and 'subscriberadmin' form Change-Id: Id8bb068ca7fcac2c0c5954f2ed79e841d18ac398	2 years ago
Kirill Solomko	ef4442feeb	MT#61805 add API phonebook support for top level inclusion ... * /api/customerphonebookentries now support "include" query param that can be either "include=all", "include=shared" or "include=reseller". With "include=all" - shared and reseller entries are included and merged as customer > shared > reseller. With "include=shared" - shared entries are included and merged as customer > shared. With "include=reseller" - reseller entries are included and merged as customer > reseller. * /api/subscriberphonebookentries now support "include" query param that can be either "include=all", "include=customer" or "include=reseller" With "include=all" - customer+shared+reseller entries are included, and merged as subscriber > customer > shared > reseller. With "include=customer" - customer+shared entries are included, and merged as subscriber > customer > shared. With "include=reseller" - customer+reseller entries are included, and merged as subscriber > reseller. * Shared numbers are considered belonging to the customer so when on the customer level the same number is provided, it takes precedence. * It is not possible to edit other level included numbers (they have composide ids). * It is possible to access an included number directly by the id. Change-Id: Ice06bc0961d42a9b64db59aa93029d7505b4805e	2 years ago
Kirill Solomko	e66c568efc	MT#61803 add /api/pbxusers endpoint ... * this endpoint is designed to provide with basic subscribers info such as display_name, primary_number, pbx_extension and only available for customers with product class 'pbxaccount'. * only GET methods are allowed for this endpoint. Change-Id: I181b863e2c3e5fad34c03a291f64fd7ddb587702	2 years ago