836 Commits (master)

Author	SHA1	Message	Date
Guillem Jover	324279c850	MT#62763 Do not return undef, just return ... Rework return statements to be standalone instead of using high-precedence boolean operators. And just «return» which handles the call sites correctly depending on the context, instead of «return undef». Warned-by: perlcritic Fixes: Subroutines::ProhibitExplicitReturnUndef Change-Id: I05f9b6e26f0369448a6536ea2ef48b650ff56ad8	2 months ago
Kirill Solomko	12e8992a78	MT#64115 add peer multi site support ... * add peering server field 'site_id' that uses $c->config->{multisite} for a list of available sites, if multi site is enabled, otherwise the column is not visible via the UI but available regardless via the API Change-Id: I5e9ec64bcc80531022b6067b0c50b197ee25b952	2 months ago
Kirill Solomko	c417cc622d	MT#64295 better handling of via_route empty string ... * transform via_route empty string into undef and store it as undef without validating it against SIP-URI Change-Id: Iefae7b26910201183ae3d049b3785a68dc81ce64	3 months ago
Kirill Solomko	638b2f20ae	MT#64295 fix /api/peeringservers via_route validation ... * NGCP::Form::Peering::Server rework via_route URI check from a comma separated list to a single value as well as improve value transformation and validation logic * /api/peeringservers add via_route value transformation as pre_proccess_form_resource() Change-Id: I742a40534a4861dd30e0ccbc6684c02d2386f642	3 months ago
Rene Krenn	10df50468b	MT#64142 do not translate CF dropdown items ... names of CF destinationsets, sourcesets etc. are provided by the user and can therefore contain patterns that are then unintentionally interpreted by the perl Maketext Module, causing 500 errors as a consequence. translations are better disabled for the dropdown option items. Change-Id: I20fa5c5ad79f78f8d2f682ea54984e92997ec34c	3 months ago
Guillem Jover	b6e2baa6c7	MT#63479 Remove prosody support ... Change-Id: I9d3e268450396c12e4058ac9394a80bb191d7635	4 months ago
Kirill Solomko	d0783b1856	MT#63859 add expand by carrier_id ... * /api/lnpnumbers can now expand by carrier_id Change-Id: Ia484041c413a240800c1610f0bc92c141bded14d	5 months ago
Kirill Solomko	be0e9de01b	MT#63839 add expand by subscriber_email_template_id ... * subscriber_email_template_id can now be globally expanded Change-Id: Ifad15d328ed6cfb81670974a8a4a2f9ad6196652	5 months ago
Kirill Solomko	67091cfb44	MT#63090 /api/conversations add phonebook entries support ... * new fields: caller_phonebook_id (id of the matched phonebook entry) caller_phonebook_name (matched name in the phonebook by the number) callee_phonebook_id (id of the matched phonebook entry) callee_phonebook_name (matched name in the phonebook by the number) * matching happens in the v_subscriber_phonebook (so all inherited entries are returned) * new private functions _get_call_phonebook() and _get_fax_voicemail_phonebook Change-Id: I321c59dce93a3c478a15ddea2155ff052713db20	8 months ago
Kirill Solomko	88a11e059e	Revert "MT#63090 /api/calllists add phonebook entries support" ... This reverts commit c5e6d15800. Reason for revert: the logic is implemented in /api/conversations instead Change-Id: I449f6793c754d6a968438de691147dcff2a33ba5	8 months ago
Kirill Solomko	c5e6d15800	MT#63090 /api/calllists add phonebook entries support ... * new fields: own_phonebook_name (matched name in the phonebook by the number) own_phonebook_id (id of the matched phonebook entry) other_phonebook_name (matched name in the phonebook by the number) other_phonebook_id (id of the matched phonebook entry) * matching happens in the v_subscriber_phonebook (so all inherited entries are returned) Change-Id: I5a0c825a8de28cd9fb11cf5e74b3941b5ba3b01c	8 months ago
Marco Capetta	1c9e706492	MT#63454 Add new time_set_invert field in NCOS Levels ... The new field allows the administrator to choose whether to invert the time set matching. Change-Id: Ibc8d4995118a743b1e6df2a498855f469ff7db7c	8 months ago
Marco Capetta	d9497ffec7	MT#60563 add /api/pbxdevices label support ... The field is a text. Change-Id: I3056acc8c6e4f300bcda3478759699a5c3018aa1	8 months ago
Rene Krenn	4c7b7891c8	MT#63358 readonly prodile_id for GET /api/subscribers ... profile_id field seems mandatory for admin UI. bringing it back as readonly. Change-Id: I40d0842b83b54b37e80a469da4234c6feddcdaba	8 months ago
Rene Krenn	eb6f74968e	MT#62987 transcript info - api ... Change-Id: Ifc83f65b36dfab3913492e8b764210da256f8004	9 months ago
Kirill Solomko	b8cd29ce32	MT#63062 /api/customercontacts fix PUT/PATCH reseller_id validation ... * add Form::Contact::AdminAPI that uses reseller_id field instead of reseller for better error message * update_contact() fix reseller_id validation for admin roles * update_contact() copy reseller_id from $old_resource for reseller roles so that further reseller_id checks can pass. Change-Id: Ic9559a944265f5c8bceada6077fcf8e14d6bc5d4	10 months ago
Kirill Solomko	f44b43eb77	MT#63047 API add 'own' field to subscriber and customer phonebook ... * add own field to contract and subscriber phonebook views to identify if the entry was created by the subscriber/contract_id or inherited. Change-Id: I775be31ec6aced4a76c9701e24b7ab1021dc36b2	10 months ago
Kirill Solomko	a38cd246c4	MT#63066 /api/subscriberphonebook add filter by customer_id ... * customer_id is now present in the response * customer_id is supported as the query parameter Change-Id: Ia529fa653b165f743c006cb99f6518ae686e517c	10 months ago
Rene Krenn	0bd2c64b98	MT#53706 OTP: login, show registration info ... Change-Id: I20e6fba357b6bfed868edb8030009683b8df29ef	1 year ago
Kirill Solomko	24d28676a1	MT#62289 /api/pbxusers add username and domain fields ... * username represents provisioning.voip_subscribers.username * domain represents provisionoing.voip_domains.domain Change-Id: I98f4043f9b044a7829603f2a350d1548be935ff1	1 year ago
Kirill Solomko	97e457c92b	MT#62178 fix external_id, profile auto removal for subscriber roles ... * fix 'subscriber' and 'subscriberadmin' roles using PATCH to cause external_id, and profile fields removed. * remove profile_id field from the 'subscriber' and 'subscriberadmin' form Change-Id: Id8bb068ca7fcac2c0c5954f2ed79e841d18ac398	1 year ago
Kirill Solomko	e66c568efc	MT#61803 add /api/pbxusers endpoint ... * this endpoint is designed to provide with basic subscribers info such as display_name, primary_number, pbx_extension and only available for customers with product class 'pbxaccount'. * only GET methods are allowed for this endpoint. Change-Id: I181b863e2c3e5fad34c03a291f64fd7ddb587702	1 year ago
Rene Krenn	143bd0dba9	MT#62084 contract_id field for /api/topupcash and /api/topupvoucher ... so far the topup api rails had just a subscriber_id field. for the AUI migration a contract_id field is required. Change-Id: I2b53971ecd0abe06f7e0ff0e72b9bb83d12a4f6b	1 year ago
Rene Krenn	de0595c089	MT#59447 admin user LDAP authentication #1 ... Change-Id: Ic31236d933f022b567c74998959267ef9a549b7e	1 year ago
Rene Krenn	358139edee	MT#59447 admin user LDAP authentication ... Change-Id: I86005af30dee6285d80fe69f020f4a33cb23a608	1 year ago
Kirill Solomko	e83588874b	MT#60553 handle API subscriber timezone field separately ... * timezone field for SubscriberSubAdminAPI form is now Text instead of +NGCP::Panel::Field::TimezoneSelect because the template => 'helpers/datatables_field.tt' produces a field validation error, as well as the Field is designed for UI and not API. * add validate_timezone() field validation to SubscriberAPI and SubscriberSubAdminAPI forms. Change-Id: I6391694284477976d8d6cee71a81e2241bd94937	2 years ago
Kirill Solomko	bbd44f16fa	MT#60858 add /api/passwordchange endpoint ... * the new endpoint accepts new_password fields and enables for authenticated user a mechanism to quickly change their password * the global password validation rules are enabled * returns 204 No Content * if user's password is expired, the endpoint is the only accessible for the user to change the password and unlock other endpoints. * a few fixes in validate_password() to correctly fetch provisioning subscriber for password change scenarios and webpassword field Change-Id: I906fcfe5c780b850d322b46b445b54c054767673	2 years ago
Kirill Solomko	b97be4502d	MT#60709 add PBX expand by device_id,profile_id,config_id ... * device_id, profile_id (device related), config_id are now expandable in the respective /api/pbxdevice* endpoints. * fix expand collection logic to avoid ambiguous 'order by id'. Change-Id: I0b1f4b3da093fb04a30e5097881af6131c1afe46	2 years ago
Kirill Solomko	b041888807	MT#60656 add max_age password validation support ... * UI: password are now validated against $c->config->{security}{password}{web_max_age_days} (unless it's 0) and if the password is expired the user is redirected automatically to /changepassword page, and after successful password change back to the original page. * API: if password is expired all API requests will be returning 403 Forbidden "Password expired", except PUT/PATCH to /api/admins or /api/subscribers with the new password in place. * successful login on the UI now redirects to /dashboard instead of / (to prevent unintended redirect to v2) Change-Id: I075f8e17cc9b0658d6b3b3d526ca5b379d050ce4	2 years ago
Kirill Solomko	f383837ea9	MT#60595 add expand by package_id ... * package_id field can now be expanded Change-Id: I6555134fbc5c50aae49a64876712fcc8678385f2	2 years ago
Kirill Solomko	e6b29d3e7b	MT#59449 fix password validation enabled/disabled, admins ... * correctly detect and skip password validation when sip_validatation or web_validation is not enabled respectively * better detect web password for admin users * /api/admins PUT/PATCH now also correctly checks last used passwords Change-Id: I9a6fa9b8e30ae2b81d2852dec0e1f9d858be13ef	2 years ago
Kirill Solomko	d9f283cbc8	MT#59449 enhance password validation and handling ... * passwords are now validated based on - minlen - maxlen - min lower case chars - min uppper case chars - min digits - min special chars * Data::Password::zxcvbn is used to calculate password score and reject passwords with score < 3 as weak (this library is ported from the Dropbox password validation) * Add password journals and check last used passwords in the journals * Improve password generator javascript function to generate a password with at least 4 of each of the char group types. * Currently affected are subcriber and admin entry creation or modification via UI/API * NGCP::Utils::Auth add optional bcrypt_cost support as last argument for generate_salted_hash and get_usr_salted_pass Change-Id: I100c25107d91741d5101bc58d29a3fa558b0b017	2 years ago
Kirill Solomko	9d021be65a	MT#59979 add license control ... * UI and API parts are now under license control * new Util::License::get_license($c, $name) - fetches license status by name (1 if enabled, and also if /proc/ngcp/check if 'ok') * add Catalyst::Plugins::NGCP::License with license($name) to fetch valid license by name from anywhere using $c->license('pbx') or from the templates using c.license('pbx'). It internally uses Util::License::get_license($c, $name) * License::get_license_status($c) now requires $c as first argument as well logs license status check errors. * new ActionRoles::License that enables usage of :Does(License) RequiresLicense('pbx') LicenseDetachTo('/denied_page') in the Controller chains * Add license control for UI elements and return 403 Forbidden if a resource is covered by licenses and the license is not active * Hide UI elements if a license is not active * API/Entities/Entities new $c->set_config key: - per endpoint: $c->set_config({ required_licenses => [qw/pbx device_provisioning/] } - or per method: $c->set_config({ required_licenses => { POST => [qw/pbx device_provisioning/] } } } * In case if an API endpoint does not have a license: 403 Forbidden "Invalid license" reply is returned. * Add license based restrictions to API endpoints * /api documentation: - completely hide endpoints that do not have an active license - hide only methods that does not have an active license Change-Id: Iba45fc5068b02306a617fed7b5405f2210574b61	2 years ago
Rene Krenn	9c103302c8	MT#60575 dynamically load provisioning templates module ... Change-Id: Ibff509825f82a75c9b0221505a1673d78b401989	2 years ago
Marco Capetta	551cc2fb98	MT#60515 rename hm inbound/outbound directions to a_inbound/a_outbound ... inbound/outbound no longer represent the "full" direction and belong only to A leg, so they are renamed to a_inbound/a_outbound accordingly. Change-Id: I639b799c3649c9b3ca78eee831b49ef0cfa14287	2 years ago
Marco Capetta	fefa5ea173	MT#60511 Form/Header/Rule add direction "b_outbound" ... This is needed to perform manipulations to the SIP message just before it leaves the system on the B-Leg side. Change-Id: If93d0277582a086253b84088a93adc4ecfa187b1	2 years ago
Donat Zenichev	844a9e5920	MT#59011 Cleanup panel from the reference to "sip:localuser" ... An outdated and not used implementation for the "sip:localuser" in the ngcp-panel. Change-Id: I7c83bee0da07f7fafe7b1cb669a8c5080bc8565e	2 years ago
Marco Capetta	42f8747a6f	MT#59749 Add use_redirection flag to Call Forwards configuration ... This new flag controls wether the CF is processed as usual (flag with value 0, default) or generates a 302 redirect message back to the caller (flag with value 1). The implementation cover both the UI and the API. Change-Id: Idf945262e17de0d77bb612101d268fd6ea7a309e	2 years ago
Kirill Solomko	aef4c89197	MT#59662 enhance subscriber assigned header rules/sets handling ... * POST /api/headerrules now supports either 'set_id' or 'subscriber_id'. When 'subsriber_id' is specified, a subscriber assigned header rule set is automatically created if it does not exist, as well as automatically removed when its last header rule is deleted. * It is now possible to directly GET and DELETE /api/headerrules/:id where :id is a subscriber assigned header rule. * It is now possible to directly GET and DELETE /api/headerrulesets/:id where :id is a subscriber assigned header rule set. * Improve /api/headerrules data validation and duplicate header rule detection. * It is now possible to expand by /api/headerrules/?expand=set_id field Change-Id: I681bc61c2eed47a8e54847f07f31134f643930c2	2 years ago
Kirill Solomko	7aeaf0f16d	MT#59363 /api/subscriberregistrations change socket field to Text ... * socket field is changed to text for the API endpoint as by default in the LocationEntry form that is used by the UI the field is a prebuilt options list that comes from config.yml extra_sockets, and that severely limits the usage for the API. Change-Id: I71ee1f77dbf458c12655f840282375cee62b7534	2 years ago
Kirill Solomko	f399f3cb4d	MT#58826 enable expand by rwr_set_id ... * add global expand by rwr_set_id field * adjust rwr_set_id, rule_id in Condition and Action forms to have correct type (as they were inherited as Hidden) Change-Id: Id2529c67919b496303cee24da2a2c63f22df23e9	2 years ago
Rene Krenn	bbb964f422	MT#58765 expand zones in billing fees response ... Change-Id: I91b4ccdcc2146581e56310ef1c7af0ebb1f656d9	2 years ago
Rene Krenn	7370f0e967	MT#58675 add /api/billingfees missing fields ... Change-Id: I661e3bcebe07bbc92ba6e4c8eda05f5aefeaa5df	2 years ago
Marco Capetta	958e40e2ca	MT#54356 Fix swagger documentation for 'calllist' api ... The 'duration' field is reported in the documentation as 'number' but in fact it is a string, for example: "0:00:16.495". In the commit the definition of the parameter is changed from PosInteger to Text Change-Id: I317006f5bbb5c4b7ffea0abe29dc0b175d8f95e6	3 years ago
Kirill Solomko	cec12f7b1e	MT#58333 rework /api/phonebookentries ... * /api/phonebookentries is now split into 3 parts * /api/resellerphonebookentries * /api/customerphonebookentries * /api/subscriberphonebookentries main reason is because there are 3 different contexts (tables) that in the end return "id" which is also a resource identifier and it is not unique because the contexts handle their own ids, another reason is to simplify code and access definitions, as well as to have solid and easy representation. * /api/resllerphonebookentries * can be accessed by 'admin', 'reseller' roles * /api/customerphonebookentries * can be accessed by 'admin', 'reseller', 'subscriberadmin' roles * fix contract_id field to be correctly represented as 'customer_id' * /api/subscriberphonebookentries * can be accessed by 'admin', 'reseller', 'subscriberadmin', 'subscriber' roles * add 'shared' query filter * all the new endpoints * no more required query param fields * customer_id is now optional query parameter filter * add valid/existing resource checks for POST/PATCH/PUT ops * add correct auto filtering based on the user's role * various major code simplifications, fixes and code style improvements * csv download now also allows query param filters to be applied * fix documentation Change-Id: I735df96b7a7e18006a46b82a4fcc603e400ad9e6	3 years ago
Kirill Solomko	6953de937c	MT#33041 add reseller max subscribers support ... * Max subscribers can now be defined in the Reseller contract * Max subscribers is now shown in int Reseller's "Reseller Contract" Details (with an indictaion of how many subscribers are created out of the defined max subscribers, as well as when the limit is reached (similar to the Customer's Details page) * Add reseller subscribers count checks on the UI Create Subscriber page * Add reseller subscribers count checks in /api/contracts POST/PUT * Prevent max_subscribers definition for Peering contracts in /api/contracts POST/PUT Change-Id: I1561d4eb7da5b1a0a0c99acabd18d2a9cd98dec7	3 years ago
Rene Krenn	cde01e7d66	MT#53849 peer/reseller invoicing ... Change-Id: I0d869edb697779e7d02caaea70c237f0c87f4d50	3 years ago
Donat Zenichev	fd796a91ba	MT#56845 HG: introduce new field `Cancel Mode` ... This field controls a behavior upon cancelling unsuccessful legs: - terminate legs with CANCEL (default way) - terminate legs with BYE Change-Id: I2ff5c758c319714f0e6636db8b8ba5c0fd495e1f	3 years ago
Kirill Solomko	9d9c0d0669	MT#57580 add expose_to_customer support for NCOS ... * NCOS Levels and NCOS Sets now have expose_to_customer option (boolean). If enabled, the NCOS Level/Set can be seen and used by Customers in their and their subscribers' preferences * NCOS Levels and NCOS Sets with expose_to_customer = 0 (default) are not visible anymore to subscribers. * API GET /api/ncoslevels is now accessible by 'subscriberadmin' role and returns a list of NCOS Levels that belong to the same reseller and with expose_to_customer = 1 (fields are limited to id,name,description). * When NCOS Level is expose_to_customer is set from 1 to 0, all assigned ncos preferences for contracts and subscribers are that contain the NCOS Level are removed. Change-Id: Id7c444b4a0834939a128179ded6670705258519b	3 years ago
Kirill Solomko	c5b288a9da	MT#57085 fix /api/peeringroups form operations ... * API now has own GroupAPI form with the correct fields for API * db/form field name conversion is moved to the newly added resource_from_item() and process_form_resource() functions * simplify code for GET/POST/PUT/PATCH operations Change-Id: I99b76801a2894c8a4821513186796627db728189	3 years ago