34 Commits (master)

Author	SHA1	Message	Date
Richard Fuchs	b2b5600c16	MT#61630 invalidate rtpengine cached files ... Add class to make RPC calls to rtpengine. Add invokations to clear rtpengine audio cache where appropriate, whenever a file stored in DB is deleted or changed. Change-Id: I3660f9f67dfb0c68c1af80a5439982046be3b6f6	3 months ago
Kirill Solomko	205b27a267	MT#59478 API better transaction and error handling ... * Role/Entities*: POST/PUT/PATCH/DELETE methods changes: - support deadlock detection and transaction retry (2 retry attempts at the moment) - improve transaction control, use local $guard instead of saving the ref to $c->stash, as in that case it went out of scope too late and also reported an error message into the log about abnormal $guard out of scope interruption - move all non transaction related code outside of the scope - add error handling when methods such as update_item, and a like do not return the expected data, instead of simply going out of scope and resulting in an uncontrolled reply * Role/API: - rework transaction control: + get_transaction_control() is renamed to start_transaction() to better reflect what it does + complete_transaction() is renamed to commit_transaction() + remove unused %params arg + pass $guard into commit_transaction() instead of having it stored as $c->stash->{transaction_guard) that caused the $guard ref to be destroyed much late than expected (there was also a typo as transaction_quard, which is not relevant anymore with the changes + add check_deadlock() that is invoked when an exception is caught or an $c->errors contain an error, and if the error message represents a transaction error, the transaction block is re-invoked via "goto TX_START" - rework error(): + it now accepts args as following: ($self, $c, $code, $message, @errors) # code -> returned as HTTP code in the reply # message -> returned as HTTP message in the reply # errors -> contain errors for internal logging, last element often contains a DBIx exception + populates all @errors into $c->error so they are available on demend in the code via $c->error or $c->last_error + $c->log->error is not invoked now as the errors become printed in log_response() - log_response() now prints collected errors from $c->error correctly as a separate log line, that is alike to the other api logs so that those can be looked up by the request's tx_id, also all errors are now printed only into api.log * Adjust all $self->error() calls in catch($e) to include $e as the last argument, as well as the duplicate $c->log->error is removed from those ocassions * Remove all $c->log->error() calls as they are replaced with either $self->error() (that logs it correctly into api.log) or $c->error('err') that also adds it correctly into api.log * API::CallForwards: rework to use Entities/EntitiesItem * API::Contracts: rework POST to use Entities * API::PeeringGroups: rework POST to use Entities * API::SubscriberRegistrations: rework POST to use Entities * API::RewriteRuleSets: improve create_item() functionality * Utils/Message: add 'api_retry' log type * $c->session->{api_request_tx_id} is changed to $c->stash->{api_request_tx_id} because sometimes the session ref is different and a different tx_id becomes used Change-Id: I633ce7a8047b1bf00a2f6889003088edf0825dcd	1 year ago
Kirill Solomko	a4d54b10e4	MT#58709 rework NGCP::Utils::Sound::get_handlers_rs ... * get_handlers_rs() is renamed into get_file_handles() and reworked from an indented 'from' resultset into 2 separate resultsets, one fetching all the handles and another one files for the sound set, it is now returned as an array with the similar data. Reason for this rework is the deprecated use of 'from', that resulted in a lot of warnings in panel-fcgi.log: DBIx::Class::SQLMaker::ClassicExtensions::_join_condition(): ResultSet {from} structures with conditions not conforming to the SQL::Abstract::Classic syntax are deprecated: you either need to stop abusing {from} altogether, or express the condition properly using the { -ident => ... } * adjust file_handles data key names to better follow the naming conventions and readability, e.g.: groupname -> group_name, fileid -> file_id Change-Id: Ia91c9104c0b4dc79ee5bc359eb0b6e035e56ef3e	1 year ago
Kirill Solomko	22a8e95c29	MT#57708 sound set/file use READ COMMITTED ... * as changes to sound sets and sound files cause internal triggers + SP to be invoked, the gap locking should be reduced to avoid possible deadlocks, hence READ COMMITTED transaction isolation level is used for all sound sets and sound files change operations. * fix a condition that caused an evaluation error when both old_parent_id and parent_id are undef. Change-Id: I7e69a0a0e5878c03b086977933315e532aaa2a29	2 years ago
Kirill Solomko	89173442f3	MT#57223 improve sems audio cache invalidation ... * clear_audio_cache is now invoked also from: - when a sound file is added (to reflect use_parent/potential child sets) - when a parent is changed for a sound set (to reflect current and potential child sets) - when a sound set is removed (to reflect potential child sets) * clear_audio_cache() is reworked - clear_audio_cache() now calls virtual_child_sound_sets to fetch all potentially affected child sound sets and also clears audio cache for them. if the amount of fetched sound_sets is greater than 10000 then the the whole audio cache is invalidated * _clear_audio_cache_service() is reworked - supports/expects a list of sound sets and sends them as a string with ':' separator - if both sound handle and sound sets are provided it calls clearFiles (so that only the specific sound handle is cleared) - if only sound sets are provided it calls clearSets (so that all of the cached files beloning to the sets are removed) - if none of the above are provided it calls clearAll to invalidate the whole cache Change-Id: Ie85f208e27183e88665803b93bb16d7de8e3d7ac	2 years ago
Kirill Solomko	407d6f3f3b	MT#56693 /api/soundets fix DELETE subscriberadmin access ... * subscriberadmin can only delete items that belong to the same contract_id, otherwise 'read-only' forbidden error is returned Change-Id: I3ef2716039626bc1b208a5c7af06cf87f69cad73	2 years ago
Oleksandr Duts	8af29b6470	TT#154351 Sound set propagation ... * Contract default sound set - subscriber propagation for cases: - New customer sound set is created as default. - Customer sound set is changed to default. - New subscriber creation - setting contract default sound set id. * The mentioned cases were implemented for both UI and API. Change-Id: Ia4733c972ae388d3457d0336e3f85b85eec6e9a2	3 years ago
Irina Peshinskaya	bb04e38d65	Revert "Revert "TT#47906 Remove unnecessary code from /api/soundsets/"" ... This reverts commit 04500cbc40. Change-Id: Id13dc9c487420371bf5e69a519fd6a135d9f0d92	7 years ago
Kirill Solomko	04500cbc40	Revert "TT#47906 Remove unnecessary code from /api/soundsets/" ... This reverts commit af314a0d33. Change-Id: Ieb643178d9b8168f4c1b56dce6d621f306094751	7 years ago
Irina Peshinskaya	af314a0d33	TT#47906 Remove unnecessary code from /api/soundsets/ ... And fix discrepancy between doc and accepted parameter Change-Id: Ied28b5c93f2f6c528af4dba070054c828404e84e	7 years ago
Irina Peshinskaya	0aa178ee01	TT#37552 Fix formatting - add missed newline ... Change-Id: Ia33d864175439dca679916fbac667d78244fc0f1	7 years ago
Alexander Lutay	5626bfc678	TT#29620 Clean TAP test warning: ProhibitMutatingListFunctions = Don't modify in list functions ... Change-Id: Ic9f19e4ee575044947bb6c38e8ca8217b369394f	7 years ago
Irina Peshinskaya	0d4d8cdb23	TT#28460 Format: Remove excrescent empty lines ... Change-Id: I5ff73d92bf62451fb6dbdae85ca07428c3f5af5d	7 years ago
Irina Peshinskaya	75d6edbcd9	TT#28460 Format: add line between subs in API controllers ... Change-Id: I67f11fef716941dc965dffd4e8fbb1a211791bbf	7 years ago
Irina Peshinskaya	d527ebd953	TT#28460 Configs - replace Journalized items ... Change-Id: I5f6604cbd97e1b0b7eb4e566f1c1ef38f605bf33	7 years ago
Irina Peshinskaya	92e6215b71	TT#28460 Remove gather_default_action_roles ... Change-Id: Ie8080a9ac3b5b1004de456fe0ece7b31ed1541fe	7 years ago
Irina Peshinskaya	6dbb3b2229	TT#28460 Introduce return_representation in item packages ... Change-Id: Ibc2afdffd8a70245b6656f78bad2c4fc5273526e	7 years ago
Irina Peshinskaya	2498c8810e	TT#28460 Remove copy-pasted sub HEAD and sub end ... Change-Id: Ia06320ead891945eebe715fa34012a14d5529f17	7 years ago
Irina Peshinskaya	05774c2338	TT#28460 Remove copy-pasted sub OPTIONS ... Change-Id: I2b00ea267edcc3caa00eaac5753638794a13398c	7 years ago
Irina Peshinskaya	a113cbf1d0	TT#28460 Remove copy-pasted sub auto ... Without config changes - all custom subs are in place Change-Id: I23e50e7d1fcb02c245bc995a26e16e97308177c8	7 years ago
Irina Peshinskaya	b14f34f008	TT#28460 Change parents in API controllers ... Use Entities and EntitiesItem respectively Change-Id: I5d32b010cc51810acee42d14c5c24ce3d4267602	7 years ago
Andreas Granig	0d3bf6b1ce	TT#22827 Implement form factory ... This patch reuses existing forms by clearing them, rather than re-instantiating them again and again. Also, panel start time should be better due to less package pre-loading. Change-Id: Ia3e64fd4b4084bb5ec35a669c5840c9fc3c58f2e	8 years ago
Rene Krenn	72d9c10650	TT#13973 fix http method override ... the factory Catalyst::ActionRole::HTTPMethods action role is set for any action, and in race with our own NGCP::Panel::Role::HTTPMethods. the testcase could have been misleading ever since, as it uses DELETE /api/customers, which was present when implemting the method override initially, but dropped on the road to 4.5. the issue is resolved by overriding Catalyst::Controller::gather_default_action_roles. until the class hierachy refactoring is completed, only consistent way is to add the override to each api controller. the action_roles config attribute can therefore be removed. using Plack::Middleware::MethodOverride as an alternative from upstream has the drawback to work only with POST. but a required usecase is to also support translation DELETE requests to PATCH. Change-Id: I204ba59869a8327bdd5db8a867fbbb061d1c9e7c	8 years ago
Gerhard Jungwirth	3fc22bd277	TT#4334 adapt soundsets and autoattendants for subadmin ... Change-Id: I62f5d4d6227f209ebe1e8949fe0d5db5303c30e9	8 years ago
Gerhard Jungwirth	b34a7df2e1	MT#21193 use Sipwise::Base in api modules ... which implies, among others, strict and warnings. these should never be omitted and are one of the most frequent complaints of perlcritic currently. as a result TryCatch can be removed (imported by Sipwise::Base). also, "no Moose" is removed (has no effect). Change-Id: I901b6a9f0f6d426f62b73e68f2c5ad6365c1eeef	9 years ago
Rene Krenn	3e57109750	MT#19419 custom action role to support http method override ... Change-Id: I2d9fbf1f4feca76b91bdf73d4184ea707cc04e78	9 years ago
Guillem Jover	0632585eba	MT#18443 Use parent instead of base module ... Switch from the discouraged base module to the light-weight parent module. Also remove some surrounding BEGIN blocks from 'use parent' which are completely unnecessary. Change-Id: I3a669e8024f098819be45030ca9d1afa8756105c	9 years ago
Irina Peshinskaya	0272c297b8	MT#17173 Remove Moose Roles from API ... Conflicts: lib/NGCP/Panel/Controller/API/MetaConfigDefs.pm lib/NGCP/Panel/Controller/API/Root.pm Change-Id: I25597baebbec6e2436b15776da17bd6d1bfef838	9 years ago
Andreas Granig	04a64e1493	MT#16465 partly remove namespace::sweep and others ... Remove namespace::sweep Remove MooseX stuff Remove perl5i Remove Moose where possible Change-Id: I4f873afb466f4e58a04c3304ff74df2185470b03	10 years ago
Rene Krenn	a750b795f1	MT#11917 align snapshots in DELETE methods ... +error message in test descriptions texts +with recent changes to "description" fields to "required", the strict_sql_mode flage in api-journals.t has to be set. +missing cftimestes and cfdestinationsets DELETE methods are now finally "journalized" and tested OK. +other tests were disabled: >test_billingzone -> journal settings not in yaml file yet, test_customerpreferences -> a valid ncos level item has to be referred (since today?) - ncos api crud methods not journalized yet >test_profilepreferences -> a valid rewrite rule set item has to be referred (since today?) - rewrite rule set api crud methods not journalized yet >test_autoattendants -> journal settings not in yaml file yet >test_subscriberpreferences -> a valid ncos level item has to be referred (since today?) - ncos api crud methods not journalized yet Change-Id: I75b24b3eb0758d6e4e248758c7861f93abc791c0	10 years ago
Rene Krenn	bce0058915	MT#11917 test enviroment json boolean conversion ... Change-Id: I5b880bfdd39898a14e50949aa9858f800d4bd558	10 years ago
Rene Krenn	b5dca5e6e2	MT#11917 next batch of API resources w. journal ... -enhanced test detail: did not detect missing CRUD operations yet -query param 'operation' didn't work for 'recent' yournal entry of all API resources so far -fix of several copy paste errors in existing rest api code -... Change-Id: I71b54212d8126b0280fcad2e568fad52a673cbf0	10 years ago
Andreas Granig	1306ba53c6	MT#8561 API: filter write ops for r/o users	11 years ago
Andreas Granig	aaac4b6415	MT#7067 API: Implement sound set handling.	11 years ago