20 Commits (master)

Author	SHA1	Message	Date
Kirill Solomko	205b27a267	MT#59478 API better transaction and error handling ... * Role/Entities*: POST/PUT/PATCH/DELETE methods changes: - support deadlock detection and transaction retry (2 retry attempts at the moment) - improve transaction control, use local $guard instead of saving the ref to $c->stash, as in that case it went out of scope too late and also reported an error message into the log about abnormal $guard out of scope interruption - move all non transaction related code outside of the scope - add error handling when methods such as update_item, and a like do not return the expected data, instead of simply going out of scope and resulting in an uncontrolled reply * Role/API: - rework transaction control: + get_transaction_control() is renamed to start_transaction() to better reflect what it does + complete_transaction() is renamed to commit_transaction() + remove unused %params arg + pass $guard into commit_transaction() instead of having it stored as $c->stash->{transaction_guard) that caused the $guard ref to be destroyed much late than expected (there was also a typo as transaction_quard, which is not relevant anymore with the changes + add check_deadlock() that is invoked when an exception is caught or an $c->errors contain an error, and if the error message represents a transaction error, the transaction block is re-invoked via "goto TX_START" - rework error(): + it now accepts args as following: ($self, $c, $code, $message, @errors) # code -> returned as HTTP code in the reply # message -> returned as HTTP message in the reply # errors -> contain errors for internal logging, last element often contains a DBIx exception + populates all @errors into $c->error so they are available on demend in the code via $c->error or $c->last_error + $c->log->error is not invoked now as the errors become printed in log_response() - log_response() now prints collected errors from $c->error correctly as a separate log line, that is alike to the other api logs so that those can be looked up by the request's tx_id, also all errors are now printed only into api.log * Adjust all $self->error() calls in catch($e) to include $e as the last argument, as well as the duplicate $c->log->error is removed from those ocassions * Remove all $c->log->error() calls as they are replaced with either $self->error() (that logs it correctly into api.log) or $c->error('err') that also adds it correctly into api.log * API::CallForwards: rework to use Entities/EntitiesItem * API::Contracts: rework POST to use Entities * API::PeeringGroups: rework POST to use Entities * API::SubscriberRegistrations: rework POST to use Entities * API::RewriteRuleSets: improve create_item() functionality * Utils/Message: add 'api_retry' log type * $c->session->{api_request_tx_id} is changed to $c->stash->{api_request_tx_id} because sometimes the session ref is different and a different tx_id becomes used Change-Id: I633ce7a8047b1bf00a2f6889003088edf0825dcd	1 year ago
Marco Capetta	967bc581fe	TT#179901 Discontinue iNew dedicated features and code (part 2) ... Remove party_call_control feature Change-Id: I6ea1c725a463ee62696de93a7ee52080515cc2b7	2 years ago
Rene Krenn	cae5270af5	TT#56340 panel logline obfuscation ... adds gdpr obfuscation quoting for: + subscriber numbers + subscriber ip addresses + subscriber usernames + any logmessage "DATA": query parameters, form data, response data + subscriber uuid's + call id's + callforward sip uri's the quoting is centralized by $c->qs() ("quote sensitive"), using catalyst plugin mechanism. escape symbols are set to « (\x{ab}) and » (\x{bb}). generate_logfile_data_inventory.pl was modified to mark loglines with "gdpr affected" status, if $c->qs() was used in a log message. Change-Id: I0f42d7992594232ae33e5666b0a64009211c5b76	6 years ago
Kirill Solomko	091dee6d0b	TT#35507 use domain sms_peer preference for SMS outbound routing ... * smsc_peer preference is mandatory for NGCP::Utils::SMS::send_sms() and contains a handle of one of the avilable group=smsc id * sms_journal is extended to also store smsc_peer Change-Id: I1a368b55c263bb5ea2acda004bbaf463d6431413	7 years ago
Irina Peshinskaya	2b8ae95170	TT#28460 Remove unused libraries ... require Catalyst::ActionRole::ACL; require Catalyst::ActionRole::CheckTrailingSlash; require NGCP::Panel::Role::HTTPMethods; require Catalyst::ActionRole::RequireSSL; Change-Id: I3880fcb10067810d5e2de10a0c14bf6b15e34710	7 years ago
Irina Peshinskaya	0d4d8cdb23	TT#28460 Format: Remove excrescent empty lines ... Change-Id: I5ff73d92bf62451fb6dbdae85ca07428c3f5af5d	7 years ago
Irina Peshinskaya	75d6edbcd9	TT#28460 Format: add line between subs in API controllers ... Change-Id: I67f11fef716941dc965dffd4e8fbb1a211791bbf	7 years ago
Irina Peshinskaya	9fa2a19b4f	TT#28460 Replace configs - not journalized ... Change-Id: I9843a780817922f23faa91041d3fab9b7336b2a3	7 years ago
Irina Peshinskaya	92e6215b71	TT#28460 Remove gather_default_action_roles ... Change-Id: Ie8080a9ac3b5b1004de456fe0ece7b31ed1541fe	7 years ago
Irina Peshinskaya	2498c8810e	TT#28460 Remove copy-pasted sub HEAD and sub end ... Change-Id: Ia06320ead891945eebe715fa34012a14d5529f17	7 years ago
Irina Peshinskaya	05774c2338	TT#28460 Remove copy-pasted sub OPTIONS ... Change-Id: I2b00ea267edcc3caa00eaac5753638794a13398c	7 years ago
Irina Peshinskaya	a113cbf1d0	TT#28460 Remove copy-pasted sub auto ... Without config changes - all custom subs are in place Change-Id: I23e50e7d1fcb02c245bc995a26e16e97308177c8	7 years ago
Irina Peshinskaya	b14f34f008	TT#28460 Change parents in API controllers ... Use Entities and EntitiesItem respectively Change-Id: I5d32b010cc51810acee42d14c5c24ce3d4267602	7 years ago
Gerhard Jungwirth	24de4232e6	TT#30507 remove DataHal workaround layer ... (NGCP::Panel was loaded every time this was used) Change-Id: I62861e0756aaaf548c9be42b4842e9a06127119c	7 years ago
Andreas Granig	0d3bf6b1ce	TT#22827 Implement form factory ... This patch reuses existing forms by clearing them, rather than re-instantiating them again and again. Also, panel start time should be better due to less package pre-loading. Change-Id: Ia3e64fd4b4084bb5ec35a669c5840c9fc3c58f2e	8 years ago
Rene Krenn	72d9c10650	TT#13973 fix http method override ... the factory Catalyst::ActionRole::HTTPMethods action role is set for any action, and in race with our own NGCP::Panel::Role::HTTPMethods. the testcase could have been misleading ever since, as it uses DELETE /api/customers, which was present when implemting the method override initially, but dropped on the road to 4.5. the issue is resolved by overriding Catalyst::Controller::gather_default_action_roles. until the class hierachy refactoring is completed, only consistent way is to add the override to each api controller. the action_roles config attribute can therefore be removed. using Plack::Middleware::MethodOverride as an alternative from upstream has the drawback to work only with POST. but a required usecase is to also support translation DELETE requests to PATCH. Change-Id: I204ba59869a8327bdd5db8a867fbbb061d1c9e7c	8 years ago
Irina Peshinskaya	2073b9e760	TT#9309 Introduce local version of the Data::HAL::Link ... Change-Id: Ifdf95cef32f0d118330c20316ed447e00c6dae3c	8 years ago
Irina Peshinskaya	41f32401a7	TT#9309 Introduce local version of the Data::HAL with default forcearray ... Change-Id: Ie33396a75fc6d27fd28fe8f7717caba0a476c776	8 years ago
Andreas Granig	5ca51f930a	TT#2371 Implement 3pcc for sms ... If pcc is enabled for a subscriber, don't forward sms immediately, rather than mark for forwarding and let the API forward it on incoming request. Change-Id: I75104266a1c1fccc7165af9ba65b31f085d7081f	8 years ago
Kirill Solomko	1bbad6aaf2	TT#2651 add /partycallcontrols API ... Used to notify NGCP about pending calls and sms. * /partycallcontrols is for handling incoming call control requests from external API sources Change-Id: I4d886f941f19f659017e32504fdb10e8ae02ba8b	8 years ago