35 Commits (master)

Author	SHA1	Message	Date
Marco Capetta	a2a01d4690	MT#59979 permit GET on resellers and billing profiles items even without license ... In some cases the UI requires to GET information from a specific reseller or billing profile because needed to show/created other endpoints (for example 'customers'). Due to that it has been added the possiiblity to do the GET not only of the list of the resellers and biling profiles, but also of each specific item. Change-Id: Iebbbbc494ce71e616d8e41ca20e97bebce7998b8	9 months ago
Kirill Solomko	9d021be65a	MT#59979 add license control ... * UI and API parts are now under license control * new Util::License::get_license($c, $name) - fetches license status by name (1 if enabled, and also if /proc/ngcp/check if 'ok') * add Catalyst::Plugins::NGCP::License with license($name) to fetch valid license by name from anywhere using $c->license('pbx') or from the templates using c.license('pbx'). It internally uses Util::License::get_license($c, $name) * License::get_license_status($c) now requires $c as first argument as well logs license status check errors. * new ActionRoles::License that enables usage of :Does(License) RequiresLicense('pbx') LicenseDetachTo('/denied_page') in the Controller chains * Add license control for UI elements and return 403 Forbidden if a resource is covered by licenses and the license is not active * Hide UI elements if a license is not active * API/Entities/Entities new $c->set_config key: - per endpoint: $c->set_config({ required_licenses => [qw/pbx device_provisioning/] } - or per method: $c->set_config({ required_licenses => { POST => [qw/pbx device_provisioning/] } } } * In case if an API endpoint does not have a license: 403 Forbidden "Invalid license" reply is returned. * Add license based restrictions to API endpoints * /api documentation: - completely hide endpoints that do not have an active license - hide only methods that does not have an active license Change-Id: Iba45fc5068b02306a617fed7b5405f2210574b61	9 months ago
Kirill Solomko	205b27a267	MT#59478 API better transaction and error handling ... * Role/Entities*: POST/PUT/PATCH/DELETE methods changes: - support deadlock detection and transaction retry (2 retry attempts at the moment) - improve transaction control, use local $guard instead of saving the ref to $c->stash, as in that case it went out of scope too late and also reported an error message into the log about abnormal $guard out of scope interruption - move all non transaction related code outside of the scope - add error handling when methods such as update_item, and a like do not return the expected data, instead of simply going out of scope and resulting in an uncontrolled reply * Role/API: - rework transaction control: + get_transaction_control() is renamed to start_transaction() to better reflect what it does + complete_transaction() is renamed to commit_transaction() + remove unused %params arg + pass $guard into commit_transaction() instead of having it stored as $c->stash->{transaction_guard) that caused the $guard ref to be destroyed much late than expected (there was also a typo as transaction_quard, which is not relevant anymore with the changes + add check_deadlock() that is invoked when an exception is caught or an $c->errors contain an error, and if the error message represents a transaction error, the transaction block is re-invoked via "goto TX_START" - rework error(): + it now accepts args as following: ($self, $c, $code, $message, @errors) # code -> returned as HTTP code in the reply # message -> returned as HTTP message in the reply # errors -> contain errors for internal logging, last element often contains a DBIx exception + populates all @errors into $c->error so they are available on demend in the code via $c->error or $c->last_error + $c->log->error is not invoked now as the errors become printed in log_response() - log_response() now prints collected errors from $c->error correctly as a separate log line, that is alike to the other api logs so that those can be looked up by the request's tx_id, also all errors are now printed only into api.log * Adjust all $self->error() calls in catch($e) to include $e as the last argument, as well as the duplicate $c->log->error is removed from those ocassions * Remove all $c->log->error() calls as they are replaced with either $self->error() (that logs it correctly into api.log) or $c->error('err') that also adds it correctly into api.log * API::CallForwards: rework to use Entities/EntitiesItem * API::Contracts: rework POST to use Entities * API::PeeringGroups: rework POST to use Entities * API::SubscriberRegistrations: rework POST to use Entities * API::RewriteRuleSets: improve create_item() functionality * Utils/Message: add 'api_retry' log type * $c->session->{api_request_tx_id} is changed to $c->stash->{api_request_tx_id} because sometimes the session ref is different and a different tx_id becomes used Change-Id: I633ce7a8047b1bf00a2f6889003088edf0825dcd	1 year ago
Rene Krenn	92455d8566	TT#107051 enable "add" for PATCH /billingprofiles/x ... Change-Id: Ifc9e54987eacd5f4b09e15c8866c25e6537619d3	4 years ago
Rene Krenn	00f0614ef9	TT#107051 fix PATCH /billingprofiles/x - peaktimes ... Change-Id: I3d074976f15618d84cfd8ee4694a0fd4250fe091	4 years ago
Kirill Solomko	ce664263b2	TT#65101 add ccareadmin ccare roles ... * ccareadmin and ccare roles have full access to Customers, Subscribers and their preferences/settings, and read-only access to BillingProfiles,InvoceTemplates, EmailTemplates * ccare role is restricted to the related reseller Change-Id: I6cf7d3adf912f0fa98d1ef5c02abea2f4331ec4b	6 years ago
Flaviu Mates	378d27d0a9	TT#33114 Implement DELETE method to terminate BillingProfiles and BillingNetworks ... Change-Id: I5cb2beee5c8edd8efe4b1435a5f4f67d6737be19	6 years ago
Alexander Lutay	5626bfc678	TT#29620 Clean TAP test warning: ProhibitMutatingListFunctions = Don't modify in list functions ... Change-Id: Ic9f19e4ee575044947bb6c38e8ca8217b369394f	7 years ago
Irina Peshinskaya	0d4d8cdb23	TT#28460 Format: Remove excrescent empty lines ... Change-Id: I5ff73d92bf62451fb6dbdae85ca07428c3f5af5d	7 years ago
Irina Peshinskaya	75d6edbcd9	TT#28460 Format: add line between subs in API controllers ... Change-Id: I67f11fef716941dc965dffd4e8fbb1a211791bbf	7 years ago
Irina Peshinskaya	d527ebd953	TT#28460 Configs - replace Journalized items ... Change-Id: I5f6604cbd97e1b0b7eb4e566f1c1ef38f605bf33	7 years ago
Irina Peshinskaya	92e6215b71	TT#28460 Remove gather_default_action_roles ... Change-Id: Ie8080a9ac3b5b1004de456fe0ece7b31ed1541fe	7 years ago
Irina Peshinskaya	6dbb3b2229	TT#28460 Introduce return_representation in item packages ... Change-Id: Ibc2afdffd8a70245b6656f78bad2c4fc5273526e	7 years ago
Irina Peshinskaya	2498c8810e	TT#28460 Remove copy-pasted sub HEAD and sub end ... Change-Id: Ia06320ead891945eebe715fa34012a14d5529f17	7 years ago
Irina Peshinskaya	05774c2338	TT#28460 Remove copy-pasted sub OPTIONS ... Change-Id: I2b00ea267edcc3caa00eaac5753638794a13398c	7 years ago
Irina Peshinskaya	a113cbf1d0	TT#28460 Remove copy-pasted sub auto ... Without config changes - all custom subs are in place Change-Id: I23e50e7d1fcb02c245bc995a26e16e97308177c8	7 years ago
Irina Peshinskaya	b14f34f008	TT#28460 Change parents in API controllers ... Use Entities and EntitiesItem respectively Change-Id: I5d32b010cc51810acee42d14c5c24ce3d4267602	7 years ago
Andreas Granig	0d3bf6b1ce	TT#22827 Implement form factory ... This patch reuses existing forms by clearing them, rather than re-instantiating them again and again. Also, panel start time should be better due to less package pre-loading. Change-Id: Ia3e64fd4b4084bb5ec35a669c5840c9fc3c58f2e	8 years ago
Rene Krenn	72d9c10650	TT#13973 fix http method override ... the factory Catalyst::ActionRole::HTTPMethods action role is set for any action, and in race with our own NGCP::Panel::Role::HTTPMethods. the testcase could have been misleading ever since, as it uses DELETE /api/customers, which was present when implemting the method override initially, but dropped on the road to 4.5. the issue is resolved by overriding Catalyst::Controller::gather_default_action_roles. until the class hierachy refactoring is completed, only consistent way is to add the override to each api controller. the action_roles config attribute can therefore be removed. using Plack::Middleware::MethodOverride as an alternative from upstream has the drawback to work only with POST. but a required usecase is to also support translation DELETE requests to PATCH. Change-Id: I204ba59869a8327bdd5db8a867fbbb061d1c9e7c	8 years ago
Gerhard Jungwirth	b34a7df2e1	MT#21193 use Sipwise::Base in api modules ... which implies, among others, strict and warnings. these should never be omitted and are one of the most frequent complaints of perlcritic currently. as a result TryCatch can be removed (imported by Sipwise::Base). also, "no Moose" is removed (has no effect). Change-Id: I901b6a9f0f6d426f62b73e68f2c5ad6365c1eeef	9 years ago
Rene Krenn	3e57109750	MT#19419 custom action role to support http method override ... Change-Id: I2d9fbf1f4feca76b91bdf73d4184ea707cc04e78	9 years ago
Guillem Jover	0632585eba	MT#18443 Use parent instead of base module ... Switch from the discouraged base module to the light-weight parent module. Also remove some surrounding BEGIN blocks from 'use parent' which are completely unnecessary. Change-Id: I3a669e8024f098819be45030ca9d1afa8756105c	9 years ago
Irina Peshinskaya	0272c297b8	MT#17173 Remove Moose Roles from API ... Conflicts: lib/NGCP/Panel/Controller/API/MetaConfigDefs.pm lib/NGCP/Panel/Controller/API/Root.pm Change-Id: I25597baebbec6e2436b15776da17bd6d1bfef838	9 years ago
Rene Krenn	ad3719772a	MT#17263 edit offpeak/onpeak using api ... +input validation for verlapping time ranges for both weekdays and special. can be disabled. +root entiy locking +peektime special is growing and not paginated, so PUT/PATCH will get slower if special peektimes are added on a regular basis. they can be removed using the UI however +testcase to check overlap detection Change-Id: I935d943078ab5c81263da88ecd04e004deb26c8b	9 years ago
Andreas Granig	04a64e1493	MT#16465 partly remove namespace::sweep and others ... Remove namespace::sweep Remove MooseX stuff Remove perl5i Remove Moose where possible Change-Id: I4f873afb466f4e58a04c3304ff74df2185470b03	10 years ago
Rene Krenn	b5dca5e6e2	MT#11917 next batch of API resources w. journal ... -enhanced test detail: did not detect missing CRUD operations yet -query param 'operation' didn't work for 'recent' yournal entry of all API resources so far -fix of several copy paste errors in existing rest api code -... Change-Id: I71b54212d8126b0280fcad2e568fad52a673cbf0	10 years ago
Rene Krenn	96c731a144	MT#11917 Journaling for first set of resources ... the journal module introduces a change history of resources modified by api invocations. the history of the 'customer' resource demo is accessible at /api/customers/x/journal. Change-Id: I4d5d11bc3e35160feed587ce4c1db565991866b2	10 years ago
Andreas Granig	1306ba53c6	MT#8561 API: filter write ops for r/o users	11 years ago
Andreas Granig	45a42b9b61	MT#6479 API: Allow resellers to access some funcs.	11 years ago
Andreas Granig	11d83a7ead	MT#6283 Implement search-framework. ... - let custom roles "derive" from main api role - have an item_rs in each role - call search logic after each item_rs call automatically - render search query doc dynamically	11 years ago
Andreas Granig	2f749a341a	MT#3933 API: add subscriber editing via PUT/PATCH	11 years ago
Andreas Granig	c799df3ebd	MT#3925 API: dynamically render API documentation.	11 years ago
Andreas Granig	71658e12a7	MT#5599 Rework auth/authz for pwd-based API access ... Cleanup unnecessary realms. Use roles instead of realms for authz. HTTP basic auth for api access. Use admin/reseller roles instead of api_admin/api_reseller. Fix API::Root invalid_user detaching.	11 years ago
Andreas Granig	cd2d9e47aa	MT#5255 Fix boolean handling and HFH validation	12 years ago
Andreas Granig	829b432b47	MT#5299 API: PUT/PATCH/GET billingprofiles item	12 years ago