871 Commits (master)

Author	SHA1	Message	Date
Kirill Solomko	1b605496cb	MT#66370 /api/platforminfo add grafana section ... * grafana config section is exposed for users with the admin role. Change-Id: Ia59eae42ca96b1aec7dc5953f6a50953842c240c	4 days ago
Rene Krenn	5e9aeb21f2	MT#66071 add contact_email and billing_profile_name filters to contracts API ... Add contact_email and billing_profile_name query params to GET /api/contracts/, plus order_by support for both, so the Contact Email and Billing Profile columns can be filtered and sorted. billing_profile_name resolves through the actual_billing_profile relationship, which matches the currently effective profile already reported as billing_profile_id, rather than any historical or future billing mapping. The column values themselves need no API change, as ?expand=contact_id,billing_profile_id already returns them as contact_id_expand.email and billing_profile_id_expand.name. Change-Id: I4022a602f3d1dcca15617a3da4c4950edff34ee9	3 weeks ago
Rene Krenn	7251904014	MT#66160 fix 500 on contract-only provisioning templates ... The API POST success path assumed a subscriber was created. Contract-only templates now log and return Location for the created contract instead. Change-Id: Ibf4990038643840f48798dff4bd518a08f7f562b	3 weeks ago
Marco Capetta	45aafa74bb	MT#65904 report rejected CSV rows on calllistsuppressions API ... A CSV upload to /api/calllistsuppressions/ answered with a success status even when rows were rejected, so a user had no way to notice that the import was incomplete. The rejected rows are reported with a 422 now, whose message tells how many rows were imported and which line numbers were skipped, the same information the web interface shows. Change-Id: I7ab235227a3f69c8739e8ff2b199debf6fa8a304	1 month ago
Rene Krenn	ae0be66a54	MT#65953 add status/not_status filters to contracts API ... Allow comma-separated status and not_status query params on GET /api/contracts/, matching /api/customers. Change-Id: Ic7857dd08bc04806ee8a42fcfe5c125df614578e	1 month ago
Kirill Solomko	e4a0c7b734	MT#66012 add collections filter by resource ID ... * all GET "collection" now can search by the resource ID as /?id=123. this is beneficial for when a filtering logic needs to filter by various params and one of them is the id, as querying by /:id also returns a different type of the response. * the id is only injected into the accepted query params if it doesn't exist there (some endpoints might have it already). * the id is also injected (on top) into the API documentation as: id => 'Filter the collection by resource ID' Change-Id: I96fa5a96e55c3b1cd38cafd7c9f05b27aaa32f7d	1 month ago
Kirill Solomko	db77631c79	MT#65239 enhance /api/platforminfo with meta release info ... * /api/platforminfo now returns a new 'release_info' section that contains info about: - latest NGCP release - latest NGCP LTS release - info about the current release such as expiration dates, lts, supported flags. - 'this' subsection contains current release version and also a platform type * caching support, the info is retrieved and parsed only once after the ngcp-panel service restart and then once every hour and only if the content is changed. * NGCP::Panel add Catalyst::Cache and Plugin::Cache support accessible via $c->cache Change-Id: I50c58e2563db5962f498d3523db95b4f6372596c	1 month ago
Rene Krenn	871f002b95	MT#65713 include contract_cnt and voucher_cnt in profilepackages ... * expose already-selected contract and voucher counts on GET responses * document them as readonly PackageAPI fields and strip on write * apply the same limit+1 count cap (default 10) as billingprofiles Change-Id: If1644a3b7f9824c4ce03a68c2a8fec166e3ec3ef	1 month ago
Kirill Solomko	d12b794b21	MT#65906 /api/platforminfo returns call_flow data ... * call_flow ip:port info is returned for admin users Change-Id: Ie98222672beab61d2d02fc6b182f8fb3a667df55	2 months ago
Marco Capetta	f7ac7d96be	MT#65890 Fix regression on PATCH calls to CallForwardsItem api ... Add missing "add" and "remove" operations for /api/callforwardsitem PATCH When the endpoint was refactored in commit 205b27a26 to use the EntitiesItem, this block was dropped - my $json = $self->get_valid_patch_data( - c => $c, - id => $id, - media_type => 'application/json-patch+json', - ops => [qw/add replace remove copy/], - ); And by default EntitiesItem allows only "replace, copy" operations. They missing operations are added back using set_config({ PATCH => { ops => [qw/add replace remove copy/] }, }) Change-Id: Id9c131d679511efa1eeef040373ae7b53a4f93f8	2 months ago
Marco Capetta	5cf446e477	MT#65852 support wildcard search on calllistsuppressions domain ... The domain query parameter of GET /api/calllistsuppressions/ now uses the wildcard query type, so "*" can be used the same way as in the pattern and label filters, e.g. domain=*word*, domain=word* and domain=*word. A value without any "*" still matches exactly, and an empty value still filters for the suppressions applying to any domain. Change-Id: Ib1b03faefdf9dba69168fb3b0a4273b5bff5756f	2 months ago
Kirill Solomko	ed41c13926	MT#65799 customercontacts, systemcontacts expand terminated contacts ... * when expand is used to expand a contact_id, it now expands contacts that are in any state (including terminated). * direct use of /api/customercontacts and /api/systemcontacts remains unchanged. Change-Id: I89738968fafd061d8a516aeab82c7a0fddd5c64b	2 months ago
Marco Capetta	50b518c259	MT#51865 support CSV upload and download on calllistsuppressions API ... Add the CSV bulk import and export already offered by the web interface to the /api/calllistsuppressions/ collection. The suppressions are downloaded by requesting the collection with an "Accept: text/csv" header. The suppressions are uploaded by POSTing the CSV in the request body with the "text/csv" content type, optionally together with a "purge_existing=true" parameter. The columns are domain, direction, pattern, mode and label, without a header row. Change-Id: I000de048b95d7cba6cb38a986914c49810cf626e	2 months ago
Marco Capetta	6a942068be	MT#51865 add calllistsuppressions API endpoint ... Expose the global call list suppressions (billing.call_list_suppressions) via /api/calllistsuppressions/, so far only manageable through the admin web interface. Supports GET, POST, PUT, PATCH and DELETE, and is restricted to the admin role. The already existing but so far unreferenced form CallListSuppression::SuppressionAPI is reused for validation and API documentation. The domain/direction/pattern uniqueness of the table is enforced in check_duplicate, which covers both create and update. Journaling is enabled for create, update and delete operations. Change-Id: I11be61ace5c64610644b714baa45d984313f647c	2 months ago
Marco Capetta	d01cff87ba	MT#65224 renumber voicemail msgnum on folder change and delete ... Asterisk uses its built-in ODBC voicemail storage against kamailio.voicemail_spool, which expects msgnum to be contiguous 0..N-1 within each (mailboxuser, dir) folder. Asterisk maintains that invariant itself, but the panel rewrote dir (or deleted a row) without ever touching msgnum, leaving gaps and duplicates that make asterisk mis-play and mis-count the messages. Add two helpers to Utils::Subscriber reproducing the asterisk semantics: * renumber_voicemail_folder() compacts a single folder to 0..N-1 ordered by (msgnum, id). It skips greetings, which live in the same table with msgnum -1. * move_voicemail_to_folder() appends the message at the end of the target folder the way asterisk does (last_msg_index + 1), then compacts both the source and the target folder. Both run inside a transaction, so the web UI paths that have no transaction guard of their own are covered as well. Use them in all four affected paths: * PATCH/PUT /api/voicemails/{id} (Role::API::Voicemails) * DELETE /api/voicemails/{id} (Controller::API::VoicemailsItem) * mark_voicemail_read() for the CSC/admin listen action * delete_voicemail() in the subscriber web UI The compaction is deliberately self-healing, so it also repairs folders already corrupted by the previous behaviour. Change-Id: I665de1966bc37c1069ff56fb30c99da85f224f71	3 months ago
Kirill Solomko	9470652038	MT#65572 rework call forward sets resource validation ... * streamline the validation behaviour among all the call forward set endpoints to be the same: - all of them contain process_form_resource() check_resource() check_duplicate() and also update_item() calls those functions in the exact order * subscriber_id validation is performed in check_resource only once and removed from the other places. * subscriberadmin role now uses the same Form as the admin users (that contains the subscriber_id field). * subscriberadmin role is now allowed to provide with the subscriber_id, otherwise if undefined, the user's id is taken. * check_resource() now checks for subscriberadmin if the subscriber_id belongs to the same customer. * check_duplicate() only contains the duplicate entry check. * the following above fix inconsistent validation that produces different results, minimises the amount of sql queries as well as extends the functionality to enable the subscriberadmin role to create call forward sets on behalf of the own subscribers. Change-Id: I60ddd5aa2bd5228efeca9f8c1a593d24179b959a	3 months ago
Kirill Solomko	deeaa10794	MT#64924 add PUT|PATCH cfmappings delete_unused_sets support ... * with PUT or PATCH /api/cfmappings/:id/?delete_unused_sets=1, all sets that become unused after the request and also a) not used by another subscriber b) belong to the same subscriber are are automatically deleted. * add query_params "delete_unused_sets" doc for PUT and PATCH Change-Id: I1485d35e905de391ed3e92d0fe75f3e72155a239	3 months ago
Kirill Solomko	67f7eaa65b	MT#65550 add PUT,PATCH,DELETE swagger query_params support ... * with a snippet as: __PACKAGE__->set_config({ ... DELETE => { query_params => [ { param => 'foo', description => 'Description', query_type => 'integer', }, ], }, }); it renders the query parameter on the API swagger documentation. * query_type must be according to the swagger API, of ommitted it falls back to 'string'. Change-Id: I9345a97ad9a4c674e757cd032fb719f51c25f5b6	3 months ago
Kirill Solomko	0c9f3e5ed0	MT#65549 add cf sets DELETE ?unassign_first=1 support ... * it is now possible to invoke the following endpoints as: - DELETE /api/cfbnumbersets/:id?unassign_first=1 - DELETE /api/cfsourcesets/:id?unassign_first=1 - DELETE /api/cftimesets/:id?unassign_first=1 in which case before the actual deletion, the cf set is unassigned from the cf_mappings, so that the cf_mappings are not automatically deleted by the constraints. Change-Id: I7fa40eba2790edcc62d8430ebbe6f752b13353f9	3 months ago
Rene Krenn	19ed6c93f5	MT#65173 billing networks optional usage columns ... Change-Id: I730950af2d53570faff1a68ddc2e8c13952279f3 Co-authored-by: Cursor <cursoragent@cursor.com>	4 months ago
Rene Krenn	12d2906b31	MT#65173 billing profiles DELETE usage checks ... Change-Id: I359e5d74fb8f46c5892584d11fd22ccab1a09f52 Co-authored-by: Cursor <cursoragent@cursor.com>	4 months ago
Rene Krenn	9714863a98	MT#65173 add optional usage columns to billing profiles API ... load contract_cnt, contract_exists, and package_cnt only when requested via query params, matching the web UI ajax behavior while keeping update validation working for interval field changes. Change-Id: Ie1d889fcac3227e81f37031c55fcf765e489cf9a	4 months ago
Kirill Solomko	9a12bc2ddf	MT#65445 autosync "cli" on update with the same primary_number ... * on /api/subscribers PUT/PATCH if the "auto_sync_cli" config option is enabled and the primary_number is unchanged, check and sync the "cli" preference value if it differs from the primary number. * Controller::API::Subscribers remove incorrect "last" occurences. * /api/subscribers return "primary_number: null if it's not defined. * api-subscribers.t fix exists to defined for the $resource->{primary_number} check as it might be there as undef. * api-rest/tests fix primary_number to be unique for ceratin failing tests. Change-Id: I10c784ee6d3e2544d97dfaa66dc7aae10ba1990a	4 months ago
Kirill Solomko	44cab5c602	MT#65092 fix /api/voicemails $q variable typo ... Change-Id: I7e662960b873124762dcc3711636fc9a243fe0fa	4 months ago
Kirill Solomko	8089861097	MT#65092 address query param string pattern match in certain endpoints ... * new function Generic::Utils::parse_query_string($str) that performs the following: - escapes unescaped '%' and '_' occurrences when needed (as they are reserved internally for the "like" operation - converts all unescaped '*' and '?' chars to their "sql like op" '%' and '_' counterparts. * change endpoints that used escape_search_string_pattern() to use parse_query_string() instead, to avoid: a) overescaping b) automatic string wrapping with '*' that prevents strict match all sql builder queries that use $q after parse_query_string() use returned $op ('like', '=') as the operator, to easily set strict or like match. Change-Id: I961b5d032036f13a7460d91f8c197538ffba1997	4 months ago
Rene Krenn	91ac920f8d	MT#65177 contract_id filter for CustomerLocations ... the contract_id query param allows to filter CustomerLocations by contract_id. Change-Id: I66e89fc65aa46a80c6a39fd5892c6410116da91a	4 months ago
Kirill Solomko	a7f13331e8	MT#65048 check subscriber profile preferences on update ... * when subcsriber preferences are modified, keys are checked against a subscriber profile and if any of them is not accessible (disabled in the assigned profile) a 422 error is now raised. That is mostly relevant for PATCH "op":"add" that returned 204 OK before regardless. This change only affects access to /api/subscriberpreferences by the 'subscriber' and the 'subscriberadmin' roles * Controller::API::SubscriberPreferencesItem: remove unintended "last" from catch {}. * Utils::Preferences: remove 2 debug lines. Change-Id: Ie20e5b8d4420c814bc786c34ddd952ee13d355ae	5 months ago
Kirill Solomko	e956227ab0	MT#64972 /api/customers email_template auto assign change ... * if an email template id is explicitly provided as "null", it will be assigned as "null". * remove email templates auto creation (copy from raw) for resellers if they do not have the specific one assigned to them. that proved to work contraversal as if a customer doesn't have an email template assigned to the reseller, and does not want to change their business logic (by explicitly providing "null") during POST /api/customers for those templates, the auto creation for reseller prevents it and causes complications, as well as it's not the intended role for /api/customers to automatically affect reseller configuration in such a way. Change-Id: Ie8cf0bffdd397279260a9601367f4457634ed5c8	6 months ago
Marco Capetta	079ae19306	MT#64627 Call sip_dispatcher_reload when peer transport is updated ... In case of update of the transport protocol used by the peer, the kamailio dispatcher module has to be reloaded because the probing. if enabled, has to be sent using the new protocol. Change-Id: Iab5fe2c63547068c3aca0e46e8862b025475d8f0	6 months ago
Kirill Solomko	d1280015c4	MT#62339 /api/subscriberregistrations add total_count support ... * Panel::Utils::RedisLocationResultSet: - add total_count() that returns total count of all entries without pagination - add total count aggregation during _find(), _row_from_mapkey(), _scan() that aggregates total entries that can be shown without pagination * SubscriberRegistrations: - return correct total_count of all possible entries that can be shown (without pagination) - fix a 500 error when 'subscriber_id' contains a non-existing subscriber Change-Id: I914356a809a005c21bb662498ca78dd35affc0ee	7 months ago
Rene Krenn	47b5cc7b7b	MT#64594 prov templates: fraud preferences support ... this change introduces support to set contract fraud preferences via provisioning template, ie: fraud_preferences: fraud_interval_limit: "function { current_fraud_interval_source == 'profile' ? current_fraud_interval_limit : 10000; }" fraud_interval_lock: "function { current_fraud_interval_source == 'profile' ? current_fraud_interval_lock : 2; }" fraud_interval_notify: "function { current_fraud_interval_source == 'profile' ? current_fraud_interval_notify : 'jdoe@sipwise.com'; }" fraud_daily_limit: 500 fraud_daily_lock: 2 fraud_daily_notify: "jdoe@sipwise.com" Change-Id: Id7e67fd71e0b1d291ee5e2ea9e2ea9b6bae64781	8 months ago
Kirill Solomko	81a4a2ff03	MT#64434 /api/platforminfo add multisite support ... * return multisite data if multi site is enabled, otherwise an empty hash. Change-Id: I46f4aa30fe7b31949cd471079d749d75d2f70f01	8 months ago
Kirill Solomko	a97490e97d	MT#64297 /api/platforminfo expose sip.external_sbc config ... * sip.external_sbc options are exposed to authenticated admin users in /api/platforminfo Change-Id: Ifea5eb43b8638299d1ef916c65a17fa18f833f82	9 months ago
Kirill Solomko	638b2f20ae	MT#64295 fix /api/peeringservers via_route validation ... * NGCP::Form::Peering::Server rework via_route URI check from a comma separated list to a single value as well as improve value transformation and validation logic * /api/peeringservers add via_route value transformation as pre_proccess_form_resource() Change-Id: I742a40534a4861dd30e0ccbc6684c02d2386f642	9 months ago
Guillem Jover	b6e2baa6c7	MT#63479 Remove prosody support ... Change-Id: I9d3e268450396c12e4058ac9394a80bb191d7635	10 months ago
Kirill Solomko	56b15e8197	MT#64067 fix subscriberpreferences PUT update_item ... * PUT update_item is fixed to properly expect 3 values Change-Id: Id63445f76ffbc312aadafc7b502fffd070eb0089	11 months ago
Kirill Solomko	eae620f204	MT#64067 address deadlock detection for preferences ... * improve Role/API/Preferences err_code callback to check deadlocks (via $self->check_deadlock) and set $process_extras->{retry_tx} = 1 so that the outer caller can act upon it and restart the transaction. * increase deadlock attempts from 2 to 5 as some deadlocks seem to take longer time to resolve. * wait 1 second between deadlock retry attempts as otherwise if a deadlock takes more than 1 second and all the retries are done within less than a second it will cause an error. * EntitiesItem: add support for retry_tx and call goto TX_START if $process_extras->{retry_tx} (when check_deadlock is processed externally, like in Utils::Preferences::update_item in the err_code callback). Change-Id: Ib56383710041c21d72782047a852353296c22215	11 months ago
Kirill Solomko	6e2ca03a6e	MT#63997 make underrun lock on requests optional ... * a new ngcp_panel option $c->config->{api}{underrun_lock_on_request} is in place and if disabled - the underrun lock logic on GET contracts,customers,subscribers,subscriberpreferences, and POST subscribers is skipped. Change-Id: I5ea337ce42b3c979fe55b3df3516a19548b64f90	11 months ago
Marco Capetta	4f64c07ac5	MT#63893 Fix typo in commit 3b17ab6c54 ... Change-Id: Ieaa0f18cfab821a2c85de1a3602946c1855c8dba	12 months ago
Marco Capetta	3b17ab6c54	MT#63893 Call 'sip_dispatcher_reload' while changing peerings via API ... For scenarios when: * a peering server is enabled or disabled * a peering probe is enabled or disabled * a peering group with active peering servers or peering probes is removed a "sip_dispatcher_reload" XMLRPC request is sent to kamalilio-proxy, otherwise the dispatcher cache is not reflected and therefore, not available with the actual state until next kamailio-proxy restart. Change-Id: If3a98115224eb132126d5a53df7320cb6a33deba	12 months ago
Rene Krenn	2a5bd4c409	MT#63706 skip_locked for DELETE /api/subscriber/id ... while acquiring locks is skipped nowadays for collections eg. a GET /api/subscribers/, timeouts were still reported for individual DELETE /api/subscriber/id requests. this change adds logic to skip acquiring locks for DELETE /api/subscribers. there is also a fix to make GET /api/subscribers/id and GET /api/subsriberpreferences/id work. Change-Id: Ie71abecd1f8387b9f56e8e0a47a5f1b16a6f308d	1 year ago
Kirill Solomko	d1686f5243	MT#63050 /api/customers email_template auto assign ... * POST /api/customers now assigns reseller's default email_templates that are not specified in the DTO. If reseller's default template does not exist (reseller that was created via UI v1 without values), it automatically created as a copy of the raw default template for the reseller, and then assigned to the customer. Change-Id: I0f74154724e1d053002ec4fcc59a5f99cedd322c	1 year ago
Rene Krenn	73664f29ba	MT#63706 skip_locked for GET /api/subscriber/id ... while acquiring locks is skipped meanwhile for collections eg. a GET /api/subscribers/, timeouts were still reported for individual GET /api/subscriber/id requests. this change adds logic to skip acquiring locks for GET /apu/subscribers/id and GET /api/subsriberpreferences/id. Change-Id: I0b739dd42947e30938e84b1339ba9b7535da8cb8	1 year ago
Rene Krenn	3451546c41	MT#63617 reset admin OTP instead of clearing ... admin OTP has no lazy initialisation, so it needs to be reset rather than cleared. Change-Id: I2d18dd7c78a475ee37bb89f99eff3109b6820a80	1 year ago
Kirill Solomko	b6df422bba	MT#63597 fix /api/callists GET by id ... * GET by id no longer throws 500 error with DBIx::Class::Row::get_column(): No such column 'source_cli_suppression_id' Change-Id: I852451e001b5fbbbd8e6363bc36da0d5b06c1539	1 year ago
Rene Krenn	da9ad91532	MT#62569 reset admin/subscriber OTP secret - restapi ... the 2FA OTP secret can be reset by removing it, the new one is to be created again during the next login attempt. therefore a corresponding "DELETE /api/otpsecret" rail is introduced. while resetting the own OTP is restricted, the OTP of a specific user requires the ID to be passed as query parameter: - DELETE /api/otpsecret/?admin_id=123 - DELETE /api/otpsecret/?subscriber_id=456 Change-Id: I92839b5b682bc61f4d28ad707e9893add6770af0	1 year ago
Kirill Solomko	b74fbabccc	MT#63320 /api/vouchers rename to search by base64_code ... * the query parameter is now named base64_code to closely represent the expected value. * check and add trailing '=' if it's missing in the provided base64_code. Change-Id: I37c03cd663116d85b5115b5feee1eb6b282596be	1 year ago
Kirill Solomko	aff1517a59	MT#63182 add deadlock detection for DELETE /api/subscribers ... Change-Id: Idce6eccdbd490e69349808b6965f8212fe3e6e37	1 year ago
Kirill Solomko	927be2a757	MT#63320 fix /api/vouchers search by code ... * base64 code provided in the query params is now correctly re-encoded as encrypted base64 string to use in search. Change-Id: Id9e45079b260bdc51465a781124f6fbb636cf2db	1 year ago
Kirill Solomko	4c28a0d0cc	MT#63320 /api/vouchers add search by code ... * search can now be performed by code, where the code is expected to be a base64 encoded string Change-Id: Ic53f28aef1cc676570aec3f346818f717c565bc4	1 year ago