MT#57342 /api/subscribers fix field role inconsistency

When the subscriber preferences API is called by a subscriber
admin of a normal (not PBX) customer, then some values are
removed from the output. In all the other cases those values
are instead returned.

This fix let expose the profile_id, domain_id, status and
webpassword to all the types of subscribers because necessary
in the CSC context.

Change-Id: I629475e7f51d747a55ebfbc44232fb94a54fed06

lib/NGCP/Panel/Role/API/Subscribers.pm

@@ -192,17 +192,12 @@ sub resource_from_item {
             }
         }
     } else {
-        if ($c->user->roles eq "subscriberadmin" && !$self->subscriberadmin_write_access($c)) {
-            # fields we never want to see
-            foreach my $k(qw/domain_id status profile_id profile_set_id external_id/) {
-                delete $resource{$k};
-            }
-
-            # TODO: make custom filtering configurable!
-            foreach my $k (qw/password webpassword/) {
-                delete $resource{'_' . $k};
-            }
+        # fields we never want to see
+        foreach my $k(qw/profile_set_id external_id/) {
+            delete $resource{$k};
         }
+        delete $resource{'password'} if $c->user->roles eq 'subscriber';
+
         if ($c->user->roles eq "subscriberadmin") {
             $resource{customer_id} = $contract_id;
             if ($item->id != $c->user->voip_subscriber->id) {