TT#98650 speedup redis locaction search by id

instantiation a redis location resultset can cause
a scan if no filter args are provided.

Change-Id: I398398115011774c20fdecbc675223a22b9e1917

lib/NGCP/Panel/Role/API/SubscriberRegistrations.pm

@@ -14,35 +14,37 @@ use NGCP::Panel::Utils::Kamailio;
 use NGCP::Panel::Utils::Subscriber;
 
 sub _item_rs {
-    my ($self, $c) = @_;
+    my ($self, $c, $filter) = @_;
 
     my $item_rs;
 
     if ($c->config->{redis}->{usrloc}) {
         # TODO: will this survive with like 1M records?
 
-        my $filter = {};
+        unless (defined $filter) {
-        if ($c->req->param('subscriber_id')) {
+            $filter = {};
-            my $sub = $c->model('DB')->resultset('voip_subscribers')->find($c->req->param('subscriber_id'));
+            if ($c->req->param('subscriber_id')) {
-            if ($sub) {
+                my $sub = $c->model('DB')->resultset('voip_subscribers')->find($c->req->param('subscriber_id'));
-                $filter->{username} = $sub->username;
+                if ($sub) {
-            }
+                    $filter->{username} = $sub->username;
-            if($c->config->{features}->{multidomain}) {
+                }
-                $filter->{domain} = $sub->domain->domain;
+                if($c->config->{features}->{multidomain}) {
-            } else {
+                    $filter->{domain} = $sub->domain->domain;
-                $filter->{domain} = undef;
+                } else {
-            }
+                    $filter->{domain} = undef;
-        } else {
+                }
-            if ($c->config->{features}->{multidomain}) {
-                $filter->{domain} = { like => '.+' };
             } else {
-                $filter->{domain} = undef;
+                if ($c->config->{features}->{multidomain}) {
+                    $filter->{domain} = { like => '.+' };
+                } else {
+                    $filter->{domain} = undef;
+                }
             }
-        }
 
-        if ($c->user->roles eq "admin" || $c->user->roles eq "ccareadmin") {
+            if ($c->user->roles eq "admin" || $c->user->roles eq "ccareadmin") {
-        } elsif ($c->user->roles eq "reseller" || $c->user->roles eq "ccare") {
+            } elsif ($c->user->roles eq "reseller" || $c->user->roles eq "ccare") {
-            $filter->{reseller_id} = $c->user->reseller_id;
+                $filter->{reseller_id} = $c->user->reseller_id;
+            }
         }
         $item_rs = NGCP::Panel::Utils::Subscriber::get_subscriber_location_rs($c, $filter);
     } else {
@@ -136,7 +138,7 @@ sub resource_from_item {
 sub item_by_id {
     my ($self, $c, $id) = @_;
 
-    my $item_rs = $self->item_rs($c);
+    my $item_rs = $self->item_rs($c,{ id => $id, });
     return $item_rs->find($id);
 }
 

lib/NGCP/Panel/Utils/Subscriber.pm

@@ -51,7 +51,7 @@ sub get_subscriber_location_rs {
             }
             $redis->select($c->config->{redis}->{usrloc_db});
             my $rs = NGCP::Panel::Utils::RedisLocationResultSet->new(_redis => $redis, _c => $c);
-            $rs = $rs->search($filter) if $filter;
+            $rs = $rs->search($filter) if ($filter and scalar keys %$filter);
             return $rs;
         } catch($e) {
             $c->log->error("Failed to fetch location information from redis: $e");