TT#38005 clean/ignore remaining perlcritic issues

in ngcp-panel repo so the repo can be marked clean

Change-Id: Ia44f13fd87563b014d31fdfe055e7b6b34947d25

lib/NGCP/Panel/Form/CallListSuppression/SuppressionAPI.pm

@@ -1,4 +1,4 @@
-package NGCP::Panel::Form::CallListSuppression::Suppression;
+package NGCP::Panel::Form::CallListSuppression::SuppressionAPI;
 
 use HTML::FormHandler::Moose;
 extends 'HTML::FormHandler';

lib/NGCP/Panel/Utils/DialogicImg.pm

@@ -1,5 +1,8 @@
+package NGCP::Panel::Utils::DialogicImg;
+
 use strict;
 use warnings;
+
 {
     package My::Serializer::Custom;
     use Moo;
@@ -42,8 +45,6 @@ use warnings;
     };
 }
 
-package NGCP::Panel::Utils::DialogicImg;
-
 use Moo;
 use Digest::MD5 qw/md5_hex/;
 use HTTP::Tiny;

sandbox/billing_mapping_effective_date.t

@@ -10,11 +10,9 @@ use Tie::IxHash;
 # try using the db directly ...
 my $schema = undef;
 
-eval <<'EVALLINE' ;
+eval 'use lib "/home/rkrenn/sipwise/git/ngcp-schema/lib";';
-    use lib "/home/rkrenn/sipwise/git/ngcp-schema/lib";
+eval 'use lib "/home/rkrenn/sipwise/git/sipwise-base/lib";';
-    use lib "/home/rkrenn/sipwise/git/sipwise-base/lib";
+eval 'use NGCP::Schema;';
-    use NGCP::Schema;
-EVALLINE
 
 print $@;
 unless ($@) {

sandbox/tracemem.pm

@@ -1,5 +1,5 @@
 
-## no critic (RequireUseWarnings, RequireUseStrict)
+## no critic (RequireUseWarnings, RequireUseStrict, RequireExplicitPackage)
 our $old = 0;
 BEGIN {
     unshift @INC, sub {

share/tools/generate_invoices.pl

@@ -60,10 +60,15 @@ my @opt_spec = (
                 }
             }else{#takes value
                 if($opt_spec->{$key} =~/i\@$/){
-#                    $val ="1,5,10..13,4";
+                    # $val = "1,5,10-13,4";
-                    $val=~s/-/../g;
                     my @vals;
-                    eval "\@vals = ($val);";
+                    for my $range (split /,/, $val) {
+                        if ( my ($start, $end) = ($range =~ m/([0-9]+)-([0-9]+)/) ) {
+                            push @vals, ($start .. $end);
+                        } else {
+                            push @vals, $range;
+                        }
+                    }
                     $res = " --$key=".join(" --$key=", @vals);
                 }else{
                     $res = " --$key=$val ";

t/api-rest/api-journals.t

@@ -1,4 +1,5 @@
-#use Sipwise::Base;
+## no critic (RequireUseStrict, RequireUseWarnings)
+
 use Net::Domain qw(hostfqdn);
 use JSON -support_by_pp, -no_export;
 use Test::More;

t/lib/Selenium/Remote/Driver/Extensions.pm

@@ -6,6 +6,9 @@ use Test::More import => [qw(diag ok is)];
 use MooseX::Method::Signatures;
 extends 'Selenium::Remote::Driver';
 
+## no critic (RequireEndWithOne)
+# false positive (probably due to parsing Method Signatures)
+
 sub BUILD {
     my $self = shift;
 

tools_bin/create_testusers.pl

@@ -79,7 +79,7 @@ say "   sip-password=$password";
 say "   number-cc=$number_cc";
 say "   number-ac=$number_ac";
 print "Proceed <YES|no>: ";
-my $confirm = <STDIN>;
+my $confirm = <STDIN>;  ## no critic (ProhibitExplicitStdin)
 chomp $confirm;
 if($confirm eq "" || lc($confirm) eq "yes") {
     say "Proceeding as requested.";