TT#133800 fix webpassword field removal

* webpassword field was unconditionally deleted
  in API GET and DELETE methods, it now relies
  on resource_from_item for the common approach

Change-Id: I703158fd2022b49a49470db28cb22f37e613f841
mr10.0
Kirill Solomko 4 years ago
parent 3ef167575c
commit 02f3f6b3a1

@ -51,7 +51,6 @@ sub GET :Allow {
my ($form) = $self->get_form($c); my ($form) = $self->get_form($c);
my $resource = $self->resource_from_item($c, $subscriber, $form); my $resource = $self->resource_from_item($c, $subscriber, $form);
delete $resource->{webpassword}; # since it's encrypted, no point to return it
my $hal = $self->hal_from_item($c, $subscriber, $resource, $form); my $hal = $self->hal_from_item($c, $subscriber, $resource, $form);
$guard->commit; #potential db write ops in hal_from $guard->commit; #potential db write ops in hal_from
@ -215,7 +214,6 @@ sub DELETE :Allow {
my ($_form) = $self->get_form($c); my ($_form) = $self->get_form($c);
#my $_subscriber = $self->item_by_id($c, $id); #my $_subscriber = $self->item_by_id($c, $id);
my $_resource = $self->resource_from_item($c, $subscriber, $_form); my $_resource = $self->resource_from_item($c, $subscriber, $_form);
delete $_resource->{webpassword}; # since it's encrypted, no point writing it into journal as well
return $self->hal_from_item($c,$subscriber,$_resource,$_form); }); return $self->hal_from_item($c,$subscriber,$_resource,$_form); });
NGCP::Panel::Utils::Subscriber::terminate(c => $c, subscriber => $subscriber); NGCP::Panel::Utils::Subscriber::terminate(c => $c, subscriber => $subscriber);

Loading…
Cancel
Save