Jenkins job ngcp-csc-manage-docker has been created recently,
we need to touch Dockerfile to trigger docker images building
and publishing.
Also added 'cd /code' in testrunner to build Sencha app properly
in Docker.
Change-Id: I6846cf34f57dd0073fd28d587cd395ee1e3228a8
What's done:
1. Reorder menu to groups, seats, devices order
2. Map out the data flow, see workfront docs
3. Plan data store merge implementation
4. Plan out what needs validation, and is required
5. Implement validation in view and controller
7. Fix bug in Groups module, where hunt 'for' label does not get
extra margin-top when saved with enter, only with button
8. Implement store merge as per Cvenusinos suggestion
a. introduce in Groups data/model a unique id field (was already
there)
b. change seat data to have the groups field as array of group ids
c. where you assign the value of groups label in seat card, you
have to iterate&find the records in Groups store which have the
ids of groups field in seat record, and extract the names
d. as for the tagfield, you have to use Groups store
e. define valueField and displayField using fields which exists in
group model (id & name for example)
f. if the store has autoLoad: true (=dropdown populated),
binding the groups field in seat model to the array of ids
should automatically display the selected group names
g. Filter out field arrays where fieldLabel is "User" or "Type"
9. Fix bugs with "delayed" save, or "first save not working when
adding new seat or group"
10. Change blur listener controller to only save, and not hide
11. Issue with saving of name field in Groups and Devices (not
Seats). Only happens when clicking button/save-icon, and for
dirty record. It gets saved, but fields not hidden. A second
click hides
12. Issue with cut off of cards in relation to issue 11, same
steps to reproduce
Change-Id: I2af41a6e9799b7cbd268b1217ed49b9381272d6a
What was done:
1. Set initial hidden value to false for panel and all toggleable
components within it
Change-Id: I6ce4296fea4525c4e92994ca8a4887e73d961d3c
What was done:
- 1. Changed background color to grey
- 2. Increased font size, and added some padding
- 3. Added icons based on message type (success or not)
- 4. Repositioned it to be top right instead of top center this was
done for these reasons:
a. Andreas was pointing out the messages didn't look centered
in the previous iteration, but the fact is they were centered
in relation to the whole browser window, and not in relation
to main container wrapper. This solves this issue
b. Users are more likely to notice the messages overlaying top
right, as it does not compete with green background of panel
title
c. Users are more likely to be used to notifications on top
right in their OSes, browser notifications, and other apps
- 5. Increased time before close of notification box (3 to 5 secs)
- 6. Set the notification box max and min width to 365px, and
verified that text wrap is working
Change-Id: I3065ee208b01ccd48604a47da1c94e4c7b88659b
What was done:
1. Visually implement "Allow [TOGGLE BUTTON] block" for Outg/Inc
2. Visually implement "Show own number [TOGGLE BUTTON] hide own
number" for Privacy
3. Implement css and classes
4. Implement controllers and bind to vm values
Change-Id: I76afe1d30cefee64faa1f8e0174eb3af2de76576
What was done:
1. Add blur listeners to fields
2. Implement controller for blur event that checks if any of the
fields in DOM .hasFocus, and if false we save card
3. Implement change of tooltip for editCard icon when clicked and
changes to saveCard icon
Change-Id: I772fa4f033b5ec2a4656cc372ad5b57cb42c3ad1
What was done:
1. Change timeset grid column title from "Closed" to "Full Day"
2. Implement "save" and "close" buttons for timeset grid, and
controller (controllers fire msg for now)
3. Copy "For calls during after hours..." to panel title (keep it
in both places)
4. Implement changes to tabs and timeset appearance, see wireframe
in balsamiq
5. Change "Sourceset title" to "Title"
6. Implement Sourceset grid save button in row, and editor field
slightly less wide to make room for button
7. Make sourceset title input field full width
8. Change color for "move icon" to same color as "trash icon"
9. Implement tooltips in grids
10. Fix titles to "Call Forward - Always", and remove "For calls
during always..." in always submodule
11. Move the loadingBar
12. Local storage for persistent state of collapsable panel
13. Full width timeset grid, and place inside panel so it can be
properly collapsed
14. Locales all the things
15. Adjust width of sourceset grid to 100% as well, and move buttons
to right align
Change-Id: Id31fe3f34cb0009fa24068acc242daaa2b4bb481
As specified in meeting 20.03, we need to implement new fields and
tag fields. Need to implement both in rowwidget in view, manual bind
in controller, add in gridfilters form, and add controller logic to
handle tag fields both in pbxconfig and gridfilters.
Change-Id: I7dad57af0ee6fa40bad1cb839d2d9c17a127211f
Split Ngcp-csc call forward module into three submodules based on
timesource (always/after hours/company hours).
Plus implement the following changes:
* not bold text
* new placement/implementation of timeset grid
* add cursor pointer to sourceset/timeset grid
* autofocus on bottom list A/B row when add new
* remove bulletpoints
* change to tabpanel for sourcesets
* implement clickable icons in tabs
* adjust layout of "first ring" and "then ring" fields and labels
* implement 'big-820'/'small-100' layout to be consistent with other views
* implement onEnterPressed ability
* change structure of views (mainform/tabpanel, etc) and affected controllers to use new ids
* ability to change List A/List B name
* refactor controller where needed
* implement validity check for controllers for saving "then ring" destinations to store
* correct styling after restructuring views
Change-Id: Ied00dd73f2044c0af2fb82a0be17c66c3c597663
Fix issue with "Name:" labels always being visible in
seats/groups/devices after first time editing a card. Also fix
duplicate hidden values (both bind and explicit) for labels/fields
in grid views, and this issue reported by Carlo:
> Start edit a new card, click save before all fields are
filled -> message alert which all fields are mandatory (correct),
but the filled ones should not be deleted.
Change-Id: I00c59e4b9f489c3905540238b6032105b3040347
Implement cancel button for seats/groups/devices submodules.
Cancel button that appears when editing inline in cards, and when
clicked hides fields and shows the labels again. When pressed after
adding a new empty card, it should delete the card.
Change-Id: I9225031bdeae0fd1a6b611ab76fb50d9d9fe196d
Implement inline editing and "add new" functionality for pbx
submodules; groups, seats and devices.
Due to issues with rowwidget, implement workaround for binding, and
click listener - which are not working as expected/at all (respctvly).
Also refactor structure of views, to consolidate duplicate code for
these submodules - and implement onEnterPressed feature.
Change-Id: If6b34fff1634e87aedb28232a859529e7616173d
Implement "SAVE" button in call blocking module, to have in addition
to the existing "press ENTER to save" feature.
Also minor locales.js change due to duplicates.
Change-Id: I59d20d10b1aeba86241995ebb4f4e82f4ac75391
Implement layout adjustments to bring reminder module in line with
new styling for callblocking/conversations/pbx, and also implement
controller with message events firing on inactive/active mode switch.
Change-Id: I01eb6d55b289ffb26f13fcc889f94c1c7c72aa1d
After last card changes to conversations module (rowbody, styling,
etc), pbx cards are not expanding, and also needs a round of changes.
Change-Id: I2fb81e9229dbd9f5720761a266e3c491072ce302
As agreed in 27.01 meeting, create callblocking privacy module. Also
add missing strings to locales, fix css green bg on conversations
"new xxx" icons, and add xtype variable to show/hide all callblocking
modules.
Change-Id: If25be661097c755368fe99495a531e1438e29fbd
As specified in meeting 27.01, create these two Call Blocking
submodules. Also add extra checks to prevent duplicate records,
and refactor controller.
Change-Id: I73644343ded6b3093c4cb9fd16e5402ff38bf927
Implement new logic and layout for adding new rule in call forward
module, based on new sketches and specs in 27.01 meeting. Also fix
issue with "nowhere" emptyText not showing circle, missing message
event, and move timeset/sourceset widget to be embedded in buttons
instead (this was missing from task 10057). Also clean up sass a bit
and refactor use of "element: 'el'" in controller (not needed).
Change-Id: Idab0ccb3a0d4f15b18fac2accd1c75bdf809e5f8
Current filters implementation in sidebar needs to be adapted to
changes (as specified in 27.01 meeting), and moved from widget
location to location in headerBar on top in mainView. Also needs
styling, collapse/expand functionality, autosearch on input,
autosubmit on field change, dynamic visibility on route change,
and change of linkedStore and form fields based on route. Added
toggle for headerBar field, to switch between freeform and
card-header-title-only search.
Remaining tasks:
> [MOVED To SEPARATE TASK] Fix pbx filter fields not working
> [DONE] Fix "delayed" binds in formFilter, see submitFilters() in
controller. I had another look after our talk, and looks like I
improperly changed the tabfilters to checkboxgroup, and there
are still references to that in controller
> [DONE] Tried to center field, but needs to be grouped with icons to
be able to center them with "margin: 0 auto;" together
> [DONE] Fix hover bg color for "new ..." icons
Change-Id: Icc5c0d552827f4ea504ffa5e6c70045455165ed4
Adjust layout and styling of sections, for call forward module, so
that it meets new requirements (from 27.01 meeting).
Change-Id: I3d0adc914aec796ece36143a6fd7c8491a1e42cf
Implement changes to gridpanel for displaying call forwarding rules,
according to specs given in 27.01 meeting.
Too make it possible to implement drag and drop move functionality
(without writing such a functionality from scratch that also enables
syncing of data to store), use standard gridpanels. Use renderer to
create list styling, prepend "+" char, and display placeholder text
when creating new rules.
Change-Id: I590b794ee193ca0594039d3bc44cd94490e3b2cd
Remove pbx extensions and fax send module. Change auto attendant
module to sub module of pbx config submodule (awaiting specs from
Andreas, so leave this module as is for now). Correct naming mistake
for pbxconfig folder (is named pbfconfig), and remove redundant scss
and locales.
Leave Ngcp.csc.locales.faxsend locales object for now, as it can be
reused for the upcoming "Action/calls sidebar" module.
Change-Id: Id951a943dedae24b1719953ba62f38f0b6ae69c0
Desktop section moved to bottom, rename "Account" to "Password" and
set "Unified Inbox"/"Conversations" to default/top route.
Change-Id: If093e2015d66b7d4c5ac1eeea5ba24aa6447b7ca
Added missing field "folder" for voicemails, change voicemails title
to number, and removed settings widget. Status is already covered
by color coding of arrows (answered/missed).
Change-Id: I1d8cb686d6e63df0abc285887b260c03a7b32fe3
In Calls/Unified Inbox module, when I am viewing it from my laptop, the
right border is "cut off". After experimenting with @media rules, and
discovering that it could not be fixed with a max-width rule, I fixed
this by simply adding a small margin-right.
Change-Id: I3c82014e19a5b006b89aa8cdb9cdb2ecff192f34
Carlo
Robert Axelsen
Alexander Lutay
Markus Danek
Andreas Granig