TT#72407 Additional refactoring of conference store

Change-Id: Ic96a8f39c388425051aa0b438f124d8f7a447086
changes/32/36032/8
Hans-Peter Herzog 5 years ago committed by Carlo Venusino
parent ea14a25cd7
commit df3f485a7a

@ -64,17 +64,7 @@
</div> </div>
<div <div
id="csc-conf-main-media" id="csc-conf-main-media"
v-show="!isJoined v-show="showMainMedia"
&& isMediaEnabled
&& ( isCameraEnabled || isScreenEnabled )
|| (selectedParticipant
&& (selectedParticipant == 'local'
&& isMediaEnabled
&& (isCameraEnabled
|| isScreenEnabled)
)
|| selectedHasVideo
)"
> >
<csc-media <csc-media
ref="localMedia" ref="localMedia"
@ -124,7 +114,7 @@
> >
<q-popover <q-popover
ref="popover" ref="popover"
:disable="participantsList.length < 1"> :disable="conferenceHasParticipants">
<q-list <q-list
link link
class="no-border" class="no-border"
@ -261,6 +251,22 @@
default: default:
return this.hasRemoteVideo(selectedParticipant); return this.hasRemoteVideo(selectedParticipant);
} }
},
showMainMedia(){
return !this.isJoined
&& this.isMediaEnabled
&& ( this.isCameraEnabled || this.isScreenEnabled )
|| (this.selectedParticipant
&& (this.selectedParticipant == 'local'
&& this.isMediaEnabled
&& (this.isCameraEnabled
|| this.isScreenEnabled)
)
|| this.selectedHasVideo
)
},
conferenceHasParticipants(){
return Object.keys(this.participantsList).length < 1;
} }
}, },
methods: { methods: {

@ -8,19 +8,18 @@
v-if="!localMediaStream || localMediaStream && (!isCameraEnabled && !isScreenEnabled)" v-if="!localMediaStream || localMediaStream && (!isCameraEnabled && !isScreenEnabled)"
> >
</q-icon> </q-icon>
<csc-media
<csc-media
ref="cscMedia" ref="cscMedia"
v-show="localMediaStream && (isCameraEnabled || isScreenEnabled)" v-show="localMediaStream && (isCameraEnabled || isScreenEnabled)"
class="csc-media-cont" class="csc-media-cont"
:muted="true" :muted="true"
:stream="localMediaStream" :stream="localMediaStream"
/> />
<q-card-title <q-card-title
class="csc-conf-participants-item-title" class="csc-conf-participants-item-title"
> >
{{ localParticipant.displayName }} {{ localParticipant.displayName }}
</q-card-title> </q-card-title>
</q-card> </q-card>
</template> </template>

@ -211,7 +211,6 @@ export default {
}); });
} }
state.participants.push(participant.getId()); state.participants.push(participant.getId());
}, },
participantLeft(state, participant) { participantLeft(state, participant) {
state.participants = state.participants.filter(($participant) => { state.participants = state.participants.filter(($participant) => {

@ -4,7 +4,7 @@
import ConferenceModule from '../../src/store/conference'; import ConferenceModule from '../../src/store/conference';
import { assert } from 'chai'; import { assert } from 'chai';
describe('ConferenceModule', function(){ describe('Conference', function(){
it('should add a participant id to the store if not already stored', () => { it('should add a participant id to the store if not already stored', () => {
let state = { let state = {
@ -48,17 +48,6 @@ describe('ConferenceModule', function(){
}); });
it('should add a participant mediastream to the store', () => {
let state = {
remoteMediaStreams: {}
};
const participantId = '123456789';
ConferenceModule.mutations.addRemoteMedia(state, participantId);
assert.exists(state.remoteMediaStreams[participantId]);
});
it('should remove a participant mediastream from the store', () => { it('should remove a participant mediastream from the store', () => {
let state = { let state = {
remoteMediaStreams: { remoteMediaStreams: {
@ -104,6 +93,4 @@ describe('ConferenceModule', function(){
assert.equal(state.selectedParticipant, null); assert.equal(state.selectedParticipant, null);
}); });
}); });

Loading…
Cancel
Save