Test empty parameters on load.

ngcp/dp.lua

@@ -17,10 +17,16 @@ NGCPDomainPrefs_MT = { __index = NGCPDomainPrefs }
     end
 
     function NGCPDomainPrefs:caller_load(uuid)
+        if not uuid then
+            error("uuid is empty")
+        end
         return NGCPDomainPrefs._load(self,"caller",uuid)
     end
 
     function NGCPDomainPrefs:callee_load(uuid)
+        if not uuid then
+            error("uuid is empty")
+        end
         return NGCPDomainPrefs._load(self,"callee",uuid)
     end
 

ngcp/pp.lua

@@ -17,12 +17,16 @@ NGCPPeerPrefs_MT = { __index = NGCPPeerPrefs }
     end
 
     function NGCPPeerPrefs:caller_load(uuid)
+        if uuid then
             return self:_load("caller",uuid)
         end
+    end
 
     function NGCPPeerPrefs:callee_load(uuid)
+        if uuid then
             return self:_load("callee",uuid)
         end
+    end
 
     function NGCPPeerPrefs:_load(level, uuid)
         local con = assert (self.config:getDBConnection())

ngcp/up.lua

@@ -17,10 +17,16 @@ NGCPUserPrefs_MT = { __index = NGCPUserPrefs }
     end
 
     function NGCPUserPrefs:caller_load(uuid)
+        if not uuid then
+            error("uuid is empty")
+        end
         return NGCPUserPrefs._load(self,"caller",uuid)
     end
 
     function NGCPUserPrefs:callee_load(uuid)
+        if not uuid then
+            error("uuid is empty")
+        end
         return NGCPUserPrefs._load(self,"callee",uuid)
     end
 

tests/ngcp_dp.lua

@@ -70,6 +70,16 @@ TestNGCPDomainPrefs = {} --class
         assertEquals(self.d.db_table, "dom_preferences")
     end
 
+    function TestNGCPDomainPrefs:test_caller_load_empty()
+        assertTrue(self.d.config)
+        assertError(self.d.caller_load, nil)
+    end
+
+    function TestNGCPDomainPrefs:test_callee_load_empty()
+        assertTrue(self.d.config)
+        assertError(self.d.callee_load, nil)
+    end
+
     function TestNGCPDomainPrefs:test_caller_load()
         assertTrue(self.d.config)
         self.config:getDBConnection() ;mc :returns(self.con)

tests/ngcp_pp.lua

@@ -70,6 +70,16 @@ TestNGCPPeerPrefs = {} --class
         assertEquals(self.d.db_table, "peer_preferences")
     end
 
+    function TestNGCPPeerPrefs:test_caller_load_empty()
+        assertTrue(self.d.config)
+        assertEquals(self.d.caller_load(), nil)
+    end
+
+    function TestNGCPPeerPrefs:test_callee_load_empty()
+        assertTrue(self.d.config)
+        assertEquals(self.d.callee_load(), nil)
+    end
+
     function TestNGCPPeerPrefs:test_caller_load()
         assertTrue(self.d.config)
         self.config:getDBConnection() ;mc :returns(self.con)

tests/ngcp_rp.lua

@@ -57,6 +57,14 @@ TestNGCPRealPrefs = {} --class
        sr.log("info", "---cleaned---")
     end
 
+    function TestNGCPRealPrefs:test_caller_load_empty()
+        assertError(self.real.caller_load, nil)
+    end
+
+    function TestNGCPRealPrefs:test_callee_load_empty()
+        assertError(self.real.callee_load, nil)
+    end
+
     function TestNGCPRealPrefs:test_caller_load()
         local keys = {"uno"}
         local xavp = {

tests/ngcp_up.lua

@@ -65,6 +65,16 @@ TestNGCPUserPrefs = {} --class
         sr.log("info", "---cleaned---")
     end
 
+    function TestNGCPUserPrefs:test_caller_load_empty()
+        assertTrue(self.d.config)
+        assertError(self.d.caller_load, nil)
+    end
+
+    function TestNGCPUserPrefs:test_callee_load_empty()
+        assertTrue(self.d.config)
+        assertError(self.d.callee_load, nil)
+    end
+
     function TestNGCPUserPrefs:test_init()
         --print("TestNGCPUserPrefs:test_init")
         assertEquals(self.d.db_table, "usr_preferences")